]> git.sesse.net Git - vlc/commitdiff
Avoid alloca()
authorRémi Denis-Courmont <remi@remlab.net>
Fri, 10 Apr 2009 18:15:18 +0000 (21:15 +0300)
committerRémi Denis-Courmont <remi@remlab.net>
Fri, 10 Apr 2009 18:15:18 +0000 (21:15 +0300)
By the way, alloca() _cannot_ return NULL. It simply crashes if there
is not enough memory.

projects/activex/persiststreaminit.cpp

index 0660566fca2911c1edc763b0181625524a0dff7e..2ec4adb7e77c6ac77b9d702937fbfbd525c0ad42 100644 (file)
@@ -417,9 +417,7 @@ private:
         if( 0 == len )
             return E_INVALIDARG;
 
-        LPWSTR propName = (LPOLESTR)::alloca((len+1)*sizeof(WCHAR));
-        if( NULL == propName )
-            return E_OUTOFMEMORY;
+        WCHAR propName[len + 1];
 
         result = pStm->Read(propName, len*sizeof(WCHAR), NULL);
         if( FAILED(result) )