fixed misc/stats.c:399: warning: comparison between signed and unsigned in function...

Based on usage of i_id, other stats_* functions and my opinion i_id should be unsigned int instead of int, but I might be missing the bigger picture related to changing public APIs. Please, let me know how to correctly deal with such warnings.

diff --git a/include/vlc_messages.h b/include/vlc_messages.h
index d8b7b3806f3773f4750016643d589cbd861edfbb..113825cbce414cc2b58ecbfdda7605f7e3e60eb0 100644 (file)
--- a/include/vlc_messages.h
+++ b/include/vlc_messages.h
@@ -377,6 +377,6 @@ VLC_EXPORT( void,__stats_TimersDumpAll, (vlc_object_t*) );
 VLC_EXPORT( void, __stats_TimersCleanAll, (vlc_object_t * ) );
 
 #define stats_TimerClean(a,b) __stats_TimerClean( VLC_OBJECT(a), b )
-VLC_EXPORT( void, __stats_TimerClean, (vlc_object_t *, int ) );
+VLC_EXPORT( void, __stats_TimerClean, (vlc_object_t *, unsigned int ) );
 
 #endif

diff --git a/src/misc/stats.c b/src/misc/stats.c
index 7e967f9437497959a7b7a111965d4dde76a43283..191dc82d362eeb36d2b9d4a6c5d42bee9b4a3c12 100644 (file)
--- a/src/misc/stats.c
+++ b/src/misc/stats.c
@@ -389,7 +389,7 @@ void __stats_TimersDumpAll( vlc_object_t *p_obj )
     vlc_mutex_unlock( &p_obj->p_libvlc->timer_lock );
 }
 
-void __stats_TimerClean( vlc_object_t *p_obj, int i_id )
+void __stats_TimerClean( vlc_object_t *p_obj, unsigned int i_id )
 {
     int i;
     vlc_mutex_lock( &p_obj->p_libvlc->timer_lock );