]> git.sesse.net Git - vlc/commitdiff
Qt: OpenUrlDialog ain't a Singleton anymore
authorJean-Baptiste Kempf <jb@videolan.org>
Thu, 4 Feb 2010 02:46:49 +0000 (03:46 +0100)
committerJean-Baptiste Kempf <jb@videolan.org>
Thu, 4 Feb 2010 02:47:25 +0000 (03:47 +0100)
And remove unnecessary killInstances

modules/gui/qt4/dialogs/openurl.hpp
modules/gui/qt4/dialogs_provider.cpp

index c7fae158a972e2c0865078fc8048abbcf138c9de..3fb0929322b913c37b9362f31dc10750d789cd09 100644 (file)
 
 class ClickLineEdit;
 
-class OpenUrlDialog : public QVLCDialog, public Singleton<OpenUrlDialog>
+class OpenUrlDialog : public QVLCDialog
 {
     Q_OBJECT
 
 private:
-    OpenUrlDialog( intf_thread_t *, bool bClipboard = true );
     QString lastUrl;
     bool bClipboard, bShouldEnqueue;
     ClickLineEdit *edit;
@@ -49,6 +48,7 @@ private slots:
     void play();
 
 public:
+    OpenUrlDialog( intf_thread_t *, bool bClipboard = true );
     virtual ~OpenUrlDialog() {}
 
     QString url() const;
@@ -58,7 +58,6 @@ public:
 public slots:
     virtual void close() { play(); };
 
-    friend class    Singleton<OpenUrlDialog>;
 };
 
 #endif
index 557097420ab0ef0d13a1121c547ce1ffbd02cbb3..0eced2bd10d81fcc6a6a53b808363f6436bc435e 100644 (file)
@@ -91,14 +91,10 @@ DialogsProvider::~DialogsProvider()
     ExtendedDialog::killInstance();
     BookmarksDialog::killInstance();
     HelpDialog::killInstance();
-    AboutDialog::killInstance();
 #ifdef UPDATE_CHECK
     UpdateDialog::killInstance();
 #endif
     PluginDialog::killInstance();
-    VLMDialog::killInstance();
-    OpenUrlDialog::killInstance();
-    GotoTimeDialog::killInstance();
     PodcastConfigDialog::killInstance();
     EpgDialog::killInstance();
     ErrorsDialog::killInstance();
@@ -470,7 +466,7 @@ void DialogsProvider::simpleMLAppendDialog()
  **/
 void DialogsProvider::openUrlDialog()
 {
-    OpenUrlDialog *oud = OpenUrlDialog::getInstance( p_intf );
+    OpenUrlDialog *oud = new OpenUrlDialog( p_intf );
     if( oud->exec() == QDialog::Accepted )
     {
         QString url = oud->url();
@@ -484,6 +480,7 @@ void DialogsProvider::openUrlDialog()
             RecentsMRL::getInstance( p_intf )->addRecent( url );
         }
     }
+    delete oud;
 }
 
 /* Directory */