]> git.sesse.net Git - vlc/commitdiff
projects / vlc / commitdiff
? search:
summary | shortlog | log | commit | commitdiff | tree
raw | patch | inline | side by side (parent: dc4c75f)
* modules/gui/macosx/controls.m: fixed race condition in prev/next commands.
authorGildas Bazin <gbazin@videolan.org>
Tue, 29 Jul 2003 21:14:10 +0000 (21:14 +0000)
committerGildas Bazin <gbazin@videolan.org>
Tue, 29 Jul 2003 21:14:10 +0000 (21:14 +0000)
* modules/gui/wxwindows/wxwindows.cpp: raised the priority of the wxwin interface so it is now the default.
    We also lower the priority if there is no DISPLAY env variable.
* modules/gui/wxwindows/interface.cpp: prev/next buttons are also used to navigate through titles.
* modules/video_output/directx/events.c: use arrow keys for DVD navigation.
* modules/video_output/x11/xcommon.c: page up/down now seek -10/10 secs.
* share/vlc_win32_rc.rc: compilation fix.

modules/gui/macosx/controls.m patch | blob | history
modules/gui/wxwindows/interface.cpp patch | blob | history
modules/gui/wxwindows/wxwindows.cpp patch | blob | history
modules/video_output/directx/events.c patch | blob | history
modules/video_output/x11/xcommon.c patch | blob | history
share/vlc_win32_rc.rc patch | blob | history

diff --git a/modules/gui/macosx/controls.m b/modules/gui/macosx/controls.m
index 24b8b03e9caf3fd23227999cef188c3e659f00ad..f8f46d3ef04f30c11ab30cfd2a4110d83c7a75de 100644 (file)
--- a/modules/gui/macosx/controls.m
+++ b/modules/gui/macosx/controls.m
@@ -2,7 +2,7 @@
  * controls.m: MacOS X interface plugin
  *****************************************************************************
  * Copyright (C) 2002-2003 VideoLAN
- * $Id: controls.m,v 1.46 2003/07/27 14:10:02 massiot Exp $
+ * $Id: controls.m,v 1.47 2003/07/29 21:14:10 gbazin Exp $
  *
  * Authors: Jon Lech Johansen <jon-vl@nanocrew.net>
  *          Christophe Massiot <massiot@via.ecp.fr>
@@ -150,21 +150,20 @@
     }
 
     vlc_mutex_lock( &p_playlist->p_input->stream.stream_lock );
+    val.b_bool = VLC_TRUE;
 
 #define p_area p_playlist->p_input->stream.p_selected_area
     if( p_area->i_part > 0 && p_area->i_part_nb > 1)
     {
         vlc_mutex_unlock( &p_playlist->p_input->stream.stream_lock );
-        vlc_mutex_unlock( &p_playlist->object_lock );
-        var_Get( p_playlist->p_input, "prev-chapter", &val );
         var_Set( p_playlist->p_input, "prev-chapter", val );
+        vlc_mutex_unlock( &p_playlist->object_lock );
     }
     else if( p_area->i_id > 1 )
     {
         vlc_mutex_unlock( &p_playlist->p_input->stream.stream_lock );
-        vlc_mutex_unlock( &p_playlist->object_lock );
-        var_Get( p_playlist->p_input, "prev-title", &val );
         var_Set( p_playlist->p_input, "prev-title", val );
+        vlc_mutex_unlock( &p_playlist->object_lock );
     }
     else
     {
@@ -199,21 +198,20 @@
     }
 
     vlc_mutex_lock( &p_playlist->p_input->stream.stream_lock );
+    val.b_bool = VLC_TRUE;
 
 #define p_area p_playlist->p_input->stream.p_selected_area
-    if( p_area->i_part < p_area->i_part_nb && p_area->i_part_nb > 1 )
+    if( p_area->i_part < p_area->i_part_nb - 1 && p_area->i_part_nb > 1 )
     {
         vlc_mutex_unlock( &p_playlist->p_input->stream.stream_lock );
-        vlc_mutex_unlock( &p_playlist->object_lock );
-        var_Get( p_playlist->p_input, "next-chapter", &val );
         var_Set( p_playlist->p_input, "next-chapter", val );
+        vlc_mutex_unlock( &p_playlist->object_lock );
     }
     else if( p_area->i_id < p_playlist->p_input->stream.i_area_nb && p_playlist->p_input->stream.i_area_nb > 1 )
     {
         vlc_mutex_unlock( &p_playlist->p_input->stream.stream_lock );
-        vlc_mutex_unlock( &p_playlist->object_lock );
-        var_Get( p_playlist->p_input, "next-title", &val );
         var_Set( p_playlist->p_input, "next-title", val );
+        vlc_mutex_unlock( &p_playlist->object_lock );
     }
     else
     {
diff --git a/modules/gui/wxwindows/interface.cpp b/modules/gui/wxwindows/interface.cpp
index 0d953a817cd3026ee2b8a2d454f44cd942f044f4..ebf7db7e024708e653c38da47c617eee3dfa9793 100644 (file)
--- a/modules/gui/wxwindows/interface.cpp
+++ b/modules/gui/wxwindows/interface.cpp
@@ -2,7 +2,7 @@
  * interface.cpp : wxWindows plugin for vlc
  *****************************************************************************
  * Copyright (C) 2000-2001 VideoLAN
- * $Id: interface.cpp,v 1.53 2003/07/23 01:13:47 gbazin Exp $
+ * $Id: interface.cpp,v 1.54 2003/07/29 21:14:10 gbazin Exp $
  *
  * Authors: Gildas Bazin <gbazin@netcourrier.com>
  *
@@ -743,6 +743,23 @@ void Interface::OnPrevStream( wxCommandEvent& WXUNUSED(event) )
         return;
     }
 
+    vlc_mutex_lock( &p_playlist->object_lock );
+    if( p_playlist->p_input != NULL )
+    {
+        vlc_mutex_lock( &p_playlist->p_input->stream.stream_lock );
+        if( p_playlist->p_input->stream.p_selected_area->i_id > 1 )
+        {
+            vlc_value_t val; val.b_bool = VLC_TRUE;
+            vlc_mutex_unlock( &p_playlist->p_input->stream.stream_lock );
+            var_Set( p_playlist->p_input, "prev-title", val );
+            vlc_mutex_unlock( &p_playlist->object_lock );
+            vlc_object_release( p_playlist );  
+            return;
+        }
+        vlc_mutex_unlock( &p_playlist->p_input->stream.stream_lock );
+    }
+    vlc_mutex_unlock( &p_playlist->object_lock );
+
     playlist_Prev( p_playlist );
     vlc_object_release( p_playlist );
 }
@@ -757,6 +774,25 @@ void Interface::OnNextStream( wxCommandEvent& WXUNUSED(event) )
         return;
     }
 
+    vlc_mutex_lock( &p_playlist->object_lock );
+    if( p_playlist->p_input != NULL )
+    {
+        vlc_mutex_lock( &p_playlist->p_input->stream.stream_lock );
+        if( p_playlist->p_input->stream.i_area_nb > 1 &&
+            p_playlist->p_input->stream.p_selected_area->i_id <
+              p_playlist->p_input->stream.i_area_nb - 1 )
+        {
+            vlc_value_t val; val.b_bool = VLC_TRUE;
+            vlc_mutex_unlock( &p_playlist->p_input->stream.stream_lock );
+            var_Set( p_playlist->p_input, "next-title", val );
+            vlc_mutex_unlock( &p_playlist->object_lock );
+            vlc_object_release( p_playlist );  
+            return;
+        }
+        vlc_mutex_unlock( &p_playlist->p_input->stream.stream_lock );
+    }
+    vlc_mutex_unlock( &p_playlist->object_lock );
+
     playlist_Next( p_playlist );
     vlc_object_release( p_playlist );
 }
diff --git a/modules/gui/wxwindows/wxwindows.cpp b/modules/gui/wxwindows/wxwindows.cpp
index 6827540b3181a821b97faf47b70c88deda802c52..1ec8fbcc4887ae339b20eed627c94397df133125 100644 (file)
--- a/modules/gui/wxwindows/wxwindows.cpp
+++ b/modules/gui/wxwindows/wxwindows.cpp
@@ -2,7 +2,7 @@
  * wxwindows.cpp : wxWindows plugin for vlc
  *****************************************************************************
  * Copyright (C) 2000-2001 VideoLAN
- * $Id: wxwindows.cpp,v 1.27 2003/07/25 22:50:12 gbazin Exp $
+ * $Id: wxwindows.cpp,v 1.28 2003/07/29 21:14:10 gbazin Exp $
  *
  * Authors: Gildas Bazin <gbazin@netcourrier.com>
  *
@@ -88,8 +88,13 @@ private:
  * Module descriptor
  *****************************************************************************/
 vlc_module_begin();
+#ifdef WIN32
+    int i_score = 150;
+#else
+    int i_score = getenv( "DISPLAY" ) == NULL ? 15 : 150;
+#endif
     set_description( (char *) _("wxWindows interface module") );
-    set_capability( "interface", 50 );
+    set_capability( "interface", i_score );
     set_callbacks( Open, Close );
     add_shortcut( "wxwindows" );
     add_shortcut( "wxwin" );
diff --git a/modules/video_output/directx/events.c b/modules/video_output/directx/events.c
index 707a84e7e3ad723180bebd255d896be1015c33d0..24985ddcaf5d8ee67488f9096a091404d8d0f9c4 100644 (file)
--- a/modules/video_output/directx/events.c
+++ b/modules/video_output/directx/events.c
@@ -2,7 +2,7 @@
  * events.c: Windows DirectX video output events handler
  *****************************************************************************
  * Copyright (C) 2001 VideoLAN
- * $Id: events.c,v 1.19 2003/07/25 11:37:22 gbazin Exp $
+ * $Id: events.c,v 1.20 2003/07/29 21:14:10 gbazin Exp $
  *
  * Authors: Gildas Bazin <gbazin@netcourrier.com>
  *
@@ -217,20 +217,32 @@ void DirectXEventThread( event_thread_t *p_event )
                 break;
 
             case VK_LEFT:
-                input_Seek( p_event->p_vout, -5,
-                            INPUT_SEEK_SECONDS | INPUT_SEEK_CUR );
+                /* input_Seek( p_event->p_vout, -5,
+                   INPUT_SEEK_SECONDS | INPUT_SEEK_CUR ); */
+                val.psz_string = "LEFT";
+                var_Set( p_vout, "key-pressed", val );
                 break;
             case VK_RIGHT:
-                input_Seek( p_event->p_vout, 5,
-                            INPUT_SEEK_SECONDS | INPUT_SEEK_CUR );
+                /* input_Seek( p_event->p_vout, 5,
+                   INPUT_SEEK_SECONDS | INPUT_SEEK_CUR ); */
+                val.psz_string = "RIGHT";
+                var_Set( p_vout, "key-pressed", val );
                 break;
             case VK_UP:
-                input_Seek( p_event->p_vout, 60,
-                            INPUT_SEEK_SECONDS | INPUT_SEEK_CUR );
+                /* input_Seek( p_event->p_vout, 60,
+                   INPUT_SEEK_SECONDS | INPUT_SEEK_CUR ); */
+                val.psz_string = "UP";
+                var_Set( p_vout, "key-pressed", val );
                 break;
             case VK_DOWN:
-                input_Seek( p_event->p_vout, -60,
-                            INPUT_SEEK_SECONDS | INPUT_SEEK_CUR );
+                /* input_Seek( p_event->p_vout, -60,
+                   INPUT_SEEK_SECONDS | INPUT_SEEK_CUR ); */
+                val.psz_string = "DOWN";
+                var_Set( p_vout, "key-pressed", val );
+                break;
+            case VK_RETURN:
+                val.psz_string = "ENTER";
+                var_Set( p_vout, "key-pressed", val );
                 break;
             case VK_HOME:
                 input_Seek( p_event->p_vout, 0,
@@ -241,11 +253,11 @@ void DirectXEventThread( event_thread_t *p_event )
                             INPUT_SEEK_BYTES | INPUT_SEEK_END );
                 break;
             case VK_PRIOR:
-                input_Seek( p_event->p_vout, 900,
+                input_Seek( p_event->p_vout, 10,
                             INPUT_SEEK_SECONDS | INPUT_SEEK_CUR );
                 break;
             case VK_NEXT:
-                input_Seek( p_event->p_vout, -900,
+                input_Seek( p_event->p_vout, -10,
                             INPUT_SEEK_SECONDS | INPUT_SEEK_CUR );
                 break;
             case VK_SPACE:
diff --git a/modules/video_output/x11/xcommon.c b/modules/video_output/x11/xcommon.c
index f4c55244df978ceb101ff3f64e341b1716b75ee1..8c7a360ccd5189a276d6a4cd0cb657fae9c513d2 100644 (file)
--- a/modules/video_output/x11/xcommon.c
+++ b/modules/video_output/x11/xcommon.c
@@ -2,7 +2,7 @@
  * xcommon.c: Functions common to the X11 and XVideo plugins
  *****************************************************************************
  * Copyright (C) 1998-2001 VideoLAN
- * $Id: xcommon.c,v 1.25 2003/07/29 09:32:14 sam Exp $
+ * $Id: xcommon.c,v 1.26 2003/07/29 21:14:10 gbazin Exp $
  *
  * Authors: Vincent Seguin <seguin@via.ecp.fr>
  *          Samuel Hocevar <sam@zoy.org>
@@ -583,10 +583,10 @@ static int ManageVideo( vout_thread_t *p_vout )
                 input_Seek( p_vout, 0, INPUT_SEEK_BYTES | INPUT_SEEK_END );
                 break;
             case XK_Page_Up:
-                input_Seek( p_vout, 5, INPUT_SEEK_SECONDS | INPUT_SEEK_CUR );
+                input_Seek( p_vout, 10, INPUT_SEEK_SECONDS | INPUT_SEEK_CUR );
                 break;
             case XK_Page_Down:
-                input_Seek( p_vout, -5, INPUT_SEEK_SECONDS | INPUT_SEEK_CUR );
+                input_Seek( p_vout, -10, INPUT_SEEK_SECONDS | INPUT_SEEK_CUR );
                 break;
             case XK_space:
                 input_SetStatus( p_vout, INPUT_STATUS_PAUSE );
diff --git a/share/vlc_win32_rc.rc b/share/vlc_win32_rc.rc
index 8f084641cf4328263df9d8eff269cc4633ce6759..1512b239d5f82351c9caa2630e3b72b747da9276 100644 (file)
--- a/share/vlc_win32_rc.rc
+++ b/share/vlc_win32_rc.rc
@@ -17,7 +17,7 @@ BEGIN
     BLOCK "040904E4"
     BEGIN
       VALUE "CompanyName", "VideoLAN"
-      VALUE "FileVersion", "VERSION"
+      VALUE "FileVersion", "0.6.1"
       VALUE "FileDescription", "VLC media player"
       VALUE "LegalCopyright", "(c) 1996-2003 VideoLAN"
     END
Unnamed repository; edit this file 'description' to name the repository.