mmal/vout: Remove bad locking

This removes some bad locking. In fact this lock could cause a deadlock on
shutdown as the lock is held by the main thread when shutting down and this
function might be called as a result of shutting the ports down.

Signed-off-by: Julian Scheel <julian@jusst.de>
Signed-off-by: Rémi Denis-Courmont <remi@remlab.net>

diff --git a/modules/hw/mmal/codec.c b/modules/hw/mmal/codec.c
index 687e25b272abbc71c1c9df957d0fa4a3eaad55d2..d2424eaad8c2f82cf29c270dbcc363b8b4019f40 100644 (file)
--- a/modules/hw/mmal/codec.c
+++ b/modules/hw/mmal/codec.c
@@ -449,10 +449,8 @@ static picture_t *decode(decoder_t *dec, block_t **pblock)
      * Configure output port if necessary
      */
     if (sys->output_format) {
-        vlc_mutex_lock(&sys->mutex);
         if (change_output_format(dec) < 0)
             msg_Err(dec, "Failed to change output port format");
-        vlc_mutex_unlock(&sys->mutex);
     }
 
     /*