]> git.sesse.net Git - vlc/commitdiff
Qt4: remove incorrect use of EQ callbacks
authorRémi Denis-Courmont <remi@remlab.net>
Sat, 7 Nov 2009 14:56:21 +0000 (16:56 +0200)
committerRémi Denis-Courmont <remi@remlab.net>
Sat, 7 Nov 2009 14:57:39 +0000 (16:57 +0200)
 * deleting non-existent callback is not allowed (-> abort),
 * adding a callback but not deleting it is a bad idea,
 * deleting a callback while setting the valeu can race against other
   interfaces.

modules/gui/qt4/components/extended_panels.cpp

index 045c245525f9d44b2613f0a5975384db673d2214..240878480c4ed550050ab7ef4e955942e1a4d95b 100644 (file)
@@ -1054,13 +1054,11 @@ void Equalizer::setCorePreset( int i_preset )
     aout_instance_t *p_aout= THEMIM->getAout();
     if( p_aout )
     {
-        delCallbacks( p_aout );
         var_SetString( p_aout , "equalizer-preset" , preset_list[i_preset] );
 
         var_SetString( p_aout, "equalizer-bands", psz_values );
         var_SetFloat( p_aout, "equalizer-preamp",
                       eqz_preset_10b[i_preset]->f_preamp );
-        addCallbacks( p_aout );
         vlc_object_release( p_aout );
     }
     config_PutPsz( p_intf, "equalizer-bands", psz_values );