]> git.sesse.net Git - ffmpeg/commitdiff
avcodec/aacdec_template: Avoid undefined negation in imdct_and_windowing_eld()
authorMichael Niedermayer <michael@niedermayer.cc>
Wed, 20 Jan 2021 22:56:43 +0000 (23:56 +0100)
committerMichael Niedermayer <michael@niedermayer.cc>
Mon, 8 Mar 2021 21:08:49 +0000 (22:08 +0100)
Fixes: negation of -2147483648 cannot be represented in type 'INTFLOAT' (aka 'int'); cast to an unsigned type to negate this value to itself
Fixes: 29057/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_AAC_FIXED_fuzzer-5642758933053440
Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
libavcodec/aacdec_template.c

index aa89f7cbb8139088884bc165035609cd4153f913..7b53b27616c7ece74ceae53ace5e44f473faf158 100644 (file)
@@ -2905,7 +2905,7 @@ static void imdct_and_windowing_ld(AACContext *ac, SingleChannelElement *sce)
 
 static void imdct_and_windowing_eld(AACContext *ac, SingleChannelElement *sce)
 {
-    INTFLOAT *in    = sce->coeffs;
+    UINTFLOAT *in   = sce->coeffs;
     INTFLOAT *out   = sce->ret;
     INTFLOAT *saved = sce->saved;
     INTFLOAT *buf  = ac->buf_mdct;