]> git.sesse.net Git - ffmpeg/commitdiff
avcodec/vp8: Move end check into MB loop in vp78_decode_mv_mb_modes()
authorMichael Niedermayer <michael@niedermayer.cc>
Mon, 15 Feb 2021 16:13:34 +0000 (17:13 +0100)
committerMichael Niedermayer <michael@niedermayer.cc>
Tue, 16 Feb 2021 18:02:24 +0000 (19:02 +0100)
Fixes: Timeout (long -> 5sec)
Fixes: 30269/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_VP7_fuzzer-5430325004075008
Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg
Reviewed-by: Peter Ross <pross@xvid.org>
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
libavcodec/vp8.c

index 5fa7971f8fb3c23a998a6d1a40e344d510c412b0..89c48e6cb14a4ead0dfa97e9c8309ff82c42b1df 100644 (file)
@@ -2293,10 +2293,10 @@ int vp78_decode_mv_mb_modes(AVCodecContext *avctx, VP8Frame *curframe,
         s->mv_bounds.mv_min.x = -MARGIN;
         s->mv_bounds.mv_max.x = ((s->mb_width - 1) << 6) + MARGIN;
 
-        if (vpX_rac_is_end(&s->c)) {
-            return AVERROR_INVALIDDATA;
-        }
         for (mb_x = 0; mb_x < s->mb_width; mb_x++, mb_xy++, mb++) {
+            if (vpX_rac_is_end(&s->c)) {
+                return AVERROR_INVALIDDATA;
+            }
             if (mb_y == 0)
                 AV_WN32A((mb - s->mb_width - 1)->intra4x4_pred_mode_top,
                          DC_PRED * 0x01010101);