]> git.sesse.net Git - vlc/commitdiff
omxil: Skip a kinda-broken samsung mp3 decoder
authorMartin Storsjö <martin@martin.st>
Fri, 1 Feb 2013 09:42:19 +0000 (11:42 +0200)
committerMartin Storsjö <martin@martin.st>
Sat, 2 Feb 2013 13:58:27 +0000 (15:58 +0200)
Signed-off-by: Martin Storsjö <martin@martin.st>
modules/codec/omxil/omxil.c

index a69b41fc5bd490ce1d9a3cedbfa5a0d07e0266b7..ba73f04e99f92d80c308d8a93b61f25694ffd9f9 100644 (file)
@@ -1019,6 +1019,14 @@ loaded:
         /* Use VC1 decoder for WMV3 for now */
         if (!strcmp(p_sys->ppsz_components[i], "OMX.SEC.WMV.Decoder"))
             continue;
+        /* This decoder does work, but has an insane latency (leading to errors
+         * about "main audio output playback way too late" and dropped frames).
+         * At least Samsung Galaxy S III (where this decoder is present) has
+         * got another one, OMX.SEC.mp3.dec, that works well and has a
+         * sensible latency. (Also, even if that one isn't found, in general,
+         * using SW codecs is usually more than fast enough for MP3.) */
+        if (!strcmp(p_sys->ppsz_components[i], "OMX.SEC.MP3.Decoder"))
+            continue;
 #endif
         omx_error = InitialiseComponent(p_dec, p_sys->ppsz_components[i],
                                         &p_sys->omx_handle);