]> git.sesse.net Git - ffmpeg/commitdiff
avcodec/alsdec: Fix integer overflow with quant_cof
authorMichael Niedermayer <michael@niedermayer.cc>
Sat, 26 Dec 2020 17:55:08 +0000 (18:55 +0100)
committerMichael Niedermayer <michael@niedermayer.cc>
Tue, 5 Jan 2021 01:00:05 +0000 (02:00 +0100)
Fixes: signed integer overflow: -210824 * 16384 cannot be represented in type 'int'
Fixes: 28670/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_ALS_fuzzer-5682310846480384
Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
libavcodec/alsdec.c

index c318ad088ef6f9e2ec93695c62141713e9d07542..b3c444c54f4a601d48724626c0a1f4d789fe561f 100644 (file)
@@ -762,7 +762,7 @@ static int read_var_block_data(ALSDecContext *ctx, ALSBlockData *bd)
             }
 
             for (k = 2; k < opt_order; k++)
-                quant_cof[k] = (quant_cof[k] * (1 << 14)) + (add_base << 13);
+                quant_cof[k] = (quant_cof[k] * (1U << 14)) + (add_base << 13);
         }
     }