]> git.sesse.net Git - ffmpeg/commitdiff
avcodec/libxvid: Fix leak of AVPacket on error
authorAndreas Rheinhardt <andreas.rheinhardt@gmail.com>
Fri, 19 Mar 2021 00:38:59 +0000 (01:38 +0100)
committerAndreas Rheinhardt <andreas.rheinhardt@gmail.com>
Fri, 19 Mar 2021 01:25:09 +0000 (02:25 +0100)
Regression since 2101b99777860c853ca2321031eb3f4047dc5894.
Fixes Coverity issue #1473721.

Reviewed-by: James Almer <jamrial@gmail.com>
Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt@gmail.com>
libavcodec/libxvid.c

index 7dc6859571b08adf7df1d1fa293cf014103c6133..25b0025d5f2dfa282752fbb4fd4661aadbbd6927 100644 (file)
@@ -692,8 +692,10 @@ FF_ENABLE_DEPRECATION_WARNINGS
             return AVERROR(ENOMEM);
 
         picture = av_frame_alloc();
-        if (!picture)
+        if (!picture) {
+            av_packet_free(&packet);
             return AVERROR(ENOMEM);
+        }
 
         xerr = xvid_encore(NULL, XVID_ENC_CREATE, &xvid_enc_create, NULL);
         if( xerr ) {