]> git.sesse.net Git - ffmpeg/commitdiff
avcodec/ttadsp: Fix several integer overflows in tta_filter_process_c()
authorMichael Niedermayer <michael@niedermayer.cc>
Sun, 10 May 2020 19:12:22 +0000 (21:12 +0200)
committerMichael Niedermayer <michael@niedermayer.cc>
Mon, 11 May 2020 23:00:28 +0000 (01:00 +0200)
Fixes: signed integer overflow: 1931744255 + 252497024 cannot be represented in type 'int'
Fixes: 20492/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_TTA_fuzzer-5763348114440192
Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
libavcodec/ttadsp.c

index 056a2c7ef17d1b614fefef294db826d2a1fbaa53..1d1443aee0523045b63c69f2436196c483d4b00e 100644 (file)
 #include "ttadsp.h"
 #include "config.h"
 
-static void tta_filter_process_c(int32_t *qm, int32_t *dx, int32_t *dl,
+static void tta_filter_process_c(int32_t *qmi, int32_t *dx, int32_t *dl,
                                  int32_t *error, int32_t *in, int32_t shift,
                                  int32_t round) {
+    uint32_t *qm = qmi;
+
     if (*error < 0) {
         qm[0] -= dx[0]; qm[1] -= dx[1]; qm[2] -= dx[2]; qm[3] -= dx[3];
         qm[4] -= dx[4]; qm[5] -= dx[5]; qm[6] -= dx[6]; qm[7] -= dx[7];