Use const'ref.

Remove not necessary ";"
Fix includes

diff --git a/src/abstractmonitor.cpp b/src/abstractmonitor.cpp
index b1b3875c67577330ec83ba99c481ef58da014660..ea729887c2817fdf5ad55d35a83c257219694a1a 100644 (file)
--- a/src/abstractmonitor.cpp
+++ b/src/abstractmonitor.cpp
@@ -41,8 +41,7 @@ AbstractMonitor::AbstractMonitor(Kdenlive::MONITORID id, MonitorManager *manager
 
 AbstractMonitor::~AbstractMonitor()
 {
-    if (videoSurface)
-       delete videoSurface;
+    delete videoSurface;
 }
 
 void AbstractMonitor::createVideoSurface()

diff --git a/src/abstractmonitor.h b/src/abstractmonitor.h
index eec0cfefb30cf0af7965febcf7bc4a34f9ef5cda..b55fbd0f9d178025a5e905e06605295e9c803c4c 100644 (file)
--- a/src/abstractmonitor.h
+++ b/src/abstractmonitor.h
@@ -26,9 +26,7 @@
 #include <QVector>
 #include <QWidget>
 #include <QImage>
-#include <QPainter>
 #include <QFrame>
-#include <QTimer>
 
 #include <stdint.h>
 
@@ -43,10 +41,10 @@ Q_OBJECT public:
      *  @param name A unique identifier for this renderer
      *  @param winid The parent widget identifier (required for SDL display). Set to 0 for OpenGL rendering
      *  @param profile The MLT profile used for the renderer (default one will be used if empty). */
-    explicit AbstractRender(Kdenlive::MONITORID name, QWidget *parent = 0):QObject(parent), sendFrameForAnalysis(false), analyseAudio(false), m_name(name) {};
+    explicit AbstractRender(Kdenlive::MONITORID name, QWidget *parent = 0):QObject(parent), sendFrameForAnalysis(false), analyseAudio(false), m_name(name) {}
 
     /** @brief Destroy the MLT Renderer. */
-    virtual ~AbstractRender() {};
+    virtual ~AbstractRender() {}
 
     /** @brief This property is used to decide if the renderer should convert it's frames to QImage for use in other Kdenlive widgets. */
     bool sendFrameForAnalysis;
@@ -54,7 +52,7 @@ Q_OBJECT public:
     /** @brief This property is used to decide if the renderer should send audio data for monitoring. */
     bool analyseAudio;
     
-    const QString &name() const {return m_name;};
+    const QString &name() const {return m_name;}
 
     /** @brief Someone needs us to send again a frame. */
     virtual void sendFrameUpdate() = 0;

diff --git a/src/kthumb.cpp b/src/kthumb.cpp
index 2c8ac9b7cfbe628d00b6088334e9e089ec456d5d..63b41efb2841388d25a75554c4ebb505bee9a953 100644 (file)
--- a/src/kthumb.cpp
+++ b/src/kthumb.cpp
@@ -39,8 +39,9 @@
 #include <QApplication>
 #include <QtConcurrentRun>
 #include <QVarLengthArray>
+#include <QPainter>
 
-KThumb::KThumb(ClipManager *clipManager, KUrl url, const QString &id, const QString &hash, QObject * parent) :
+KThumb::KThumb(ClipManager *clipManager, const KUrl &url, const QString &id, const QString &hash, QObject * parent) :
     QObject(parent),
     m_url(url),
     m_thumbFile(),

diff --git a/src/kthumb.h b/src/kthumb.h
index 70b9041230c3747bcf9def6980c2f9bf72eafec5..148aaa73f4bb9b1803d72e7b04e53b4d2147a66b 100644 (file)
--- a/src/kthumb.h
+++ b/src/kthumb.h
@@ -50,10 +50,10 @@ typedef QMap <int, QMap <int, QByteArray> > audioByteArray;
 
 class KThumb: public QObject
 {
-Q_OBJECT public:
+   Q_OBJECT 
+public:
 
-
-    KThumb(ClipManager *clipManager, KUrl url, const QString &id, const QString &hash, QObject * parent = 0);
+    KThumb(ClipManager *clipManager, const KUrl &url, const QString &id, const QString &hash, QObject * parent = 0);
     ~KThumb();
     void setProducer(Mlt::Producer *producer);
     bool hasProducer() const;

diff --git a/src/mltdevicecapture.cpp b/src/mltdevicecapture.cpp
index 629ed5175941dc723e5dfad2f473a29058832dfc..b55556dcbd1a8d0bd07fa60c55943550b3069b17 100644 (file)
--- a/src/mltdevicecapture.cpp
+++ b/src/mltdevicecapture.cpp
@@ -33,6 +33,7 @@
 #include <QString>
 #include <QApplication>
 #include <QThread>
+#include <QTimer>
 
 #include <cstdlib>
 #include <cstdarg>

diff --git a/src/mltdevicecapture.h b/src/mltdevicecapture.h
index b0004a31519c86c0b630394bd6779a39b207616b..91faa5baf4e8939cc97a7ff3c1bc7b45e696a295 100644 (file)
--- a/src/mltdevicecapture.h
+++ b/src/mltdevicecapture.h
@@ -30,7 +30,8 @@
 #include <mlt/framework/mlt_types.h>
 
 #include <QtConcurrentRun>
-
+#include <QTimer>
+ 
 namespace Mlt
 {
 class Consumer;

diff --git a/src/renderer.h b/src/renderer.h
index 26add5a8810d6d5fdfc062cc4fc7d0b24eb130fa..d0c7d34a25475494fa3564bf365a2341923de213 100644 (file)
--- a/src/renderer.h
+++ b/src/renderer.h
@@ -45,8 +45,8 @@
 #include <QMutex>
 #include <QFuture>
 #include <QSemaphore>
+#include <QTimer>
 
-class QTimer;
 class QPixmap;
 
 class KComboBox;