]> git.sesse.net Git - ffmpeg/commitdiff
avformat/matroskaenc: Use comparison instead of assignment
authorAndreas Rheinhardt <andreas.rheinhardt@gmail.com>
Wed, 22 Apr 2020 01:42:00 +0000 (03:42 +0200)
committerAndreas Rheinhardt <andreas.rheinhardt@gmail.com>
Wed, 22 Apr 2020 01:45:44 +0000 (03:45 +0200)
This bug was introduced in 3589b3f2e217e78d16a92b372d95ce4a3f7df896.
Fixes Coverity ID 1462425.

Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt@gmail.com>
libavformat/matroskaenc.c

index 0034e225efb5fbd3bdc1cc1a27c5bef28fd071ce..784973a9515700a707c7bc8d11e40515d3a99a5c 100644 (file)
@@ -1733,7 +1733,7 @@ static int mkv_write_attachments(AVFormatContext *s)
             const AVCodecDescriptor *desc = avcodec_descriptor_get(st->codecpar->codec_id);
             if (desc && desc->mime_types) {
                 mimetype = desc->mime_types[0];
-            } else if (st->codecpar->codec_id = AV_CODEC_ID_TEXT)
+            } else if (st->codecpar->codec_id == AV_CODEC_ID_TEXT)
                 mimetype = "text/plain";
         }
         if (!mimetype) {