]> git.sesse.net Git - ffmpeg/commitdiff
tools/zmqsend: Avoid mem copy past the end of input buffer
authorAndriy Gelman <andriy.gelman@gmail.com>
Thu, 8 Aug 2019 14:37:10 +0000 (10:37 -0400)
committerMichael Niedermayer <michael@niedermayer.cc>
Fri, 9 Aug 2019 21:18:58 +0000 (23:18 +0200)
This patch avoids a read past the end of the input buffer in memcpy since the size
of the received zmq message is recv_buf_size - 1.

Reviewed-by: Paul B Mahol <onemda@gmail.com>
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
tools/zmqsend.c

index 7bd7fe4199c29b3d62c6293349a0f35ad39a75c0..f26fa9c1c24301af6dc9a007fd70a949b822d43d 100644 (file)
@@ -155,7 +155,7 @@ int main(int argc, char **argv)
         ret = 1;
         goto end;
     }
-    memcpy(recv_buf, zmq_msg_data(&msg), recv_buf_size);
+    memcpy(recv_buf, zmq_msg_data(&msg), recv_buf_size - 1);
     recv_buf[recv_buf_size-1] = 0;
     printf("%s\n", recv_buf);
     zmq_msg_close(&msg);