- WTF?! Do not use non-existant vlc_closedir_wrapper

- Do not leak result from utf8_readdir (ALWAYS strdup'ed).

diff --git a/modules/demux/mkv.cpp b/modules/demux/mkv.cpp
index 6a2823c53cd8e207ab2b7ccc0d64b2f2f7c6914e..5600c07e3f847eef2f9be76fb8c0eda5a66dc7cc 100644 (file)
--- a/modules/demux/mkv.cpp
+++ b/modules/demux/mkv.cpp
@@ -1547,9 +1547,9 @@ static int Open( vlc_object_t * p_this )
                             }
                         }
                     }
-                    LocaleFree (psz_file);
+                    free (psz_file);
                 }
-                vlc_closedir_wrapper( p_src_dir );
+                closedir( p_src_dir );
             }
         }
 

diff --git a/modules/gui/ncurses.c b/modules/gui/ncurses.c
index 15a77b9d7fb1b0978e51bead4f33408ad9fe271b..857db4fb6e082454bb273ec40e09d6a56d18d6b5 100644 (file)
--- a/modules/gui/ncurses.c
+++ b/modules/gui/ncurses.c
@@ -1995,7 +1995,7 @@ static void ReadDir( intf_thread_t *p_intf )
         qsort( p_sys->pp_dir_entries, p_sys->i_dir_entries,
                sizeof(struct dir_entry_t*), &comp_dir_entries );
 
-        vlc_closedir_wrapper( p_current_dir );
+        closedir( p_current_dir );
         return;
     }
     else

diff --git a/modules/misc/gnutls.c b/modules/misc/gnutls.c
index 2ee21b32371a3becc588bd3237ad56e9f841c8e3..58a052af90fc560b00c21ad9f4057d250bca4ee8 100644 (file)
--- a/modules/misc/gnutls.c
+++ b/modules/misc/gnutls.c
@@ -597,7 +597,7 @@ gnutls_Addx509Directory( vlc_object_t *p_this,
          || fstat( fd, &st1 ) || utf8_lstat( psz_dirname, &st2 )
          || S_ISLNK( st2.st_mode ) || ( st1.st_ino != st2.st_ino ) )
         {
-            vlc_closedir_wrapper( dir );
+            closedir( dir );
             return VLC_EGENERIC;
         }
     }
@@ -619,7 +619,7 @@ gnutls_Addx509Directory( vlc_object_t *p_this,
         gnutls_Addx509File( p_this, cred, path, b_priv );
     }
 
-    vlc_closedir_wrapper( dir );
+    closedir( dir );
     return VLC_SUCCESS;
 }
 

diff --git a/src/text/unicode.c b/src/text/unicode.c
index 5fa2843cfeddaad6fd92e7834363ebd1e866239e..5b4adf4a66c352d720368eab5f7cdf71701bc9ac 100644 (file)
--- a/src/text/unicode.c
+++ b/src/text/unicode.c
@@ -436,7 +436,8 @@ int utf8_mkdir( const char *dirname )
  *
  * @param dirname UTF-8 representation of the directory name
  *
- * @return a pointer to the DIR struct. Use vlc_closedir_wrapper() once you are done.
+ * @return a pointer to the DIR struct. Release with closedir().
+ */
 DIR *utf8_opendir( const char *dirname )
 {
 #ifdef WIN32
@@ -531,7 +532,7 @@ int utf8_scandir( const char *dirname, char ***namelist,
             tab = newtab;
             tab[num++] = entry;
         }
-        vlc_closedir_wrapper( dir );
+        closedir( dir );
 
         if( compar != NULL )
             qsort( tab, num, sizeof( tab[0] ),

diff --git a/src/video_output/vout_intf.c b/src/video_output/vout_intf.c
index 38122186c7412fa937c27e6f7b192253e00804e2..f2c7c24894a5ad202116df793fa33b382fc27b3c 100644 (file)
--- a/src/video_output/vout_intf.c
+++ b/src/video_output/vout_intf.c
@@ -637,7 +637,7 @@ int vout_Snapshot( vout_thread_t *p_vout, picture_t *p_pic )
         char *psz_prefix = var_GetString( p_vout, "snapshot-prefix" );
         if( !psz_prefix ) psz_prefix = strdup( "vlcsnap-" );
 
-        vlc_closedir_wrapper( path );
+        closedir( path );
         if( var_GetBool( p_vout, "snapshot-sequential" ) == VLC_TRUE )
         {
             int i_num = var_GetInteger( p_vout, "snapshot-num" );