]> git.sesse.net Git - casparcg/commitdiff
2.0.0.2: ffmpeg_producer: Refactored.
authorronag <ronag@362d55ac-95cf-4e76-9f9a-cbaa9c17b72d>
Mon, 23 May 2011 21:09:03 +0000 (21:09 +0000)
committerronag <ronag@362d55ac-95cf-4e76-9f9a-cbaa9c17b72d>
Mon, 23 May 2011 21:09:03 +0000 (21:09 +0000)
git-svn-id: https://casparcg.svn.sourceforge.net/svnroot/casparcg/server/branches/2.0.0.2@805 362d55ac-95cf-4e76-9f9a-cbaa9c17b72d

modules/ffmpeg/producer/audio/audio_decoder.cpp
modules/ffmpeg/producer/audio/audio_decoder.h
modules/ffmpeg/producer/ffmpeg_producer.cpp
modules/ffmpeg/producer/input.cpp
modules/ffmpeg/producer/input.h
modules/ffmpeg/producer/video/video_decoder.cpp
modules/ffmpeg/producer/video/video_decoder.h

index 5e57252f214eaadea6317a458da7c58b69d09543..e68bdc912f8adf4634e9cedef81d31ace9a77d66 100644 (file)
@@ -39,14 +39,14 @@ extern "C"
 namespace caspar {\r
 \r
 struct audio_decoder::implementation : boost::noncopyable\r
-{\r
-       typedef std::vector<short, tbb::cache_aligned_allocator<short>> aligned_buffer;\r
-       \r
+{      \r
        AVCodecContext& codec_context_;\r
                \r
        const core::video_format_desc format_desc_;\r
 \r
-       aligned_buffer current_chunk_;\r
+       std::vector<short> current_chunk_;\r
+\r
+       std::vector<std::vector<short>> chunks_;\r
 \r
 public:\r
        explicit implementation(AVCodecContext& codec_context, const core::video_format_desc& format_desc) \r
@@ -64,12 +64,10 @@ public:
                }\r
        }\r
                \r
-       std::vector<std::vector<short>> execute(std::shared_ptr<AVPacket>&& audio_packet)\r
+       void push(std::shared_ptr<AVPacket>&& audio_packet)\r
        {       \r
-               std::vector<std::vector<short>> result;\r
-\r
                if(!audio_packet)\r
-                       return result;\r
+                       return;\r
 \r
                auto s = current_chunk_.size();\r
                current_chunk_.resize(s + 4*format_desc_.audio_sample_rate*2+FF_INPUT_BUFFER_PADDING_SIZE/2);\r
@@ -89,14 +87,30 @@ public:
                const auto last = current_chunk_.end() - current_chunk_.size() % format_desc_.audio_samples_per_frame;\r
                \r
                for(auto it = current_chunk_.begin(); it != last; it += format_desc_.audio_samples_per_frame)           \r
-                       result.push_back(std::vector<short>(it, it + format_desc_.audio_samples_per_frame));            \r
+                       chunks_.push_back(std::vector<short>(it, it + format_desc_.audio_samples_per_frame));           \r
 \r
                current_chunk_.erase(current_chunk_.begin(), last);\r
-                               \r
-               return result;\r
+       }\r
+\r
+       bool empty() const\r
+       {\r
+               return chunks_.empty();\r
+       }\r
+\r
+       std::vector<short> front()\r
+       {\r
+               return chunks_.front();\r
+       }\r
+\r
+       void pop()\r
+       {\r
+               chunks_.pop_back();\r
        }\r
 };\r
 \r
 audio_decoder::audio_decoder(AVCodecContext& codec_context, const core::video_format_desc& format_desc) : impl_(new implementation(codec_context, format_desc)){}\r
-std::vector<std::vector<short>> audio_decoder::execute(std::shared_ptr<AVPacket>&& audio_packet){return impl_->execute(std::move(audio_packet));}\r
+void audio_decoder::push(std::shared_ptr<AVPacket>&& audio_packet){impl_->push(std::move(audio_packet));}\r
+bool audio_decoder::empty() const {return impl_->empty();}\r
+std::vector<short> audio_decoder::front() {return impl_->front();}\r
+void audio_decoder::pop(){impl_->pop();}\r
 }
\ No newline at end of file
index 6121fbc10bace930fc6897cf9e322ecd79b61a13..5291526ef04f68a6102d57f7529fd54f222ae09a 100644 (file)
@@ -36,7 +36,11 @@ class audio_decoder : boost::noncopyable
 {\r
 public:\r
        explicit audio_decoder(AVCodecContext& codec_context, const core::video_format_desc& format_desc);\r
-       std::vector<std::vector<short>> execute(std::shared_ptr<AVPacket>&& audio_packet);\r
+       void push(std::shared_ptr<AVPacket>&& audio_packet);\r
+       \r
+       bool empty() const;\r
+       std::vector<short> front();\r
+       void pop();\r
 private:\r
        struct implementation;\r
        std::shared_ptr<implementation> impl_;\r
index 30f66590871d5a898a9ae5002853af8895c4e499..51ff7dfc568609c13df7ae69401915cba04e3c38 100644 (file)
@@ -47,18 +47,11 @@ namespace caspar {
        \r
 struct ffmpeg_producer : public core::frame_producer\r
 {\r
-       static const size_t                                             DECODED_PACKET_BUFFER_SIZE = 4;\r
-       static const size_t                                             MAX_PACKET_OFFSET = 64; // Avoid infinite looping.\r
-\r
        const std::wstring                                              filename_;\r
-       const bool                                                              loop_;\r
        \r
        const safe_ptr<diagnostics::graph>              graph_;\r
        boost::timer                                                    frame_timer_;\r
-               \r
-       std::deque<safe_ptr<core::write_frame>> video_frame_buffer_;    \r
-       std::deque<std::vector<short>>                  audio_chunk_buffer_;\r
-                       \r
+                                       \r
        const safe_ptr<core::frame_factory>             frame_factory_;\r
 \r
        input                                                                   input_; \r
@@ -67,10 +60,9 @@ struct ffmpeg_producer : public core::frame_producer
 public:\r
        explicit ffmpeg_producer(const safe_ptr<core::frame_factory>& frame_factory, const std::wstring& filename, bool loop, int start, int length) \r
                : filename_(filename)\r
-               , loop_(loop) \r
                , graph_(diagnostics::create_graph(narrow(print())))\r
                , frame_factory_(frame_factory)         \r
-               , input_(safe_ptr<diagnostics::graph>(graph_), filename_, loop_, start)\r
+               , input_(safe_ptr<diagnostics::graph>(graph_), filename_, loop, start)\r
        {\r
                graph_->add_guide("frame-time", 0.5);\r
                graph_->set_color("frame-time",  diagnostics::color(1.0f, 0.0f, 0.0f));\r
@@ -80,155 +72,93 @@ public:
                double format_frame_time = 1.0/frame_factory->get_video_format_desc().fps;\r
                if(abs(frame_time - format_frame_time) > 0.0001 && abs(frame_time - format_frame_time/2) > 0.0001)\r
                        CASPAR_LOG(warning) << print() << L" Invalid framerate detected. This may cause distorted audio during playback. frame-time: " << frame_time;\r
-\r
-               try\r
-               {                       \r
-                       video_decoder_.reset(input_.get_video_codec_context() ? \r
-                               new video_decoder(*input_.get_video_codec_context(), frame_factory) : nullptr);\r
-               }\r
-               catch(...)\r
-               {\r
-                       CASPAR_LOG_CURRENT_EXCEPTION();\r
-                       CASPAR_LOG(warning) << print() << " failed to initialize video-decoder.";\r
-               }\r
                \r
-               try\r
-               {                       \r
-                       audio_decoder_.reset(input_.get_audio_codec_context() ? \r
-                               new audio_decoder(*input_.get_audio_codec_context(), frame_factory->get_video_format_desc()) : nullptr);\r
-               }\r
-               catch(...)\r
-               {\r
-                       CASPAR_LOG_CURRENT_EXCEPTION();\r
-                       CASPAR_LOG(warning) << print() << " failed to initialize audio-decoder.";\r
-               }               \r
-\r
-               if(!video_decoder_ && !audio_decoder_)\r
-               {\r
-                       BOOST_THROW_EXCEPTION(\r
-                               caspar_exception() <<\r
-                               source_info(narrow(print())) << \r
-                               msg_info("Failed to initialize any decoder"));\r
-               }\r
+               video_decoder_.reset(input_.get_video_codec_context() ? \r
+                       new video_decoder(*input_.get_video_codec_context(), frame_factory) : nullptr);\r
                        \r
-               // Pre-roll since first frames can be heavy.\r
-               while(video_frame_buffer_.size() < DECODED_PACKET_BUFFER_SIZE && \r
-                         audio_chunk_buffer_.size() < DECODED_PACKET_BUFFER_SIZE && \r
-                         input_.has_packet())\r
-               {\r
-                       try_decode_packet();\r
-               }\r
+               audio_decoder_.reset(input_.get_audio_codec_context() ? \r
+                       new audio_decoder(*input_.get_audio_codec_context(), frame_factory->get_video_format_desc()) : nullptr);                \r
+                                       \r
+               // Fill buffers.\r
+               decode_next_packets();\r
        }\r
 \r
        virtual safe_ptr<core::basic_frame> receive()\r
        {\r
                frame_timer_.restart();\r
 \r
-               std::shared_ptr<core::basic_frame> frame;       \r
-               for(size_t n = 0; !frame && input_.has_packet() && n < MAX_PACKET_OFFSET ; ++n) \r
-                       frame = try_get_frame();\r
+               auto result = decode_frame();\r
                                \r
                graph_->update_value("frame-time", static_cast<float>(frame_timer_.elapsed()*frame_factory_->get_video_format_desc().fps*0.5));\r
                                        \r
-               if(frame)\r
-                       return make_safe(frame);\r
-               \r
-               if(!input_.is_running())\r
-                       return core::basic_frame::eof();\r
-\r
-               if(!video_decoder_ && !audio_decoder_)\r
-                       return core::basic_frame::eof();\r
-                       \r
-               graph_->add_tag("underflow");\r
-               return core::basic_frame::late();       \r
+               return result;\r
        }\r
        \r
        virtual std::wstring print() const\r
        {\r
                return L"ffmpeg[" + boost::filesystem::wpath(filename_).filename() + L"]";\r
        }\r
-       \r
-       void try_decode_packet()\r
+\r
+       void decode_next_packets()\r
        {\r
                tbb::parallel_invoke\r
                (\r
                        [&]\r
                        {\r
-                               if(video_frame_buffer_.size() < DECODED_PACKET_BUFFER_SIZE)\r
-                                       try_decode_video_packet(input_.get_video_packet());\r
+                               std::shared_ptr<AVPacket> pkt;\r
+                               for(int n = 0; n < 8 && video_decoder_ && video_decoder_->empty() && input_.try_pop_video_packet(pkt); ++n)\r
+                                       video_decoder_->push(std::move(pkt));\r
                        }, \r
                        [&]\r
                        {\r
-                               if(audio_chunk_buffer_.size() < DECODED_PACKET_BUFFER_SIZE)\r
-                                       try_decode_audio_packet(input_.get_audio_packet());\r
+                               std::shared_ptr<AVPacket> pkt;\r
+                               for(int n = 0; n < 8 && audio_decoder_ && audio_decoder_->empty() && input_.try_pop_audio_packet(pkt); ++n)\r
+                                       audio_decoder_->push(std::move(pkt));\r
                        }\r
                );      \r
        }\r
 \r
-       void try_decode_video_packet(std::shared_ptr<AVPacket>&& video_packet)\r
+       safe_ptr<core::basic_frame> decode_frame()\r
        {\r
-               if(!video_decoder_)\r
-                       return;\r
+               decode_next_packets();\r
 \r
-               try\r
-               {\r
-                       boost::range::push_back(video_frame_buffer_, video_decoder_->execute(std::move(video_packet)));\r
-               }\r
-               catch(...)\r
+               if(video_decoder_ && !video_decoder_->empty() && audio_decoder_ && !audio_decoder_->empty())\r
                {\r
-                       CASPAR_LOG_CURRENT_EXCEPTION();\r
-                       video_decoder_.reset();\r
-                       CASPAR_LOG(warning) << print() << " removed video-stream.";\r
-               }\r
-       }\r
-\r
-       void try_decode_audio_packet(std::shared_ptr<AVPacket>&& audio_packet)\r
-       {\r
-               if(!audio_decoder_)\r
-                       return;\r
+                       auto frame = std::move(video_decoder_->front());                                \r
+                       video_decoder_->pop();\r
+                               \r
+                       frame->audio_data() = std::move(audio_decoder_->front());\r
+                       audio_decoder_->pop();\r
 \r
-               try\r
-               {\r
-                       boost::range::push_back(audio_chunk_buffer_, audio_decoder_->execute(std::move(audio_packet)));\r
+                       return frame;\r
                }\r
-               catch(...)\r
+               else if(video_decoder_ && !video_decoder_->empty() && !audio_decoder_)\r
                {\r
-                       CASPAR_LOG_CURRENT_EXCEPTION();\r
-                       audio_decoder_.reset();\r
-                       CASPAR_LOG(warning) << print() << " removed audio-stream.";\r
-               }\r
-       }\r
-\r
-       std::shared_ptr<core::basic_frame> try_get_frame()\r
-       {               \r
-               try_decode_packet();\r
-\r
-               std::shared_ptr<core::write_frame> frame;       \r
+                       auto frame = std::move(video_decoder_->front());                                \r
+                       video_decoder_->pop();\r
+                       frame->get_audio_transform().set_has_audio(false);      \r
 \r
-               if(!video_frame_buffer_.empty() && !audio_chunk_buffer_.empty())\r
+                       return frame;\r
+               }\r
+               else if(audio_decoder_ && !audio_decoder_->empty() && !video_decoder_)\r
                {\r
-                       frame = video_frame_buffer_.front();                            \r
-                       video_frame_buffer_.pop_front();\r
+                       auto frame = frame_factory_->create_frame(this, 1, 1);\r
+                       std::fill(frame->image_data().begin(), frame->image_data().end(), 0);\r
                                \r
-                       frame->audio_data() = std::move(audio_chunk_buffer_.front());\r
-                       audio_chunk_buffer_.pop_front();        \r
+                       frame->audio_data() = std::move(audio_decoder_->front());\r
+                       audio_decoder_->pop();\r
+\r
+                       return frame;\r
                }\r
-               else if(!video_frame_buffer_.empty() && !audio_decoder_)\r
+               else if(!input_.is_running() || (!video_decoder_ && !audio_decoder_))\r
                {\r
-                       frame = std::move(video_frame_buffer_.front());                         \r
-                       video_frame_buffer_.pop_front();\r
-                       frame->get_audio_transform().set_has_audio(false);      \r
+                       return core::basic_frame::eof();\r
                }\r
-               else if(!audio_chunk_buffer_.empty() && !video_decoder_)\r
+               else\r
                {\r
-                       frame = frame_factory_->create_frame(this, 1, 1);\r
-                       std::fill(frame->image_data().begin(), frame->image_data().end(), 0);\r
-                               \r
-                       frame->audio_data() = std::move(audio_chunk_buffer_.front());\r
-                       audio_chunk_buffer_.pop_front();\r
+                       graph_->add_tag("underflow");\r
+                       return core::basic_frame::late();\r
                }\r
-               \r
-               return frame;   \r
        }\r
 };\r
 \r
index 1e6ff9ab7226a1c4ac337f66e40d312cb6d805b8..733f8627a608415399fb4026d65310f139bb7d3d 100644 (file)
@@ -92,11 +92,9 @@ public:
                return errn;    \r
        }\r
 \r
-       std::shared_ptr<AVPacket> pop()\r
+       bool try_pop(std::shared_ptr<AVPacket>& pkt)\r
        {\r
-               std::shared_ptr<AVPacket> pkt;\r
-               buffer_.try_pop(pkt);\r
-               return pkt;\r
+               return buffer_.try_pop(pkt);\r
        }\r
 \r
        void push(const std::shared_ptr<AVPacket>& pkt)\r
@@ -207,21 +205,17 @@ public:
                stop();\r
        }\r
                \r
-       std::shared_ptr<AVPacket> get_video_packet()\r
-       {\r
-               return video_stream_.pop();\r
-       }\r
 \r
-       std::shared_ptr<AVPacket> get_audio_packet()\r
+       bool try_pop_video_packet(std::shared_ptr<AVPacket>& packet)\r
        {\r
-               return audio_stream_.pop();\r
+               return video_stream_.try_pop(packet);\r
        }\r
 \r
-       bool has_packet() const\r
+       bool try_pop_audio_packet(std::shared_ptr<AVPacket>& packet)\r
        {\r
-               return !video_stream_.empty() || !audio_stream_.empty();\r
+               return audio_stream_.try_pop(packet);\r
        }\r
-                               \r
+\r
        double fps()\r
        {\r
                return fps_;\r
@@ -232,8 +226,12 @@ private:
        void stop()\r
        {\r
                executor_.stop();\r
-               get_video_packet();\r
-               get_audio_packet();\r
+\r
+               // Unblock thread.\r
+               std::shared_ptr<AVPacket> packet;\r
+               try_pop_video_packet(packet);\r
+               try_pop_audio_packet(packet);\r
+\r
                CASPAR_LOG(info) << print() << " Stopping.";\r
        }\r
 \r
@@ -332,9 +330,8 @@ input::input(const safe_ptr<diagnostics::graph>& graph, const std::wstring& file
        : impl_(new implementation(graph, filename, loop, start)){}\r
 const std::shared_ptr<AVCodecContext>& input::get_video_codec_context() const{return impl_->video_stream_.ctx();}\r
 const std::shared_ptr<AVCodecContext>& input::get_audio_codec_context() const{return impl_->audio_stream_.ctx();}\r
-bool input::has_packet() const{return impl_->has_packet();}\r
 bool input::is_running() const {return impl_->executor_.is_running();}\r
-std::shared_ptr<AVPacket> input::get_video_packet(){return impl_->get_video_packet();}\r
-std::shared_ptr<AVPacket> input::get_audio_packet(){return impl_->get_audio_packet();}\r
+bool input::try_pop_video_packet(std::shared_ptr<AVPacket>& packet){return impl_->try_pop_video_packet(packet);}\r
+bool input::try_pop_audio_packet(std::shared_ptr<AVPacket>& packet){return impl_->try_pop_audio_packet(packet);}\r
 double input::fps() const { return impl_->fps(); }\r
 }
\ No newline at end of file
index ad8c23a94a449e3f18f350268f790e48118c8a81..587579fbd526e1f7b00624ad42c3e5178dea28ec 100644 (file)
@@ -35,10 +35,11 @@ public:
        const std::shared_ptr<AVCodecContext>& get_video_codec_context() const;\r
        const std::shared_ptr<AVCodecContext>& get_audio_codec_context() const;\r
 \r
-       std::shared_ptr<AVPacket> get_video_packet();\r
-       std::shared_ptr<AVPacket> get_audio_packet();\r
+       bool try_pop_video_packet(std::shared_ptr<AVPacket>& packet);\r
+       bool try_pop_audio_packet(std::shared_ptr<AVPacket>& packet);\r
 \r
-       bool has_packet() const;\r
+       bool has_video_packet() const;\r
+       bool has_audio_packet() const;\r
        bool is_running() const;\r
        double fps() const;\r
 private:\r
index 459314df67b6bf73d08600d2b8a2e8bf5d5a6f62..bf716ba8f1807cb748a6270267f8a70222ef098d 100644 (file)
@@ -124,6 +124,7 @@ struct video_decoder::implementation : boost::noncopyable
        const int                                                                       height_;\r
        const PixelFormat                                                       pix_fmt_;\r
        core::pixel_format_desc                                         desc_;\r
+       std::vector<safe_ptr<core::write_frame>>        frames_;\r
 \r
 public:\r
        explicit implementation(AVCodecContext& codec_context, const safe_ptr<core::frame_factory>& frame_factory) \r
@@ -148,12 +149,10 @@ public:
                }\r
        }\r
        \r
-       std::vector<safe_ptr<core::write_frame>> execute(std::shared_ptr<AVPacket>&& video_packet)\r
+       void push(std::shared_ptr<AVPacket>&& video_packet)\r
        {                               \r
-               std::vector<safe_ptr<core::write_frame>> result;\r
-\r
                if(!video_packet)\r
-                       return result;\r
+                       return;\r
        \r
                safe_ptr<AVFrame> decoded_frame(avcodec_alloc_frame(), av_free);\r
 \r
@@ -170,9 +169,7 @@ public:
                }\r
                \r
                if(frame_finished != 0)         \r
-                       result.push_back(make_write_frame(decoded_frame));\r
-\r
-               return result;\r
+                       frames_.push_back(make_write_frame(decoded_frame));\r
        }\r
 \r
        safe_ptr<core::write_frame> make_write_frame(safe_ptr<AVFrame> decoded_frame)\r
@@ -211,9 +208,27 @@ public:
 \r
                return write;\r
        }\r
+\r
+       bool empty() const\r
+       {\r
+               return frames_.empty();\r
+       }\r
+\r
+       safe_ptr<core::write_frame> front()\r
+       {\r
+               return frames_.front();\r
+       }\r
+\r
+       void pop()\r
+       {\r
+               frames_.pop_back();\r
+       }\r
 };\r
 \r
 video_decoder::video_decoder(AVCodecContext& codec_context, const safe_ptr<core::frame_factory>& frame_factory) : impl_(new implementation(codec_context, frame_factory)){}\r
-std::vector<safe_ptr<core::write_frame>> video_decoder::execute(std::shared_ptr<AVPacket>&& video_packet){return impl_->execute(std::move(video_packet));}\r
+void video_decoder::push(std::shared_ptr<AVPacket>&& video_packet){impl_->push(std::move(video_packet));}\r
+bool video_decoder::empty() const {return impl_->empty();}\r
+safe_ptr<core::write_frame> video_decoder::front() {return impl_->front();}\r
+void video_decoder::pop(){impl_->pop();}\r
 \r
 }
\ No newline at end of file
index 7b402dce0b73069eda34572b2d0eeed4b42009e7..ddb9c94cf48f75bf8aed036eda368cc71c04e608 100644 (file)
@@ -34,7 +34,11 @@ class video_decoder : boost::noncopyable
 {\r
 public:\r
        explicit video_decoder(AVCodecContext& codec_context, const safe_ptr<core::frame_factory>& frame_factory);\r
-       std::vector<safe_ptr<core::write_frame>> execute(std::shared_ptr<AVPacket>&& video_packet);     \r
+       void push(std::shared_ptr<AVPacket>&& video_packet);    \r
+\r
+       bool empty() const;\r
+       safe_ptr<core::write_frame> front();\r
+       void pop();\r
 private:\r
        struct implementation;\r
        safe_ptr<implementation> impl_;\r