Fix double free

diff --git a/modules/gui/qt4/components/complete_preferences.cpp b/modules/gui/qt4/components/complete_preferences.cpp
index 84cb7943fe23cfe4c389f17e5231d50a27113cdd..f144fc87c98ff8dc32b31a86f65c8849462a9780 100644 (file)
--- a/modules/gui/qt4/components/complete_preferences.cpp
+++ b/modules/gui/qt4/components/complete_preferences.cpp
@@ -86,9 +86,7 @@ PrefsTree::PrefsTree( intf_thread_t *_p_intf, QWidget *_parent ) :
     PrefsItemData *data = NULL;
     QTreeWidgetItem *current_item = NULL;
     unsigned confsize;
-    module_config_t *p_config;
-
-    p_config = module_GetConfig (p_module, &confsize);
+    module_config_t *const p_config = module_GetConfig (p_module, &confsize);
 
     for (size_t i = 0; i < confsize; i++)
     {
@@ -193,7 +191,7 @@ PrefsTree::PrefsTree( intf_thread_t *_p_intf, QWidget *_parent ) :
 
         unsigned i_subcategory = 0, i_category = 0, confsize;
         bool b_options = false;
-        module_config_t *p_config = module_GetConfig (p_module, &confsize);
+        module_config_t *const p_config = module_GetConfig (p_module, &confsize);
 
         for (size_t i = 0; i < confsize; i++)
         {
@@ -346,7 +344,7 @@ AdvPrefsPanel::AdvPrefsPanel( intf_thread_t *_p_intf, QWidget *_parent,
     }
 
     unsigned confsize;
-    module_config_t *p_config = module_GetConfig (p_module, &confsize),
+    module_config_t *const p_config = module_GetConfig (p_module, &confsize),
                     *p_item = p_config,
                     *p_end = p_config + confsize;
 
@@ -363,7 +361,6 @@ AdvPrefsPanel::AdvPrefsPanel( intf_thread_t *_p_intf, QWidget *_parent,
             p_item++;
         }
     }
-    module_PutConfig (p_config);
 
     /* Widgets now */
     global_layout = new QVBoxLayout();