]> git.sesse.net Git - vlc/commitdiff
omxil: Ignore a codec that we know we don't work well with
authorMartin Storsjö <martin@martin.st>
Mon, 25 Feb 2013 20:32:46 +0000 (22:32 +0200)
committerMartin Storsjö <martin@martin.st>
Mon, 25 Feb 2013 20:32:46 +0000 (22:32 +0200)
This still keeps the mapping for VC1 and WMV3 that works fine on
e.g. Samsung Galaxy S3, without negatively affecting other devices
that expose decoders with this role but that we don't work well
with.

Signed-off-by: Martin Storsjö <martin@martin.st>
modules/codec/omxil/omxil.c

index 8adcb42fd0bc00ac2cb1aa5dd455995f26a69b51..8f35c6cc0a67727b0a82ad37b620bccf381dd77f 100644 (file)
@@ -1007,6 +1007,12 @@ loaded:
          * using SW codecs is usually more than fast enough for MP3.) */
         if (!strcmp(p_sys->ppsz_components[i], "OMX.SEC.MP3.Decoder"))
             continue;
+        /* This codec should be able to handle both VC1 and WMV3, but
+         * for VC1 it doesn't output any buffers at all (in the way we use
+         * it) and for WMV3 it outputs plain black buffers. Thus ignore
+         * it until we can make it work properly. */
+        if (!strcmp(p_sys->ppsz_components[i], "OMX.Nvidia.vc1.decode"))
+            continue;
 #endif
         omx_error = InitialiseComponent(p_dec, p_sys->ppsz_components[i],
                                         &p_sys->omx_handle);