]> git.sesse.net Git - mlt/commitdiff
kdenlive/producer_framebuffer.c: check return values
authorMikko Rapeli <mikko.rapeli@iki.fi>
Mon, 30 Jul 2012 16:20:24 +0000 (18:20 +0200)
committerMikko Rapeli <mikko.rapeli@iki.fi>
Mon, 6 Aug 2012 16:37:25 +0000 (18:37 +0200)
Check calloc() return and fix Coverity CID 709328: Unchecked return value (CHECKED_RETURN)
Calling function "mlt_producer_init" without checking return value (as is done elsewhere 19 out of 20 times).
No check of the return value of "mlt_producer_init(producer, NULL)".
254        mlt_producer_init( producer, NULL );

src/modules/kdenlive/producer_framebuffer.c

index bdc8434cd52c8a1e83e7acd76a685c0c1998af21..d7bd900730645e12af81731b187e6f7db82ec782 100644 (file)
@@ -252,7 +252,14 @@ mlt_producer producer_framebuffer_init( mlt_profile profile, mlt_service_type ty
        if ( !arg ) return NULL;
        mlt_producer producer = NULL;
        producer = calloc( 1, sizeof( struct mlt_producer_s ) );
-       mlt_producer_init( producer, NULL );
+       if ( !producer )
+               return NULL;
+
+       if ( mlt_producer_init( producer, NULL ) )
+       {
+               free( producer );
+               return NULL;
+       }
 
        // Wrap loader
        mlt_producer real_producer;