Fix XML encoding of our crappy XSPF extensions

(still not handling errors correctly)

diff --git a/modules/access/directory.c b/modules/access/directory.c
index 4b3e57ab0646081113ebd2b0705f276958466822..927efa522796b137625744c2eca8f0b6af0e9a9a 100644 (file)
--- a/modules/access/directory.c
+++ b/modules/access/directory.c
@@ -383,11 +383,17 @@ static block_t *Block (access_t *p_access)
             if (old_xspf_extension == NULL)
                 goto fatal;
 
-            int len2 = asprintf( &p_sys->psz_xspf_extension, "%s  <vlc:node title=\"%s\">\n", old_xspf_extension, entry );
-            if (len2 == -1)
+            char *title = convert_xml_special_chars (entry);
+            if (title == NULL
+             || asprintf (&p_sys->psz_xspf_extension, "%s"
+                          "  <vlc:node title=\"%s\">\n", old_xspf_extension,
+                          title) == -1)
+            {
+                free (title);
                 goto fatal;
-            free( old_xspf_extension );
-
+            }
+            free (title);
+            free (old_xspf_extension);
             return NULL;
         }
         else