]> git.sesse.net Git - ffmpeg/commitdiff
avformat/fitsdec: Fix potential leak of string in AVBPrint
authorAndreas Rheinhardt <andreas.rheinhardt@gmail.com>
Tue, 7 Jan 2020 13:55:42 +0000 (14:55 +0100)
committerMichael Niedermayer <michael@niedermayer.cc>
Wed, 8 Jan 2020 00:32:26 +0000 (01:32 +0100)
by freeing it a bit earlier.

Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt@gmail.com>
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
libavformat/fitsdec.c

index c7d1edec60d7724288baedd65c8f45d5626a1bf6..30e34fc4d5e0c73f7891364bb97e8be7d7460af0 100644 (file)
@@ -157,11 +157,11 @@ static int fits_read_packet(AVFormatContext *s, AVPacket *pkt)
 
     av_bprint_init(&avbuf, FITS_BLOCK_SIZE, AV_BPRINT_SIZE_UNLIMITED);
     while ((ret = is_image(s, fits, &header, &avbuf, &size)) == 0) {
+        av_bprint_finalize(&avbuf, NULL);
         pos = avio_skip(s->pb, size);
         if (pos < 0)
             return pos;
 
-        av_bprint_finalize(&avbuf, NULL);
         av_bprint_init(&avbuf, FITS_BLOCK_SIZE, AV_BPRINT_SIZE_UNLIMITED);
         avpriv_fits_header_init(&header, STATE_XTENSION);
     }