kdenlive/producer_framebuffer.c: check for null pointer

Fixes Coverity CID 709398: Dereference before null check (REVERSE_INULL)
Directly dereferencing pointer "frame".
203        *frame = mlt_frame_init( MLT_PRODUCER_SERVICE( producer ) );
Dereferencing "frame" before a null check.
204        if( frame != NULL )

diff --git a/src/modules/kdenlive/producer_framebuffer.c b/src/modules/kdenlive/producer_framebuffer.c
index a7a81ff025483417db1da39c3839b5dcb2f8f914..bdc8434cd52c8a1e83e7acd76a685c0c1998af21 100644 (file)
--- a/src/modules/kdenlive/producer_framebuffer.c
+++ b/src/modules/kdenlive/producer_framebuffer.c
@@ -199,10 +199,11 @@ static int framebuffer_get_image( mlt_frame frame, uint8_t **image, mlt_image_fo
 
 static int producer_get_frame( mlt_producer producer, mlt_frame_ptr frame, int index )
 {
-       // Construct a new frame
-       *frame = mlt_frame_init( MLT_PRODUCER_SERVICE( producer ) );
-       if( frame != NULL )
+       if ( frame )
        {
+               // Construct a new frame
+               *frame = mlt_frame_init( MLT_PRODUCER_SERVICE( producer ) );
+
                // Stack the producer and producer's get image
                mlt_frame_push_service( *frame, (void*) index );
                mlt_frame_push_service( *frame, producer );