]> git.sesse.net Git - vlc/commitdiff
dash: No need to instantiate a factory.
authorHugo Beauzée-Luyssen <beauze.h@gmail.com>
Thu, 24 Nov 2011 10:26:47 +0000 (11:26 +0100)
committerRémi Denis-Courmont <remi@remlab.net>
Thu, 24 Nov 2011 16:59:49 +0000 (18:59 +0200)
Signed-off-by: Rémi Denis-Courmont <remi@remlab.net>
modules/stream_filter/dash/DASHManager.cpp
modules/stream_filter/dash/DASHManager.h
modules/stream_filter/dash/adaptationlogic/AdaptationLogicFactory.cpp
modules/stream_filter/dash/adaptationlogic/AdaptationLogicFactory.h

index ef102831320fb0356593b7378d2d8dce8fb6df8f..9dfb3335e73b4813251933bff882763be31e09ae 100644 (file)
@@ -42,15 +42,13 @@ DASHManager::DASHManager    (HTTPConnectionManager *conManager, Node *node, IAda
     this->profile           = profile;
     this->mpdManagerFactory = new MPDManagerFactory();
     this->mpdManager        = this->mpdManagerFactory->create(this->profile, this->node);
-    this->logicFactory      = new AdaptationLogicFactory();
-    this->adaptationLogic   = this->logicFactory->create(this->logicType, this->mpdManager);
+    this->adaptationLogic   = AdaptationLogicFactory::create( this->logicType, this->mpdManager );
     this->currentChunk      = NULL;
 
     this->conManager->attach(this->adaptationLogic);
 }
 DASHManager::~DASHManager   ()
 {
-    delete(this->logicFactory);
     delete(this->adaptationLogic);
     delete(this->mpdManager);
 }
index 870ce13928ee39d8de90cb7dd04fafa918f7e5bb..e35d10b8192719409731d771ff6a8692eee13f4e 100644 (file)
@@ -47,7 +47,6 @@ namespace dash
         private:
             http::HTTPConnectionManager         *conManager;
             http::Chunk                         *currentChunk;
-            logic::AdaptationLogicFactory       *logicFactory;
             logic::IAdaptationLogic             *adaptationLogic;
             logic::IAdaptationLogic::LogicType  logicType;
             mpd::Profile                        profile;
index 3e286521c5b18ac9050a453a0bfbd9c7df84497f..0bd8478d2196568e1db3840db9dd55a4b93af2e3 100644 (file)
@@ -31,15 +31,6 @@ using namespace dash::logic;
 using namespace dash::xml;
 using namespace dash::mpd;
 
-AdaptationLogicFactory::AdaptationLogicFactory  ()
-{
-
-}
-AdaptationLogicFactory::~AdaptationLogicFactory ()
-{
-
-}
-
 IAdaptationLogic* AdaptationLogicFactory::create (IAdaptationLogic::LogicType logic, IMPDManager *mpdManager)
 {
     switch(logic)
index 9988d2eb1c15c0bb8fa4c7c99625aa0fc9c3e0b8..79ff47b3c062260c20952ea9f4e7c75895359c04 100644 (file)
@@ -39,10 +39,7 @@ namespace dash
         class AdaptationLogicFactory
         {
             public:
-                AdaptationLogicFactory          ();
-                virtual ~AdaptationLogicFactory ();
-
-                IAdaptationLogic* create (IAdaptationLogic::LogicType logic, dash::mpd::IMPDManager *mpdManager);
+                static IAdaptationLogic* create (IAdaptationLogic::LogicType logic, dash::mpd::IMPDManager *mpdManager);
         };
     }
 }