xtag: simplify (remove a dummy test and makes some static code analyser happy).

diff --git a/modules/misc/xml/xtag.c b/modules/misc/xml/xtag.c
index 957bd597a477ab56a3dc85e4ddb98de1b08877eb..668fd80b78b569446eadb360e7a882f29c9bd046 100644 (file)
--- a/modules/misc/xml/xtag.c
+++ b/modules/misc/xml/xtag.c
@@ -361,13 +361,12 @@ static XList *xlist_append( XList *list, void *data )
     if( !list )
         return l;
 
-    for( last = list; last; last = last->next )
-    {
-        if( !last->next )
-            break;
-    }
+    /* Find the last element */
+    last = list;
+    while( last->next )
+        last = last->next;
 
-    if( last ) last->next = l;
+    last->next = l;
     l->prev = last;
     return list;
 }