]> git.sesse.net Git - vlc/commitdiff
Fix "Use after free" (CID 248)
authorRémi Duraffort <ivoire@videolan.org>
Wed, 1 Oct 2008 18:01:12 +0000 (20:01 +0200)
committerRémi Duraffort <ivoire@videolan.org>
Wed, 1 Oct 2008 18:01:12 +0000 (20:01 +0200)
src/control/media_discoverer.c

index c1b811b0383c54b2aee07751ffc6d308f4f411f0..a0875490a81ff2e0a0e3241ce550e2552a65b13a 100644 (file)
@@ -178,9 +178,9 @@ libvlc_media_discoverer_new_from_name( libvlc_instance_t * p_inst,
 
     if( !p_mdis->p_sd )
     {
-        free( p_mdis );
         libvlc_media_list_release( p_mdis->p_mlist );
         libvlc_exception_raise( p_e, "Can't find the services_discovery module named '%s'", psz_name );
+        free( p_mdis );
         return NULL;
     }
 
@@ -205,9 +205,9 @@ libvlc_media_discoverer_new_from_name( libvlc_instance_t * p_inst,
     bool ret = services_discovery_Start( p_mdis->p_sd );
     if(!ret)
     {
-        free( p_mdis );
         libvlc_media_list_release( p_mdis->p_mlist );
         libvlc_exception_raise( p_e, "Can't start the services_discovery module named '%s'", psz_name );
+        free( p_mdis );
         return NULL;
     }