]> git.sesse.net Git - ffmpeg/commitdiff
avcodec/mpeg4videodec: Fix 2 integer overflows in get_amv()
authorMichael Niedermayer <michael@niedermayer.cc>
Thu, 11 Jun 2020 20:22:57 +0000 (22:22 +0200)
committerMichael Niedermayer <michael@niedermayer.cc>
Sun, 14 Jun 2020 17:17:07 +0000 (19:17 +0200)
Fixes: signed integer overflow: -144876608 * 16 cannot be represented in type 'int'
Fixes: 22782/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_MPEG4_fuzzer-6039584977977344
Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
libavcodec/mpeg4videodec.c

index 58ee62641c16ca45f7bce290397556dae26c1be4..14fb79261d848d6ba5daa129e47a088cde2d17c8 100644 (file)
@@ -610,7 +610,7 @@ static inline int get_amv(Mpeg4DecContext *ctx, int n)
             dy -= 1 << (shift + a + 1);
         else
             dx -= 1 << (shift + a + 1);
-        mb_v = s->sprite_offset[0][n] + dx * s->mb_x * 16 + dy * s->mb_y * 16;
+        mb_v = s->sprite_offset[0][n] + dx * s->mb_x * 16U + dy * s->mb_y * 16U;
 
         sum = 0;
         for (y = 0; y < 16; y++) {