]> git.sesse.net Git - vlc/commitdiff
taglib: fix potential null dereference.
authorRémi Duraffort <ivoire@videolan.org>
Wed, 29 Aug 2012 17:30:58 +0000 (19:30 +0200)
committerRémi Duraffort <ivoire@videolan.org>
Wed, 29 Aug 2012 17:30:58 +0000 (19:30 +0200)
modules/meta_engine/taglib.cpp

index 011ffb2fefbcdd684374b960c2347a29d6a77f2b..db9cb3a85eaeb432905720586c4971f4c5f8d9b8 100644 (file)
@@ -385,10 +385,14 @@ static void ReadMetaFromId3v2( ID3v2::Tag* tag, demux_meta_t* p_demux_meta, vlc_
 
         p_attachment = vlc_input_attachment_New( psz_name, psz_mime,
                                 psz_description, p_data, i_data );
-        if( p_attachment )
-            TAB_APPEND_CAST( (input_attachment_t**),
-                             p_demux_meta->i_attachments, p_demux_meta->attachments,
-                             p_attachment );
+        if( !p_attachment )
+        {
+            free( psz_description );
+            continue;
+        }
+        TAB_APPEND_CAST( (input_attachment_t**),
+                         p_demux_meta->i_attachments, p_demux_meta->attachments,
+                         p_attachment );
         free( psz_description );
 
         unsigned i_pic_type = p_apic->type();