]> git.sesse.net Git - vlc/commitdiff
Don't move an item to the middle of nowhere.
authorRémi Duraffort <ivoire@videolan.org>
Thu, 21 Aug 2008 18:57:00 +0000 (20:57 +0200)
committerRémi Duraffort <ivoire@videolan.org>
Fri, 22 Aug 2008 21:55:11 +0000 (23:55 +0200)
modules/gui/qt4/components/playlist/playlist_model.cpp

index 3bb985c00f79e386b559c22e88acf67986331227..2a55d951a71967626fc0a8abf84bfb0c200d1a9a 100644 (file)
@@ -149,11 +149,11 @@ bool PLModel::dropMimeData( const QMimeData *data, Qt::DropAction action,
         if( action == Qt::IgnoreAction )
             return true;
 
-        PLItem *targetItem;
-        if( target.isValid() )
-            targetItem = static_cast<PLItem*>( target.internalPointer() );
-        else
-            targetItem = rootItem;
+        if( !target.isValid() )
+            /* We don't want to move on an invalid position */
+            return true;
+
+        PLItem *targetItem = static_cast<PLItem*>( target.internalPointer() );
 
         QByteArray encodedData = data->data( "vlc/playlist-item-id" );
         QDataStream stream( &encodedData, QIODevice::ReadOnly );