]> git.sesse.net Git - vlc/commitdiff
config_Get*Choices(): deal with empty strings (NULL) correctly
authorRémi Denis-Courmont <remi@remlab.net>
Fri, 24 Aug 2012 11:22:11 +0000 (14:22 +0300)
committerRémi Denis-Courmont <remi@remlab.net>
Fri, 24 Aug 2012 11:22:44 +0000 (14:22 +0300)
src/config/core.c

index 148d6edebf99c30c7be6458f9fbf4096c9fd217a..f7d59be31fd6855ff687bac97b25fd7e15decd2b 100644 (file)
@@ -363,7 +363,8 @@ ssize_t config_GetIntChoices (vlc_object_t *obj, const char *name,
     {
         vals[i] = cfg->list.i[i];
         /* FIXME: use module_gettext() instead */
-        txts[i] = strdup (vlc_gettext (cfg->list_text[i]));
+        txts[i] = strdup ((cfg->list_text[i] != NULL)
+                                       ? vlc_gettext (cfg->list_text[i]) : "");
         if (unlikely(txts[i] == NULL))
             abort ();
     }
@@ -409,9 +410,10 @@ ssize_t config_GetPszChoices (vlc_object_t *obj, const char *name,
 
     for (size_t i = 0; i < count; i++)
     {
-        vals[i] = strdup (cfg->list.psz[i]);
+        vals[i] = strdup ((cfg->list.psz[i] != NULL) ? cfg->list.psz[i] : "");
         /* FIXME: use module_gettext() instead */
-        txts[i] = strdup (vlc_gettext(cfg->list_text[i]));
+        txts[i] = strdup ((cfg->list_text[i] != NULL)
+                                       ? vlc_gettext (cfg->list_text[i]) : "");
         if (unlikely(vals[i] == NULL || txts[i] == NULL))
             abort ();
     }