Fix potential use-after-free (cid #1047503)

psz_realhost is an alias to psz_socks when using socks.

diff --git a/src/network/tcp.c b/src/network/tcp.c
index 61159e0fd267e5c252777d346a93bc21bb4c34d5..8c294e7cbcbadeebb618e60a94018d81fc960ff1 100644 (file)
--- a/src/network/tcp.c
+++ b/src/network/tcp.c
@@ -138,14 +138,15 @@ int net_Connect( vlc_object_t *p_this, const char *psz_host, int i_port,
     }, *res;
 
     int val = vlc_getaddrinfo (psz_realhost, i_realport, &hints, &res);
-    free( psz_socks );
 
     if (val)
     {
         msg_Err (p_this, "cannot resolve %s port %d : %s", psz_realhost,
                  i_realport, gai_strerror (val));
+        free( psz_socks );
         return -1;
     }
+    free( psz_socks );
 
     int timeout = var_InheritInteger (p_this, "ipv4-timeout");
     if (timeout < 0)