]> git.sesse.net Git - vlc/log
vlc
14 years agoUpdate MagSoft THANKS entry.
Jean-Baptiste Kempf [Sat, 25 Jul 2009 13:55:38 +0000 (15:55 +0200)]
Update MagSoft THANKS entry.

14 years agoNEWS about Direct3D desktop mode.
Jean-Baptiste Kempf [Sat, 25 Jul 2009 13:53:30 +0000 (15:53 +0200)]
NEWS about Direct3D desktop mode.

14 years agoRemove trailing spaces.
Jean-Baptiste Kempf [Sat, 25 Jul 2009 13:51:14 +0000 (15:51 +0200)]
Remove trailing spaces.

14 years agoAdd a desktop mode to the Direct3d video output. This allow displaying video on a...
Adrien Maglo [Sat, 25 Jul 2009 13:37:38 +0000 (15:37 +0200)]
Add a desktop mode to the Direct3d video output. This allow displaying video on a window located just up the desktop icon window.

Signed-off-by: Jean-Baptiste Kempf <jb@videolan.org>
14 years agovlc_clone(): abide by --rt-priority and --rt-offset
Rémi Denis-Courmont [Sat, 25 Jul 2009 13:21:18 +0000 (16:21 +0300)]
vlc_clone(): abide by --rt-priority and --rt-offset

This avoids using real-time when not asked. It should also fix a
pthread_create() permission failure on FreeBSD (Linux seems to ignore
this error silently).

14 years agoQT4: only scroll playlist to new item when it changes
Ilkka Ollakka [Sat, 25 Jul 2009 12:26:07 +0000 (15:26 +0300)]
QT4: only scroll playlist to new item when it changes

should fix bug #2947 ,now it scrolls to new item when theres actual
input-change, not just data changed.

14 years agoFixed libass 0.9.7 support.
Laurent Aimar [Fri, 24 Jul 2009 21:42:14 +0000 (23:42 +0200)]
Fixed libass 0.9.7 support.

b670356d167bf66f870ee3daf9dbac581eaf0651 introduced a segfault.

14 years agoUsed light hinting in libass to increase the quality.
Laurent Aimar [Fri, 24 Jul 2009 21:13:24 +0000 (23:13 +0200)]
Used light hinting in libass to increase the quality.

14 years agoRemoved useless pre render callback in ssa decoder.
Laurent Aimar [Fri, 24 Jul 2009 21:04:22 +0000 (23:04 +0200)]
Removed useless pre render callback in ssa decoder.

14 years agoFixed flicker with overlapped subtitles in ssa.
Laurent Aimar [Thu, 23 Jul 2009 19:52:15 +0000 (21:52 +0200)]
Fixed flicker with overlapped subtitles in ssa.

14 years agoMerge branch 'master' of git@git.videolan.org:vlc
JP Dinger [Fri, 24 Jul 2009 15:24:46 +0000 (17:24 +0200)]
Merge branch 'master' of git@git.videolan.org:vlc

14 years agoSimplify vlc_about.h generation.
JP Dinger [Fri, 24 Jul 2009 15:24:08 +0000 (17:24 +0200)]
Simplify vlc_about.h generation.

14 years agocontribs: updated ffmpeg ppc patch
Felix Paul Kühne [Fri, 24 Jul 2009 14:41:58 +0000 (16:41 +0200)]
contribs: updated ffmpeg ppc patch

14 years agoRemove var_SetVoid: this function is doing exactly the same job than
Rémi Duraffort [Fri, 24 Jul 2009 13:29:40 +0000 (15:29 +0200)]
Remove var_SetVoid: this function is doing exactly the same job than
var_TriggerCallback but slowly.

14 years agoUse var_TriggerCallback instead of var_SetVoid (the result is exactly the same
Rémi Duraffort [Fri, 24 Jul 2009 13:10:06 +0000 (15:10 +0200)]
Use var_TriggerCallback instead of var_SetVoid (the result is exactly the same
but a bit faster).

14 years agoskins2: fix "control reaches end of non-void function" (spoted by Dominique
Rémi Duraffort [Fri, 24 Jul 2009 13:07:10 +0000 (15:07 +0200)]
skins2: fix "control reaches end of non-void function" (spoted by Dominique
Leuenberger)

14 years agominimal_macosx: cleanup
Jean-Paul Saman [Fri, 24 Jul 2009 10:10:26 +0000 (12:10 +0200)]
minimal_macosx: cleanup

14 years agoauhal: cleanup
Jean-Paul Saman [Fri, 24 Jul 2009 08:33:38 +0000 (10:33 +0200)]
auhal: cleanup

14 years agoauhal: do not destroy "audio-device" when AudioHardwarePropertyListener failed, but...
Jean-Paul Saman [Wed, 22 Jul 2009 19:52:10 +0000 (21:52 +0200)]
auhal: do not destroy "audio-device" when AudioHardwarePropertyListener failed, but try to use it anyway.

It allows multiple Safari webplugins to play audio at the sametime, just as 2 vlc instances would do.

14 years agolive555: do not trigger "no data received in 10s" case when pausing during buffering
Jean-Paul Saman [Tue, 21 Jul 2009 12:18:49 +0000 (14:18 +0200)]
live555: do not trigger "no data received in 10s" case when pausing during buffering

14 years agomozilla: do not ship gui/macosx plugin in Safari webplugin
Jean-Paul Saman [Tue, 14 Jul 2009 09:22:37 +0000 (11:22 +0200)]
mozilla: do not ship gui/macosx plugin in Safari webplugin

It is the main cause for memory leaks of VLC browser plugin for MacOS X. Every time the browser plugin is reloaded, vlc core reloads the plugins which causes all global defined objects to initialize. Since there are objects in libmacosx_plugin.dylib that are supposed to live as long as the application these are never freed. Testing is done with --enable-debug.

14 years agomozilla: use minimal_macosx as vout in webplugin, it leaks way less then macosx vout.
Jean-Paul Saman [Sun, 21 Jun 2009 14:09:52 +0000 (16:09 +0200)]
mozilla: use minimal_macosx as vout in webplugin, it leaks way less then macosx vout.

14 years agolive555: handle WMServer as a special case
Jean-Paul Saman [Fri, 24 Jul 2009 11:38:03 +0000 (13:38 +0200)]
live555: handle WMServer as a special case

This patch adds --rtsp-wmserver which is needed to support pause mode. WMServer does not report any of the known RTSP OPTIONS when asking for it. Instead it returns a list of non-standard options.

Conflicts:

modules/demux/live555.cpp

14 years agoCleanup mozilla plugin
Jean-Paul Saman [Sun, 14 Jun 2009 20:57:32 +0000 (22:57 +0200)]
Cleanup mozilla plugin
(cherry picked from commit be262960c031fbab9e2600969b08e516f20b6679)

Conflicts:

projects/mozilla/vlcshell.cpp

14 years agomozilla: don't allocate a zero sized array.
Jean-Paul Saman [Sat, 13 Jun 2009 22:09:45 +0000 (00:09 +0200)]
mozilla: don't allocate a zero sized array.

(cherry-picked from commit aed48363a478e9767a374154d703d7c84857707b)

Conflict:
projects/mozilla/control/npolibvlc.cpp

14 years agomozilla: fix small memory leak
Jean-Paul Saman [Mon, 1 Jun 2009 14:08:40 +0000 (16:08 +0200)]
mozilla: fix small memory leak
(cherry picked from commit 63ae92da20faa6dafa8fa4dc808bb27ad2bcb455)

14 years agoAdd Speex in flv demuxing support. #2973
Jean-Baptiste Kempf [Fri, 24 Jul 2009 12:17:43 +0000 (14:17 +0200)]
Add Speex in flv demuxing support. #2973

However, it only works with the avcodec module. --codec avcodec if you want it.

14 years agotest: destroy the variables.
Rémi Duraffort [Fri, 24 Jul 2009 11:30:02 +0000 (13:30 +0200)]
test: destroy the variables.

14 years agoNo need to memset val to 0 because the variable is initialized just after (the
Rémi Duraffort [Fri, 24 Jul 2009 11:16:06 +0000 (13:16 +0200)]
No need to memset val to 0 because the variable is initialized just after (the
only case without initialization is for a void variable in which case the val
variable isn't used)

14 years agoUse VLC_VAR_CLASS when applicable.
Rémi Duraffort [Fri, 24 Jul 2009 11:11:18 +0000 (13:11 +0200)]
Use VLC_VAR_CLASS when applicable.

14 years agoMerge branch 'master' of git@git.videolan.org:vlc
JP Dinger [Fri, 24 Jul 2009 11:38:22 +0000 (13:38 +0200)]
Merge branch 'master' of git@git.videolan.org:vlc

14 years agoFix another realloc() that can easily be fixed. The other one in the file
JP Dinger [Fri, 24 Jul 2009 11:36:51 +0000 (13:36 +0200)]
Fix another realloc() that can easily be fixed. The other one in the file
I don't immediately see a solution for.

14 years agoMore NEWS
Jean-Baptiste Kempf [Fri, 24 Jul 2009 11:27:15 +0000 (13:27 +0200)]
More NEWS

14 years agoFinish the zvbi port to Windows.
Jean-Baptiste Kempf [Fri, 24 Jul 2009 11:26:38 +0000 (13:26 +0200)]
Finish the zvbi port to Windows.

The .dll is still a bit big, because of static linking to libiconv, I think

14 years agoRemove asa from contribs.
Jean-Baptiste Kempf [Fri, 24 Jul 2009 10:54:58 +0000 (12:54 +0200)]
Remove asa from contribs.

14 years agoQt: fix crash in customize toolbar dialog.
Jean-Baptiste Kempf [Fri, 24 Jul 2009 10:15:13 +0000 (12:15 +0200)]
Qt: fix crash in customize toolbar dialog.

For some reasons, this doesn't crash on Linux...
(cherry picked from commit 25d37a4930519c5bcabbe2c0fae8c86e38d9ea54)

Signed-off-by: Jean-Baptiste Kempf <jb@videolan.org>
14 years agopanoramix: fix memleak.
Rémi Duraffort [Fri, 24 Jul 2009 09:42:49 +0000 (11:42 +0200)]
panoramix: fix memleak.

14 years agoUse native dialog for saving VLM files.
Jean-Baptiste Kempf [Fri, 24 Jul 2009 09:10:45 +0000 (11:10 +0200)]
Use native dialog for saving VLM files.

14 years agovariables: factorize the callback code, using a special function.
Rémi Duraffort [Fri, 24 Jul 2009 08:39:05 +0000 (10:39 +0200)]
variables: factorize the callback code, using a special function.
As a side effect, fix a potential memleak if the variable disappeares in
var_SetChecked.

14 years agoncurses: factorize (no need to use a macro here).
Rémi Duraffort [Fri, 24 Jul 2009 08:12:55 +0000 (10:12 +0200)]
ncurses: factorize (no need to use a macro here).

14 years agoUnused variables (remaining from a previous cleanup).
Rémi Duraffort [Fri, 24 Jul 2009 07:34:09 +0000 (09:34 +0200)]
Unused variables (remaining from a previous cleanup).

14 years agoUe var_Get(Time|Address) when applicable.
Rémi Duraffort [Fri, 24 Jul 2009 07:30:09 +0000 (09:30 +0200)]
Ue var_Get(Time|Address) when applicable.

14 years agoNo need to check for the existence of the variable to destroy it.
Rémi Duraffort [Fri, 24 Jul 2009 07:05:58 +0000 (09:05 +0200)]
No need to check for the existence of the variable to destroy it.
Destroying directly saves one Lookup.

14 years agopostproc: no need to set the flag again as the bug is now fixed (previous commit).
Rémi Duraffort [Fri, 24 Jul 2009 06:55:28 +0000 (08:55 +0200)]
postproc: no need to set the flag again as the bug is now fixed (previous commit).
Also remove an uneeded var_Destroy.

14 years agovariables: when the variable already exist, check the type only (integer,
Rémi Duraffort [Fri, 24 Jul 2009 05:46:48 +0000 (07:46 +0200)]
variables: when the variable already exist, check the type only (integer,
float, ...), so remove all the flags before the check.

14 years agotest_variables: add a bunch of test to show a tiny bug when the variable is
Rémi Duraffort [Fri, 24 Jul 2009 05:48:12 +0000 (07:48 +0200)]
test_variables: add a bunch of test to show a tiny bug when the variable is
created two times with the same type but different flags.

14 years agozipaccess: correct memory leak (probing work moved before calloc)
Erwan Tulou [Tue, 21 Jul 2009 11:32:42 +0000 (13:32 +0200)]
zipaccess: correct memory leak (probing work moved before calloc)

14 years agoskins2: cosmetics (for better reading)
Erwan Tulou [Thu, 23 Jul 2009 20:52:51 +0000 (22:52 +0200)]
skins2: cosmetics (for better reading)

14 years agofile: do POSIX advisory I/O
Rémi Denis-Courmont [Thu, 23 Jul 2009 20:20:12 +0000 (23:20 +0300)]
file: do POSIX advisory I/O

The system can use the hint to prefetch the data into memory, if
possible. Hopefully, this will reduce choppiness, as well as power
consumption.

14 years agoDirectly release the input thread.
Rémi Duraffort [Thu, 23 Jul 2009 19:01:08 +0000 (21:01 +0200)]
Directly release the input thread.

14 years agoGlobal headers.
Rémi Duraffort [Thu, 23 Jul 2009 17:25:42 +0000 (19:25 +0200)]
Global headers.

14 years agoUse Brackets for global headers.
Jean-Baptiste Kempf [Thu, 23 Jul 2009 16:30:34 +0000 (18:30 +0200)]
Use Brackets for global headers.

14 years agoIncludes corrections
Jean-Baptiste Kempf [Thu, 23 Jul 2009 16:10:15 +0000 (18:10 +0200)]
Includes corrections

14 years agoRemove timer serialization (we don't do it on POSIX anyway)
Rémi Denis-Courmont [Thu, 23 Jul 2009 16:11:09 +0000 (19:11 +0300)]
Remove timer serialization (we don't do it on POSIX anyway)

14 years agoUpdate SSA/ASS subtitle decoder for the new version of libass included in contribs.
Barry Wardell [Thu, 23 Jul 2009 15:00:22 +0000 (16:00 +0100)]
Update SSA/ASS subtitle decoder for the new version of libass included in contribs.

Signed-off-by: Jean-Baptiste Kempf <jb@videolan.org>
14 years agofile: network file extra caching for Win32
Rémi Denis-Courmont [Thu, 23 Jul 2009 15:08:44 +0000 (18:08 +0300)]
file: network file extra caching for Win32

Fixes #2983 for good ths time hopefully...

14 years agoFix warning
Rémi Denis-Courmont [Thu, 23 Jul 2009 15:05:08 +0000 (18:05 +0300)]
Fix warning

14 years agoinverted parameters to memset. Setting the length to 0 looks bogus.
Dominique Leuenberger [Thu, 23 Jul 2009 07:33:55 +0000 (09:33 +0200)]
inverted parameters to memset. Setting the length to 0 looks bogus.

Signed-off-by: Rémi Denis-Courmont <remi@remlab.net>
14 years agotest: add some more tests for vlc variables.
Rémi Duraffort [Thu, 23 Jul 2009 13:20:05 +0000 (15:20 +0200)]
test: add some more tests for vlc variables.

14 years agofactorize.
Rémi Duraffort [Thu, 23 Jul 2009 12:23:32 +0000 (14:23 +0200)]
factorize.

14 years agoFix previous commit about drag&drop.
Rémi Duraffort [Thu, 23 Jul 2009 12:21:28 +0000 (14:21 +0200)]
Fix previous commit about drag&drop.

14 years agohttp access_out: factorize.
Rémi Duraffort [Thu, 23 Jul 2009 11:16:41 +0000 (13:16 +0200)]
http access_out: factorize.

14 years agoFixed wrong documentation reference.
Vicente Jimenez Aguilar [Thu, 23 Jul 2009 10:38:01 +0000 (12:38 +0200)]
Fixed wrong documentation reference.

Signed-off-by: Rémi Duraffort <ivoire@videolan.org>
14 years agoQt : Add PLAYLIST_PREPARSE flag to drag&dropped items
Besnard Jean-Baptiste [Thu, 23 Jul 2009 08:59:17 +0000 (10:59 +0200)]
Qt : Add PLAYLIST_PREPARSE flag to drag&dropped items

Signed-off-by: Rémi Duraffort <ivoire@videolan.org>
14 years agoGlobal include not local.
Rémi Duraffort [Thu, 23 Jul 2009 06:56:44 +0000 (08:56 +0200)]
Global include not local.

14 years agocosmetics.
Rémi Duraffort [Thu, 23 Jul 2009 06:18:20 +0000 (08:18 +0200)]
cosmetics.

14 years agoWork-around yet another bug of hopelessly broken MacOS X
Rémi Denis-Courmont [Wed, 22 Jul 2009 19:02:16 +0000 (22:02 +0300)]
Work-around yet another bug of hopelessly broken MacOS X

Fixes #2984

14 years agoopengl: fix an crash/hang on exit because opengl needs the init and end to be done...
Rémi Duraffort [Wed, 22 Jul 2009 08:48:46 +0000 (10:48 +0200)]
opengl: fix an crash/hang on exit because opengl needs the init and end to be done in the same thread.

14 years agovout modules: remove uneeded includes.
Rémi Duraffort [Wed, 22 Jul 2009 08:12:41 +0000 (10:12 +0200)]
vout modules: remove uneeded includes.

14 years agoQt : Fix the way playlist columns are saved
Besnard Jean-Baptiste [Wed, 22 Jul 2009 13:49:03 +0000 (15:49 +0200)]
Qt : Fix the way playlist columns are saved

Signed-off-by: Jean-Baptiste Kempf <jb@videolan.org>
14 years agoThanks to Luca Barbato
Jean-Baptiste Kempf [Wed, 22 Jul 2009 15:34:08 +0000 (17:34 +0200)]
Thanks to Luca Barbato

14 years agoshine: cleanup
Jean-Paul Saman [Tue, 21 Jul 2009 09:23:25 +0000 (11:23 +0200)]
shine: cleanup

14 years agoshine: add missing assert.h
Jean-Paul Saman [Tue, 21 Jul 2009 09:23:04 +0000 (11:23 +0200)]
shine: add missing assert.h

14 years agolive555: fix seeking
Jean-Paul Saman [Tue, 21 Jul 2009 09:04:38 +0000 (11:04 +0200)]
live555: fix seeking

According to RFC 2326 a PAUSE command should be issued when requesting an immediate seek to a new PLAY position.

14 years agoQt : Keep preparsed items synced in playlist
Besnard Jean-Baptiste [Wed, 22 Jul 2009 07:21:43 +0000 (09:21 +0200)]
Qt : Keep preparsed items synced in playlist

Signed-off-by: Ilkka Ollakka <ileoo@videolan.org>
14 years agox264.c: add psy-rd string to modify psy-rd settings
Ilkka Ollakka [Wed, 22 Jul 2009 07:32:17 +0000 (10:32 +0300)]
x264.c: add psy-rd string to modify psy-rd settings

psy-rd should be default on when subme >= 6 (x264 library mentions
this), and I'm not sure how much this options is used in 'normal use'

14 years agoThank Michael for RAOP work.
Jean-Baptiste Kempf [Wed, 22 Jul 2009 08:04:54 +0000 (10:04 +0200)]
Thank Michael for RAOP work.

14 years agoDailymotion: fix double encoding in video description
Fabio Ritrovato [Tue, 21 Jul 2009 10:46:04 +0000 (12:46 +0200)]
Dailymotion: fix double encoding in video description

Signed-off-by: Jean-Baptiste Kempf <jb@videolan.org>
14 years agoRemove useless boolean
Rémi Denis-Courmont [Tue, 21 Jul 2009 16:11:22 +0000 (19:11 +0300)]
Remove useless boolean

14 years agox264 change that qcomp-parameter determinates rc-mode
Ilkka Ollakka [Tue, 21 Jul 2009 12:48:55 +0000 (15:48 +0300)]
x264 change that qcomp-parameter determinates rc-mode

default qp=-1, so it can be detected even if theres bitrate

change default crf=23 as x264 has

if user defines qcomp<=0.1 then define ABR-mode, otherwise CRF-mode.
And override it to QP-mode if user has defined qp-value.

14 years agox264.c: change defaults allmost same as current x264 has
Ilkka Ollakka [Tue, 21 Jul 2009 11:04:20 +0000 (14:04 +0300)]
x264.c: change defaults allmost same as current x264 has

14 years agox264.c: set vbv max bitrate to bitrate if doing cbr
Ilkka Ollakka [Tue, 21 Jul 2009 11:03:58 +0000 (14:03 +0300)]
x264.c: set vbv max bitrate to bitrate if doing cbr

14 years agoDailymotion: fix for other domains and description parsing
Fabio Ritrovato [Tue, 21 Jul 2009 10:19:53 +0000 (12:19 +0200)]
Dailymotion: fix for other domains and description parsing

Signed-off-by: Jean-Baptiste Kempf <jb@videolan.org>
14 years agoprojectm: manage the events.
Rémi Duraffort [Tue, 21 Jul 2009 09:29:17 +0000 (11:29 +0200)]
projectm: manage the events.

14 years agofix wrong codec ID assigned to kate streams
ogg.k.ogg.k [Mon, 20 Jul 2009 21:59:57 +0000 (22:59 +0100)]
fix wrong codec ID assigned to kate streams

Signed-off-by: Jean-Baptiste Kempf <jb@videolan.org>
14 years agoForwardport THANKS.
Rémi Duraffort [Tue, 21 Jul 2009 06:59:58 +0000 (08:59 +0200)]
Forwardport THANKS.

14 years agoQt: add some missing const.
Rémi Duraffort [Mon, 20 Jul 2009 13:23:49 +0000 (15:23 +0200)]
Qt: add some missing const.

14 years agomacosx: forward-port [d0fbd04ce361f9dbc16d44dae09c168db708b3a3]
Felix Paul Kühne [Mon, 20 Jul 2009 22:00:58 +0000 (00:00 +0200)]
macosx: forward-port [d0fbd04ce361f9dbc16d44dae09c168db708b3a3]

14 years agoHandle an error
Rémi Denis-Courmont [Mon, 20 Jul 2009 16:59:48 +0000 (19:59 +0300)]
Handle an error

14 years agoRemove redumdant boolean
Rémi Denis-Courmont [Mon, 20 Jul 2009 16:59:39 +0000 (19:59 +0300)]
Remove redumdant boolean

14 years agoDo not generate a SDP file if SDP is not yet defined (fixes: #2981)
Rémi Denis-Courmont [Mon, 20 Jul 2009 16:51:30 +0000 (19:51 +0300)]
Do not generate a SDP file if SDP is not yet defined (fixes: #2981)

14 years agoDecode file path in sout-rtp-sdp
Rémi Denis-Courmont [Mon, 20 Jul 2009 16:44:36 +0000 (19:44 +0300)]
Decode file path in sout-rtp-sdp

14 years agoMake the extra network file caching configurable
Rémi Denis-Courmont [Mon, 20 Jul 2009 16:37:17 +0000 (19:37 +0300)]
Make the extra network file caching configurable

I thought of using a completely separate setting. But that would break
backward compatibility. I think it is best to let --file-caching
increase caching for all files. I guess that is how TheDJ intended it.

14 years agoSort of handle ;type= in FTP URLs
Rémi Denis-Courmont [Mon, 20 Jul 2009 15:58:56 +0000 (18:58 +0300)]
Sort of handle ;type= in FTP URLs

14 years agoFTP path must be decoded - fixes #2982.
Rémi Denis-Courmont [Mon, 20 Jul 2009 15:50:11 +0000 (18:50 +0300)]
FTP path must be decoded - fixes #2982.

14 years agoQt: remove button duplicated in Classic style.
Jean-Baptiste Kempf [Mon, 20 Jul 2009 07:30:51 +0000 (09:30 +0200)]
Qt: remove button duplicated in Classic style.

14 years agoCopyright correction.
Jean-Baptiste Kempf [Mon, 20 Jul 2009 07:25:04 +0000 (09:25 +0200)]
Copyright correction.

14 years agoQt: customize dialogs, fix a misswrite with the last item of a toolbar.
Jean-Baptiste Kempf [Sun, 19 Jul 2009 22:55:53 +0000 (00:55 +0200)]
Qt: customize dialogs, fix a misswrite with the last item of a toolbar.

14 years agoFix spurious "please select network protocol manually" error
Rémi Denis-Courmont [Sun, 19 Jul 2009 19:00:16 +0000 (22:00 +0300)]
Fix spurious "please select network protocol manually" error

getaddrinfo() may list IPv4 before IPv6 depending on system
configuration.

14 years agoRTP: fix corner-case memory leak (fd_dead is a cancellation point)
Rémi Denis-Courmont [Sun, 19 Jul 2009 17:04:53 +0000 (20:04 +0300)]
RTP: fix corner-case memory leak (fd_dead is a cancellation point)