]> git.sesse.net Git - vlc/log
vlc
16 years agoThanks more Enrique Osuna.
Pierre d'Herbemont [Wed, 3 Oct 2007 00:29:18 +0000 (00:29 +0000)]
Thanks more Enrique Osuna.

16 years agocontrol/media_instance.c: Fix a segfault caused by libvlc_media_instance_release...
Pierre d'Herbemont [Wed, 3 Oct 2007 00:28:36 +0000 (00:28 +0000)]
control/media_instance.c: Fix a segfault caused by libvlc_media_instance_release. (Patch by Enrique Osuna).

16 years agoncurses: sets the parent node when selecting an item. fix playing from media library.
Rafaël Carré [Tue, 2 Oct 2007 23:14:43 +0000 (23:14 +0000)]
ncurses: sets the parent node when selecting an item. fix playing from media library.

16 years agoplaylist: don't request art nor set "playlist-current" for directory: & vlc: URIs
Rafaël Carré [Tue, 2 Oct 2007 22:17:50 +0000 (22:17 +0000)]
playlist: don't request art nor set "playlist-current" for directory: & vlc: URIs

16 years ago* xspf.c: fixes parsing with xtag - closes #1293
Yoann Peronneau [Tue, 2 Oct 2007 21:51:43 +0000 (21:51 +0000)]
* xspf.c: fixes parsing with xtag - closes #1293
  Someone should check if we could make xtag not send ENDELEM for self-closing tags, as libxml doesn't.

16 years agoinput: Removes useless "item-change" variable
Rafaël Carré [Tue, 2 Oct 2007 21:37:54 +0000 (21:37 +0000)]
input: Removes useless "item-change" variable

16 years agom4a demuxer: initialize correctly p_sys
Rafaël Carré [Tue, 2 Oct 2007 21:19:36 +0000 (21:19 +0000)]
m4a demuxer: initialize correctly p_sys

16 years agodecoder_synchro_t does not need to be a vlc_object_t.
Laurent Aimar [Tue, 2 Oct 2007 19:06:09 +0000 (19:06 +0000)]
decoder_synchro_t does not need to be a vlc_object_t.

16 years agoFixed const warnings.
Laurent Aimar [Tue, 2 Oct 2007 18:58:29 +0000 (18:58 +0000)]
Fixed const warnings.

16 years agoCompilation fix, again.
Laurent Aimar [Tue, 2 Oct 2007 18:48:51 +0000 (18:48 +0000)]
Compilation fix, again.

16 years agoCompilation fix.
Laurent Aimar [Tue, 2 Oct 2007 18:47:29 +0000 (18:47 +0000)]
Compilation fix.

16 years agoMoved vout_synchro to decoder_synchro.
Laurent Aimar [Tue, 2 Oct 2007 18:43:23 +0000 (18:43 +0000)]
Moved vout_synchro to decoder_synchro.

16 years agoRemoved unused values.
Laurent Aimar [Tue, 2 Oct 2007 18:29:47 +0000 (18:29 +0000)]
Removed unused values.

16 years agoHide private vout_synchro_t.
Laurent Aimar [Tue, 2 Oct 2007 18:22:44 +0000 (18:22 +0000)]
Hide private vout_synchro_t.

16 years agoOops fix compilation.
Laurent Aimar [Tue, 2 Oct 2007 18:16:55 +0000 (18:16 +0000)]
Oops fix compilation.

16 years agoUse decoder_GetDisplayDate.
Laurent Aimar [Tue, 2 Oct 2007 18:03:50 +0000 (18:03 +0000)]
Use decoder_GetDisplayDate.
(libmpeg2/xvmc pending)

16 years agoalsa: resume output when waking up, fix #1286. some coding style cleanup
Rafaël Carré [Tue, 2 Oct 2007 17:59:31 +0000 (17:59 +0000)]
alsa: resume output when waking up, fix #1286. some coding style cleanup

16 years agoAdded a new decoder function (decoder_GetDisplayDate) to be used to convert a
Laurent Aimar [Tue, 2 Oct 2007 17:41:13 +0000 (17:41 +0000)]
Added a new decoder function (decoder_GetDisplayDate) to be used to convert a
decoder block_t date to a display date (identify for now)

16 years ago - Heavily simplify the MPJPEG mux (closes #1188); please test.
Rémi Denis-Courmont [Tue, 2 Oct 2007 17:26:35 +0000 (17:26 +0000)]
 - Heavily simplify the MPJPEG mux (closes #1188); please test.
 - Remove configurable boundary that had never been working anyway (did not match the original value from MUX_GET_MIME)

16 years agoPass content-type from access to stream
Rémi Denis-Courmont [Tue, 2 Oct 2007 16:05:13 +0000 (16:05 +0000)]
Pass content-type from access to stream

16 years agoExport Content-Type out of HTTP access using Control.
Rémi Denis-Courmont [Tue, 2 Oct 2007 15:54:16 +0000 (15:54 +0000)]
Export Content-Type out of HTTP access using Control.

16 years agoDon't reinvent free()
Rémi Denis-Courmont [Tue, 2 Oct 2007 15:23:28 +0000 (15:23 +0000)]
Don't reinvent free()

16 years agoWe use error code 456
Rémi Denis-Courmont [Tue, 2 Oct 2007 15:03:08 +0000 (15:03 +0000)]
We use error code 456

16 years agoThanks Enrique Osuna.
Pierre d'Herbemont [Tue, 2 Oct 2007 11:30:56 +0000 (11:30 +0000)]
Thanks Enrique Osuna.

16 years agocontrol/media_list_player.c: Remove a double event registration. (Patch by Enrique...
Pierre d'Herbemont [Tue, 2 Oct 2007 11:30:12 +0000 (11:30 +0000)]
control/media_list_player.c: Remove a double event registration. (Patch by Enrique Osuna).

16 years agocontrol/media_instance.c: Don't forget to register emitted event. (Patch by Enrique...
Pierre d'Herbemont [Tue, 2 Oct 2007 11:29:20 +0000 (11:29 +0000)]
control/media_instance.c: Don't forget to register emitted event. (Patch by Enrique Osuna).

16 years agosap discovery: fix [22368] by using (int) casting on the unsigned size_t value
Rafaël Carré [Tue, 2 Oct 2007 11:11:53 +0000 (11:11 +0000)]
sap discovery: fix [22368] by using (int) casting on the unsigned size_t value

16 years agofix indentation
Jean-Paul Saman [Tue, 2 Oct 2007 06:59:23 +0000 (06:59 +0000)]
fix indentation

16 years agodemux: fix a memory leak in flac & mpga when attachments are present
Rafaël Carré [Tue, 2 Oct 2007 02:50:10 +0000 (02:50 +0000)]
demux: fix a memory leak in flac & mpga when attachments are present

16 years agotaglib: support for id3v2 embedded album art
Rafaël Carré [Tue, 2 Oct 2007 02:11:11 +0000 (02:11 +0000)]
taglib: support for id3v2 embedded album art
the only demuxer supported is mpga, other demuxers should be updated if they demux files that can have id3v2 tags
fix some bugs in flac & ogg demuxers

16 years agoinput_ExtractAttachmentAndCacheArt(): use the attachment's mime type, don't use input...
Rafaël Carré [Tue, 2 Oct 2007 01:44:26 +0000 (01:44 +0000)]
input_ExtractAttachmentAndCacheArt(): use the attachment's mime type, don't use input_item_ functions as the input_item_t has been locked previously.

16 years agosap discovery: (size_t) casting
Rafaël Carré [Mon, 1 Oct 2007 21:28:36 +0000 (21:28 +0000)]
sap discovery: (size_t) casting

16 years agoncurses: adds some (size_t) casting
Rafaël Carré [Mon, 1 Oct 2007 20:41:15 +0000 (20:41 +0000)]
ncurses: adds some (size_t) casting

16 years agoClean up.
Laurent Aimar [Mon, 1 Oct 2007 19:57:24 +0000 (19:57 +0000)]
Clean up.

16 years agoOops, fix subtitle decoding.
Laurent Aimar [Mon, 1 Oct 2007 19:37:37 +0000 (19:37 +0000)]
Oops, fix subtitle decoding.

16 years agoClean up/Factorize.
Laurent Aimar [Mon, 1 Oct 2007 19:33:30 +0000 (19:33 +0000)]
Clean up/Factorize.

16 years agoncurses: fix KeyToUTF8() breakage introduced in [22313]
Rafaël Carré [Mon, 1 Oct 2007 19:33:24 +0000 (19:33 +0000)]
ncurses: fix KeyToUTF8() breakage introduced in [22313]

16 years agoCleanup previous commit
Rémi Denis-Courmont [Mon, 1 Oct 2007 18:11:03 +0000 (18:11 +0000)]
Cleanup previous commit

16 years agoRemoved b_die arbitrary timer from httpd.
Rémi Denis-Courmont [Mon, 1 Oct 2007 18:04:10 +0000 (18:04 +0000)]
Removed b_die arbitrary timer from httpd.

16 years agoFix deadlock
Rémi Denis-Courmont [Mon, 1 Oct 2007 18:00:42 +0000 (18:00 +0000)]
Fix deadlock

16 years agoReset PCR when gap has been detected.
Jean-Paul Saman [Mon, 1 Oct 2007 17:35:35 +0000 (17:35 +0000)]
Reset PCR when gap has been detected.

16 years agoAdd the missing function to allocate and get the object event OS pipe
Rémi Denis-Courmont [Mon, 1 Oct 2007 17:12:21 +0000 (17:12 +0000)]
Add the missing function to allocate and get the object event OS pipe

16 years agoRemove the HTTP interface thread, and save 20 wakeups per seconds.
Rémi Denis-Courmont [Mon, 1 Oct 2007 16:07:17 +0000 (16:07 +0000)]
Remove the HTTP interface thread, and save 20 wakeups per seconds.
The idle HTTP interace is down from 30 to 10 wakeups/s (I think the remaining ones are due to HTTPd core).

16 years ago - Do not release the input while we did not yield it...
Rémi Denis-Courmont [Mon, 1 Oct 2007 15:57:22 +0000 (15:57 +0000)]
 - Do not release the input while we did not yield it...
 - Really yield the input (and release it) on a need-basis in the HTTP handler rather than in a custom thread. This is probably not thread-safe, but it's less unsafe than the previous code anyway.
This makes the HTTP interface thread very much useless, niark niark

16 years agoReally fix playlist enqueue
Rémi Denis-Courmont [Mon, 1 Oct 2007 15:43:30 +0000 (15:43 +0000)]
Really fix playlist enqueue

16 years agoPlaylist is always true here
Rémi Denis-Courmont [Mon, 1 Oct 2007 15:33:24 +0000 (15:33 +0000)]
Playlist is always true here

16 years agoFind the playlist once *before* starting.
Rémi Denis-Courmont [Mon, 1 Oct 2007 15:31:09 +0000 (15:31 +0000)]
Find the playlist once *before* starting.
LibVLC always creates the (singleton) playlist before the interfaces anyway.
Besides, the HTTP interface callbacks assumes the playlist is yield.
This removes one of two reasons for running the damn HTTP interface thread.

16 years agoMake a bunch of HTTP macro functions static
Rémi Denis-Courmont [Mon, 1 Oct 2007 15:17:21 +0000 (15:17 +0000)]
Make a bunch of HTTP macro functions static

16 years agoFix playlist enqueue RPC
Rémi Denis-Courmont [Mon, 1 Oct 2007 14:30:02 +0000 (14:30 +0000)]
Fix playlist enqueue RPC

16 years agomacosx interface: fix regression introduced in [21230]. patch by John Dalgliesh
Rafaël Carré [Mon, 1 Oct 2007 12:38:29 +0000 (12:38 +0000)]
macosx interface: fix regression introduced in [21230]. patch by John Dalgliesh

16 years agoQt4 - New volume icons. Still to be worked out.
Jean-Baptiste Kempf [Mon, 1 Oct 2007 11:31:16 +0000 (11:31 +0000)]
Qt4 - New volume icons. Still to be worked out.

16 years agoQt4 - Prefs: Change audio icon and modify the codec one.
Jean-Baptiste Kempf [Mon, 1 Oct 2007 10:08:30 +0000 (10:08 +0000)]
Qt4 - Prefs: Change audio icon and modify the codec one.

16 years agoThat shouldn't have been part of the previous commit
Rafaël Carré [Mon, 1 Oct 2007 00:33:08 +0000 (00:33 +0000)]
That shouldn't have been part of the previous commit

16 years agoconfigure.ac: typo, fix #1204
Rafaël Carré [Mon, 1 Oct 2007 00:29:00 +0000 (00:29 +0000)]
configure.ac: typo, fix #1204

16 years agoimage vout: assigning -1 to an unsigned int is not that clever.
Rafaël Carré [Sun, 30 Sep 2007 23:47:55 +0000 (23:47 +0000)]
image vout: assigning -1 to an unsigned int is not that clever.

16 years agocontrol/media_instance.c: Remove access to p_input_thread->p_internals. (which was...
Pierre d'Herbemont [Sun, 30 Sep 2007 23:25:18 +0000 (23:25 +0000)]
control/media_instance.c: Remove access to p_input_thread->p_internals. (which was a broken hack by the way).

16 years agoAdded a INPUT_GET_VIDEO_FPS (get the fps of the main video, should works with
Laurent Aimar [Sun, 30 Sep 2007 23:17:19 +0000 (23:17 +0000)]
Added a INPUT_GET_VIDEO_FPS (get the fps of the main video, should works with
input slave) Untested.
media_instance.c no longer depends on input_internal.h
Clean up a bit es_out pause handling.
Fixed DEMUX_GET_FPS description (double not float)

16 years agocontrol/media_instance.c: Remove one occurence of input->p.
Pierre d'Herbemont [Sun, 30 Sep 2007 22:56:37 +0000 (22:56 +0000)]
control/media_instance.c: Remove one occurence of input->p.

16 years agolibvlc_playlist_get_media_instance(): raise an exception when there is no input,...
Rafaël Carré [Sun, 30 Sep 2007 22:55:35 +0000 (22:55 +0000)]
libvlc_playlist_get_media_instance(): raise an exception when there is no input, fix #1265

16 years agoPartial fix for media instance. (It was using input_control_e intead of
Laurent Aimar [Sun, 30 Sep 2007 22:20:31 +0000 (22:20 +0000)]
Partial fix for media instance. (It was using input_control_e intead of
input_query_e).

Btw input_internal.h is an internal header for src/input/* ONLY.
If input/control/* need it, then it is BROKEN (or there is a missing
functionnality, just ask for it then)
 I see it calling demux2_Control, this will segfault if you are unlucky.
 Accessing directly to p_input->p member is also forbidden.

16 years agoncurses: display random/repeat/loop status
Rafaël Carré [Sun, 30 Sep 2007 20:54:30 +0000 (20:54 +0000)]
ncurses: display random/repeat/loop status

16 years agosvn:keywords
Christophe Mutricy [Sun, 30 Sep 2007 20:01:20 +0000 (20:01 +0000)]
svn:keywords

16 years agoPartial unfinished pipes conditional fallback for condition variables.
Rémi Denis-Courmont [Sun, 30 Sep 2007 19:31:08 +0000 (19:31 +0000)]
Partial unfinished pipes conditional fallback for condition variables.
This would be necessary to rid the networking code of arbitrary timers (but it does not work yet).

16 years agoSimplify and fix (real) vlc dependencies and "make core" assuming libtool is used
Rémi Denis-Courmont [Sun, 30 Sep 2007 19:28:30 +0000 (19:28 +0000)]
Simplify and fix (real) vlc dependencies and "make core" assuming libtool is used

16 years agoAdd missing copyright and license header
Rémi Denis-Courmont [Sun, 30 Sep 2007 19:08:11 +0000 (19:08 +0000)]
Add missing copyright and license header

16 years agoHacks for On2 AVI files (close #1318)
Laurent Aimar [Sun, 30 Sep 2007 17:25:55 +0000 (17:25 +0000)]
Hacks for On2 AVI files (close #1318)

16 years agoFix segmentation fault
Rémi Denis-Courmont [Sun, 30 Sep 2007 16:58:33 +0000 (16:58 +0000)]
Fix segmentation fault

16 years agoActually remove unused FREE() macro
Rémi Denis-Courmont [Sun, 30 Sep 2007 16:37:07 +0000 (16:37 +0000)]
Actually remove unused FREE() macro

16 years agoRemove FREE() macro, since free() does the same internally
Rémi Denis-Courmont [Sun, 30 Sep 2007 16:31:02 +0000 (16:31 +0000)]
Remove FREE() macro, since free() does the same internally

16 years agoAdded const wheen needed for stream_Peek (demuxer/access)
Laurent Aimar [Sun, 30 Sep 2007 15:40:34 +0000 (15:40 +0000)]
Added const wheen needed for stream_Peek (demuxer/access)
Made demux2_IsPathExtension case insensitive.
Used demux2_IsPathExtension/p_demux->b_force when appropriate
Fixed a regression in flac demuxer (segfault when reading meta data)
Added a VLC_UNUSED(x) macro to avoid seeing ugly (void)x around the code.
Improved a bit a few vlc_common.h macro (do {} while(0))

16 years agoTypo
Rémi Denis-Courmont [Sun, 30 Sep 2007 14:50:12 +0000 (14:50 +0000)]
Typo

16 years agoRename var_GetGlobalMutex to var_AcquireMutex and make it lock the mutex automatically
Rémi Denis-Courmont [Sun, 30 Sep 2007 14:33:22 +0000 (14:33 +0000)]
Rename var_GetGlobalMutex to var_AcquireMutex and make it lock the mutex automatically

16 years agoFix tiny race condition
Rémi Denis-Courmont [Sun, 30 Sep 2007 14:11:47 +0000 (14:11 +0000)]
Fix tiny race condition

16 years agoHide object reference counter.
Rémi Denis-Courmont [Sun, 30 Sep 2007 14:01:24 +0000 (14:01 +0000)]
Hide object reference counter.
Good news is, no plugins used it anyway.
Bad news is, some parts of libvlc still use which is wrong (i_refcount is protected by the "structure lock", meaning only misc/objects.c functions can use it safely).

16 years agoreference count should really be unsigned
Rémi Denis-Courmont [Sun, 30 Sep 2007 13:59:28 +0000 (13:59 +0000)]
reference count should really be unsigned

16 years agoMacOSX/Framework: Use --opengl-provider=minimal_macosx. (Original patch by Enrique...
Pierre d'Herbemont [Sun, 30 Sep 2007 10:40:30 +0000 (10:40 +0000)]
MacOSX/Framework: Use --opengl-provider=minimal_macosx. (Original patch by Enrique Osuna <enrique.osuna a gmail d com>).

16 years agomodules/gui/minimal_macosx: Fix shortname and add shortcut, after funman answer to...
Pierre d'Herbemont [Sun, 30 Sep 2007 10:37:45 +0000 (10:37 +0000)]
modules/gui/minimal_macosx: Fix shortname and add shortcut, after funman answer to Enrique Osuna patch.

16 years agomodules/video_output/opengl.c: Allow opengl provider override at runtime.(Original...
Pierre d'Herbemont [Sun, 30 Sep 2007 10:36:19 +0000 (10:36 +0000)]
modules/video_output/opengl.c: Allow opengl provider override at runtime.(Original patch by Enrique Osuna <enrique.osuna a gmail d com>).

16 years agoSome fixes for compiling on Cygwin: x264, pthreads, taglib and dirac.
Bernie Purcell [Sun, 30 Sep 2007 07:43:53 +0000 (07:43 +0000)]
Some fixes for compiling on Cygwin: x264, pthreads, taglib and dirac.
Reverse previous workaround for pthreads lib having GC2 suffix - that
is actually normal; patch should instead go into x264 to make it ignore
the presence of a local pthread lib under cygwin when doing configure tests.

16 years agoFixed regression in EITConvertToUTF8.
Laurent Aimar [Sat, 29 Sep 2007 23:09:10 +0000 (23:09 +0000)]
Fixed regression in EITConvertToUTF8.

16 years agoQt4 - add a record icon, might be unused.
Jean-Baptiste Kempf [Sat, 29 Sep 2007 22:50:30 +0000 (22:50 +0000)]
Qt4 - add a record icon, might be unused.

16 years agoQt4 - New icons for extended preferences.
Jean-Baptiste Kempf [Sat, 29 Sep 2007 21:56:07 +0000 (21:56 +0000)]
Qt4 - New icons for extended preferences.

16 years agoContribs: take libebml and libmatroska from released versions... Way easier to not...
Jean-Baptiste Kempf [Sat, 29 Sep 2007 21:13:44 +0000 (21:13 +0000)]
Contribs: take libebml and libmatroska from released versions... Way easier to not compile it everytime.

16 years agoFixed a regression with --sub-autodetect-path
Laurent Aimar [Sat, 29 Sep 2007 16:02:15 +0000 (16:02 +0000)]
Fixed a regression with --sub-autodetect-path
Ignore directories in --sub-autodetect-path that match the directory
of the current file (But it does not works with symbolic links).

16 years agoncurses: don't use *Locale() conversion functions when compiled with wide characters...
Rafaël Carré [Sat, 29 Sep 2007 16:00:07 +0000 (16:00 +0000)]
ncurses: don't use *Locale() conversion functions when compiled with wide characters support

16 years agoCheck all(?) memory allocations (if you do it, do it completetly ;)
Laurent Aimar [Sat, 29 Sep 2007 15:51:34 +0000 (15:51 +0000)]
Check all(?) memory allocations (if you do it, do it completetly ;)
Fixed an overflow when more than MAX_SUBTITLE_FILES are detected.
Fixed a bunch of memory leaks.
Fixed removing sub/idx pair. (sizeof() != strlen on char*)
Clean up/Simplify (asprintf/calloc are usefull)
Cosmetics

16 years agoFixed segfault if more than 1 subtitle has been detected and you have not
Laurent Aimar [Sat, 29 Sep 2007 15:40:26 +0000 (15:40 +0000)]
Fixed segfault if more than 1 subtitle has been detected and you have not
selected one with --sub-file

16 years agoCheck malloc return value)
Jean-Paul Saman [Sat, 29 Sep 2007 14:22:50 +0000 (14:22 +0000)]
Check malloc return value)

16 years agotelepathy: 10 calls to the "item-change" callback may be necessary to have the metada...
Rafaël Carré [Sat, 29 Sep 2007 11:26:38 +0000 (11:26 +0000)]
telepathy: 10 calls to the "item-change" callback may be necessary to have the metadata available.

16 years agoSpecify SSRC in SETUP response
Rémi Denis-Courmont [Sat, 29 Sep 2007 11:20:48 +0000 (11:20 +0000)]
Specify SSRC in SETUP response

16 years agodon't compare signed with unsigned
Rafaël Carré [Fri, 28 Sep 2007 22:41:30 +0000 (22:41 +0000)]
don't compare signed with unsigned

16 years agoconfigure.ac: cosmetics
Rafaël Carré [Fri, 28 Sep 2007 22:08:01 +0000 (22:08 +0000)]
configure.ac: cosmetics

16 years agoUpdate build system for cdg demuxer/codec.
Laurent Aimar [Fri, 28 Sep 2007 21:59:25 +0000 (21:59 +0000)]
Update build system for cdg demuxer/codec.

16 years agoAdded CD+G file support:
Laurent Aimar [Fri, 28 Sep 2007 21:58:26 +0000 (21:58 +0000)]
Added CD+G file support:
 - as a standalone file
 - as a kind of subtitle (even if it is a video track).
CD-G disk are not supported.

Please, report any file incorrectly decoded. (I have 0 sample with
circular scrolling)

In subtitle_Detect, do not add as a subtitle the file for which we
are doing the detection.
 (subtitle_Detect("file.sub") returned "file.sub")

16 years agotelepathy: fixes [22301]. '-' is forbidden in variable names.
Rafaël Carré [Fri, 28 Sep 2007 21:16:40 +0000 (21:16 +0000)]
telepathy: fixes [22301]. '-' is forbidden in variable names.

16 years agotelepathy: avoid flooding the bus when playing some special inputs.
Rafaël Carré [Fri, 28 Sep 2007 21:11:01 +0000 (21:11 +0000)]
telepathy: avoid flooding the bus when playing some special inputs.

16 years agotelepathy: same than [22299]
Rafaël Carré [Fri, 28 Sep 2007 20:32:54 +0000 (20:32 +0000)]
telepathy: same than [22299]

16 years agodbus: Removes dbus_threads_init_default() since it's already done in libvlc
Rafaël Carré [Fri, 28 Sep 2007 20:27:47 +0000 (20:27 +0000)]
dbus: Removes dbus_threads_init_default() since it's already done in libvlc

16 years agoscreensaver: Removes unused variable
Rafaël Carré [Fri, 28 Sep 2007 20:09:55 +0000 (20:09 +0000)]
screensaver: Removes unused variable

16 years agoDon't show unsaveable options in the preferences
Christophe Mutricy [Fri, 28 Sep 2007 18:59:17 +0000 (18:59 +0000)]
Don't show unsaveable options in the preferences