Win32: canonicalize path separator, avoid isalpha(), remove dead code
In principle, isalpha() depends on the locale. As for directory
traversal, we should either add a boolean, or fix it manually in the
caller (on a case-by-case basis).
NSMenuItems still exist when libvlc_Quit is called, and thus some items are likely not autoreleased before vlc quits. Set all representedObjects for all menu's to null so that the menuitems no longer retain any of the vlc objects.
When building the menu's, autorelease the VLCAutoGeneratedMenu's instead of retaining. The NSMenuItem will do a retain/release for the live of the object in the NSMenuItem and thus once the menu's are done using the object, their retaincount will be 0 and they will be dealloc'ed at the end of the EventLoop. (An eventloop is One run of GUI updates you might say).
David Flynn [Wed, 1 Apr 2009 21:40:04 +0000 (21:40 +0000)]
win32: make vlc_vsnprintf more like c99 vsnprintf
Fixes following issues using MSVCRT _snprintf:
- Failure to null terminate all strings
- Failure to return number of characters that would've been
printed had the buffer been sufficiently large
- Failure to accept size = 0 (and str = NULL) to determine
final output length.
NB, the third issue above is fixed on *some* win32 implementations,
however it is not officially documented as being so.
Signed-off-by: David Flynn <davidf@rd.bbc.co.uk> Signed-off-by: Jean-Baptiste Kempf <jb@videolan.org>
David Flynn [Wed, 1 Apr 2009 21:40:03 +0000 (21:40 +0000)]
win32: vlc_fix_format_string - various fixes
- avoid mingw problems with %l*
- avoid using %I32 on Win32, since wince doesn't support it
- unify WIN64 and WIN32 cases.
- if malloc were to fail(!), don't allow unfiltered format string
to get passed to *printf.
(substitues an error message)
Signed-off-by: David Flynn <davidf@rd.bbc.co.uk> Signed-off-by: Jean-Baptiste Kempf <jb@videolan.org>
David Flynn [Wed, 1 Apr 2009 21:40:02 +0000 (21:40 +0000)]
win32: fix %zu fixups - dont use mingw's vsnprintf
Traditionally, MSVCRT has provided vsnprintf as _vsnprintf;
to 'aid' portability/standards compliance, mingw provide a
static version of [v]snprintf that is buggy.
The bug manifests as %lx is treated as a 64bit argument not
32bit, ie consumes two 32bit parameters. if a %s were to
follow a %lx, bad things can happen.
Solution: Be sure to use the MSVCRT version, at least it
behaves as expected
Additionally, make it a bit more obvious when vlc wrappers
are being called by other wrappers.
Signed-off-by: David Flynn <davidf@rd.bbc.co.uk> Signed-off-by: Jean-Baptiste Kempf <jb@videolan.org>
David Flynn [Fri, 27 Mar 2009 20:37:57 +0000 (20:37 +0000)]
codec/schroedinger: inform vlc of clean area
For SD, this should allow removal of black bars form the edge of frames.
i_aspect is set to the aspect ratio of the whole frame which may be
greater than that of the clean area. VLC should then calculate the SAR,
and eventually display a clean area sized picture that is of the correct
aspect ratio.
NB, we do actually know the SAR, but it isn't known if vlc cares at this
point.
Signed-off-by: David Flynn <davidf@rd.bbc.co.uk> Signed-off-by: Jean-Baptiste Kempf <jb@videolan.org>
David Flynn [Fri, 27 Mar 2009 20:37:54 +0000 (20:37 +0000)]
codec/schroedinger: Use new autoparse+tagging api
Schroedinger now has an api that allows passing in arbitarily aligned
data units (ie, whole encapsuation units), use this rather than attempt
to chunk up the bitstream ourselves.
This new api also enables buffer tagging, where buffers may be tagged
with arbitary data that gets associated with the next picture to
commence at or after the start of the buffer. This removes the need
for the TLBs and associated accounting.
Signed-off-by: David Flynn <davidf@rd.bbc.co.uk> Signed-off-by: Jean-Baptiste Kempf <jb@videolan.org>
contribs: removed the option to use the normal GCC instead of llvm-gcc on Darwin 9 and removed the DARWIN_COMPILER flag as it is no longer needed. llvm-gcc remains unused on Darwin 10. A new x86_64 contrib package will be provided later tonight.
Deactivated libcdio and vcdinfo, they are for cddax and vcdx, and I never managed to compile those for windows... Anyway, if people want to rip CD, VLC isn't the good soft.
Rafaël Carré [Mon, 30 Mar 2009 14:53:29 +0000 (16:53 +0200)]
ncurses : various fixes (runtime / display)
Release referenced input, only use "intf-change" playlist callback.
When using the "item-change" callback we can't lock the playlist,
because some callers lock it and some don't.
Drawback : Prevent UI updates when metadata becomes available for items.
Fix statistics box display (empty lines not refreshed)
macosx: remove the interaction code from intf.m and add a draft for dialog-fatal. The complete implementation will recycle the existing VLCInteraction dialogue code.
--snapshot-format was proposing png or jpg, but if format passed to this
option was unrecognized, then fallback to png.
This commit fix the fact that vlc was always falling back to png.
Signed-off-by: Antoine Cellerier <dionoea@videolan.org>
projects / vlc / log