]> git.sesse.net Git - vlc/log
vlc
14 years agovod preparsing : if muxer is specified, only wait for input_item_IsPreparsed
Sébastien Escudier [Fri, 11 Sep 2009 09:30:36 +0000 (11:30 +0200)]
vod preparsing : if muxer is specified, only wait for input_item_IsPreparsed

Signed-off-by: Rémi Denis-Courmont <remi@remlab.net>
14 years agoAdded a new option, play-and-pause. When this option is set, the input thread is...
Elliot Murphy [Tue, 28 Jul 2009 02:12:55 +0000 (22:12 -0400)]
Added a new option, play-and-pause. When this option is set, the input thread is automatically paused when each item reaches the end of the file.

This option is intended to make it easier to use VLC during live
productions featuring instructors and speakers working
with American Sign Language (ASL), or really any Sign Language, where
it is common for a lecturer to refer to video clips during a
presentation. The automatic pausing provides a smooth pause for the
video operator to switch the projection system back to the camera
with the live speaker once a clip has finished playing.

Signed-off-by: Rémi Denis-Courmont <remi@remlab.net>
14 years agoAC3 3F1R downmix to stereo (simple downmixer)
James Turner [Mon, 14 Sep 2009 15:09:13 +0000 (18:09 +0300)]
AC3 3F1R downmix to stereo (simple downmixer)

Signed-off-by: Rémi Denis-Courmont <remi@remlab.net>
14 years agovod input preparsing : use input events instead of msleep
Sébastien Escudier [Fri, 11 Sep 2009 09:26:22 +0000 (11:26 +0200)]
vod input preparsing : use input events instead of msleep

Signed-off-by: Rémi Denis-Courmont <remi@remlab.net>
14 years agoINPUT: Properly remove SDT and EPG entries on exit
Marian Ďurkovič [Mon, 14 Sep 2009 14:52:31 +0000 (16:52 +0200)]
INPUT: Properly remove SDT and EPG entries on exit

14 years agoEPG: Catch a replace EIT-coded CR/LFs
Marian Ďurkovič [Mon, 14 Sep 2009 10:04:27 +0000 (12:04 +0200)]
EPG: Catch a replace EIT-coded CR/LFs

14 years agoProvide local routine for ISO_6937 -> UTF-8 conversions
Marian Ďurkovič [Mon, 14 Sep 2009 07:59:50 +0000 (09:59 +0200)]
Provide local routine for ISO_6937 -> UTF-8 conversions

14 years agoavcodec: disable subtitle encoding
Pierre Ynard [Mon, 14 Sep 2009 07:32:51 +0000 (09:32 +0200)]
avcodec: disable subtitle encoding

The avcodec module can be successfully opened to encode subtitle formats
that it recognizes, but support is absent and pf_encode_sub is never
set, which leads to a crash.

14 years agov4l2: work around broken resolution detection
Pierre Ynard [Mon, 14 Sep 2009 06:32:38 +0000 (08:32 +0200)]
v4l2: work around broken resolution detection

This piece of code really ought to be fixed better than that

14 years agoEPG: Don't display extra items from extended EIT events
Marian Ďurkovič [Mon, 14 Sep 2009 06:25:30 +0000 (08:25 +0200)]
EPG: Don't display extra items from extended EIT events

Info they provide is typically also present in the text or
not usefull to VLC.

14 years agoDisplay EPG description if available
Marian Ďurkovič [Mon, 14 Sep 2009 06:19:12 +0000 (08:19 +0200)]
Display EPG description if available

14 years agoQt4: fix segfault when exiting after a service discovery has been activated
Jakob Leben [Sun, 13 Sep 2009 23:26:20 +0000 (01:26 +0200)]
Qt4: fix segfault when exiting after a service discovery has been activated

14 years agoResolve crash in mozilla plugin pointed out by Alex Millet <A.millet89@gmail.com>
JP Dinger [Sun, 13 Sep 2009 11:35:12 +0000 (13:35 +0200)]
Resolve crash in mozilla plugin pointed out by Alex Millet <A.millet89@gmail.com>

14 years agoXCB-XVideo: fix shared-memory YUY2
Rémi Denis-Courmont [Sun, 13 Sep 2009 09:25:32 +0000 (12:25 +0300)]
XCB-XVideo: fix shared-memory YUY2

14 years agoWin32: bugfix for blueish video colors useing DirectX Overlay Output
André Weber [Sat, 12 Sep 2009 17:02:47 +0000 (19:02 +0200)]
Win32: bugfix for blueish video colors useing DirectX Overlay Output

The fourcc of I420 was not recognized durring vout init so a fallback to YV12
was used - which flipped the U and V colorplanes.

(I'am not sure if this is the correct solution for this, a developer knowing
the video output more in detail should have a look on this.)

14 years agoMissing #include <errno.h>
Pierre Ynard [Sat, 12 Sep 2009 19:12:08 +0000 (21:12 +0200)]
Missing #include <errno.h>

14 years agodeinterlace: preliminary merge ARM NEON optimization
Rémi Denis-Courmont [Sat, 12 Sep 2009 16:00:49 +0000 (19:00 +0300)]
deinterlace: preliminary merge ARM NEON optimization

(It wouldn't hurt to make VLC align pixel lines more strongly, but I am
 not sure if this is feasible)

14 years agoDirect3D: don't forget to initialize the mutex
Geoffroy Couprie [Sat, 12 Sep 2009 14:34:12 +0000 (16:34 +0200)]
Direct3D: don't forget to initialize the mutex

14 years agoPulseAudio: higher priority than ALSA
Rémi Denis-Courmont [Wed, 2 Sep 2009 16:44:55 +0000 (19:44 +0300)]
PulseAudio: higher priority than ALSA

Without this, the PulseAudio output is completely useless. PulseAudio
provides ALSA emulation, so VLC would always use ALSA. Now, it will use
ALSA if PulseAudio is not available, but avoid the PulseAudio ALSA
emulation which makes more sense. Either way, if your PulseAudio setup
is broken, you are screwed - this change makes no difference.

14 years agocontrib: ffmpeg needs PIC on Linux (just like x264)
Rémi Denis-Courmont [Wed, 2 Sep 2009 19:54:40 +0000 (22:54 +0300)]
contrib: ffmpeg needs PIC on Linux (just like x264)

14 years agoFix fixed point liba52 warnings
Rémi Denis-Courmont [Sat, 12 Sep 2009 12:53:25 +0000 (15:53 +0300)]
Fix fixed point liba52 warnings

14 years agoQt4: use semaphore
Rémi Denis-Courmont [Sat, 12 Sep 2009 11:27:40 +0000 (14:27 +0300)]
Qt4: use semaphore

14 years agoQt4: remove pointless locking
Rémi Denis-Courmont [Sat, 12 Sep 2009 11:27:11 +0000 (14:27 +0300)]
Qt4: remove pointless locking

The main interface video window calls are re-entrant nowadays.

14 years agoImplement thread semaphores
Rémi Denis-Courmont [Sat, 12 Sep 2009 11:26:33 +0000 (14:26 +0300)]
Implement thread semaphores

14 years agoMissing #include <errno.h>
Rémi Denis-Courmont [Sat, 12 Sep 2009 10:44:31 +0000 (13:44 +0300)]
Missing #include <errno.h>

14 years agoqt4: refactor, remove nonsense & re-enable popup-adding items to playlist
Jakob Leben [Sat, 12 Sep 2009 05:15:00 +0000 (07:15 +0200)]
qt4: refactor, remove nonsense & re-enable popup-adding items to playlist

14 years agoContrib: projectM build fix.
Konstantin Pavlov [Fri, 11 Sep 2009 13:52:41 +0000 (17:52 +0400)]
Contrib: projectM build fix.

Note that on my system i have to do make twice in order to build the
software. SMP-incompatible build?

14 years agoContrib: libprojectM build: please send 10l to my place.
Konstantin Pavlov [Fri, 11 Sep 2009 13:37:41 +0000 (17:37 +0400)]
Contrib: libprojectM build: please send 10l to my place.

Also, set CMAKE_INSTALL_PREFIX to contrib.

14 years agoSkins2: Remove need for enum, and remove switch-o-literals.
JP Dinger [Fri, 11 Sep 2009 13:45:57 +0000 (15:45 +0200)]
Skins2: Remove need for enum, and remove switch-o-literals.

14 years agopython-ctypes: fix pylint/pyflakes warnings
Olivier Aubert [Thu, 10 Sep 2009 15:13:15 +0000 (17:13 +0200)]
python-ctypes: fix pylint/pyflakes warnings

14 years agopython-ctypes: try to detect plugin path on win32 / macosx
Olivier Aubert [Tue, 8 Sep 2009 13:47:14 +0000 (15:47 +0200)]
python-ctypes: try to detect plugin path on win32 / macosx

14 years agoBe more strict in provider name matching
Marian Ďurkovič [Fri, 11 Sep 2009 06:27:36 +0000 (08:27 +0200)]
Be more strict in provider name matching

14 years agoRTP: Make sure we wait >= 25 msec for reordered packets
Marian Ďurkovič [Fri, 11 Sep 2009 05:48:17 +0000 (07:48 +0200)]
RTP: Make sure we wait >= 25 msec for reordered packets

14 years agol10n: French update
Éric Lassauge [Thu, 10 Sep 2009 20:53:06 +0000 (21:53 +0100)]
l10n: French update

Signed-off-by: Christophe Mutricy <xtophe@videolan.org>
14 years agoContribs: Bump cmake version to 2.6.4 to enable build of libprojectM.
Pavlov Konstantin [Thu, 20 Aug 2009 21:03:57 +0000 (01:03 +0400)]
Contribs: Bump cmake version to 2.6.4 to enable build of libprojectM.

Contribs: build libprojectM trunk (fails for OSX for now).

14 years agowin32text: fix obvious null pointer dereference
Pierre Ynard [Thu, 10 Sep 2009 09:05:21 +0000 (11:05 +0200)]
win32text: fix obvious null pointer dereference

This was totally broken over the last year

14 years agoRTP: Initialize ref_ts to zero
Marian Ďurkovič [Thu, 10 Sep 2009 09:01:58 +0000 (11:01 +0200)]
RTP: Initialize ref_ts to zero

14 years agoSkins2: Cut #define down to size. Should result in identical functionality.
JP Dinger [Thu, 10 Sep 2009 08:47:36 +0000 (10:47 +0200)]
Skins2: Cut #define down to size. Should result in identical functionality.

14 years agoSet EPG default charset to ISO6937 as required by ETSI EN 300 468 Annex A
Marian Ďurkovič [Thu, 10 Sep 2009 06:54:33 +0000 (08:54 +0200)]
Set EPG default charset to ISO6937 as required by ETSI EN 300 468 Annex A
Also provide workarounds for some broadcasters which ignore this standard.

14 years agovlc: only print error message if LibVLC is initialized
Rémi Denis-Courmont [Wed, 9 Sep 2009 19:37:21 +0000 (22:37 +0300)]
vlc: only print error message if LibVLC is initialized

14 years agoAvoid non-existent HAVE_ARM_LINUX
Rémi Denis-Courmont [Wed, 9 Sep 2009 18:41:12 +0000 (21:41 +0300)]
Avoid non-existent HAVE_ARM_LINUX

14 years agoBuild liba52 with fixed point on ARM linux
Rafaël Carré [Wed, 23 Jul 2008 12:14:28 +0000 (14:14 +0200)]
Build liba52 with fixed point on ARM linux

(cherry picked from commit 97f9b3dc9f3b9ba8ca9b74ca95f1113d76ac951a)
Signed-off-by: Rémi Denis-Courmont <remi@remlab.net>
14 years agocontrib: recognize armel architecture
Rémi Denis-Courmont [Wed, 9 Sep 2009 18:32:09 +0000 (21:32 +0300)]
contrib: recognize armel architecture

14 years agoa52: fix warnings against fixed-point a52dec
Rémi Denis-Courmont [Wed, 9 Sep 2009 19:07:03 +0000 (22:07 +0300)]
a52: fix warnings against fixed-point a52dec

(and partial support for double precision, but who cares...)

14 years agoxcb-xv: allow fallback to RV32 and RV16 XVideo formats
Rémi Denis-Courmont [Wed, 9 Sep 2009 16:37:57 +0000 (19:37 +0300)]
xcb-xv: allow fallback to RV32 and RV16 XVideo formats

14 years agoxcb-xv: fix YV12 again
Rémi Denis-Courmont [Wed, 9 Sep 2009 15:52:26 +0000 (18:52 +0300)]
xcb-xv: fix YV12 again

Chrominance planes swap had been broken by the vout rework.

14 years agoxcb-xv: remove old cruft
Rémi Denis-Courmont [Wed, 9 Sep 2009 15:52:14 +0000 (18:52 +0300)]
xcb-xv: remove old cruft

14 years agoxcb-xv: no need to keep adaptor infos around
Rémi Denis-Courmont [Wed, 9 Sep 2009 15:20:05 +0000 (18:20 +0300)]
xcb-xv: no need to keep adaptor infos around

14 years agoxcb-xv: simplification
Rémi Denis-Courmont [Wed, 9 Sep 2009 15:19:41 +0000 (18:19 +0300)]
xcb-xv: simplification

14 years agoxcb-xv: adaptor selection with --xvideo-adaptor
Rémi Denis-Courmont [Wed, 9 Sep 2009 15:12:08 +0000 (18:12 +0300)]
xcb-xv: adaptor selection with --xvideo-adaptor

This uses the same numbering scheme as xvinfo and hopefully the old
Xlib XVideo plugin.

14 years ago Extended PSI DVB subtitle types to include 0x14/0x28 (indicates DDS present in HD...
Simon Hailes [Wed, 9 Sep 2009 13:30:40 +0000 (15:30 +0200)]
 Extended PSI DVB subtitle types to include 0x14/0x28 (indicates DDS present in HD spec)

Patch corrected by <jb@videolan.org>

14 years agoRTP: compute deadline for reordering from the current time
Marian Ďurkovič [Wed, 9 Sep 2009 11:25:09 +0000 (13:25 +0200)]
RTP: compute deadline for reordering from the current time

14 years agoNo fallback for Sorani
Christophe Mutricy [Tue, 8 Sep 2009 21:08:27 +0000 (22:08 +0100)]
No fallback for Sorani

Fix 271354ef76c662.
locale_match() only support 2 char code and i can't be bothered to expand it for a rare language

14 years agoWin32: fix version checks
Geoffroy Couprie [Tue, 8 Sep 2009 19:32:35 +0000 (21:32 +0200)]
Win32: fix version checks

14 years agoWin32: fix version check at install time
Geoffroy Couprie [Tue, 8 Sep 2009 17:53:49 +0000 (19:53 +0200)]
Win32: fix version check at install time

14 years agoFixed typo into invmem error message
Christophe Courtaut [Tue, 8 Sep 2009 12:04:12 +0000 (14:04 +0200)]
Fixed typo into invmem error message

Signed-off-by: Rémi Denis-Courmont <remi@remlab.net>
14 years agoFix HDTV height for H.264 streams with correct PAR.
Marian Ďurkovič [Tue, 8 Sep 2009 13:34:20 +0000 (15:34 +0200)]
Fix HDTV height for H.264 streams with correct PAR.

14 years agoWin32: add asInvoker to manifest
Geoffroy Couprie [Tue, 8 Sep 2009 11:01:12 +0000 (13:01 +0200)]
Win32: add asInvoker to manifest

14 years agoPerform charset detection and conversion to UTF-8 also for SDT fields.
Marian Ďurkovič [Tue, 8 Sep 2009 10:36:24 +0000 (12:36 +0200)]
Perform charset detection and conversion to UTF-8 also for SDT fields.

14 years agoConfigure.ac cleanup around directX
Jean-Baptiste Kempf [Tue, 8 Sep 2009 10:26:00 +0000 (12:26 +0200)]
Configure.ac cleanup around directX

14 years agoFix compilation on Windows by using a less important warning
Jean-Baptiste Kempf [Tue, 8 Sep 2009 10:25:38 +0000 (12:25 +0200)]
Fix compilation on Windows by using a less important warning

14 years agoWin7 compliance for test1: installer fixes.
Jean-Baptiste Kempf [Tue, 8 Sep 2009 10:25:09 +0000 (12:25 +0200)]
Win7 compliance for test1: installer fixes.

14 years agoCoInitialize requires -lole32
Jean-Baptiste Kempf [Tue, 8 Sep 2009 09:26:29 +0000 (11:26 +0200)]
CoInitialize requires -lole32

14 years agoRemove misleading comment, testing proved otherwise.
Marian Ďurkovič [Tue, 8 Sep 2009 10:04:36 +0000 (12:04 +0200)]
Remove misleading comment, testing proved otherwise.

14 years agoRevert "Fix demuxdump to work with RTP input ..."
Marian Ďurkovič [Tue, 8 Sep 2009 10:03:19 +0000 (12:03 +0200)]
Revert "Fix demuxdump to work with RTP input ..."

This reverts commit 8f9391f621f409375238c9967f3e264ebba38637.

(The root cause for this problem was fixed in commit
494826773c6938e3a87b12b1026c8b53c73a01a0)

14 years agoAdd support for last lines without newline in .hosts (untested).
JP Dinger [Tue, 8 Sep 2009 08:52:26 +0000 (10:52 +0200)]
Add support for last lines without newline in .hosts (untested).

14 years agoTry a better formulation for stats option
Jean-Baptiste Kempf [Tue, 8 Sep 2009 08:39:51 +0000 (10:39 +0200)]
Try a better formulation for stats option

14 years agoQt: restore system's default theme without having to guess
Francois Cartegnie [Mon, 7 Sep 2009 22:43:42 +0000 (00:43 +0200)]
Qt: restore system's default theme without having to guess

Signed-off-by: Jean-Baptiste Kempf <jb@videolan.org>
14 years agoQt: be sure that the conversion to Int from TYPE_ROLE worked
Jean-Baptiste Kempf [Tue, 8 Sep 2009 08:33:44 +0000 (10:33 +0200)]
Qt: be sure that the conversion to Int from TYPE_ROLE worked

14 years agoTemporary fix for compilation
Jean-Baptiste Kempf [Tue, 8 Sep 2009 08:29:10 +0000 (10:29 +0200)]
Temporary fix for compilation

14 years agoQt4: clean PLModel of i_depth related code
Jakob Leben [Tue, 8 Sep 2009 01:07:06 +0000 (03:07 +0200)]
Qt4: clean PLModel of i_depth related code

14 years agoremove testing artifact
Jakob Leben [Tue, 8 Sep 2009 00:43:55 +0000 (02:43 +0200)]
remove testing artifact

14 years agoqt4: implement drag&drop in playlist selector
Jakob Leben [Mon, 7 Sep 2009 23:59:06 +0000 (01:59 +0200)]
qt4: implement drag&drop in playlist selector

14 years agoQt4: make PLSelector a subclass of QTreeWidget
Jakob Leben [Mon, 7 Sep 2009 22:29:19 +0000 (00:29 +0200)]
Qt4: make PLSelector a subclass of QTreeWidget

14 years agoChange formulation to be sure people don't think we send statistics over the net.
Jean-Baptiste Kempf [Mon, 7 Sep 2009 22:23:42 +0000 (00:23 +0200)]
Change formulation to be sure people don't think we send statistics over the net.

14 years agoInfo panel text fix
Francois Cartegnie [Mon, 7 Sep 2009 17:04:12 +0000 (19:04 +0200)]
Info panel text fix

fix natural reading

Signed-off-by: Jean-Baptiste Kempf <jb@videolan.org>
14 years agoBring back aout_buffer_t.p_sys for the sole benefit of transcode
Rémi Denis-Courmont [Mon, 7 Sep 2009 21:24:18 +0000 (00:24 +0300)]
Bring back aout_buffer_t.p_sys for the sole benefit of transcode

14 years agoRemove never used function
Rémi Denis-Courmont [Mon, 7 Sep 2009 21:23:39 +0000 (00:23 +0300)]
Remove never used function

14 years agoRework aout_buffer_t layout
Rémi Denis-Courmont [Mon, 7 Sep 2009 20:53:55 +0000 (23:53 +0300)]
Rework aout_buffer_t layout

 * 12 bytes saved on 32-bits platforms,
 * 32 bytes saved on 64-bits platforms.

14 years agoCompile fix
Christophe Mutricy [Mon, 7 Sep 2009 20:30:18 +0000 (21:30 +0100)]
Compile fix

14 years agoAdd some fallback for language we have a translation
Christophe Mutricy [Sun, 6 Sep 2009 18:35:41 +0000 (19:35 +0100)]
Add some fallback for language we have a translation

14 years agoThanks
Rémi Denis-Courmont [Mon, 7 Sep 2009 19:52:18 +0000 (22:52 +0300)]
Thanks

14 years agoProperly attach stream_Demux object to its parent.
Marian Ďurkovič [Mon, 7 Sep 2009 05:47:34 +0000 (07:47 +0200)]
Properly attach stream_Demux object to its parent.

Now :demuxdump-file=foo works correctly with RTP input.

Signed-off-by: Rémi Denis-Courmont <remi@remlab.net>
14 years agoFix buggy memcpy in DstreamRead
Marian Ďurkovič [Sat, 5 Sep 2009 06:57:44 +0000 (08:57 +0200)]
Fix buggy memcpy in DstreamRead

Signed-off-by: Rémi Denis-Courmont <remi@remlab.net>
14 years agoDo not try to detach an already detached handler
Rémi Denis-Courmont [Mon, 7 Sep 2009 19:21:34 +0000 (22:21 +0300)]
Do not try to detach an already detached handler

14 years agoMove LibVLC error messages to libvlc_printerr().
Rémi Denis-Courmont [Mon, 7 Sep 2009 19:13:49 +0000 (22:13 +0300)]
Move LibVLC error messages to libvlc_printerr().

14 years agoRemove set/get drawable
Rémi Denis-Courmont [Mon, 7 Sep 2009 19:02:04 +0000 (22:02 +0300)]
Remove set/get drawable

14 years agoFixed some missing unlock() in picture_pool.
Laurent Aimar [Mon, 7 Sep 2009 18:15:34 +0000 (20:15 +0200)]
Fixed some missing unlock() in picture_pool.

14 years agoCosmetics (K&R of picture_pool).
Laurent Aimar [Mon, 7 Sep 2009 18:08:39 +0000 (20:08 +0200)]
Cosmetics (K&R of picture_pool).

14 years agoCosmetics (K&R of picture_fifo).
Laurent Aimar [Mon, 7 Sep 2009 17:39:53 +0000 (19:39 +0200)]
Cosmetics (K&R of picture_fifo).

14 years agoMoved out picture_fifo/pool_t code from vout_pictures.c
Laurent Aimar [Mon, 7 Sep 2009 17:31:51 +0000 (19:31 +0200)]
Moved out picture_fifo/pool_t code from vout_pictures.c

14 years agoEnabled vmem in "vout display" wrapper.
Laurent Aimar [Mon, 7 Sep 2009 17:06:19 +0000 (19:06 +0200)]
Enabled vmem in "vout display" wrapper.

14 years agoConverted vmem to "vout display" API.
Laurent Aimar [Mon, 7 Sep 2009 17:05:51 +0000 (19:05 +0200)]
Converted vmem to "vout display" API.

14 years agoAdded picture_pool_NewExtended.
Laurent Aimar [Mon, 7 Sep 2009 17:04:47 +0000 (19:04 +0200)]
Added picture_pool_NewExtended.

It allows to add callback called before/after a picture is used.

14 years agoRTP: apply de-jitter from last dequeuing rather than last queuing
Rémi Denis-Courmont [Mon, 7 Sep 2009 16:09:35 +0000 (19:09 +0300)]
RTP: apply de-jitter from last dequeuing rather than last queuing

Previously, if the absolute delay dropped by a longer interval than the
packetization time, we could end up repeatedly waiting into the future,
and never dequeue anything.

14 years agoCorrect samplerates...
Jean-Baptiste Kempf [Mon, 7 Sep 2009 16:00:22 +0000 (18:00 +0200)]
Correct samplerates...

14 years agoWin32: add support for Win 7 taskbar thumbnails
Geoffroy Couprie [Mon, 7 Sep 2009 14:39:41 +0000 (16:39 +0200)]
Win32: add support for Win 7 taskbar thumbnails

14 years agoWin32: make the windows_interfaces header compatible with shlobj.h
Geoffroy Couprie [Mon, 7 Sep 2009 14:38:22 +0000 (16:38 +0200)]
Win32: make the windows_interfaces header compatible with shlobj.h

14 years agoWin32: fix My Music and My Videos directories access
Geoffroy Couprie [Sun, 6 Sep 2009 18:11:02 +0000 (20:11 +0200)]
Win32: fix My Music and My Videos directories access

14 years agocontrib: Fix check for OSX Snow Leopard.
Barry Wardell [Mon, 7 Sep 2009 11:30:13 +0000 (12:30 +0100)]
contrib: Fix check for OSX Snow Leopard.

Signed-off-by: Felix Paul Kühne <fkuehne@videolan.org>