]> git.sesse.net Git - vlc/log
vlc
18 years ago* implemented MMS-support (refs #271)
Felix Paul Kühne [Wed, 3 Aug 2005 13:07:46 +0000 (13:07 +0000)]
* implemented MMS-support (refs #271)

18 years ago * extras/contrib: Added libSDL and libSDL_image to the contrib system,
Christophe Massiot [Wed, 3 Aug 2005 12:58:53 +0000 (12:58 +0000)]
 * extras/contrib: Added libSDL and libSDL_image to the contrib system,
   along with libjpeg and libtiff. SDL has been heavily patched not to
   hijack main() on Darwin, you should do the same for other platforms.
   Also fixed a huge number of typos in the Makefile, and reverted to
   an old version of ffmpeg because our friends there are breaking
   everything again.
 * Makefile.am: Re-added the "Default" directory for Xcode 2.1.

18 years ago * modules/codec/ffmpeg/encoder.c: Avoid a useless warning.
Christophe Massiot [Wed, 3 Aug 2005 12:48:10 +0000 (12:48 +0000)]
 * modules/codec/ffmpeg/encoder.c: Avoid a useless warning.

18 years ago* var_manager.cpp: explicit object destruction order to avoid access
Cyril Deguet [Tue, 2 Aug 2005 23:26:22 +0000 (23:26 +0000)]
* var_manager.cpp: explicit object destruction order to avoid access
to an already destroyed map ! (and a crash with MSVC runtime...)

18 years ago* rv32.c: new basic video filter to convert RV24 to RV32
Cyril Deguet [Tue, 2 Aug 2005 21:27:53 +0000 (21:27 +0000)]
* rv32.c: new basic video filter to convert RV24 to RV32
  (remove the dependency of skins2 to ffmpeg for PNG loading)

18 years agoUse new network modules semantics (closes #283)
Rémi Denis-Courmont [Tue, 2 Aug 2005 19:11:23 +0000 (19:11 +0000)]
Use new network modules semantics (closes #283)
but it is even more ugly than before

18 years agoAdd some sections
Christophe Mutricy [Tue, 2 Aug 2005 18:31:32 +0000 (18:31 +0000)]
Add some sections

18 years agoRename wxWindows to wxWidgets (refs #80)
Rémi Denis-Courmont [Tue, 2 Aug 2005 17:59:33 +0000 (17:59 +0000)]
Rename wxWindows to wxWidgets (refs #80)
(keep backward compatible shortcuts, of course)

18 years ago * src/stream_output/sap.c: Fixed small memory leak.
Christophe Massiot [Tue, 2 Aug 2005 17:43:34 +0000 (17:43 +0000)]
 * src/stream_output/sap.c: Fixed small memory leak.

18 years agoMinor bugfix and cleanup
Rémi Denis-Courmont [Tue, 2 Aug 2005 17:31:33 +0000 (17:31 +0000)]
Minor bugfix and cleanup

18 years ago* packages.mak: Updated the download server of libopendaap and the used version....
Felix Paul Kühne [Tue, 2 Aug 2005 16:53:43 +0000 (16:53 +0000)]
* packages.mak: Updated the download server of libopendaap and the used version. 0.4.0 is entirely free on the contrary to previous versions, since it uses a free mdns-library instead of Apple's own now.
* Makefile:
    - Our patch was applied upstream, so we don't need it anymore.
    - Fixed a copy&paste typo, which prevented the dist-clean of 9 libraries

18 years ago- When both IPv4 and IPv6 plugins return a socket, use the IPv6 one if
Rémi Denis-Courmont [Tue, 2 Aug 2005 15:31:47 +0000 (15:31 +0000)]
- When both IPv4 and IPv6 plugins return a socket, use the IPv6 one if
  IPV6_ONLY can be turned off. It is supposed to be off by default, and
  it actually is. Unfortunately, OpenBSD and NetBSD people think
  network software programmer like us are too stupid to use this
  feature properly, so they just removed it. Lets say the most stupid
  are not always the ones one think. Also, Windows doesn't support this
  yet. On all these OSes, keep the old behavior; that is prefer IPv4.
  Closes #166.

- Windows protection level compile fix

18 years agoFix typo in previous commit
Rémi Denis-Courmont [Tue, 2 Aug 2005 15:23:46 +0000 (15:23 +0000)]
Fix typo in previous commit

18 years ago * modules/codec/ffmpeg: More locking around avcodec_open() and avcodec_close().
Christophe Massiot [Tue, 2 Aug 2005 14:17:01 +0000 (14:17 +0000)]
 * modules/codec/ffmpeg: More locking around avcodec_open() and avcodec_close().

18 years ago* SDK shouldn't be enabled yet.
Derk-Jan Hartman [Tue, 2 Aug 2005 10:30:59 +0000 (10:30 +0000)]
* SDK shouldn't be enabled yet.

18 years ago* Fix mpeg2dec download
Derk-Jan Hartman [Tue, 2 Aug 2005 10:28:54 +0000 (10:28 +0000)]
* Fix mpeg2dec download

18 years ago- add libvlc.a at the end of the linking chain, so that --disable-plugins works for...
Damien Fouilleul [Tue, 2 Aug 2005 09:02:49 +0000 (09:02 +0000)]
- add libvlc.a at the end of the linking chain, so that --disable-plugins works for the ActiveX Plugin (ref. #276)

18 years agosome more suggestions by trax
Sigmund Augdal Helberg [Mon, 1 Aug 2005 21:12:22 +0000 (21:12 +0000)]
some more suggestions by trax

18 years agoadd François Seigner
Antoine Cellerier [Mon, 1 Aug 2005 19:50:19 +0000 (19:50 +0000)]
add François Seigner

18 years agomux/asf.c: codec description fixes suggested by trax
Sigmund Augdal Helberg [Mon, 1 Aug 2005 19:47:12 +0000 (19:47 +0000)]
mux/asf.c: codec description fixes suggested by trax

18 years agoadd TTL option in streamout dialog. Patch by seingier françois plus some
Antoine Cellerier [Mon, 1 Aug 2005 19:45:47 +0000 (19:45 +0000)]
add TTL option in streamout dialog. Patch by seingier françois plus some
layout and initial value fixes.

18 years agoI'll have more commits than courmisch today ! One again
Christophe Massiot [Mon, 1 Aug 2005 19:33:46 +0000 (19:33 +0000)]
I'll have more commits than courmisch today ! One again

18 years agoaccess/http.c: fixed icy with metadata
Sigmund Augdal Helberg [Mon, 1 Aug 2005 19:23:00 +0000 (19:23 +0000)]
access/http.c: fixed icy with metadata

18 years ago * wxwindows/bookmarks.cpp: cosmetics + removed a debug message
Olivier Teulière [Mon, 1 Aug 2005 18:36:09 +0000 (18:36 +0000)]
 * wxwindows/bookmarks.cpp: cosmetics + removed a debug message

18 years ago * src/input/input.c: Fixed segfault when using :programs= or the VLM.
Christophe Massiot [Mon, 1 Aug 2005 18:35:33 +0000 (18:35 +0000)]
 * src/input/input.c: Fixed segfault when using :programs= or the VLM.

18 years ago- Kludge to be able to use strerror() with Winsock
Rémi Denis-Courmont [Mon, 1 Aug 2005 18:27:44 +0000 (18:27 +0000)]
- Kludge to be able to use strerror() with Winsock
  (should fix IPv6 error reporting on Win32)
- Some cleanup

18 years ago * modules/access/fake.c: New --fake-duration option ; useful to do a
Christophe Massiot [Mon, 1 Aug 2005 17:58:22 +0000 (17:58 +0000)]
 * modules/access/fake.c: New --fake-duration option ; useful to do a
   slide-show.

18 years agoDon't reinvent strchr()
Rémi Denis-Courmont [Mon, 1 Aug 2005 17:54:14 +0000 (17:54 +0000)]
Don't reinvent strchr()

18 years agoremove compile warning
Antoine Cellerier [Mon, 1 Aug 2005 17:28:16 +0000 (17:28 +0000)]
remove compile warning

18 years agoDon't attempt to listen to link-local scope SAP address because it doesn't work
Rémi Denis-Courmont [Mon, 1 Aug 2005 17:26:37 +0000 (17:26 +0000)]
Don't attempt to listen to link-local scope SAP address because it doesn't work

18 years agofileinfo : patch by Jonas A. Larsen to remove empty fields
Antoine Cellerier [Mon, 1 Aug 2005 17:21:22 +0000 (17:21 +0000)]
fileinfo : patch by Jonas A. Larsen to remove empty fields
bookmarks : remove compile warning

18 years agoshout.c: fixed shoutcast discovery (added www. to hostname)
Sigmund Augdal Helberg [Mon, 1 Aug 2005 17:13:05 +0000 (17:13 +0000)]
shout.c: fixed shoutcast discovery (added www. to hostname)

18 years ago * modules/codec/fake.c: New obscure options to allow for maximum width
Christophe Massiot [Mon, 1 Aug 2005 16:40:24 +0000 (16:40 +0000)]
 * modules/codec/fake.c: New obscure options to allow for maximum width
   and height while keeping the aspect ratio of the original picture. New
   options to deinterlace the picture on loading.

18 years ago * src/misc/image.c: New image_Filter call to apply a filter on a picture_t
Christophe Massiot [Mon, 1 Aug 2005 16:38:56 +0000 (16:38 +0000)]
 * src/misc/image.c: New image_Filter call to apply a filter on a picture_t
   (for instance deinterlace filter).

18 years ago * extras/contrib/bootstrap: Really fixed it this time.
Christophe Massiot [Mon, 1 Aug 2005 14:58:14 +0000 (14:58 +0000)]
 * extras/contrib/bootstrap: Really fixed it this time.

18 years ago * extras/contrib/bootstrap: Typo.
Christophe Massiot [Mon, 1 Aug 2005 14:53:22 +0000 (14:53 +0000)]
 * extras/contrib/bootstrap: Typo.

18 years ago * modules/codec/twolame.c, modules/codec/ffmpeg/encoder.c: Added sanity
Christophe Massiot [Mon, 1 Aug 2005 14:50:42 +0000 (14:50 +0000)]
 * modules/codec/twolame.c, modules/codec/ffmpeg/encoder.c: Added sanity
   checks for frequencies and bitrates in MPEG audio.

18 years ago * modules/control/http.c: Add an 'ext' field to file structures in
Christophe Massiot [Mon, 1 Aug 2005 14:44:08 +0000 (14:44 +0000)]
 * modules/control/http.c: Add an 'ext' field to file structures in
   order to get the file extension.

18 years ago * Makefile.am: fix build location of Mac OS X bundle for Darwin8.
Christophe Massiot [Mon, 1 Aug 2005 14:40:53 +0000 (14:40 +0000)]
 * Makefile.am: fix build location of Mac OS X bundle for Darwin8.

18 years ago * extras/contrib/src/packages.mak: Reverted [11913] for libmpeg2
Christophe Massiot [Mon, 1 Aug 2005 12:51:00 +0000 (12:51 +0000)]
 * extras/contrib/src/packages.mak: Reverted [11913] for libmpeg2
   because the new location doesn't exist.

18 years agoFix wrong uninstall key
Jean-Paul Saman [Mon, 1 Aug 2005 11:10:19 +0000 (11:10 +0000)]
Fix wrong uninstall key

18 years ago * wxwindows: do not save the position of minimized windows. Closes #282.
Olivier Teulière [Sun, 31 Jul 2005 20:58:43 +0000 (20:58 +0000)]
 * wxwindows: do not save the position of minimized windows. Closes #282.
   We cannot do better (i.e. save the position when the window is minimized)
   because we cannot be notified of such event with the wxWindows API.

18 years ago- Put IP6 instead of IP4 when appropriate
Rémi Denis-Courmont [Sun, 31 Jul 2005 19:04:29 +0000 (19:04 +0000)]
- Put IP6 instead of IP4 when appropriate
  (closes #270)
- strlen( static string ) => sizeof
  using strlen with static strings is lame

18 years agoAdd const
Rémi Denis-Courmont [Sun, 31 Jul 2005 19:01:09 +0000 (19:01 +0000)]
Add const

18 years agofree stuff and add mutex (will be needed when RSS feed get updated)
Antoine Cellerier [Sun, 31 Jul 2005 16:29:04 +0000 (16:29 +0000)]
free stuff and add mutex (will be needed when RSS feed get updated)

18 years agoadd update checker and rss subfilter
Antoine Cellerier [Sun, 31 Jul 2005 00:25:10 +0000 (00:25 +0000)]
add update checker and rss subfilter

18 years agochange option names so users can have different settings for marq and rss modules
Antoine Cellerier [Sun, 31 Jul 2005 00:15:54 +0000 (00:15 +0000)]
change option names so users can have different settings for marq and rss modules

18 years ago * rss.c : add new rss module (sub filter)
Antoine Cellerier [Sun, 31 Jul 2005 00:07:48 +0000 (00:07 +0000)]
 * rss.c  : add new rss module (sub filter)
Still needs much work
example command line :
./vlc -vvv --color --sub-filter rss --rss-urls "http://kernel.org/kdist/rss.xml,http://fxfeeds.mozilla.org/rss20.xml

 * motiondetect.c : propset ... Id

18 years ago--sub-filter should appear in vlc -H without needing --advanced
Antoine Cellerier [Sat, 30 Jul 2005 22:14:16 +0000 (22:14 +0000)]
--sub-filter should appear in vlc -H without needing --advanced

18 years agosvn propset svn:keywords Id
Antoine Cellerier [Sat, 30 Jul 2005 20:01:33 +0000 (20:01 +0000)]
svn propset svn:keywords Id

18 years agoremove tabs and trailing spaces
Antoine Cellerier [Sat, 30 Jul 2005 19:59:19 +0000 (19:59 +0000)]
remove tabs and trailing spaces

18 years ago* forwardport [11919]
Derk-Jan Hartman [Sat, 30 Jul 2005 12:39:57 +0000 (12:39 +0000)]
* forwardport [11919]

18 years ago* Add options for SDK building. (not enabled yet) and fix liba52 downlaod
Derk-Jan Hartman [Sat, 30 Jul 2005 12:07:09 +0000 (12:07 +0000)]
* Add options for SDK building. (not enabled yet) and fix liba52 downlaod

18 years ago* modules/audio_output/waveout.c: get rid of roundf() which isn't supported on WinCE.
Gildas Bazin [Sat, 30 Jul 2005 11:30:51 +0000 (11:30 +0000)]
* modules/audio_output/waveout.c: get rid of roundf() which isn't supported on WinCE.

18 years ago* include/network.h, modules/access/mms/mmstu.c, src/stream_output/acl.c: WinCE build...
Gildas Bazin [Sat, 30 Jul 2005 10:49:52 +0000 (10:49 +0000)]
* include/network.h, modules/access/mms/mmstu.c, src/stream_output/acl.c: WinCE build fixes.

18 years ago* Update some sourceforge download locations to use the mirror
Derk-Jan Hartman [Sat, 30 Jul 2005 01:22:35 +0000 (01:22 +0000)]
* Update some sourceforge download locations to use the mirror

18 years agoFix some memleaks
Rémi Denis-Courmont [Fri, 29 Jul 2005 19:04:46 +0000 (19:04 +0000)]
Fix some memleaks

18 years ago- Put correct IP4 owner address
Rémi Denis-Courmont [Fri, 29 Jul 2005 18:45:11 +0000 (18:45 +0000)]
- Put correct IP4 owner address
- Support IP6 (refs #270)

18 years agoFix compilation. Thanks bigben
Rémi Denis-Courmont [Fri, 29 Jul 2005 18:28:45 +0000 (18:28 +0000)]
Fix compilation. Thanks bigben

18 years agoI had missed a third similar problem
Rémi Denis-Courmont [Fri, 29 Jul 2005 18:00:06 +0000 (18:00 +0000)]
I had missed a third similar problem

18 years ago- Add httpd_ServerIP() to obtain HTTP server's IP used with a given client
Rémi Denis-Courmont [Fri, 29 Jul 2005 17:53:50 +0000 (17:53 +0000)]
- Add httpd_ServerIP() to obtain HTTP server's IP used with a given client
(much like httpd_ClientIP())
- Rewrite httpd_ClientIP() to use existing API and not use malloc/free

18 years agoForgot this file
Rémi Denis-Courmont [Fri, 29 Jul 2005 17:31:00 +0000 (17:31 +0000)]
Forgot this file

18 years agoDon't require a vlc_object_t in net_Get(Sock|Peer)Address
Rémi Denis-Courmont [Fri, 29 Jul 2005 17:28:01 +0000 (17:28 +0000)]
Don't require a vlc_object_t in net_Get(Sock|Peer)Address
(will be needed by a later commit)

18 years ago * include/network.h: VLC should now compile.
Christophe Massiot [Fri, 29 Jul 2005 16:56:10 +0000 (16:56 +0000)]
 * include/network.h: VLC should now compile.

18 years agoSimilar fixes
Rémi Denis-Courmont [Fri, 29 Jul 2005 16:43:55 +0000 (16:43 +0000)]
Similar fixes
RTSP server supports IPv6 (refs #270)

18 years agoBind RTSP to all interfaces by default (refs #270)
Rémi Denis-Courmont [Fri, 29 Jul 2005 16:24:52 +0000 (16:24 +0000)]
Bind RTSP to all interfaces by default (refs #270)

18 years agoAccept NULL hostname for httpd_HostNew
Rémi Denis-Courmont [Fri, 29 Jul 2005 16:23:54 +0000 (16:23 +0000)]
Accept NULL hostname for httpd_HostNew

18 years agoDon't add brackets around IPv6 addresses, this is annoying
Rémi Denis-Courmont [Fri, 29 Jul 2005 16:09:58 +0000 (16:09 +0000)]
Don't add brackets around IPv6 addresses, this is annoying

18 years agoA bunch of minor fixes
Rémi Denis-Courmont [Fri, 29 Jul 2005 16:08:16 +0000 (16:08 +0000)]
A bunch of minor fixes

18 years agoUse more sensible/conservative buffer size for psz_ttl
Rémi Denis-Courmont [Fri, 29 Jul 2005 15:51:08 +0000 (15:51 +0000)]
Use more sensible/conservative buffer size for psz_ttl

18 years agoDon't use NULL char pointer
Rémi Denis-Courmont [Fri, 29 Jul 2005 15:47:35 +0000 (15:47 +0000)]
Don't use NULL char pointer

18 years agoInline net_GetAddress
Rémi Denis-Courmont [Fri, 29 Jul 2005 15:26:08 +0000 (15:26 +0000)]
Inline net_GetAddress

18 years ago * modules/codec/sdl_image.c: New decoder taking advantage of libSDL_image
Christophe Massiot [Fri, 29 Jul 2005 15:14:00 +0000 (15:14 +0000)]
 * modules/codec/sdl_image.c: New decoder taking advantage of libSDL_image
   to import various image formats.
 * src/misc/image.c: Fixed a segfault when loading an unknown image type.

18 years ago- Remove dead multicast code
Rémi Denis-Courmont [Thu, 28 Jul 2005 18:47:25 +0000 (18:47 +0000)]
- Remove dead multicast code
- Fix RTSP error codes

18 years agoFix RTSP error codes
Rémi Denis-Courmont [Thu, 28 Jul 2005 18:44:03 +0000 (18:44 +0000)]
Fix RTSP error codes

18 years agoReally listen to all IP addresses by default
Rémi Denis-Courmont [Thu, 28 Jul 2005 18:14:28 +0000 (18:14 +0000)]
Really listen to all IP addresses by default

18 years agoLink with libvlc.a last rather than first (closes #276)
Rémi Denis-Courmont [Thu, 28 Jul 2005 16:56:03 +0000 (16:56 +0000)]
Link with libvlc.a last rather than first (closes #276)

18 years agoFix typo
Rémi Denis-Courmont [Thu, 28 Jul 2005 16:00:27 +0000 (16:00 +0000)]
Fix typo

18 years agoFix compiler warning
Rémi Denis-Courmont [Thu, 28 Jul 2005 15:34:09 +0000 (15:34 +0000)]
Fix compiler warning

18 years agoinet_pton() replacement
Rémi Denis-Courmont [Thu, 28 Jul 2005 15:31:10 +0000 (15:31 +0000)]
inet_pton() replacement

18 years ago- replaced inet_pton() with WSAStringToAddress() for WIN32
Damien Fouilleul [Thu, 28 Jul 2005 13:21:46 +0000 (13:21 +0000)]
- replaced inet_pton() with WSAStringToAddress() for WIN32
  needs review, not tested but it compiles

18 years ago* forwardport [11883]
Derk-Jan Hartman [Thu, 28 Jul 2005 12:33:05 +0000 (12:33 +0000)]
* forwardport [11883]

18 years ago* forwardport [11880]
Derk-Jan Hartman [Wed, 27 Jul 2005 23:43:35 +0000 (23:43 +0000)]
* forwardport [11880]

18 years ago* forwardport [11877]
Derk-Jan Hartman [Wed, 27 Jul 2005 20:07:51 +0000 (20:07 +0000)]
* forwardport [11877]

18 years agoFix inet_pton check
Rémi Denis-Courmont [Wed, 27 Jul 2005 19:30:22 +0000 (19:30 +0000)]
Fix inet_pton check

18 years ago- Fix segfault when doing RTSP DESCRIBE (trunk-only bug from [11811])
Rémi Denis-Courmont [Wed, 27 Jul 2005 19:05:21 +0000 (19:05 +0000)]
- Fix segfault when doing RTSP DESCRIBE (trunk-only bug from [11811])
- cleanup net_AddressIsMulticast

18 years agoRemove FIXME that doesn't need to be fixed
Rémi Denis-Courmont [Wed, 27 Jul 2005 18:59:03 +0000 (18:59 +0000)]
Remove FIXME that doesn't need to be fixed

18 years ago- Include proper source IP address in SAP header (longstanding FIXME)
Rémi Denis-Courmont [Wed, 27 Jul 2005 18:05:22 +0000 (18:05 +0000)]
- Include proper source IP address in SAP header (longstanding FIXME)
  (btw, fixes SAP to link-local multicast IPv6)
- Fix scoped IPv6 address in SDP
- Cleanup multicast address determination and others

18 years agoFix for wxMSW
Christophe Mutricy [Wed, 27 Jul 2005 17:56:36 +0000 (17:56 +0000)]
Fix for wxMSW

18 years agoDefine HAVE_INET_PTON
Rémi Denis-Courmont [Wed, 27 Jul 2005 17:51:30 +0000 (17:51 +0000)]
Define HAVE_INET_PTON

18 years agoErr, IPv4 multicast starts at 224.0.0.0 not 225.0.0.0
Rémi Denis-Courmont [Wed, 27 Jul 2005 17:25:52 +0000 (17:25 +0000)]
Err, IPv4 multicast starts at 224.0.0.0 not 225.0.0.0

18 years ago- takes scope into account for NI_MAXNUMERICHOST
Rémi Denis-Courmont [Wed, 27 Jul 2005 17:22:28 +0000 (17:22 +0000)]
- takes scope into account for NI_MAXNUMERICHOST
- accept 224.0.0.0 as a multicast address

18 years agoHave readable debug message with IPv6 addresses
Rémi Denis-Courmont [Wed, 27 Jul 2005 16:56:58 +0000 (16:56 +0000)]
Have readable debug message with IPv6 addresses

18 years ago * modules/codec/ffmpeg: New --no-sout-ffmpeg-interlace-me option. Fixed
Christophe Massiot [Wed, 27 Jul 2005 16:55:17 +0000 (16:55 +0000)]
 * modules/codec/ffmpeg: New --no-sout-ffmpeg-interlace-me option. Fixed
   repeat_first_field handling.

18 years ago * modules/stream_out/transcode.c: Attempt at having --sout-transcode-fps
Christophe Massiot [Wed, 27 Jul 2005 16:53:25 +0000 (16:53 +0000)]
 * modules/stream_out/transcode.c: Attempt at having --sout-transcode-fps
   output correct timestamps.

18 years agoPut correct owner address in SAP-generated SDP
Rémi Denis-Courmont [Wed, 27 Jul 2005 16:30:19 +0000 (16:30 +0000)]
Put correct owner address in SAP-generated SDP

18 years agoAdd const where appropriate
Rémi Denis-Courmont [Wed, 27 Jul 2005 15:46:36 +0000 (15:46 +0000)]
Add const where appropriate

18 years ago * modules/access/dvb: Set the DVR device in non-blocking mode because it
Christophe Massiot [Wed, 27 Jul 2005 12:52:28 +0000 (12:52 +0000)]
 * modules/access/dvb: Set the DVR device in non-blocking mode because it
   sometimes blocks on read() after returning from select().

18 years agoAdd const
Rémi Denis-Courmont [Tue, 26 Jul 2005 18:05:55 +0000 (18:05 +0000)]
Add const

18 years agoFix FIXME
Rémi Denis-Courmont [Tue, 26 Jul 2005 17:14:53 +0000 (17:14 +0000)]
Fix FIXME