This fixes a case where our libmpeg2 module was not extracting
Closed Captions from the user_data, when this user_data was in the
GOP header, instead of in the picture header. This information is
retained until the next picture (date) is handled.
See sample "bob-dvd-closedcaptioning works in ffmpeg but not in libmpeg2.ts"
Tweack the rules in po/. Not perfect you can't run make update-po (and
so make dist) if your builddir isn't a subdir of srcdir. And of course
it still putting te .gmo in srcdir
macosx: paste the UDP/RTP MRL to the URL field once the sheet is dismissed so the user can see that the selection actually worked. No functional change.
win32: blind attempt at fixing RTSP connection (hopefully fixes #2560)
That being noted, I would advocate ditching all RTSP control connection
timeouts from our live555 plugins. Looking at strace, live555 waits
forever in the middle of receiving RTSP messages anyway.
Win32: canonicalize path separator, avoid isalpha(), remove dead code
In principle, isalpha() depends on the locale. As for directory
traversal, we should either add a boolean, or fix it manually in the
caller (on a case-by-case basis).
NSMenuItems still exist when libvlc_Quit is called, and thus some items are likely not autoreleased before vlc quits. Set all representedObjects for all menu's to null so that the menuitems no longer retain any of the vlc objects.
When building the menu's, autorelease the VLCAutoGeneratedMenu's instead of retaining. The NSMenuItem will do a retain/release for the live of the object in the NSMenuItem and thus once the menu's are done using the object, their retaincount will be 0 and they will be dealloc'ed at the end of the EventLoop. (An eventloop is One run of GUI updates you might say).
David Flynn [Wed, 1 Apr 2009 21:40:04 +0000 (21:40 +0000)]
win32: make vlc_vsnprintf more like c99 vsnprintf
Fixes following issues using MSVCRT _snprintf:
- Failure to null terminate all strings
- Failure to return number of characters that would've been
printed had the buffer been sufficiently large
- Failure to accept size = 0 (and str = NULL) to determine
final output length.
NB, the third issue above is fixed on *some* win32 implementations,
however it is not officially documented as being so.
Signed-off-by: David Flynn <davidf@rd.bbc.co.uk> Signed-off-by: Jean-Baptiste Kempf <jb@videolan.org>
David Flynn [Wed, 1 Apr 2009 21:40:03 +0000 (21:40 +0000)]
win32: vlc_fix_format_string - various fixes
- avoid mingw problems with %l*
- avoid using %I32 on Win32, since wince doesn't support it
- unify WIN64 and WIN32 cases.
- if malloc were to fail(!), don't allow unfiltered format string
to get passed to *printf.
(substitues an error message)
Signed-off-by: David Flynn <davidf@rd.bbc.co.uk> Signed-off-by: Jean-Baptiste Kempf <jb@videolan.org>
David Flynn [Wed, 1 Apr 2009 21:40:02 +0000 (21:40 +0000)]
win32: fix %zu fixups - dont use mingw's vsnprintf
Traditionally, MSVCRT has provided vsnprintf as _vsnprintf;
to 'aid' portability/standards compliance, mingw provide a
static version of [v]snprintf that is buggy.
The bug manifests as %lx is treated as a 64bit argument not
32bit, ie consumes two 32bit parameters. if a %s were to
follow a %lx, bad things can happen.
Solution: Be sure to use the MSVCRT version, at least it
behaves as expected
Additionally, make it a bit more obvious when vlc wrappers
are being called by other wrappers.
Signed-off-by: David Flynn <davidf@rd.bbc.co.uk> Signed-off-by: Jean-Baptiste Kempf <jb@videolan.org>
David Flynn [Fri, 27 Mar 2009 20:37:57 +0000 (20:37 +0000)]
codec/schroedinger: inform vlc of clean area
For SD, this should allow removal of black bars form the edge of frames.
i_aspect is set to the aspect ratio of the whole frame which may be
greater than that of the clean area. VLC should then calculate the SAR,
and eventually display a clean area sized picture that is of the correct
aspect ratio.
NB, we do actually know the SAR, but it isn't known if vlc cares at this
point.
Signed-off-by: David Flynn <davidf@rd.bbc.co.uk> Signed-off-by: Jean-Baptiste Kempf <jb@videolan.org>
David Flynn [Fri, 27 Mar 2009 20:37:54 +0000 (20:37 +0000)]
codec/schroedinger: Use new autoparse+tagging api
Schroedinger now has an api that allows passing in arbitarily aligned
data units (ie, whole encapsuation units), use this rather than attempt
to chunk up the bitstream ourselves.
This new api also enables buffer tagging, where buffers may be tagged
with arbitary data that gets associated with the next picture to
commence at or after the start of the buffer. This removes the need
for the TLBs and associated accounting.
Signed-off-by: David Flynn <davidf@rd.bbc.co.uk> Signed-off-by: Jean-Baptiste Kempf <jb@videolan.org>
projects / vlc / log