In OverlayEffectTest, handle that RGB on zero alpha is undefined.

[movit] / gamma_compression_effect.h

diff --git a/gamma_compression_effect.h b/gamma_compression_effect.h
index ec2a77a64ae1441f08ef6bb93207f27a904507fa..2744d2ddf65f809e96a301cdcb0e016e499c8f25 100644 (file)
--- a/gamma_compression_effect.h
+++ b/gamma_compression_effect.h
@@ -1,16 +1,36 @@
 #ifndef _GAMMA_COMPRESSION_EFFECT_H 
 #define _GAMMA_COMPRESSION_EFFECT_H 1
 
+// An effect to convert linear light to the given gamma curve,
+// typically inserted by the framework automatically at the end
+// of the processing chain.
+//
+// Currently supports sRGB and Rec. 601/709.
+
 #include "effect.h"
 #include "effect_chain.h"
 
+#define COMPRESSION_CURVE_SIZE 4096
+
 class GammaCompressionEffect : public Effect {
-public:
+private:
+       // Should not be instantiated by end users.
        GammaCompressionEffect();
-       std::string output_glsl();
+       friend class EffectChain;
+
+public:
+       virtual std::string effect_type_id() const { return "GammaCompressionEffect"; }
+       std::string output_fragment_shader();
+
+       virtual bool needs_srgb_primaries() const { return false; }
+
+       // Actually needs postmultiplied input as well as outputting it.
+       // EffectChain will take care of that.
+       virtual AlphaHandling alpha_handling() const { return OUTPUT_ALPHA_POSTMULTIPLIED; }
 
 private:
        GammaCurve destination_curve;
+       float compression_curve[COMPRESSION_CURVE_SIZE];
 };
 
 #endif // !defined(_GAMMA_COMPRESSION_EFFECT_H)