Fix another issue where an input was used twice. Add unit tests, again.

[movit] / gamma_expansion_effect.h

diff --git a/gamma_expansion_effect.h b/gamma_expansion_effect.h
index f079e7085f6e7ba6f6721f8aa3142e9ddb2f88e6..ce999902f7be24b4ddace89ea12384cb7dbf5def 100644 (file)
--- a/gamma_expansion_effect.h
+++ b/gamma_expansion_effect.h
@@ -1,6 +1,12 @@
 #ifndef _GAMMA_EXPANSION_EFFECT_H 
 #define _GAMMA_EXPANSION_EFFECT_H 1
 
+// An effect to convert the given gamma curve into linear light,
+// typically inserted by the framework automatically at the beginning
+// of the processing chain.
+//
+// Currently supports sRGB and Rec. 601/709.
+
 #include "effect.h"
 #include "effect_chain.h"
 
@@ -9,10 +15,15 @@
 class GammaExpansionEffect : public Effect {
 public:
        GammaExpansionEffect();
+       virtual std::string effect_type_id() const { return "GammaExpansionEffect"; }
        std::string output_fragment_shader();
 
-       virtual bool needs_linear_light() { return false; }
-       virtual bool needs_srgb_primaries() { return false; }
+       virtual bool needs_linear_light() const { return false; }
+       virtual bool needs_srgb_primaries() const { return false; }
+
+       // Actually processes its input in a nonlinear fashion,
+       // but does not touch alpha, and we are a special case anyway.
+       virtual AlphaHandling alpha_handling() const { return DONT_CARE_ALPHA_TYPE; }
 
 private:
        GammaCurve source_curve;