]> git.sesse.net Git - movit/blobdiff - ycbcr_input_test.cpp
Add support for 10- and 12-bit planar Y'CbCr inputs.
[movit] / ycbcr_input_test.cpp
index 109178f09e2fa8e20d805830285989437aefd7c6..1d1e23e47b2043f96e98b0c9bb214fe39f96c798 100644 (file)
@@ -1,8 +1,11 @@
-// Unit tests for YCbCrInput.
+// Unit tests for YCbCrInput. Also tests the matrix functions in ycbcr.cpp directly.
 
 #include <epoxy/gl.h>
 #include <stddef.h>
 
+#include <Eigen/Core>
+#include <Eigen/LU>
+
 #include "effect_chain.h"
 #include "gtest/gtest.h"
 #include "test_util.h"
@@ -66,6 +69,55 @@ TEST(YCbCrInputTest, Simple444) {
        expect_equal(expected_data, out_data, 4 * width, height, 0.025, 0.002);
 }
 
+TEST(YCbCrInputTest, Interleaved444) {
+       const int width = 1;
+       const int height = 5;
+
+       // Same data as Simple444, just rearranged.
+       unsigned char data[width * height * 3] = {
+                16, 128, 128,
+               235, 128, 128,
+                81,  90, 240,
+               145,  54,  34,
+                41, 240, 110,
+       };
+       float expected_data[4 * width * height] = {
+               0.0, 0.0, 0.0, 1.0,
+               1.0, 1.0, 1.0, 1.0,
+               1.0, 0.0, 0.0, 1.0,
+               0.0, 1.0, 0.0, 1.0,
+               0.0, 0.0, 1.0, 1.0,
+       };
+       float out_data[4 * width * height];
+
+       EffectChainTester tester(NULL, width, height);
+
+       ImageFormat format;
+       format.color_space = COLORSPACE_sRGB;
+       format.gamma_curve = GAMMA_sRGB;
+
+       YCbCrFormat ycbcr_format;
+       ycbcr_format.luma_coefficients = YCBCR_REC_601;
+       ycbcr_format.full_range = false;
+       ycbcr_format.num_levels = 256;
+       ycbcr_format.chroma_subsampling_x = 1;
+       ycbcr_format.chroma_subsampling_y = 1;
+       ycbcr_format.cb_x_position = 0.5f;
+       ycbcr_format.cb_y_position = 0.5f;
+       ycbcr_format.cr_x_position = 0.5f;
+       ycbcr_format.cr_y_position = 0.5f;
+
+       YCbCrInput *input = new YCbCrInput(format, ycbcr_format, width, height, YCBCR_INPUT_INTERLEAVED);
+       input->set_pixel_data(0, data);
+       tester.get_chain()->add_input(input);
+
+       tester.run(out_data, GL_RGBA, COLORSPACE_sRGB, GAMMA_sRGB);
+
+       // Y'CbCr isn't 100% accurate (the input values are rounded),
+       // so we need some leeway.
+       expect_equal(expected_data, out_data, 4 * width, height, 0.025, 0.002);
+}
+
 TEST(YCbCrInputTest, FullRangeRec601) {
        const int width = 1;
        const int height = 5;
@@ -352,7 +404,7 @@ TEST(YCbCrInputTest, Subsampling420WithNonCenteredSamples) {
 
        // Y'CbCr isn't 100% accurate (the input values are rounded),
        // so we need some leeway.
-       expect_equal(expected_data, out_data, width, height, 0.01, 0.001);
+       expect_equal(expected_data, out_data, width, height, 0.01, 0.0012);
 }
 
 // Yes, some 4:2:2 formats actually have this craziness.
@@ -612,4 +664,263 @@ TEST(YCbCrInputTest, ExternalTexture) {
        expect_equal(expected_data, out_data, 4 * width, height, 0.025, 0.002);
 }
 
+TEST(YCbCrTest, WikipediaRec601ForwardMatrix) {
+       YCbCrFormat ycbcr_format;
+       ycbcr_format.luma_coefficients = YCBCR_REC_601;
+       ycbcr_format.full_range = false;
+       ycbcr_format.num_levels = 256;
+
+       float offset[3];
+       Eigen::Matrix3d ycbcr_to_rgb;
+       compute_ycbcr_matrix(ycbcr_format, offset, &ycbcr_to_rgb);
+
+       Eigen::Matrix3d rgb_to_ycbcr = ycbcr_to_rgb.inverse() * 255.0;
+
+       // Values from https://en.wikipedia.org/wiki/YCbCr#ITU-R_BT.601_conversion.
+       EXPECT_NEAR(  65.481, rgb_to_ycbcr(0,0), 1e-3);
+       EXPECT_NEAR( 128.553, rgb_to_ycbcr(0,1), 1e-3);
+       EXPECT_NEAR(  24.966, rgb_to_ycbcr(0,2), 1e-3);
+
+       EXPECT_NEAR( -37.797, rgb_to_ycbcr(1,0), 1e-3);
+       EXPECT_NEAR( -74.203, rgb_to_ycbcr(1,1), 1e-3);
+       EXPECT_NEAR( 112.000, rgb_to_ycbcr(1,2), 1e-3);
+
+       EXPECT_NEAR( 112.000, rgb_to_ycbcr(2,0), 1e-3);
+       EXPECT_NEAR( -93.786, rgb_to_ycbcr(2,1), 1e-3);
+       EXPECT_NEAR( -18.214, rgb_to_ycbcr(2,2), 1e-3);
+
+       EXPECT_NEAR( 16.0, offset[0] * 255.0, 1e-3);
+       EXPECT_NEAR(128.0, offset[1] * 255.0, 1e-3);
+       EXPECT_NEAR(128.0, offset[2] * 255.0, 1e-3);
+}
+
+TEST(YCbCrTest, WikipediaJPEGMatrices) {
+       YCbCrFormat ycbcr_format;
+       ycbcr_format.luma_coefficients = YCBCR_REC_601;
+       ycbcr_format.full_range = true;
+       ycbcr_format.num_levels = 256;
+
+       float offset[3];
+       Eigen::Matrix3d ycbcr_to_rgb;
+       compute_ycbcr_matrix(ycbcr_format, offset, &ycbcr_to_rgb);
+
+       // Values from https://en.wikipedia.org/wiki/YCbCr#JPEG_conversion.
+       EXPECT_NEAR( 1.00000, ycbcr_to_rgb(0,0), 1e-5);
+       EXPECT_NEAR( 0.00000, ycbcr_to_rgb(0,1), 1e-5);
+       EXPECT_NEAR( 1.40200, ycbcr_to_rgb(0,2), 1e-5);
+
+       EXPECT_NEAR( 1.00000, ycbcr_to_rgb(1,0), 1e-5);
+       EXPECT_NEAR(-0.34414, ycbcr_to_rgb(1,1), 1e-5);
+       EXPECT_NEAR(-0.71414, ycbcr_to_rgb(1,2), 1e-5);
+
+       EXPECT_NEAR( 1.00000, ycbcr_to_rgb(2,0), 1e-5);
+       EXPECT_NEAR( 1.77200, ycbcr_to_rgb(2,1), 1e-5);
+       EXPECT_NEAR( 0.00000, ycbcr_to_rgb(2,2), 1e-5);
+
+       Eigen::Matrix3d rgb_to_ycbcr = ycbcr_to_rgb.inverse();
+
+       // Same.
+       EXPECT_NEAR( 0.299000, rgb_to_ycbcr(0,0), 1e-6);
+       EXPECT_NEAR( 0.587000, rgb_to_ycbcr(0,1), 1e-6);
+       EXPECT_NEAR( 0.114000, rgb_to_ycbcr(0,2), 1e-6);
+
+       EXPECT_NEAR(-0.168736, rgb_to_ycbcr(1,0), 1e-6);
+       EXPECT_NEAR(-0.331264, rgb_to_ycbcr(1,1), 1e-6);
+       EXPECT_NEAR( 0.500000, rgb_to_ycbcr(1,2), 1e-6);
+
+       EXPECT_NEAR( 0.500000, rgb_to_ycbcr(2,0), 1e-6);
+       EXPECT_NEAR(-0.418688, rgb_to_ycbcr(2,1), 1e-6);
+       EXPECT_NEAR(-0.081312, rgb_to_ycbcr(2,2), 1e-6);
+
+       EXPECT_NEAR(  0.0, offset[0] * 255.0, 1e-3);
+       EXPECT_NEAR(128.0, offset[1] * 255.0, 1e-3);
+       EXPECT_NEAR(128.0, offset[2] * 255.0, 1e-3);
+}
+
+TEST(YCbCrTest, BlackmagicForwardMatrix) {
+       YCbCrFormat ycbcr_format;
+       ycbcr_format.luma_coefficients = YCBCR_REC_709;
+       ycbcr_format.full_range = false;
+       ycbcr_format.num_levels = 256;
+
+       float offset[3];
+       Eigen::Matrix3d ycbcr_to_rgb;
+       compute_ycbcr_matrix(ycbcr_format, offset, &ycbcr_to_rgb);
+
+       Eigen::Matrix3d rgb_to_ycbcr = ycbcr_to_rgb.inverse();
+
+       // Values from DeckLink SDK documentation.
+       EXPECT_NEAR( 0.183, rgb_to_ycbcr(0,0), 1e-3);
+       EXPECT_NEAR( 0.614, rgb_to_ycbcr(0,1), 1e-3);
+       EXPECT_NEAR( 0.062, rgb_to_ycbcr(0,2), 1e-3);
+
+       EXPECT_NEAR(-0.101, rgb_to_ycbcr(1,0), 1e-3);
+       EXPECT_NEAR(-0.338, rgb_to_ycbcr(1,1), 1e-3);
+       EXPECT_NEAR( 0.439, rgb_to_ycbcr(1,2), 1e-3);
+
+       EXPECT_NEAR( 0.439, rgb_to_ycbcr(2,0), 1e-3);
+       EXPECT_NEAR(-0.399, rgb_to_ycbcr(2,1), 1e-3);
+       EXPECT_NEAR(-0.040, rgb_to_ycbcr(2,2), 1e-3);
+
+       EXPECT_NEAR( 16.0, offset[0] * 255.0, 1e-3);
+       EXPECT_NEAR(128.0, offset[1] * 255.0, 1e-3);
+       EXPECT_NEAR(128.0, offset[2] * 255.0, 1e-3);
+}
+
+TEST(YCbCrInputTest, NoData) {
+       const int width = 1;
+       const int height = 5;
+
+       float out_data[4 * width * height];
+
+       EffectChainTester tester(NULL, width, height);
+
+       ImageFormat format;
+       format.color_space = COLORSPACE_sRGB;
+       format.gamma_curve = GAMMA_sRGB;
+
+       YCbCrFormat ycbcr_format;
+       ycbcr_format.luma_coefficients = YCBCR_REC_601;
+       ycbcr_format.full_range = false;
+       ycbcr_format.num_levels = 256;
+       ycbcr_format.chroma_subsampling_x = 1;
+       ycbcr_format.chroma_subsampling_y = 1;
+       ycbcr_format.cb_x_position = 0.5f;
+       ycbcr_format.cb_y_position = 0.5f;
+       ycbcr_format.cr_x_position = 0.5f;
+       ycbcr_format.cr_y_position = 0.5f;
+
+       YCbCrInput *input = new YCbCrInput(format, ycbcr_format, width, height);
+       tester.get_chain()->add_input(input);
+
+       tester.run(out_data, GL_RGBA, COLORSPACE_sRGB, GAMMA_sRGB);
+
+       // Don't care what the output was, just that it does not crash.
+}
+
+TEST(YCbCrInputTest, TenBitInterleaved) {
+       const int width = 1;
+       const int height = 5;
+
+       // Pure-color inputs, calculated using formulas 3.2, 3.3 and 3.4 from
+       // Rec. 709. (Except the first two, which are obvious given the 64–940
+       // range of luminance.)
+       unsigned expanded_data[width * height * 3] = {
+                 64, 512, 512,
+                940, 512, 512,
+                250, 409, 960,
+                691, 167, 105,
+                127, 960, 471,
+       };
+       float expected_data[4 * width * height] = {
+               0.0, 0.0, 0.0, 1.0,
+               1.0, 1.0, 1.0, 1.0,
+               1.0, 0.0, 0.0, 1.0,
+               0.0, 1.0, 0.0, 1.0,
+               0.0, 0.0, 1.0, 1.0,
+       };
+       float out_data[4 * width * height];
+
+       // Pack 32:32:32 to 10:10:10:2.
+       uint32_t data[width * height];
+       for (unsigned i = 0; i < width * height; ++i) {
+               data[i] =
+                        expanded_data[i * 3 + 0]        |
+                       (expanded_data[i * 3 + 1] << 10) |
+                       (expanded_data[i * 3 + 2] << 20);
+       }
+
+       EffectChainTester tester(NULL, width, height);
+
+       ImageFormat format;
+       format.color_space = COLORSPACE_sRGB;
+       format.gamma_curve = GAMMA_sRGB;
+
+       YCbCrFormat ycbcr_format;
+       ycbcr_format.luma_coefficients = YCBCR_REC_709;
+       ycbcr_format.full_range = false;
+       ycbcr_format.num_levels = 1024;  // 10-bit.
+       ycbcr_format.chroma_subsampling_x = 1;
+       ycbcr_format.chroma_subsampling_y = 1;
+       ycbcr_format.cb_x_position = 0.5f;
+       ycbcr_format.cb_y_position = 0.5f;
+       ycbcr_format.cr_x_position = 0.5f;
+       ycbcr_format.cr_y_position = 0.5f;
+
+       YCbCrInput *input = new YCbCrInput(format, ycbcr_format, width, height, YCBCR_INPUT_INTERLEAVED, GL_UNSIGNED_INT_2_10_10_10_REV);
+       input->set_pixel_data(0, data);
+       tester.get_chain()->add_input(input);
+
+       tester.run(out_data, GL_RGBA, COLORSPACE_sRGB, GAMMA_sRGB);
+
+       // We can set much tighter limits on this than 8-bit Y'CbCr;
+       // even tighter than the default limits.
+       expect_equal(expected_data, out_data, 4 * width, height, 0.002, 0.0003);
+}
+
+TEST(YCbCrInputTest, TenBitPlanar) {
+       const int width = 1;
+       const int height = 5;
+
+       // The same data as TenBitInterleaved, but split.
+       uint16_t y[width * height] = {
+                 64,
+                940,
+                250,
+                691,
+                127,
+       };
+       uint16_t cb[width * height] = {
+                512,
+                512,
+                409,
+                167,
+                960,
+       };
+       uint16_t cr[width * height] = {
+                512,
+                512,
+                960,
+                105,
+                471,
+       };
+       float expected_data[4 * width * height] = {
+               0.0, 0.0, 0.0, 1.0,
+               1.0, 1.0, 1.0, 1.0,
+               1.0, 0.0, 0.0, 1.0,
+               0.0, 1.0, 0.0, 1.0,
+               0.0, 0.0, 1.0, 1.0,
+       };
+       float out_data[4 * width * height];
+
+       EffectChainTester tester(NULL, width, height);
+
+       ImageFormat format;
+       format.color_space = COLORSPACE_sRGB;
+       format.gamma_curve = GAMMA_sRGB;
+
+       YCbCrFormat ycbcr_format;
+       ycbcr_format.luma_coefficients = YCBCR_REC_709;
+       ycbcr_format.full_range = false;
+       ycbcr_format.num_levels = 1024;  // 10-bit.
+       ycbcr_format.chroma_subsampling_x = 1;
+       ycbcr_format.chroma_subsampling_y = 1;
+       ycbcr_format.cb_x_position = 0.5f;
+       ycbcr_format.cb_y_position = 0.5f;
+       ycbcr_format.cr_x_position = 0.5f;
+       ycbcr_format.cr_y_position = 0.5f;
+
+       YCbCrInput *input = new YCbCrInput(format, ycbcr_format, width, height, YCBCR_INPUT_PLANAR, GL_UNSIGNED_SHORT);
+       input->set_pixel_data(0, y);
+       input->set_pixel_data(1, cb);
+       input->set_pixel_data(2, cr);
+       tester.get_chain()->add_input(input);
+
+       tester.run(out_data, GL_RGBA, COLORSPACE_sRGB, GAMMA_sRGB);
+
+       // We can set much tighter limits on this than 8-bit Y'CbCr;
+       // even tighter than the default limits.
+       expect_equal(expected_data, out_data, 4 * width, height, 0.002, 0.0003);
+}
+
 }  // namespace movit