Revert "Reuse the VAO across all phases."
authorSteinar H. Gunderson <sgunderson@bigfoot.com>
Sat, 6 Feb 2016 23:11:51 +0000 (00:11 +0100)
committerSteinar H. Gunderson <sgunderson@bigfoot.com>
Sat, 6 Feb 2016 23:11:51 +0000 (00:11 +0100)
commit54d47f65e9abac77229636fbaaefea8caf34a4d4
treed0f7bb5594b9f2e1ee39aee665a90bf531655e78
parent7d4b25da4c2f125b9357c6f1846a1e94ab60f5dc
Revert "Reuse the VAO across all phases."

The patch trickles a bug where, if the first phase doesn't need texture
coordinates, the rest of the phases don't get it either. (Or more generally,
if the vertex shader varying indices are not predictable, the patch does
the wrong thing.) Add a unit test and revert it for now; in time, we'll find a
way that's both low-overhead (the patch fixes a real problem) _and_ correct in
these cases.

This reverts patch 5e34f7a8969f4afc169f034d34fb908019b3a389.

Reported by Christophe Thommeret.
effect_chain.cpp
effect_chain_test.cpp