]> git.sesse.net Git - nageru/blobdiff - nageru/ffmpeg_capture.cpp
Fix FFmpeg frame rate calculation with VA-API acceleration.
[nageru] / nageru / ffmpeg_capture.cpp
index cda801a240d7e81147465fe37050d8ea50c31e7f..8f174ad018f7e236c896b7458af7e3248101a62f 100644 (file)
@@ -143,7 +143,7 @@ AVPixelFormat decide_dst_format(AVPixelFormat src_format, bmusb::PixelFormat dst
        return av_get_pix_fmt(best_format);
 }
 
-YCbCrFormat decode_ycbcr_format(const AVPixFmtDescriptor *desc, const AVFrame *frame, bool is_mjpeg)
+YCbCrFormat decode_ycbcr_format(const AVPixFmtDescriptor *desc, const AVFrame *frame, bool is_mjpeg, AVColorSpace *last_colorspace, AVChromaLocation *last_chroma_location)
 {
        YCbCrFormat format;
        AVColorSpace colorspace = frame->colorspace;
@@ -163,11 +163,14 @@ YCbCrFormat decode_ycbcr_format(const AVPixFmtDescriptor *desc, const AVFrame *f
                format.luma_coefficients = (frame->height >= 720 ? YCBCR_REC_709 : YCBCR_REC_601);
                break;
        default:
-               fprintf(stderr, "Unknown Y'CbCr coefficient enum %d from FFmpeg; choosing Rec. 709.\n",
-                       colorspace);
+               if (colorspace != *last_colorspace) {
+                       fprintf(stderr, "Unknown Y'CbCr coefficient enum %d from FFmpeg; choosing Rec. 709.\n",
+                               colorspace);
+               }
                format.luma_coefficients = YCBCR_REC_709;
                break;
        }
+       *last_colorspace = colorspace;
 
        format.full_range = is_full_range(desc);
        format.num_levels = 1 << desc->comp[0].depth;
@@ -200,12 +203,15 @@ YCbCrFormat decode_ycbcr_format(const AVPixFmtDescriptor *desc, const AVFrame *f
                format.cb_y_position = 1.0;
                break;
        default:
-               fprintf(stderr, "Unknown chroma location coefficient enum %d from FFmpeg; choosing center.\n",
-                       frame->chroma_location);
+               if (frame->chroma_location != *last_chroma_location) {
+                       fprintf(stderr, "Unknown chroma location coefficient enum %d from FFmpeg; choosing center.\n",
+                               frame->chroma_location);
+               }
                format.cb_x_position = 0.5;
                format.cb_y_position = 0.5;
                break;
        }
+       *last_chroma_location = frame->chroma_location;
 
        if (is_mjpeg && !format.full_range) {
                // Limited-range MJPEG is only detected by FFmpeg whenever a special
@@ -286,6 +292,11 @@ FFmpegCapture::~FFmpegCapture()
                dequeue_cleanup_callback();
        }
        swr_free(&resampler);
+#ifdef HAVE_SRT
+       if (srt_sock != -1) {
+               srt_close(srt_sock);
+       }
+#endif
 }
 
 void FFmpegCapture::configure_card()
@@ -441,6 +452,27 @@ void FFmpegCapture::send_disconnected_frame()
        }
 }
 
+AVPixelFormat get_vaapi_hw_format(AVCodecContext *ctx, const AVPixelFormat *fmt)
+{
+       for (const AVPixelFormat *fmt_ptr = fmt; *fmt_ptr != -1; ++fmt_ptr) {
+               for (int i = 0;; ++i) {  // Termination condition inside loop.
+                       const AVCodecHWConfig *config = avcodec_get_hw_config(ctx->codec, i);
+                       if (config == nullptr) {  // End of list.
+                               fprintf(stderr, "Decoder %s does not support device.\n", ctx->codec->name);
+                               break;
+                       }
+                       if (config->methods & AV_CODEC_HW_CONFIG_METHOD_HW_DEVICE_CTX &&
+                           config->device_type == AV_HWDEVICE_TYPE_VAAPI &&
+                           config->pix_fmt == *fmt_ptr) {
+                               return config->pix_fmt;
+                       }
+               }
+       }
+
+       // We found no VA-API formats, so take the best software format.
+       return fmt[0];
+}
+
 bool FFmpegCapture::play_video(const string &pathname)
 {
        // Note: Call before open, not after; otherwise, there's a race.
@@ -454,6 +486,8 @@ bool FFmpegCapture::play_video(const string &pathname)
        } else {
                last_modified = buf.st_mtim;
        }
+       last_colorspace = static_cast<AVColorSpace>(-1);
+       last_chroma_location = static_cast<AVChromaLocation>(-1);
 
        AVFormatContextWithCloser format_ctx;
        if (srt_sock == -1) {
@@ -495,6 +529,7 @@ bool FFmpegCapture::play_video(const string &pathname)
        // Open video decoder.
        const AVCodecParameters *video_codecpar = format_ctx->streams[video_stream_index]->codecpar;
        AVCodec *video_codec = avcodec_find_decoder(video_codecpar->codec_id);
+
        video_timebase = format_ctx->streams[video_stream_index]->time_base;
        AVCodecContextWithDeleter video_codec_ctx = avcodec_alloc_context3_unique(nullptr);
        if (avcodec_parameters_to_context(video_codec_ctx.get(), video_codecpar) < 0) {
@@ -505,6 +540,18 @@ bool FFmpegCapture::play_video(const string &pathname)
                fprintf(stderr, "%s: Cannot find video decoder\n", pathname.c_str());
                return false;
        }
+
+       // Seemingly, it's not too easy to make something that just initializes
+       // “whatever goes”, so we don't get VDPAU or CUDA here without enumerating
+       // through several different types. VA-API will do for now.
+       AVBufferRef *hw_device_ctx = nullptr;
+       if (av_hwdevice_ctx_create(&hw_device_ctx, AV_HWDEVICE_TYPE_VAAPI, nullptr, nullptr, 0) < 0) {
+               fprintf(stderr, "Failed to initialize VA-API for FFmpeg acceleration. Decoding video in software.\n");
+       } else {
+               video_codec_ctx->hw_device_ctx = av_buffer_ref(hw_device_ctx);
+               video_codec_ctx->get_format = get_vaapi_hw_format;
+       }
+
        if (avcodec_open2(video_codec_ctx.get(), video_codec, nullptr) < 0) {
                fprintf(stderr, "%s: Cannot open video decoder\n", pathname.c_str());
                return false;
@@ -837,6 +884,21 @@ AVFrameWithDeleter FFmpegCapture::decode_frame(AVFormatContext *format_ctx, AVCo
                // Decode video, if we have a frame.
                int err = avcodec_receive_frame(video_codec_ctx, video_avframe.get());
                if (err == 0) {
+                       if (video_avframe->format == AV_PIX_FMT_VAAPI) {
+                               // Get the frame down to the CPU. (TODO: See if we can keep it
+                               // on the GPU all the way, since it will be going up again later.
+                               // However, this only works if the OpenGL GPU is the same one.)
+                               AVFrameWithDeleter sw_frame = av_frame_alloc_unique();
+                               int err = av_hwframe_transfer_data(sw_frame.get(), video_avframe.get(), 0);
+                               if (err != 0) {
+                                       fprintf(stderr, "%s: Cannot transfer hardware video frame to software.\n", pathname.c_str());
+                                       *error = true;
+                                       return AVFrameWithDeleter(nullptr);
+                               }
+                               sw_frame->pts = video_avframe->pts;
+                               sw_frame->pkt_duration = video_avframe->pkt_duration;
+                               video_avframe = move(sw_frame);
+                       }
                        frame_finished = true;
                        break;
                } else if (err != AVERROR(EAGAIN)) {
@@ -997,7 +1059,7 @@ UniqueFrame FFmpegCapture::make_video_frame(const AVFrame *frame, const string &
                video_frame->len = (frame_width(frame) * 2) * frame_height(frame);
 
                const AVPixFmtDescriptor *desc = av_pix_fmt_desc_get(sws_dst_format);
-               current_frame_ycbcr_format = decode_ycbcr_format(desc, frame, is_mjpeg);
+               current_frame_ycbcr_format = decode_ycbcr_format(desc, frame, is_mjpeg, &last_colorspace, &last_chroma_location);
        } else {
                assert(pixel_format == bmusb::PixelFormat_8BitYCbCrPlanar);
                const AVPixFmtDescriptor *desc = av_pix_fmt_desc_get(sws_dst_format);
@@ -1016,7 +1078,7 @@ UniqueFrame FFmpegCapture::make_video_frame(const AVFrame *frame, const string &
 
                video_frame->len = frame_width(frame) * frame_height(frame) + 2 * chroma_width * chroma_height;
 
-               current_frame_ycbcr_format = decode_ycbcr_format(desc, frame, is_mjpeg);
+               current_frame_ycbcr_format = decode_ycbcr_format(desc, frame, is_mjpeg, &last_colorspace, &last_chroma_location);
        }
        sws_scale(sws_ctx.get(), frame->data, frame->linesize, 0, frame->height, pic_data, linesizes);