udp: fix locking (fixes #14234) and cancellation

[vlc] / modules / access / udp.c

diff --git a/modules/access/udp.c b/modules/access/udp.c
index 0a233173d4599c09b806221d32a4635f9398b86c..c61bf8a8906b63a96418cf5b2c65c6d39d89c901 100644 (file)
--- a/modules/access/udp.c
+++ b/modules/access/udp.c
@@ -258,9 +258,6 @@ static void* ThreadRead( void *data )
     access_t *access = data;
     access_sys_t *sys = access->p_sys;
 
-    vlc_fifo_Lock(sys->fifo);
-    vlc_fifo_CleanupPush(sys->fifo);
-
     for(;;)
     {
         block_t *pkt = block_Alloc(MTU);
@@ -283,16 +280,22 @@ static void* ThreadRead( void *data )
 
         pkt->i_buffer = len;
 
+        vlc_fifo_Lock(sys->fifo);
         /* Discard old buffers on overflow */
         while (vlc_fifo_GetBytes(sys->fifo) + len > sys->fifo_size)
+        {
+            int canc = vlc_savecancel();
             block_Release(vlc_fifo_DequeueUnlocked(sys->fifo));
+            vlc_restorecancel(canc);
+        }
 
         vlc_fifo_QueueUnlocked(sys->fifo, pkt);
+        vlc_fifo_Unlock(sys->fifo);
     }
 
+    vlc_fifo_Lock(sys->fifo);
     sys->running = false;
     vlc_fifo_Signal(sys->fifo);
-    vlc_cleanup_run();
-
+    vlc_fifo_Unlock(sys->fifo);
     return NULL;
 }