Potential memleak.

[vlc] / modules / control / lirc.c

diff --git a/modules/control/lirc.c b/modules/control/lirc.c
index 48c18d6f59567490bb94e96bb4d24602b66268c0..0ae6fbb1faf8351274d0a73a39aa11e37fac18ed 100644 (file)
--- a/modules/control/lirc.c
+++ b/modules/control/lirc.c
@@ -27,7 +27,12 @@
 
 #include <fcntl.h>
 
-#include <vlc/vlc.h>
+#ifdef HAVE_CONFIG_H
+# include "config.h"
+#endif
+
+#include <vlc_common.h>
+#include <vlc_plugin.h>
 #include <vlc_interface.h>
 #include <vlc_osd.h>
 
@@ -58,15 +63,15 @@ static void Run     ( intf_thread_t * );
  * Module descriptor
  *****************************************************************************/
 vlc_module_begin();
-    set_shortname( _("Infrared") );
+    set_shortname( N_("Infrared") );
     set_category( CAT_INTERFACE );
     set_subcategory( SUBCAT_INTERFACE_CONTROL );
-    set_description( _("Infrared remote control interface") );
+    set_description( N_("Infrared remote control interface") );
     set_capability( "interface", 0 );
     set_callbacks( Open, Close );
 
     add_string( "lirc-file", NULL, NULL,
-                LIRC_TEXT, LIRC_LONGTEXT, VLC_TRUE );
+                LIRC_TEXT, LIRC_LONGTEXT, true );
 vlc_module_end();
 
 /*****************************************************************************
@@ -93,6 +98,7 @@ static int Open( vlc_object_t *p_this )
     if( i_fd == -1 )
     {
         msg_Err( p_intf, "lirc initialisation failed" );
+        free( p_intf->p_sys->psz_file );
         free( p_intf->p_sys );
         return 1;
     }
@@ -104,6 +110,7 @@ static int Open( vlc_object_t *p_this )
     {
         msg_Err( p_intf, "failure while reading lirc config" );
         lirc_deinit();
+        free( p_intf->p_sys->psz_file );
         free( p_intf->p_sys );
         return 1;
     }
@@ -119,8 +126,7 @@ static void Close( vlc_object_t *p_this )
     intf_thread_t *p_intf = (intf_thread_t *)p_this;
 
     /* Destroy structure */
-    if( p_intf->p_sys->psz_file )
-        free( p_intf->p_sys->psz_file );
+    free( p_intf->p_sys->psz_file );
     lirc_freeconfig( p_intf->p_sys->config );
     lirc_deinit();
     free( p_intf->p_sys );