]> git.sesse.net Git - vlc/commit
projects / vlc / commit
? search:
summary | shortlog | log | commit | commitdiff | tree
(parent: 7b91295) | patch
decoder: remove invalid call, fix races
authorRémi Denis-Courmont <remi@remlab.net>
Tue, 17 Mar 2015 20:41:46 +0000 (22:41 +0200)
committerRémi Denis-Courmont <remi@remlab.net>
Thu, 19 Mar 2015 17:56:09 +0000 (19:56 +0200)
commit16e3039284c90fae4a46c44f64422371039fa553
tree3702c0946141e1708477670b1bc4c2b50ea64e65tree | snapshot
parent7b91295fcdd16b327e7998bfaea7fb8d1cb43c5bcommit | diff
decoder: remove invalid call, fix races

Calling input_DecoderStopWait() from the decoder thread makes no sense
as it signals a condition variable that only the decoder thread itself
would ever wait on.

More importantly, the call breaks assumptions made by the input thread.
For instance, input_DecoderDecode() assumes p_owner->b_waiting is only
changed by the decoder owner (i.e. input) thread.
src/input/decoder.c diff | blob | history
Unnamed repository; edit this file 'description' to name the repository.