]> git.sesse.net Git - vlc/log
vlc
13 years agoaa: fix compilation (collision with Xlib symbols).
Rémi Duraffort [Thu, 15 Jul 2010 16:55:36 +0000 (18:55 +0200)]
aa: fix compilation (collision with Xlib symbols).

13 years agoASCII Art: initialize Xlib
Rémi Denis-Courmont [Thu, 15 Jul 2010 16:26:43 +0000 (19:26 +0300)]
ASCII Art: initialize Xlib

Don't ask me why, but libaa depends on Xlib.

13 years agosome platforms can have int64_t typedefed to long long ..This patch prevents illegal...
pk@pk-desktop.(none) [Thu, 15 Jul 2010 18:50:40 +0000 (00:20 +0530)]
some platforms can have int64_t typedefed to long long ..This patch prevents illegal implicit conversion from long long * to int *

Signed-off-by: Ilkka Ollakka <ileoo@videolan.org>
13 years agoCorrect example RTP location (fixes #3901)
Rémi Denis-Courmont [Wed, 14 Jul 2010 20:14:34 +0000 (23:14 +0300)]
Correct example RTP location (fixes #3901)

13 years agoscene: Windows cannot replace files atomically (fixes #3521)
Rémi Denis-Courmont [Wed, 14 Jul 2010 20:11:28 +0000 (23:11 +0300)]
scene: Windows cannot replace files atomically (fixes #3521)

13 years agoDoc typo
Rémi Denis-Courmont [Wed, 14 Jul 2010 19:49:07 +0000 (22:49 +0300)]
Doc typo

13 years agoTypo, fix libvlc_video_set_format() pitch
Rémi Denis-Courmont [Wed, 14 Jul 2010 19:39:18 +0000 (22:39 +0300)]
Typo, fix libvlc_video_set_format() pitch

13 years agostatistics to 64bit
Ilkka Ollakka [Wed, 14 Jul 2010 16:07:36 +0000 (19:07 +0300)]
statistics to 64bit

Didn't touch the os x interface code. I don't think I missed any core-code that relates.
Fixe #3411

13 years agoQt4: change messages-dialog to use msg_SubscriptionSetVerbosity
Ilkka Ollakka [Tue, 13 Jul 2010 16:57:16 +0000 (19:57 +0300)]
Qt4: change messages-dialog to use msg_SubscriptionSetVerbosity

13 years agoadd msg_SubscriptionSetVerbosity call, so core filter message-level for subscribers
Ilkka Ollakka [Tue, 13 Jul 2010 13:22:48 +0000 (16:22 +0300)]
add msg_SubscriptionSetVerbosity call, so core filter message-level for subscribers

13 years agoAdded an assert in mkv.
Laurent Aimar [Wed, 14 Jul 2010 18:27:18 +0000 (20:27 +0200)]
Added an assert in mkv.

13 years agoModified aout_ChangeFilterString to handle audio filter order.
Laurent Aimar [Wed, 14 Jul 2010 18:11:06 +0000 (20:11 +0200)]
Modified aout_ChangeFilterString to handle audio filter order.

For the moment, no order is imposed.

13 years agoFixed a (probable) typo in aout_ChangeFilterString().
Laurent Aimar [Wed, 14 Jul 2010 17:16:31 +0000 (19:16 +0200)]
Fixed a (probable) typo in aout_ChangeFilterString().

13 years agoMoved AoutChangeFilterString out of aout_internal.h.
Laurent Aimar [Wed, 14 Jul 2010 17:14:11 +0000 (19:14 +0200)]
Moved AoutChangeFilterString out of aout_internal.h.

No functionnal changes.

13 years agouse VA_INVALID_ID wherever appropriate (vaapi).
gbeauchesne@splitted-desktop.com [Sun, 11 Jul 2010 21:33:13 +0000 (23:33 +0200)]
use VA_INVALID_ID wherever appropriate (vaapi).

Signed-off-by: Laurent Aimar <fenrir@videolan.org>
13 years agoMKV : Add MJPEG codec ID.
Jai Menon [Tue, 13 Jul 2010 08:00:35 +0000 (13:30 +0530)]
MKV : Add MJPEG codec ID.

Signed-off-by: Rémi Duraffort <ivoire@videolan.org>
13 years agoMKV : Fix some memory leaks in the EBML parser.
Jai Menon [Wed, 14 Jul 2010 17:30:34 +0000 (23:00 +0530)]
MKV : Fix some memory leaks in the EBML parser.

Signed-off-by: Rémi Duraffort <ivoire@videolan.org>
13 years agoMKV : Add support for parsing Matroska Tag elements and exporting them as metadata...
Jai Menon [Tue, 13 Jul 2010 08:00:34 +0000 (13:30 +0530)]
MKV : Add support for parsing Matroska Tag elements and exporting them as metadata entries.

Signed-off-by: Rémi Duraffort <ivoire@videolan.org>
13 years agomodules: remove an unused define and assert if we try to add too many shortcuts.
Rémi Duraffort [Wed, 14 Jul 2010 17:02:17 +0000 (19:02 +0200)]
modules: remove an unused define and assert if we try to add too many shortcuts.

In fact the cache loader does only load less than MODULE_SHORTCUT_MAX shortcuts.

13 years agoSDL vout: fix crash due to (not calling) XInitThreads
Rémi Denis-Courmont [Mon, 12 Jul 2010 17:53:56 +0000 (20:53 +0300)]
SDL vout: fix crash due to (not calling) XInitThreads

13 years agodbus: monitor input state change through "intf-event"
Rafaël Carré [Mon, 12 Jul 2010 15:32:41 +0000 (17:32 +0200)]
dbus: monitor input state change through "intf-event"

End of playlist is still not notified

13 years agompris.glade: silence a gtk warning
Rafaël Carré [Mon, 12 Jul 2010 13:39:10 +0000 (15:39 +0200)]
mpris.glade: silence a gtk warning

13 years agoMPRIS metadata required field is "location", not "URI"
Rafaël Carré [Mon, 12 Jul 2010 13:32:48 +0000 (15:32 +0200)]
MPRIS metadata required field is "location", not "URI"

13 years agoFix make dist after moving dbus files
Rafaël Carré [Mon, 12 Jul 2010 12:35:09 +0000 (14:35 +0200)]
Fix make dist after moving dbus files

13 years agoRemove file forgotten in [79a45df736]
Rafaël Carré [Mon, 12 Jul 2010 12:33:45 +0000 (14:33 +0200)]
Remove file forgotten in [79a45df736]

13 years agofixes dailymotion parser
Rafaël Carré [Sun, 11 Jul 2010 22:26:00 +0000 (00:26 +0200)]
fixes dailymotion parser

get the SD video (in flv), the HD and HQ videos (in mp4) causes seeking
back and forth and the video is unplayable

13 years agotranscode: use var_Get(Int|Bool|String)
Ilkka Ollakka [Sun, 11 Jul 2010 17:59:08 +0000 (20:59 +0300)]
transcode: use var_Get(Int|Bool|String)

13 years agoEnabled back yadif deinterlacer mode in the vout.
Laurent Aimar [Sun, 11 Jul 2010 17:05:50 +0000 (19:05 +0200)]
Enabled back yadif deinterlacer mode in the vout.

13 years agoAdded support for video filter that introduce latency (vout).
Laurent Aimar [Sun, 11 Jul 2010 17:04:35 +0000 (19:04 +0200)]
Added support for video filter that introduce latency (vout).

It is not yet perfect as the input is not warned of the latency of the vout.

13 years agoFixed deinterlacer mode configuration (vout).
Laurent Aimar [Sun, 11 Jul 2010 17:02:37 +0000 (19:02 +0200)]
Fixed deinterlacer mode configuration (vout).

13 years agoCosmetics.
Laurent Aimar [Sun, 11 Jul 2010 17:01:51 +0000 (19:01 +0200)]
Cosmetics.

13 years agoEnabled back yadif mode in the deinterlace video filter module.
Laurent Aimar [Sun, 11 Jul 2010 16:59:11 +0000 (18:59 +0200)]
Enabled back yadif mode in the deinterlace video filter module.

Becareful that it adds a delay of one frame, so it needs to be
flushed on discontinuity and it will return NULL one time.

13 years agoAdded a way to flush video filters and video filter chains.
Laurent Aimar [Sun, 11 Jul 2010 16:55:47 +0000 (18:55 +0200)]
Added a way to flush video filters and video filter chains.

 It is not yet used, but it will be needed for filter that need to delay
frames.

13 years agoUsed VA_INVALID_ID when appropriate.
Laurent Aimar [Sun, 11 Jul 2010 16:53:05 +0000 (18:53 +0200)]
Used VA_INVALID_ID when appropriate.

13 years agoUsed VA_INVALID_SURFACE when appropriate.
Laurent Aimar [Sun, 11 Jul 2010 16:50:49 +0000 (18:50 +0200)]
Used VA_INVALID_SURFACE when appropriate.

13 years agoFixed fourcc selection used for video extraction from vaapi.
Laurent Aimar [Sun, 11 Jul 2010 16:42:07 +0000 (18:42 +0200)]
Fixed fourcc selection used for video extraction from vaapi.

We now test that the selected fourcc actually works by calling vaGetImage.
Initial patch from Gwenole Beauchesne.

13 years agoUsed the right picture to get the date we have to wait on.
Laurent Aimar [Fri, 9 Jul 2010 23:21:38 +0000 (01:21 +0200)]
Used the right picture to get the date we have to wait on.

No functional changes.

13 years agoMoved out the code retreiving a decoded picture from ThreadDisplayPicture.
Laurent Aimar [Fri, 9 Jul 2010 23:19:38 +0000 (01:19 +0200)]
Moved out the code retreiving a decoded picture from ThreadDisplayPicture.

No functional changes.

13 years agoAdd functions to get/set audio delay.
Mark Lee [Sun, 11 Jul 2010 05:47:58 +0000 (06:47 +0100)]
Add functions to get/set audio delay.

Two new functions added:

 * val = libvlc_audio_get_delay( p_mi )
 * libvlc_audio_set_delay( p_mi, i_delay )

The delay is measured in microseconds.

Signed-off-by: Rémi Denis-Courmont <remi@remlab.net>
13 years agoFix previous commit
Rémi Denis-Courmont [Sun, 11 Jul 2010 15:59:45 +0000 (18:59 +0300)]
Fix previous commit

13 years agoXCB: use var_Inherit*()
Rémi Denis-Courmont [Sun, 11 Jul 2010 15:47:44 +0000 (18:47 +0300)]
XCB: use var_Inherit*()

13 years agoWarn if xcb-keysyms is missing
Rémi Denis-Courmont [Sun, 11 Jul 2010 15:40:40 +0000 (18:40 +0300)]
Warn if xcb-keysyms is missing

As suggested by Jan Janak <jan@ryngle.com>

13 years agosupport for stream size in imem access module
Kamil Klimek [Mon, 5 Jul 2010 08:31:44 +0000 (10:31 +0200)]
support for stream size in imem access module

Signed-off-by: Rémi Denis-Courmont <remi@remlab.net>
13 years agoCheck that integers are within range when loading vlcrc
Rémi Denis-Courmont [Sun, 11 Jul 2010 15:22:54 +0000 (18:22 +0300)]
Check that integers are within range when loading vlcrc

13 years agoFix reading integers from vlcrc
Rémi Denis-Courmont [Sun, 11 Jul 2010 15:22:29 +0000 (18:22 +0300)]
Fix reading integers from vlcrc

13 years agoQt4: shorten the html in net_open.ui
Ilkka Ollakka [Sun, 11 Jul 2010 13:26:23 +0000 (16:26 +0300)]
Qt4: shorten the html in net_open.ui

13 years agoQt4: define generic font-family instead font in net-open helper-text
Ilkka Ollakka [Sun, 11 Jul 2010 13:20:00 +0000 (16:20 +0300)]
Qt4: define generic font-family instead font in net-open helper-text

13 years agoQt4: user system font in preferences labels
Ilkka Ollakka [Sun, 11 Jul 2010 13:15:23 +0000 (16:15 +0300)]
Qt4: user system font in preferences labels

13 years agoMarq: allow opacity parameter in config chain
Rémi Denis-Courmont [Sun, 11 Jul 2010 12:55:22 +0000 (15:55 +0300)]
Marq: allow opacity parameter in config chain

13 years agoRemove legacy casts
Rémi Denis-Courmont [Sun, 11 Jul 2010 12:45:40 +0000 (15:45 +0300)]
Remove legacy casts

13 years agoReturn 64-bits values for integer object variables
Rémi Denis-Courmont [Sun, 11 Jul 2010 12:45:08 +0000 (15:45 +0300)]
Return 64-bits values for integer object variables

13 years agoQt4: handle int64_t-values in preferences-widget
Ilkka Ollakka [Sun, 11 Jul 2010 12:07:47 +0000 (15:07 +0300)]
Qt4: handle int64_t-values in preferences-widget

13 years agoStore and parse 64-bits values in vlcrc
Rémi Denis-Courmont [Sun, 11 Jul 2010 11:43:43 +0000 (14:43 +0300)]
Store and parse 64-bits values in vlcrc

13 years agoUse 64-bits for integers in plugin descriptors
Rémi Denis-Courmont [Sun, 11 Jul 2010 11:43:01 +0000 (14:43 +0300)]
Use 64-bits for integers in plugin descriptors

13 years agoStore configuration integer as 64-bits values
Rémi Denis-Courmont [Sun, 11 Jul 2010 11:42:30 +0000 (14:42 +0300)]
Store configuration integer as 64-bits values

13 years agoCosmetic
Rémi Denis-Courmont [Sun, 11 Jul 2010 10:59:03 +0000 (13:59 +0300)]
Cosmetic

13 years agoAdd entity encoding for input options when outputting an xml file.
Daniel Tisza [Sun, 11 Jul 2010 08:52:23 +0000 (11:52 +0300)]
Add entity encoding for input options when outputting an xml file.

Entity encoding was missing (for options) in generation of an xspf playlist.
On the reading side the entity decoding is all fine.

Signed-off-by: Rémi Denis-Courmont <remi@remlab.net>
13 years agopulse: fix a memory leak.
Rémi Duraffort [Sun, 11 Jul 2010 06:45:57 +0000 (08:45 +0200)]
pulse: fix a memory leak.

13 years agoluatelnet: really add the possibility to pipe commands into the telnet interface.
Rémi Duraffort [Sat, 10 Jul 2010 18:05:58 +0000 (20:05 +0200)]
luatelnet: really add the possibility to pipe commands into the telnet interface.

13 years agoRevert "luatelnet: accept multiple commands seperated by '\n' or '\r'."
Rémi Duraffort [Sat, 10 Jul 2010 17:17:13 +0000 (19:17 +0200)]
Revert "luatelnet: accept multiple commands seperated by '\n' or '\r'."

This reverts commit f5b8b43a9e210a70e016871db6bab36929d6b866.

13 years agoRevert "luatelnet: missing debug message."
Rémi Duraffort [Sat, 10 Jul 2010 17:17:02 +0000 (19:17 +0200)]
Revert "luatelnet: missing debug message."

This reverts commit 8c1d2b3e3a20805becc4ce0d800f6f0c40de50dd.

13 years agoAdd LibVLC API for vmem
Rémi Denis-Courmont [Sat, 10 Jul 2010 15:09:05 +0000 (18:09 +0300)]
Add LibVLC API for vmem

13 years agovmem: major rework
Rémi Denis-Courmont [Sat, 10 Jul 2010 14:56:39 +0000 (17:56 +0300)]
vmem: major rework

 - add an optional display callback,
 - make unlock callback optional (planes could be static),
 - pass an opaque picture identifier from lock to unlock and display
   callbacks (this would enable multiple pictures later),
 - pass pixel planes back to the unlock callback for convenience,
 - use pointer VLC variables instead of configuration strings,
 - fix an unlikely memory leak.

13 years agoFix typo
Rémi Denis-Courmont [Sat, 10 Jul 2010 14:52:21 +0000 (17:52 +0300)]
Fix typo

13 years agoFix compilation
Rémi Denis-Courmont [Sat, 10 Jul 2010 14:25:41 +0000 (17:25 +0300)]
Fix compilation

13 years agoXCB/window: allow compilation without xcb-keysyms
Rémi Denis-Courmont [Sat, 10 Jul 2010 14:17:12 +0000 (17:17 +0300)]
XCB/window: allow compilation without xcb-keysyms

13 years agoavcodec: disable direct rendering for VP80
Ilkka Ollakka [Sat, 10 Jul 2010 12:39:10 +0000 (15:39 +0300)]
avcodec: disable direct rendering for VP80

avcodec native decoder has priority over libvpx one, and I don't know
howto change that easily. Fix #3820

13 years agoavformat: fix non-file usage after [1644d683e9df]
Ilkka Ollakka [Sat, 10 Jul 2010 10:31:36 +0000 (13:31 +0300)]
avformat: fix non-file usage after [1644d683e9df]

Fixes eg youtube viewing.

13 years agoFramebuffer: don't register useless signal handler
Rémi Denis-Courmont [Sat, 10 Jul 2010 09:49:16 +0000 (12:49 +0300)]
Framebuffer: don't register useless signal handler

The signal handler currently does nothing anyway, so this was a waste.

13 years agovmem: use var_Inherit*
Rémi Denis-Courmont [Fri, 9 Jul 2010 14:56:45 +0000 (17:56 +0300)]
vmem: use var_Inherit*

13 years agoAdd var_InheritAddress()
Rémi Denis-Courmont [Fri, 9 Jul 2010 14:50:50 +0000 (17:50 +0300)]
Add var_InheritAddress()

Returns NULL if the variable cannot be inherited - pointers can never
be found in the configuration.

13 years agosrc/playlist/loadsave.c : Fix [1644d683e9df]
Rafaël Carré [Fri, 9 Jul 2010 17:12:58 +0000 (19:12 +0200)]
src/playlist/loadsave.c : Fix [1644d683e9df]

typo and double free

13 years agoQt4: disable all by default if user sets message-filter
Ilkka Ollakka [Fri, 9 Jul 2010 10:15:28 +0000 (13:15 +0300)]
Qt4: disable all by default if user sets message-filter

Also accept filter-name without +/- as enabled one, so user can see
messages by just typing module-name without any other syntax.

13 years agoQt4: enable all messages only if filter is empty
Ilkka Ollakka [Fri, 9 Jul 2010 08:48:50 +0000 (11:48 +0300)]
Qt4: enable all messages only if filter is empty

13 years agoapply Enable/DisableObjectPrinting to filter subscriptions too
Ilkka Ollakka [Fri, 9 Jul 2010 08:49:48 +0000 (11:49 +0300)]
apply Enable/DisableObjectPrinting to filter subscriptions too

13 years agoQt4: do not explode if MyDocument isn't available
Jean-Baptiste Kempf [Thu, 8 Jul 2010 21:53:43 +0000 (23:53 +0200)]
Qt4: do not explode if MyDocument isn't available

See http://forum.videolan.org/viewtopic.php?f=14&t=78396

13 years agohttp-user-agent needs restart
Rémi Denis-Courmont [Thu, 8 Jul 2010 19:58:56 +0000 (22:58 +0300)]
http-user-agent needs restart

13 years agoAdd a proper API to set the user agent
Rémi Denis-Courmont [Thu, 8 Jul 2010 19:45:43 +0000 (22:45 +0300)]
Add a proper API to set the user agent

13 years agoRemove the --user-agent hack
Rémi Denis-Courmont [Thu, 8 Jul 2010 19:45:34 +0000 (22:45 +0300)]
Remove the --user-agent hack

13 years agoReject libmodplug 0.8.8
Rémi Denis-Courmont [Thu, 8 Jul 2010 18:14:05 +0000 (21:14 +0300)]
Reject libmodplug 0.8.8

13 years agoForce the X11 video outputs when libvlc_*_set_xwindow() is used
Rémi Denis-Courmont [Thu, 8 Jul 2010 17:24:32 +0000 (20:24 +0300)]
Force the X11 video outputs when libvlc_*_set_xwindow() is used

So LibVLC won't try to use a video output that cannot be embedded.

13 years agounset "window" if the LibVLC drawable is cleared
Rémi Denis-Courmont [Thu, 8 Jul 2010 17:19:49 +0000 (20:19 +0300)]
unset "window" if the LibVLC drawable is cleared

13 years agoXCB/window: force window provider when libvlc_*_set_xid() is used
Rémi Denis-Courmont [Thu, 8 Jul 2010 17:07:15 +0000 (20:07 +0300)]
XCB/window: force window provider when libvlc_*_set_xid() is used

We cannot drop the priority to zero. This would break rare but
functional use of `vlc --drawable-xid $WINDOWID`.

13 years agoWin32: drop drawable plugin priority to zero
Rémi Denis-Courmont [Thu, 8 Jul 2010 17:04:39 +0000 (20:04 +0300)]
Win32: drop drawable plugin priority to zero

We select it explicitly when a HWND is set for embedding.

13 years agoQt4: drop window provider priority to zero
Rémi Denis-Courmont [Thu, 8 Jul 2010 16:56:27 +0000 (19:56 +0300)]
Qt4: drop window provider priority to zero

Mapping the Qt4 plugin requires a particularly long time and much
memory. So we had better avoid doing this everytime we create a new
video window (if the Qt4 interface is _not_ used).

13 years agoAdd a window variable to select the window provider
Rémi Denis-Courmont [Thu, 8 Jul 2010 16:52:30 +0000 (19:52 +0300)]
Add a window variable to select the window provider

13 years agoDefine drawable-*-* variables only on MacOS
Rémi Denis-Courmont [Thu, 8 Jul 2010 16:49:38 +0000 (19:49 +0300)]
Define drawable-*-* variables only on MacOS

13 years agoplaylist: simplify with demux psz_location
Rémi Denis-Courmont [Thu, 8 Jul 2010 16:40:54 +0000 (19:40 +0300)]
playlist: simplify with demux psz_location

13 years agoRemove unused property
Rémi Denis-Courmont [Thu, 8 Jul 2010 16:25:03 +0000 (19:25 +0300)]
Remove unused property

13 years agoQt4: Cosmetics about ClickLineEdit, QVLCFramelessButton
Hugo Beauzée-Luyssen [Thu, 8 Jul 2010 14:11:56 +0000 (16:11 +0200)]
Qt4: Cosmetics about ClickLineEdit, QVLCFramelessButton

This removes useless member, useless parameter, useless empty dtor, and
adds a missing reference.

Signed-off-by: Jean-Baptiste Kempf <jb@videolan.org>
13 years agoRevert "ts.c: check that pts is valid for H264"
Ilkka Ollakka [Thu, 8 Jul 2010 13:09:56 +0000 (16:09 +0300)]
Revert "ts.c: check that pts is valid for H264"

This reverts commit cf45f5073677d2e7bfe57066c426340703198107.

13 years agodvdnav: don't decode_URI for psz_file
Ilkka Ollakka [Thu, 8 Jul 2010 11:51:53 +0000 (14:51 +0300)]
dvdnav: don't decode_URI for psz_file

13 years agotaglib: dont decode psz_file as URI
Ilkka Ollakka [Thu, 8 Jul 2010 11:49:49 +0000 (14:49 +0300)]
taglib: dont decode psz_file as URI

13 years agots.c: check that pts is valid for H264
Ilkka Ollakka [Wed, 7 Jul 2010 15:21:52 +0000 (18:21 +0300)]
ts.c: check that pts is valid for H264

Hackish workaround for #3306

13 years agopes.c: make sure H264 stream has aud
Ilkka Ollakka [Wed, 7 Jul 2010 12:52:32 +0000 (15:52 +0300)]
pes.c: make sure H264 stream has aud

TS-stream needs aud-nals, but didn't find any confirmation yet if ps needs those too,
so I assume it does. Maybe it would be better just to check first nal and set boolean for
adding aud.

13 years agortp : safety check.
Sébastien Escudier [Thu, 24 Jun 2010 06:41:16 +0000 (08:41 +0200)]
rtp : safety check.
There was a small window of opportunity between RtspSetup and RtspAddId where this can happen.

13 years agoUpdate german installer l10n
Mario Siegmann [Wed, 7 Jul 2010 22:46:25 +0000 (23:46 +0100)]
Update german installer l10n

Signed-off-by: Christophe Mutricy <xtophe@videolan.org>
13 years agoUpdate polish installer l10n
Michał Trzebiatowski [Wed, 7 Jul 2010 22:43:51 +0000 (23:43 +0100)]
Update polish installer l10n

Signed-off-by: Christophe Mutricy <xtophe@videolan.org>
13 years agoQt4: do not allow spaces in network URLs (fix #3870)
Rémi Denis-Courmont [Wed, 7 Jul 2010 20:56:33 +0000 (23:56 +0300)]
Qt4: do not allow spaces in network URLs (fix #3870)

13 years agolibass: kill unused variable warnings
Jean-Baptiste Kempf [Wed, 7 Jul 2010 20:52:14 +0000 (22:52 +0200)]
libass: kill unused variable warnings