]> git.sesse.net Git - bcachefs-tools-debian/blob - c_src/libbcachefs/data_update.c
6f13477ff652e9e0552b9fbbb49009a5651d6d76
[bcachefs-tools-debian] / c_src / libbcachefs / data_update.c
1 // SPDX-License-Identifier: GPL-2.0
2
3 #include "bcachefs.h"
4 #include "alloc_foreground.h"
5 #include "bkey_buf.h"
6 #include "btree_update.h"
7 #include "buckets.h"
8 #include "data_update.h"
9 #include "ec.h"
10 #include "error.h"
11 #include "extents.h"
12 #include "io_write.h"
13 #include "keylist.h"
14 #include "move.h"
15 #include "nocow_locking.h"
16 #include "rebalance.h"
17 #include "subvolume.h"
18 #include "trace.h"
19
20 static void trace_move_extent_finish2(struct bch_fs *c, struct bkey_s_c k)
21 {
22         if (trace_move_extent_finish_enabled()) {
23                 struct printbuf buf = PRINTBUF;
24
25                 bch2_bkey_val_to_text(&buf, c, k);
26                 trace_move_extent_finish(c, buf.buf);
27                 printbuf_exit(&buf);
28         }
29 }
30
31 static void trace_move_extent_fail2(struct data_update *m,
32                          struct bkey_s_c new,
33                          struct bkey_s_c wrote,
34                          struct bkey_i *insert,
35                          const char *msg)
36 {
37         struct bch_fs *c = m->op.c;
38         struct bkey_s_c old = bkey_i_to_s_c(m->k.k);
39         const union bch_extent_entry *entry;
40         struct bch_extent_ptr *ptr;
41         struct extent_ptr_decoded p;
42         struct printbuf buf = PRINTBUF;
43         unsigned i, rewrites_found = 0;
44
45         if (!trace_move_extent_fail_enabled())
46                 return;
47
48         prt_str(&buf, msg);
49
50         if (insert) {
51                 i = 0;
52                 bkey_for_each_ptr_decode(old.k, bch2_bkey_ptrs_c(old), p, entry) {
53                         if (((1U << i) & m->data_opts.rewrite_ptrs) &&
54                             (ptr = bch2_extent_has_ptr(old, p, bkey_i_to_s(insert))) &&
55                             !ptr->cached)
56                                 rewrites_found |= 1U << i;
57                         i++;
58                 }
59         }
60
61         prt_printf(&buf, "\nrewrite ptrs:   %u%u%u%u",
62                    (m->data_opts.rewrite_ptrs & (1 << 0)) != 0,
63                    (m->data_opts.rewrite_ptrs & (1 << 1)) != 0,
64                    (m->data_opts.rewrite_ptrs & (1 << 2)) != 0,
65                    (m->data_opts.rewrite_ptrs & (1 << 3)) != 0);
66
67         prt_printf(&buf, "\nrewrites found: %u%u%u%u",
68                    (rewrites_found & (1 << 0)) != 0,
69                    (rewrites_found & (1 << 1)) != 0,
70                    (rewrites_found & (1 << 2)) != 0,
71                    (rewrites_found & (1 << 3)) != 0);
72
73         prt_str(&buf, "\nold:    ");
74         bch2_bkey_val_to_text(&buf, c, old);
75
76         prt_str(&buf, "\nnew:    ");
77         bch2_bkey_val_to_text(&buf, c, new);
78
79         prt_str(&buf, "\nwrote:  ");
80         bch2_bkey_val_to_text(&buf, c, wrote);
81
82         if (insert) {
83                 prt_str(&buf, "\ninsert: ");
84                 bch2_bkey_val_to_text(&buf, c, bkey_i_to_s_c(insert));
85         }
86
87         trace_move_extent_fail(c, buf.buf);
88         printbuf_exit(&buf);
89 }
90
91 static int __bch2_data_update_index_update(struct btree_trans *trans,
92                                            struct bch_write_op *op)
93 {
94         struct bch_fs *c = op->c;
95         struct btree_iter iter;
96         struct data_update *m =
97                 container_of(op, struct data_update, op);
98         struct keylist *keys = &op->insert_keys;
99         struct bkey_buf _new, _insert;
100         int ret = 0;
101
102         bch2_bkey_buf_init(&_new);
103         bch2_bkey_buf_init(&_insert);
104         bch2_bkey_buf_realloc(&_insert, c, U8_MAX);
105
106         bch2_trans_iter_init(trans, &iter, m->btree_id,
107                              bkey_start_pos(&bch2_keylist_front(keys)->k),
108                              BTREE_ITER_SLOTS|BTREE_ITER_INTENT);
109
110         while (1) {
111                 struct bkey_s_c k;
112                 struct bkey_s_c old = bkey_i_to_s_c(m->k.k);
113                 struct bkey_i *insert = NULL;
114                 struct bkey_i_extent *new;
115                 const union bch_extent_entry *entry_c;
116                 union bch_extent_entry *entry;
117                 struct extent_ptr_decoded p;
118                 struct bch_extent_ptr *ptr;
119                 const struct bch_extent_ptr *ptr_c;
120                 struct bpos next_pos;
121                 bool should_check_enospc;
122                 s64 i_sectors_delta = 0, disk_sectors_delta = 0;
123                 unsigned rewrites_found = 0, durability, i;
124
125                 bch2_trans_begin(trans);
126
127                 k = bch2_btree_iter_peek_slot(&iter);
128                 ret = bkey_err(k);
129                 if (ret)
130                         goto err;
131
132                 new = bkey_i_to_extent(bch2_keylist_front(keys));
133
134                 if (!bch2_extents_match(k, old)) {
135                         trace_move_extent_fail2(m, k, bkey_i_to_s_c(&new->k_i),
136                                                 NULL, "no match:");
137                         goto nowork;
138                 }
139
140                 bkey_reassemble(_insert.k, k);
141                 insert = _insert.k;
142
143                 bch2_bkey_buf_copy(&_new, c, bch2_keylist_front(keys));
144                 new = bkey_i_to_extent(_new.k);
145                 bch2_cut_front(iter.pos, &new->k_i);
146
147                 bch2_cut_front(iter.pos,        insert);
148                 bch2_cut_back(new->k.p,         insert);
149                 bch2_cut_back(insert->k.p,      &new->k_i);
150
151                 /*
152                  * @old: extent that we read from
153                  * @insert: key that we're going to update, initialized from
154                  * extent currently in btree - same as @old unless we raced with
155                  * other updates
156                  * @new: extent with new pointers that we'll be adding to @insert
157                  *
158                  * Fist, drop rewrite_ptrs from @new:
159                  */
160                 i = 0;
161                 bkey_for_each_ptr_decode(old.k, bch2_bkey_ptrs_c(old), p, entry_c) {
162                         if (((1U << i) & m->data_opts.rewrite_ptrs) &&
163                             (ptr = bch2_extent_has_ptr(old, p, bkey_i_to_s(insert))) &&
164                             !ptr->cached) {
165                                 bch2_extent_ptr_set_cached(bkey_i_to_s(insert), ptr);
166                                 rewrites_found |= 1U << i;
167                         }
168                         i++;
169                 }
170
171                 if (m->data_opts.rewrite_ptrs &&
172                     !rewrites_found &&
173                     bch2_bkey_durability(c, k) >= m->op.opts.data_replicas) {
174                         trace_move_extent_fail2(m, k, bkey_i_to_s_c(&new->k_i), insert, "no rewrites found:");
175                         goto nowork;
176                 }
177
178                 /*
179                  * A replica that we just wrote might conflict with a replica
180                  * that we want to keep, due to racing with another move:
181                  */
182 restart_drop_conflicting_replicas:
183                 extent_for_each_ptr(extent_i_to_s(new), ptr)
184                         if ((ptr_c = bch2_bkey_has_device_c(bkey_i_to_s_c(insert), ptr->dev)) &&
185                             !ptr_c->cached) {
186                                 bch2_bkey_drop_ptr_noerror(bkey_i_to_s(&new->k_i), ptr);
187                                 goto restart_drop_conflicting_replicas;
188                         }
189
190                 if (!bkey_val_u64s(&new->k)) {
191                         trace_move_extent_fail2(m, k, bkey_i_to_s_c(&new->k_i), insert, "new replicas conflicted:");
192                         goto nowork;
193                 }
194
195                 /* Now, drop pointers that conflict with what we just wrote: */
196                 extent_for_each_ptr_decode(extent_i_to_s(new), p, entry)
197                         if ((ptr = bch2_bkey_has_device(bkey_i_to_s(insert), p.ptr.dev)))
198                                 bch2_bkey_drop_ptr_noerror(bkey_i_to_s(insert), ptr);
199
200                 durability = bch2_bkey_durability(c, bkey_i_to_s_c(insert)) +
201                         bch2_bkey_durability(c, bkey_i_to_s_c(&new->k_i));
202
203                 /* Now, drop excess replicas: */
204 restart_drop_extra_replicas:
205                 bkey_for_each_ptr_decode(old.k, bch2_bkey_ptrs(bkey_i_to_s(insert)), p, entry) {
206                         unsigned ptr_durability = bch2_extent_ptr_durability(c, &p);
207
208                         if (!p.ptr.cached &&
209                             durability - ptr_durability >= m->op.opts.data_replicas) {
210                                 durability -= ptr_durability;
211
212                                 bch2_extent_ptr_set_cached(bkey_i_to_s(insert), &entry->ptr);
213                                 goto restart_drop_extra_replicas;
214                         }
215                 }
216
217                 /* Finally, add the pointers we just wrote: */
218                 extent_for_each_ptr_decode(extent_i_to_s(new), p, entry)
219                         bch2_extent_ptr_decoded_append(insert, &p);
220
221                 bch2_bkey_narrow_crcs(insert, (struct bch_extent_crc_unpacked) { 0 });
222                 bch2_extent_normalize(c, bkey_i_to_s(insert));
223
224                 ret = bch2_sum_sector_overwrites(trans, &iter, insert,
225                                                  &should_check_enospc,
226                                                  &i_sectors_delta,
227                                                  &disk_sectors_delta);
228                 if (ret)
229                         goto err;
230
231                 if (disk_sectors_delta > (s64) op->res.sectors) {
232                         ret = bch2_disk_reservation_add(c, &op->res,
233                                                 disk_sectors_delta - op->res.sectors,
234                                                 !should_check_enospc
235                                                 ? BCH_DISK_RESERVATION_NOFAIL : 0);
236                         if (ret)
237                                 goto out;
238                 }
239
240                 next_pos = insert->k.p;
241
242                 /*
243                  * Check for nonce offset inconsistency:
244                  * This is debug code - we've been seeing this bug rarely, and
245                  * it's been hard to reproduce, so this should give us some more
246                  * information when it does occur:
247                  */
248                 struct printbuf err = PRINTBUF;
249                 int invalid = bch2_bkey_invalid(c, bkey_i_to_s_c(insert), __btree_node_type(0, m->btree_id), 0, &err);
250                 printbuf_exit(&err);
251
252                 if (invalid) {
253                         struct printbuf buf = PRINTBUF;
254
255                         prt_str(&buf, "about to insert invalid key in data update path");
256                         prt_str(&buf, "\nold: ");
257                         bch2_bkey_val_to_text(&buf, c, old);
258                         prt_str(&buf, "\nk:   ");
259                         bch2_bkey_val_to_text(&buf, c, k);
260                         prt_str(&buf, "\nnew: ");
261                         bch2_bkey_val_to_text(&buf, c, bkey_i_to_s_c(insert));
262
263                         bch2_print_string_as_lines(KERN_ERR, buf.buf);
264                         printbuf_exit(&buf);
265
266                         bch2_fatal_error(c);
267                         goto out;
268                 }
269
270                 if (trace_data_update_enabled()) {
271                         struct printbuf buf = PRINTBUF;
272
273                         prt_str(&buf, "\nold: ");
274                         bch2_bkey_val_to_text(&buf, c, old);
275                         prt_str(&buf, "\nk:   ");
276                         bch2_bkey_val_to_text(&buf, c, k);
277                         prt_str(&buf, "\nnew: ");
278                         bch2_bkey_val_to_text(&buf, c, bkey_i_to_s_c(insert));
279
280                         trace_data_update(c, buf.buf);
281                         printbuf_exit(&buf);
282                 }
283
284                 ret =   bch2_insert_snapshot_whiteouts(trans, m->btree_id,
285                                                 k.k->p, bkey_start_pos(&insert->k)) ?:
286                         bch2_insert_snapshot_whiteouts(trans, m->btree_id,
287                                                 k.k->p, insert->k.p) ?:
288                         bch2_bkey_set_needs_rebalance(c, insert,
289                                                       op->opts.background_target,
290                                                       op->opts.background_compression) ?:
291                         bch2_trans_update(trans, &iter, insert,
292                                 BTREE_UPDATE_INTERNAL_SNAPSHOT_NODE) ?:
293                         bch2_trans_commit(trans, &op->res,
294                                 NULL,
295                                 BCH_TRANS_COMMIT_no_check_rw|
296                                 BCH_TRANS_COMMIT_no_enospc|
297                                 m->data_opts.btree_insert_flags);
298                 if (!ret) {
299                         bch2_btree_iter_set_pos(&iter, next_pos);
300
301                         this_cpu_add(c->counters[BCH_COUNTER_move_extent_finish], new->k.size);
302                         trace_move_extent_finish2(c, bkey_i_to_s_c(&new->k_i));
303                 }
304 err:
305                 if (bch2_err_matches(ret, BCH_ERR_transaction_restart))
306                         ret = 0;
307                 if (ret)
308                         break;
309 next:
310                 while (bkey_ge(iter.pos, bch2_keylist_front(keys)->k.p)) {
311                         bch2_keylist_pop_front(keys);
312                         if (bch2_keylist_empty(keys))
313                                 goto out;
314                 }
315                 continue;
316 nowork:
317                 if (m->stats) {
318                         BUG_ON(k.k->p.offset <= iter.pos.offset);
319                         atomic64_inc(&m->stats->keys_raced);
320                         atomic64_add(k.k->p.offset - iter.pos.offset,
321                                      &m->stats->sectors_raced);
322                 }
323
324                 count_event(c, move_extent_fail);
325
326                 bch2_btree_iter_advance(&iter);
327                 goto next;
328         }
329 out:
330         bch2_trans_iter_exit(trans, &iter);
331         bch2_bkey_buf_exit(&_insert, c);
332         bch2_bkey_buf_exit(&_new, c);
333         BUG_ON(bch2_err_matches(ret, BCH_ERR_transaction_restart));
334         return ret;
335 }
336
337 int bch2_data_update_index_update(struct bch_write_op *op)
338 {
339         return bch2_trans_run(op->c, __bch2_data_update_index_update(trans, op));
340 }
341
342 void bch2_data_update_read_done(struct data_update *m,
343                                 struct bch_extent_crc_unpacked crc)
344 {
345         /* write bio must own pages: */
346         BUG_ON(!m->op.wbio.bio.bi_vcnt);
347
348         m->op.crc = crc;
349         m->op.wbio.bio.bi_iter.bi_size = crc.compressed_size << 9;
350
351         closure_call(&m->op.cl, bch2_write, NULL, NULL);
352 }
353
354 void bch2_data_update_exit(struct data_update *update)
355 {
356         struct bch_fs *c = update->op.c;
357         struct bkey_ptrs_c ptrs =
358                 bch2_bkey_ptrs_c(bkey_i_to_s_c(update->k.k));
359
360         bkey_for_each_ptr(ptrs, ptr) {
361                 if (c->opts.nocow_enabled)
362                         bch2_bucket_nocow_unlock(&c->nocow_locks,
363                                                  PTR_BUCKET_POS(c, ptr), 0);
364                 percpu_ref_put(&bch_dev_bkey_exists(c, ptr->dev)->ref);
365         }
366
367         bch2_bkey_buf_exit(&update->k, c);
368         bch2_disk_reservation_put(c, &update->op.res);
369         bch2_bio_free_pages_pool(c, &update->op.wbio.bio);
370 }
371
372 static void bch2_update_unwritten_extent(struct btree_trans *trans,
373                                   struct data_update *update)
374 {
375         struct bch_fs *c = update->op.c;
376         struct bio *bio = &update->op.wbio.bio;
377         struct bkey_i_extent *e;
378         struct write_point *wp;
379         struct closure cl;
380         struct btree_iter iter;
381         struct bkey_s_c k;
382         int ret;
383
384         closure_init_stack(&cl);
385         bch2_keylist_init(&update->op.insert_keys, update->op.inline_keys);
386
387         while (bio_sectors(bio)) {
388                 unsigned sectors = bio_sectors(bio);
389
390                 bch2_trans_iter_init(trans, &iter, update->btree_id, update->op.pos,
391                                      BTREE_ITER_SLOTS);
392                 ret = lockrestart_do(trans, ({
393                         k = bch2_btree_iter_peek_slot(&iter);
394                         bkey_err(k);
395                 }));
396                 bch2_trans_iter_exit(trans, &iter);
397
398                 if (ret || !bch2_extents_match(k, bkey_i_to_s_c(update->k.k)))
399                         break;
400
401                 e = bkey_extent_init(update->op.insert_keys.top);
402                 e->k.p = update->op.pos;
403
404                 ret = bch2_alloc_sectors_start_trans(trans,
405                                 update->op.target,
406                                 false,
407                                 update->op.write_point,
408                                 &update->op.devs_have,
409                                 update->op.nr_replicas,
410                                 update->op.nr_replicas,
411                                 update->op.watermark,
412                                 0, &cl, &wp);
413                 if (bch2_err_matches(ret, BCH_ERR_operation_blocked)) {
414                         bch2_trans_unlock(trans);
415                         closure_sync(&cl);
416                         continue;
417                 }
418
419                 bch_err_fn_ratelimited(c, ret);
420
421                 if (ret)
422                         return;
423
424                 sectors = min(sectors, wp->sectors_free);
425
426                 bch2_key_resize(&e->k, sectors);
427
428                 bch2_open_bucket_get(c, wp, &update->op.open_buckets);
429                 bch2_alloc_sectors_append_ptrs(c, wp, &e->k_i, sectors, false);
430                 bch2_alloc_sectors_done(c, wp);
431
432                 bio_advance(bio, sectors << 9);
433                 update->op.pos.offset += sectors;
434
435                 extent_for_each_ptr(extent_i_to_s(e), ptr)
436                         ptr->unwritten = true;
437                 bch2_keylist_push(&update->op.insert_keys);
438
439                 ret = __bch2_data_update_index_update(trans, &update->op);
440
441                 bch2_open_buckets_put(c, &update->op.open_buckets);
442
443                 if (ret)
444                         break;
445         }
446
447         if (closure_nr_remaining(&cl) != 1) {
448                 bch2_trans_unlock(trans);
449                 closure_sync(&cl);
450         }
451 }
452
453 int bch2_extent_drop_ptrs(struct btree_trans *trans,
454                           struct btree_iter *iter,
455                           struct bkey_s_c k,
456                           struct data_update_opts data_opts)
457 {
458         struct bch_fs *c = trans->c;
459         struct bkey_i *n;
460         int ret;
461
462         n = bch2_bkey_make_mut_noupdate(trans, k);
463         ret = PTR_ERR_OR_ZERO(n);
464         if (ret)
465                 return ret;
466
467         while (data_opts.kill_ptrs) {
468                 unsigned i = 0, drop = __fls(data_opts.kill_ptrs);
469                 struct bch_extent_ptr *ptr;
470
471                 bch2_bkey_drop_ptrs(bkey_i_to_s(n), ptr, i++ == drop);
472                 data_opts.kill_ptrs ^= 1U << drop;
473         }
474
475         /*
476          * If the new extent no longer has any pointers, bch2_extent_normalize()
477          * will do the appropriate thing with it (turning it into a
478          * KEY_TYPE_error key, or just a discard if it was a cached extent)
479          */
480         bch2_extent_normalize(c, bkey_i_to_s(n));
481
482         /*
483          * Since we're not inserting through an extent iterator
484          * (BTREE_ITER_ALL_SNAPSHOTS iterators aren't extent iterators),
485          * we aren't using the extent overwrite path to delete, we're
486          * just using the normal key deletion path:
487          */
488         if (bkey_deleted(&n->k) && !(iter->flags & BTREE_ITER_IS_EXTENTS))
489                 n->k.size = 0;
490
491         return bch2_trans_relock(trans) ?:
492                 bch2_trans_update(trans, iter, n, BTREE_UPDATE_INTERNAL_SNAPSHOT_NODE) ?:
493                 bch2_trans_commit(trans, NULL, NULL, BCH_TRANS_COMMIT_no_enospc);
494 }
495
496 int bch2_data_update_init(struct btree_trans *trans,
497                           struct btree_iter *iter,
498                           struct moving_context *ctxt,
499                           struct data_update *m,
500                           struct write_point_specifier wp,
501                           struct bch_io_opts io_opts,
502                           struct data_update_opts data_opts,
503                           enum btree_id btree_id,
504                           struct bkey_s_c k)
505 {
506         struct bch_fs *c = trans->c;
507         struct bkey_ptrs_c ptrs = bch2_bkey_ptrs_c(k);
508         const union bch_extent_entry *entry;
509         struct extent_ptr_decoded p;
510         unsigned i, reserve_sectors = k.k->size * data_opts.extra_replicas;
511         unsigned ptrs_locked = 0;
512         int ret = 0;
513
514         bch2_bkey_buf_init(&m->k);
515         bch2_bkey_buf_reassemble(&m->k, c, k);
516         m->btree_id     = btree_id;
517         m->data_opts    = data_opts;
518         m->ctxt         = ctxt;
519         m->stats        = ctxt ? ctxt->stats : NULL;
520
521         bch2_write_op_init(&m->op, c, io_opts);
522         m->op.pos       = bkey_start_pos(k.k);
523         m->op.version   = k.k->version;
524         m->op.target    = data_opts.target;
525         m->op.write_point = wp;
526         m->op.nr_replicas = 0;
527         m->op.flags     |= BCH_WRITE_PAGES_STABLE|
528                 BCH_WRITE_PAGES_OWNED|
529                 BCH_WRITE_DATA_ENCODED|
530                 BCH_WRITE_MOVE|
531                 m->data_opts.write_flags;
532         m->op.compression_opt   = io_opts.background_compression ?: io_opts.compression;
533         m->op.watermark         = m->data_opts.btree_insert_flags & BCH_WATERMARK_MASK;
534
535         bkey_for_each_ptr(ptrs, ptr)
536                 percpu_ref_get(&bch_dev_bkey_exists(c, ptr->dev)->ref);
537
538         unsigned durability_have = 0, durability_removing = 0;
539
540         i = 0;
541         bkey_for_each_ptr_decode(k.k, ptrs, p, entry) {
542                 bool locked;
543
544                 if (((1U << i) & m->data_opts.rewrite_ptrs)) {
545                         BUG_ON(p.ptr.cached);
546
547                         if (crc_is_compressed(p.crc))
548                                 reserve_sectors += k.k->size;
549
550                         m->op.nr_replicas += bch2_extent_ptr_desired_durability(c, &p);
551                         durability_removing += bch2_extent_ptr_desired_durability(c, &p);
552                 } else if (!p.ptr.cached &&
553                            !((1U << i) & m->data_opts.kill_ptrs)) {
554                         bch2_dev_list_add_dev(&m->op.devs_have, p.ptr.dev);
555                         durability_have += bch2_extent_ptr_durability(c, &p);
556                 }
557
558                 /*
559                  * op->csum_type is normally initialized from the fs/file's
560                  * current options - but if an extent is encrypted, we require
561                  * that it stays encrypted:
562                  */
563                 if (bch2_csum_type_is_encryption(p.crc.csum_type)) {
564                         m->op.nonce     = p.crc.nonce + p.crc.offset;
565                         m->op.csum_type = p.crc.csum_type;
566                 }
567
568                 if (p.crc.compression_type == BCH_COMPRESSION_TYPE_incompressible)
569                         m->op.incompressible = true;
570
571                 if (c->opts.nocow_enabled) {
572                         if (ctxt) {
573                                 move_ctxt_wait_event(ctxt,
574                                                 (locked = bch2_bucket_nocow_trylock(&c->nocow_locks,
575                                                                           PTR_BUCKET_POS(c, &p.ptr), 0)) ||
576                                                 (!atomic_read(&ctxt->read_sectors) &&
577                                                  !atomic_read(&ctxt->write_sectors)));
578
579                                 if (!locked)
580                                         bch2_bucket_nocow_lock(&c->nocow_locks,
581                                                                PTR_BUCKET_POS(c, &p.ptr), 0);
582                         } else {
583                                 if (!bch2_bucket_nocow_trylock(&c->nocow_locks,
584                                                                PTR_BUCKET_POS(c, &p.ptr), 0)) {
585                                         ret = -BCH_ERR_nocow_lock_blocked;
586                                         goto err;
587                                 }
588                         }
589                         ptrs_locked |= (1U << i);
590                 }
591
592                 i++;
593         }
594
595         /*
596          * If current extent durability is less than io_opts.data_replicas,
597          * we're not trying to rereplicate the extent up to data_replicas here -
598          * unless extra_replicas was specified
599          *
600          * Increasing replication is an explicit operation triggered by
601          * rereplicate, currently, so that users don't get an unexpected -ENOSPC
602          */
603         if (!(m->data_opts.write_flags & BCH_WRITE_CACHED) &&
604             durability_have >= io_opts.data_replicas) {
605                 m->data_opts.kill_ptrs |= m->data_opts.rewrite_ptrs;
606                 m->data_opts.rewrite_ptrs = 0;
607                 /* if iter == NULL, it's just a promote */
608                 if (iter)
609                         ret = bch2_extent_drop_ptrs(trans, iter, k, m->data_opts);
610                 goto done;
611         }
612
613         m->op.nr_replicas = min(durability_removing, io_opts.data_replicas - durability_have) +
614                 m->data_opts.extra_replicas;
615         m->op.nr_replicas_required = m->op.nr_replicas;
616
617         BUG_ON(!m->op.nr_replicas);
618
619         if (reserve_sectors) {
620                 ret = bch2_disk_reservation_add(c, &m->op.res, reserve_sectors,
621                                 m->data_opts.extra_replicas
622                                 ? 0
623                                 : BCH_DISK_RESERVATION_NOFAIL);
624                 if (ret)
625                         goto err;
626         }
627
628         if (bkey_extent_is_unwritten(k)) {
629                 bch2_update_unwritten_extent(trans, m);
630                 goto done;
631         }
632
633         return 0;
634 err:
635         i = 0;
636         bkey_for_each_ptr_decode(k.k, ptrs, p, entry) {
637                 if ((1U << i) & ptrs_locked)
638                         bch2_bucket_nocow_unlock(&c->nocow_locks,
639                                                  PTR_BUCKET_POS(c, &p.ptr), 0);
640                 percpu_ref_put(&bch_dev_bkey_exists(c, p.ptr.dev)->ref);
641                 i++;
642         }
643
644         bch2_bkey_buf_exit(&m->k, c);
645         bch2_bio_free_pages_pool(c, &m->op.wbio.bio);
646         return ret;
647 done:
648         bch2_data_update_exit(m);
649         return ret ?: -BCH_ERR_data_update_done;
650 }
651
652 void bch2_data_update_opts_normalize(struct bkey_s_c k, struct data_update_opts *opts)
653 {
654         struct bkey_ptrs_c ptrs = bch2_bkey_ptrs_c(k);
655         unsigned i = 0;
656
657         bkey_for_each_ptr(ptrs, ptr) {
658                 if ((opts->rewrite_ptrs & (1U << i)) && ptr->cached) {
659                         opts->kill_ptrs |= 1U << i;
660                         opts->rewrite_ptrs ^= 1U << i;
661                 }
662
663                 i++;
664         }
665 }