]> git.sesse.net Git - bcachefs-tools-debian/blob - libbcachefs/btree_iter.c
Update bcachefs sources to 1a739db0b256 bcachefs; guard against overflow in btree...
[bcachefs-tools-debian] / libbcachefs / btree_iter.c
1 // SPDX-License-Identifier: GPL-2.0
2
3 #include "bcachefs.h"
4 #include "bkey_methods.h"
5 #include "bkey_buf.h"
6 #include "btree_cache.h"
7 #include "btree_iter.h"
8 #include "btree_journal_iter.h"
9 #include "btree_key_cache.h"
10 #include "btree_locking.h"
11 #include "btree_update.h"
12 #include "debug.h"
13 #include "error.h"
14 #include "extents.h"
15 #include "journal.h"
16 #include "journal_io.h"
17 #include "replicas.h"
18 #include "snapshot.h"
19 #include "trace.h"
20
21 #include <linux/random.h>
22 #include <linux/prefetch.h>
23
24 static inline void btree_path_list_remove(struct btree_trans *, struct btree_path *);
25 static inline void btree_path_list_add(struct btree_trans *,
26                         btree_path_idx_t, btree_path_idx_t);
27
28 static inline unsigned long btree_iter_ip_allocated(struct btree_iter *iter)
29 {
30 #ifdef TRACK_PATH_ALLOCATED
31         return iter->ip_allocated;
32 #else
33         return 0;
34 #endif
35 }
36
37 static btree_path_idx_t btree_path_alloc(struct btree_trans *, btree_path_idx_t);
38 static void bch2_trans_srcu_lock(struct btree_trans *);
39
40 static inline int __btree_path_cmp(const struct btree_path *l,
41                                    enum btree_id        r_btree_id,
42                                    bool                 r_cached,
43                                    struct bpos          r_pos,
44                                    unsigned             r_level)
45 {
46         /*
47          * Must match lock ordering as defined by __bch2_btree_node_lock:
48          */
49         return   cmp_int(l->btree_id,   r_btree_id) ?:
50                  cmp_int((int) l->cached,       (int) r_cached) ?:
51                  bpos_cmp(l->pos,       r_pos) ?:
52                 -cmp_int(l->level,      r_level);
53 }
54
55 static inline int btree_path_cmp(const struct btree_path *l,
56                                  const struct btree_path *r)
57 {
58         return __btree_path_cmp(l, r->btree_id, r->cached, r->pos, r->level);
59 }
60
61 static inline struct bpos bkey_successor(struct btree_iter *iter, struct bpos p)
62 {
63         /* Are we iterating over keys in all snapshots? */
64         if (iter->flags & BTREE_ITER_ALL_SNAPSHOTS) {
65                 p = bpos_successor(p);
66         } else {
67                 p = bpos_nosnap_successor(p);
68                 p.snapshot = iter->snapshot;
69         }
70
71         return p;
72 }
73
74 static inline struct bpos bkey_predecessor(struct btree_iter *iter, struct bpos p)
75 {
76         /* Are we iterating over keys in all snapshots? */
77         if (iter->flags & BTREE_ITER_ALL_SNAPSHOTS) {
78                 p = bpos_predecessor(p);
79         } else {
80                 p = bpos_nosnap_predecessor(p);
81                 p.snapshot = iter->snapshot;
82         }
83
84         return p;
85 }
86
87 static inline struct bpos btree_iter_search_key(struct btree_iter *iter)
88 {
89         struct bpos pos = iter->pos;
90
91         if ((iter->flags & BTREE_ITER_IS_EXTENTS) &&
92             !bkey_eq(pos, POS_MAX))
93                 pos = bkey_successor(iter, pos);
94         return pos;
95 }
96
97 static inline bool btree_path_pos_before_node(struct btree_path *path,
98                                               struct btree *b)
99 {
100         return bpos_lt(path->pos, b->data->min_key);
101 }
102
103 static inline bool btree_path_pos_after_node(struct btree_path *path,
104                                              struct btree *b)
105 {
106         return bpos_gt(path->pos, b->key.k.p);
107 }
108
109 static inline bool btree_path_pos_in_node(struct btree_path *path,
110                                           struct btree *b)
111 {
112         return path->btree_id == b->c.btree_id &&
113                 !btree_path_pos_before_node(path, b) &&
114                 !btree_path_pos_after_node(path, b);
115 }
116
117 /* Btree iterator: */
118
119 #ifdef CONFIG_BCACHEFS_DEBUG
120
121 static void bch2_btree_path_verify_cached(struct btree_trans *trans,
122                                           struct btree_path *path)
123 {
124         struct bkey_cached *ck;
125         bool locked = btree_node_locked(path, 0);
126
127         if (!bch2_btree_node_relock(trans, path, 0))
128                 return;
129
130         ck = (void *) path->l[0].b;
131         BUG_ON(ck->key.btree_id != path->btree_id ||
132                !bkey_eq(ck->key.pos, path->pos));
133
134         if (!locked)
135                 btree_node_unlock(trans, path, 0);
136 }
137
138 static void bch2_btree_path_verify_level(struct btree_trans *trans,
139                                 struct btree_path *path, unsigned level)
140 {
141         struct btree_path_level *l;
142         struct btree_node_iter tmp;
143         bool locked;
144         struct bkey_packed *p, *k;
145         struct printbuf buf1 = PRINTBUF;
146         struct printbuf buf2 = PRINTBUF;
147         struct printbuf buf3 = PRINTBUF;
148         const char *msg;
149
150         if (!bch2_debug_check_iterators)
151                 return;
152
153         l       = &path->l[level];
154         tmp     = l->iter;
155         locked  = btree_node_locked(path, level);
156
157         if (path->cached) {
158                 if (!level)
159                         bch2_btree_path_verify_cached(trans, path);
160                 return;
161         }
162
163         if (!btree_path_node(path, level))
164                 return;
165
166         if (!bch2_btree_node_relock_notrace(trans, path, level))
167                 return;
168
169         BUG_ON(!btree_path_pos_in_node(path, l->b));
170
171         bch2_btree_node_iter_verify(&l->iter, l->b);
172
173         /*
174          * For interior nodes, the iterator will have skipped past deleted keys:
175          */
176         p = level
177                 ? bch2_btree_node_iter_prev(&tmp, l->b)
178                 : bch2_btree_node_iter_prev_all(&tmp, l->b);
179         k = bch2_btree_node_iter_peek_all(&l->iter, l->b);
180
181         if (p && bkey_iter_pos_cmp(l->b, p, &path->pos) >= 0) {
182                 msg = "before";
183                 goto err;
184         }
185
186         if (k && bkey_iter_pos_cmp(l->b, k, &path->pos) < 0) {
187                 msg = "after";
188                 goto err;
189         }
190
191         if (!locked)
192                 btree_node_unlock(trans, path, level);
193         return;
194 err:
195         bch2_bpos_to_text(&buf1, path->pos);
196
197         if (p) {
198                 struct bkey uk = bkey_unpack_key(l->b, p);
199
200                 bch2_bkey_to_text(&buf2, &uk);
201         } else {
202                 prt_printf(&buf2, "(none)");
203         }
204
205         if (k) {
206                 struct bkey uk = bkey_unpack_key(l->b, k);
207
208                 bch2_bkey_to_text(&buf3, &uk);
209         } else {
210                 prt_printf(&buf3, "(none)");
211         }
212
213         panic("path should be %s key at level %u:\n"
214               "path pos %s\n"
215               "prev key %s\n"
216               "cur  key %s\n",
217               msg, level, buf1.buf, buf2.buf, buf3.buf);
218 }
219
220 static void bch2_btree_path_verify(struct btree_trans *trans,
221                                    struct btree_path *path)
222 {
223         struct bch_fs *c = trans->c;
224         unsigned i;
225
226         EBUG_ON(path->btree_id >= BTREE_ID_NR);
227
228         for (i = 0; i < (!path->cached ? BTREE_MAX_DEPTH : 1); i++) {
229                 if (!path->l[i].b) {
230                         BUG_ON(!path->cached &&
231                                bch2_btree_id_root(c, path->btree_id)->b->c.level > i);
232                         break;
233                 }
234
235                 bch2_btree_path_verify_level(trans, path, i);
236         }
237
238         bch2_btree_path_verify_locks(path);
239 }
240
241 void bch2_trans_verify_paths(struct btree_trans *trans)
242 {
243         struct btree_path *path;
244         unsigned iter;
245
246         trans_for_each_path(trans, path, iter)
247                 bch2_btree_path_verify(trans, path);
248 }
249
250 static void bch2_btree_iter_verify(struct btree_iter *iter)
251 {
252         struct btree_trans *trans = iter->trans;
253
254         BUG_ON(iter->btree_id >= BTREE_ID_NR);
255
256         BUG_ON(!!(iter->flags & BTREE_ITER_CACHED) != btree_iter_path(trans, iter)->cached);
257
258         BUG_ON((iter->flags & BTREE_ITER_IS_EXTENTS) &&
259                (iter->flags & BTREE_ITER_ALL_SNAPSHOTS));
260
261         BUG_ON(!(iter->flags & __BTREE_ITER_ALL_SNAPSHOTS) &&
262                (iter->flags & BTREE_ITER_ALL_SNAPSHOTS) &&
263                !btree_type_has_snapshot_field(iter->btree_id));
264
265         if (iter->update_path)
266                 bch2_btree_path_verify(trans, &trans->paths[iter->update_path]);
267         bch2_btree_path_verify(trans, btree_iter_path(trans, iter));
268 }
269
270 static void bch2_btree_iter_verify_entry_exit(struct btree_iter *iter)
271 {
272         BUG_ON((iter->flags & BTREE_ITER_FILTER_SNAPSHOTS) &&
273                !iter->pos.snapshot);
274
275         BUG_ON(!(iter->flags & BTREE_ITER_ALL_SNAPSHOTS) &&
276                iter->pos.snapshot != iter->snapshot);
277
278         BUG_ON(bkey_lt(iter->pos, bkey_start_pos(&iter->k)) ||
279                bkey_gt(iter->pos, iter->k.p));
280 }
281
282 static int bch2_btree_iter_verify_ret(struct btree_iter *iter, struct bkey_s_c k)
283 {
284         struct btree_trans *trans = iter->trans;
285         struct btree_iter copy;
286         struct bkey_s_c prev;
287         int ret = 0;
288
289         if (!bch2_debug_check_iterators)
290                 return 0;
291
292         if (!(iter->flags & BTREE_ITER_FILTER_SNAPSHOTS))
293                 return 0;
294
295         if (bkey_err(k) || !k.k)
296                 return 0;
297
298         BUG_ON(!bch2_snapshot_is_ancestor(trans->c,
299                                           iter->snapshot,
300                                           k.k->p.snapshot));
301
302         bch2_trans_iter_init(trans, &copy, iter->btree_id, iter->pos,
303                              BTREE_ITER_NOPRESERVE|
304                              BTREE_ITER_ALL_SNAPSHOTS);
305         prev = bch2_btree_iter_prev(&copy);
306         if (!prev.k)
307                 goto out;
308
309         ret = bkey_err(prev);
310         if (ret)
311                 goto out;
312
313         if (bkey_eq(prev.k->p, k.k->p) &&
314             bch2_snapshot_is_ancestor(trans->c, iter->snapshot,
315                                       prev.k->p.snapshot) > 0) {
316                 struct printbuf buf1 = PRINTBUF, buf2 = PRINTBUF;
317
318                 bch2_bkey_to_text(&buf1, k.k);
319                 bch2_bkey_to_text(&buf2, prev.k);
320
321                 panic("iter snap %u\n"
322                       "k    %s\n"
323                       "prev %s\n",
324                       iter->snapshot,
325                       buf1.buf, buf2.buf);
326         }
327 out:
328         bch2_trans_iter_exit(trans, &copy);
329         return ret;
330 }
331
332 void bch2_assert_pos_locked(struct btree_trans *trans, enum btree_id id,
333                             struct bpos pos, bool key_cache)
334 {
335         struct btree_path *path;
336         struct trans_for_each_path_inorder_iter iter;
337         struct printbuf buf = PRINTBUF;
338
339         btree_trans_sort_paths(trans);
340
341         trans_for_each_path_inorder(trans, path, iter) {
342                 int cmp = cmp_int(path->btree_id, id) ?:
343                         cmp_int(path->cached, key_cache);
344
345                 if (cmp > 0)
346                         break;
347                 if (cmp < 0)
348                         continue;
349
350                 if (!btree_node_locked(path, 0) ||
351                     !path->should_be_locked)
352                         continue;
353
354                 if (!key_cache) {
355                         if (bkey_ge(pos, path->l[0].b->data->min_key) &&
356                             bkey_le(pos, path->l[0].b->key.k.p))
357                                 return;
358                 } else {
359                         if (bkey_eq(pos, path->pos))
360                                 return;
361                 }
362         }
363
364         bch2_dump_trans_paths_updates(trans);
365         bch2_bpos_to_text(&buf, pos);
366
367         panic("not locked: %s %s%s\n",
368               bch2_btree_id_str(id), buf.buf,
369               key_cache ? " cached" : "");
370 }
371
372 #else
373
374 static inline void bch2_btree_path_verify_level(struct btree_trans *trans,
375                                                 struct btree_path *path, unsigned l) {}
376 static inline void bch2_btree_path_verify(struct btree_trans *trans,
377                                           struct btree_path *path) {}
378 static inline void bch2_btree_iter_verify(struct btree_iter *iter) {}
379 static inline void bch2_btree_iter_verify_entry_exit(struct btree_iter *iter) {}
380 static inline int bch2_btree_iter_verify_ret(struct btree_iter *iter, struct bkey_s_c k) { return 0; }
381
382 #endif
383
384 /* Btree path: fixups after btree updates */
385
386 static void btree_node_iter_set_set_pos(struct btree_node_iter *iter,
387                                         struct btree *b,
388                                         struct bset_tree *t,
389                                         struct bkey_packed *k)
390 {
391         struct btree_node_iter_set *set;
392
393         btree_node_iter_for_each(iter, set)
394                 if (set->end == t->end_offset) {
395                         set->k = __btree_node_key_to_offset(b, k);
396                         bch2_btree_node_iter_sort(iter, b);
397                         return;
398                 }
399
400         bch2_btree_node_iter_push(iter, b, k, btree_bkey_last(b, t));
401 }
402
403 static void __bch2_btree_path_fix_key_modified(struct btree_path *path,
404                                                struct btree *b,
405                                                struct bkey_packed *where)
406 {
407         struct btree_path_level *l = &path->l[b->c.level];
408
409         if (where != bch2_btree_node_iter_peek_all(&l->iter, l->b))
410                 return;
411
412         if (bkey_iter_pos_cmp(l->b, where, &path->pos) < 0)
413                 bch2_btree_node_iter_advance(&l->iter, l->b);
414 }
415
416 void bch2_btree_path_fix_key_modified(struct btree_trans *trans,
417                                       struct btree *b,
418                                       struct bkey_packed *where)
419 {
420         struct btree_path *path;
421         unsigned i;
422
423         trans_for_each_path_with_node(trans, b, path, i) {
424                 __bch2_btree_path_fix_key_modified(path, b, where);
425                 bch2_btree_path_verify_level(trans, path, b->c.level);
426         }
427 }
428
429 static void __bch2_btree_node_iter_fix(struct btree_path *path,
430                                        struct btree *b,
431                                        struct btree_node_iter *node_iter,
432                                        struct bset_tree *t,
433                                        struct bkey_packed *where,
434                                        unsigned clobber_u64s,
435                                        unsigned new_u64s)
436 {
437         const struct bkey_packed *end = btree_bkey_last(b, t);
438         struct btree_node_iter_set *set;
439         unsigned offset = __btree_node_key_to_offset(b, where);
440         int shift = new_u64s - clobber_u64s;
441         unsigned old_end = t->end_offset - shift;
442         unsigned orig_iter_pos = node_iter->data[0].k;
443         bool iter_current_key_modified =
444                 orig_iter_pos >= offset &&
445                 orig_iter_pos <= offset + clobber_u64s;
446
447         btree_node_iter_for_each(node_iter, set)
448                 if (set->end == old_end)
449                         goto found;
450
451         /* didn't find the bset in the iterator - might have to readd it: */
452         if (new_u64s &&
453             bkey_iter_pos_cmp(b, where, &path->pos) >= 0) {
454                 bch2_btree_node_iter_push(node_iter, b, where, end);
455                 goto fixup_done;
456         } else {
457                 /* Iterator is after key that changed */
458                 return;
459         }
460 found:
461         set->end = t->end_offset;
462
463         /* Iterator hasn't gotten to the key that changed yet: */
464         if (set->k < offset)
465                 return;
466
467         if (new_u64s &&
468             bkey_iter_pos_cmp(b, where, &path->pos) >= 0) {
469                 set->k = offset;
470         } else if (set->k < offset + clobber_u64s) {
471                 set->k = offset + new_u64s;
472                 if (set->k == set->end)
473                         bch2_btree_node_iter_set_drop(node_iter, set);
474         } else {
475                 /* Iterator is after key that changed */
476                 set->k = (int) set->k + shift;
477                 return;
478         }
479
480         bch2_btree_node_iter_sort(node_iter, b);
481 fixup_done:
482         if (node_iter->data[0].k != orig_iter_pos)
483                 iter_current_key_modified = true;
484
485         /*
486          * When a new key is added, and the node iterator now points to that
487          * key, the iterator might have skipped past deleted keys that should
488          * come after the key the iterator now points to. We have to rewind to
489          * before those deleted keys - otherwise
490          * bch2_btree_node_iter_prev_all() breaks:
491          */
492         if (!bch2_btree_node_iter_end(node_iter) &&
493             iter_current_key_modified &&
494             b->c.level) {
495                 struct bkey_packed *k, *k2, *p;
496
497                 k = bch2_btree_node_iter_peek_all(node_iter, b);
498
499                 for_each_bset(b, t) {
500                         bool set_pos = false;
501
502                         if (node_iter->data[0].end == t->end_offset)
503                                 continue;
504
505                         k2 = bch2_btree_node_iter_bset_pos(node_iter, b, t);
506
507                         while ((p = bch2_bkey_prev_all(b, t, k2)) &&
508                                bkey_iter_cmp(b, k, p) < 0) {
509                                 k2 = p;
510                                 set_pos = true;
511                         }
512
513                         if (set_pos)
514                                 btree_node_iter_set_set_pos(node_iter,
515                                                             b, t, k2);
516                 }
517         }
518 }
519
520 void bch2_btree_node_iter_fix(struct btree_trans *trans,
521                               struct btree_path *path,
522                               struct btree *b,
523                               struct btree_node_iter *node_iter,
524                               struct bkey_packed *where,
525                               unsigned clobber_u64s,
526                               unsigned new_u64s)
527 {
528         struct bset_tree *t = bch2_bkey_to_bset_inlined(b, where);
529         struct btree_path *linked;
530         unsigned i;
531
532         if (node_iter != &path->l[b->c.level].iter) {
533                 __bch2_btree_node_iter_fix(path, b, node_iter, t,
534                                            where, clobber_u64s, new_u64s);
535
536                 if (bch2_debug_check_iterators)
537                         bch2_btree_node_iter_verify(node_iter, b);
538         }
539
540         trans_for_each_path_with_node(trans, b, linked, i) {
541                 __bch2_btree_node_iter_fix(linked, b,
542                                            &linked->l[b->c.level].iter, t,
543                                            where, clobber_u64s, new_u64s);
544                 bch2_btree_path_verify_level(trans, linked, b->c.level);
545         }
546 }
547
548 /* Btree path level: pointer to a particular btree node and node iter */
549
550 static inline struct bkey_s_c __btree_iter_unpack(struct bch_fs *c,
551                                                   struct btree_path_level *l,
552                                                   struct bkey *u,
553                                                   struct bkey_packed *k)
554 {
555         if (unlikely(!k)) {
556                 /*
557                  * signal to bch2_btree_iter_peek_slot() that we're currently at
558                  * a hole
559                  */
560                 u->type = KEY_TYPE_deleted;
561                 return bkey_s_c_null;
562         }
563
564         return bkey_disassemble(l->b, k, u);
565 }
566
567 static inline struct bkey_s_c btree_path_level_peek_all(struct bch_fs *c,
568                                                         struct btree_path_level *l,
569                                                         struct bkey *u)
570 {
571         return __btree_iter_unpack(c, l, u,
572                         bch2_btree_node_iter_peek_all(&l->iter, l->b));
573 }
574
575 static inline struct bkey_s_c btree_path_level_peek(struct btree_trans *trans,
576                                                     struct btree_path *path,
577                                                     struct btree_path_level *l,
578                                                     struct bkey *u)
579 {
580         struct bkey_s_c k = __btree_iter_unpack(trans->c, l, u,
581                         bch2_btree_node_iter_peek(&l->iter, l->b));
582
583         path->pos = k.k ? k.k->p : l->b->key.k.p;
584         trans->paths_sorted = false;
585         bch2_btree_path_verify_level(trans, path, l - path->l);
586         return k;
587 }
588
589 static inline struct bkey_s_c btree_path_level_prev(struct btree_trans *trans,
590                                                     struct btree_path *path,
591                                                     struct btree_path_level *l,
592                                                     struct bkey *u)
593 {
594         struct bkey_s_c k = __btree_iter_unpack(trans->c, l, u,
595                         bch2_btree_node_iter_prev(&l->iter, l->b));
596
597         path->pos = k.k ? k.k->p : l->b->data->min_key;
598         trans->paths_sorted = false;
599         bch2_btree_path_verify_level(trans, path, l - path->l);
600         return k;
601 }
602
603 static inline bool btree_path_advance_to_pos(struct btree_path *path,
604                                              struct btree_path_level *l,
605                                              int max_advance)
606 {
607         struct bkey_packed *k;
608         int nr_advanced = 0;
609
610         while ((k = bch2_btree_node_iter_peek_all(&l->iter, l->b)) &&
611                bkey_iter_pos_cmp(l->b, k, &path->pos) < 0) {
612                 if (max_advance > 0 && nr_advanced >= max_advance)
613                         return false;
614
615                 bch2_btree_node_iter_advance(&l->iter, l->b);
616                 nr_advanced++;
617         }
618
619         return true;
620 }
621
622 static inline void __btree_path_level_init(struct btree_path *path,
623                                            unsigned level)
624 {
625         struct btree_path_level *l = &path->l[level];
626
627         bch2_btree_node_iter_init(&l->iter, l->b, &path->pos);
628
629         /*
630          * Iterators to interior nodes should always be pointed at the first non
631          * whiteout:
632          */
633         if (level)
634                 bch2_btree_node_iter_peek(&l->iter, l->b);
635 }
636
637 void bch2_btree_path_level_init(struct btree_trans *trans,
638                                 struct btree_path *path,
639                                 struct btree *b)
640 {
641         BUG_ON(path->cached);
642
643         EBUG_ON(!btree_path_pos_in_node(path, b));
644
645         path->l[b->c.level].lock_seq = six_lock_seq(&b->c.lock);
646         path->l[b->c.level].b = b;
647         __btree_path_level_init(path, b->c.level);
648 }
649
650 /* Btree path: fixups after btree node updates: */
651
652 static void bch2_trans_revalidate_updates_in_node(struct btree_trans *trans, struct btree *b)
653 {
654         struct bch_fs *c = trans->c;
655
656         trans_for_each_update(trans, i)
657                 if (!i->cached &&
658                     i->level    == b->c.level &&
659                     i->btree_id == b->c.btree_id &&
660                     bpos_cmp(i->k->k.p, b->data->min_key) >= 0 &&
661                     bpos_cmp(i->k->k.p, b->data->max_key) <= 0) {
662                         i->old_v = bch2_btree_path_peek_slot(trans->paths + i->path, &i->old_k).v;
663
664                         if (unlikely(trans->journal_replay_not_finished)) {
665                                 struct bkey_i *j_k =
666                                         bch2_journal_keys_peek_slot(c, i->btree_id, i->level,
667                                                                     i->k->k.p);
668
669                                 if (j_k) {
670                                         i->old_k = j_k->k;
671                                         i->old_v = &j_k->v;
672                                 }
673                         }
674                 }
675 }
676
677 /*
678  * A btree node is being replaced - update the iterator to point to the new
679  * node:
680  */
681 void bch2_trans_node_add(struct btree_trans *trans,
682                          struct btree_path *path,
683                          struct btree *b)
684 {
685         struct btree_path *prev;
686
687         BUG_ON(!btree_path_pos_in_node(path, b));
688
689         while ((prev = prev_btree_path(trans, path)) &&
690                btree_path_pos_in_node(prev, b))
691                 path = prev;
692
693         for (;
694              path && btree_path_pos_in_node(path, b);
695              path = next_btree_path(trans, path))
696                 if (path->uptodate == BTREE_ITER_UPTODATE && !path->cached) {
697                         enum btree_node_locked_type t =
698                                 btree_lock_want(path, b->c.level);
699
700                         if (t != BTREE_NODE_UNLOCKED) {
701                                 btree_node_unlock(trans, path, b->c.level);
702                                 six_lock_increment(&b->c.lock, (enum six_lock_type) t);
703                                 mark_btree_node_locked(trans, path, b->c.level, t);
704                         }
705
706                         bch2_btree_path_level_init(trans, path, b);
707                 }
708
709         bch2_trans_revalidate_updates_in_node(trans, b);
710 }
711
712 /*
713  * A btree node has been modified in such a way as to invalidate iterators - fix
714  * them:
715  */
716 void bch2_trans_node_reinit_iter(struct btree_trans *trans, struct btree *b)
717 {
718         struct btree_path *path;
719         unsigned i;
720
721         trans_for_each_path_with_node(trans, b, path, i)
722                 __btree_path_level_init(path, b->c.level);
723
724         bch2_trans_revalidate_updates_in_node(trans, b);
725 }
726
727 /* Btree path: traverse, set_pos: */
728
729 static inline int btree_path_lock_root(struct btree_trans *trans,
730                                        struct btree_path *path,
731                                        unsigned depth_want,
732                                        unsigned long trace_ip)
733 {
734         struct bch_fs *c = trans->c;
735         struct btree *b, **rootp = &bch2_btree_id_root(c, path->btree_id)->b;
736         enum six_lock_type lock_type;
737         unsigned i;
738         int ret;
739
740         EBUG_ON(path->nodes_locked);
741
742         while (1) {
743                 b = READ_ONCE(*rootp);
744                 path->level = READ_ONCE(b->c.level);
745
746                 if (unlikely(path->level < depth_want)) {
747                         /*
748                          * the root is at a lower depth than the depth we want:
749                          * got to the end of the btree, or we're walking nodes
750                          * greater than some depth and there are no nodes >=
751                          * that depth
752                          */
753                         path->level = depth_want;
754                         for (i = path->level; i < BTREE_MAX_DEPTH; i++)
755                                 path->l[i].b = NULL;
756                         return 1;
757                 }
758
759                 lock_type = __btree_lock_want(path, path->level);
760                 ret = btree_node_lock(trans, path, &b->c,
761                                       path->level, lock_type, trace_ip);
762                 if (unlikely(ret)) {
763                         if (bch2_err_matches(ret, BCH_ERR_lock_fail_root_changed))
764                                 continue;
765                         if (bch2_err_matches(ret, BCH_ERR_transaction_restart))
766                                 return ret;
767                         BUG();
768                 }
769
770                 if (likely(b == READ_ONCE(*rootp) &&
771                            b->c.level == path->level &&
772                            !race_fault())) {
773                         for (i = 0; i < path->level; i++)
774                                 path->l[i].b = ERR_PTR(-BCH_ERR_no_btree_node_lock_root);
775                         path->l[path->level].b = b;
776                         for (i = path->level + 1; i < BTREE_MAX_DEPTH; i++)
777                                 path->l[i].b = NULL;
778
779                         mark_btree_node_locked(trans, path, path->level,
780                                                (enum btree_node_locked_type) lock_type);
781                         bch2_btree_path_level_init(trans, path, b);
782                         return 0;
783                 }
784
785                 six_unlock_type(&b->c.lock, lock_type);
786         }
787 }
788
789 noinline
790 static int btree_path_prefetch(struct btree_trans *trans, struct btree_path *path)
791 {
792         struct bch_fs *c = trans->c;
793         struct btree_path_level *l = path_l(path);
794         struct btree_node_iter node_iter = l->iter;
795         struct bkey_packed *k;
796         struct bkey_buf tmp;
797         unsigned nr = test_bit(BCH_FS_started, &c->flags)
798                 ? (path->level > 1 ? 0 :  2)
799                 : (path->level > 1 ? 1 : 16);
800         bool was_locked = btree_node_locked(path, path->level);
801         int ret = 0;
802
803         bch2_bkey_buf_init(&tmp);
804
805         while (nr-- && !ret) {
806                 if (!bch2_btree_node_relock(trans, path, path->level))
807                         break;
808
809                 bch2_btree_node_iter_advance(&node_iter, l->b);
810                 k = bch2_btree_node_iter_peek(&node_iter, l->b);
811                 if (!k)
812                         break;
813
814                 bch2_bkey_buf_unpack(&tmp, c, l->b, k);
815                 ret = bch2_btree_node_prefetch(trans, path, tmp.k, path->btree_id,
816                                                path->level - 1);
817         }
818
819         if (!was_locked)
820                 btree_node_unlock(trans, path, path->level);
821
822         bch2_bkey_buf_exit(&tmp, c);
823         return ret;
824 }
825
826 static int btree_path_prefetch_j(struct btree_trans *trans, struct btree_path *path,
827                                  struct btree_and_journal_iter *jiter)
828 {
829         struct bch_fs *c = trans->c;
830         struct bkey_s_c k;
831         struct bkey_buf tmp;
832         unsigned nr = test_bit(BCH_FS_started, &c->flags)
833                 ? (path->level > 1 ? 0 :  2)
834                 : (path->level > 1 ? 1 : 16);
835         bool was_locked = btree_node_locked(path, path->level);
836         int ret = 0;
837
838         bch2_bkey_buf_init(&tmp);
839
840         while (nr-- && !ret) {
841                 if (!bch2_btree_node_relock(trans, path, path->level))
842                         break;
843
844                 bch2_btree_and_journal_iter_advance(jiter);
845                 k = bch2_btree_and_journal_iter_peek(jiter);
846                 if (!k.k)
847                         break;
848
849                 bch2_bkey_buf_reassemble(&tmp, c, k);
850                 ret = bch2_btree_node_prefetch(trans, path, tmp.k, path->btree_id,
851                                                path->level - 1);
852         }
853
854         if (!was_locked)
855                 btree_node_unlock(trans, path, path->level);
856
857         bch2_bkey_buf_exit(&tmp, c);
858         return ret;
859 }
860
861 static noinline void btree_node_mem_ptr_set(struct btree_trans *trans,
862                                             struct btree_path *path,
863                                             unsigned plevel, struct btree *b)
864 {
865         struct btree_path_level *l = &path->l[plevel];
866         bool locked = btree_node_locked(path, plevel);
867         struct bkey_packed *k;
868         struct bch_btree_ptr_v2 *bp;
869
870         if (!bch2_btree_node_relock(trans, path, plevel))
871                 return;
872
873         k = bch2_btree_node_iter_peek_all(&l->iter, l->b);
874         BUG_ON(k->type != KEY_TYPE_btree_ptr_v2);
875
876         bp = (void *) bkeyp_val(&l->b->format, k);
877         bp->mem_ptr = (unsigned long)b;
878
879         if (!locked)
880                 btree_node_unlock(trans, path, plevel);
881 }
882
883 static noinline int btree_node_iter_and_journal_peek(struct btree_trans *trans,
884                                                      struct btree_path *path,
885                                                      unsigned flags,
886                                                      struct bkey_buf *out)
887 {
888         struct bch_fs *c = trans->c;
889         struct btree_path_level *l = path_l(path);
890         struct btree_and_journal_iter jiter;
891         struct bkey_s_c k;
892         int ret = 0;
893
894         __bch2_btree_and_journal_iter_init_node_iter(&jiter, c, l->b, l->iter, path->pos);
895
896         k = bch2_btree_and_journal_iter_peek(&jiter);
897
898         bch2_bkey_buf_reassemble(out, c, k);
899
900         if (flags & BTREE_ITER_PREFETCH)
901                 ret = btree_path_prefetch_j(trans, path, &jiter);
902
903         bch2_btree_and_journal_iter_exit(&jiter);
904         return ret;
905 }
906
907 static __always_inline int btree_path_down(struct btree_trans *trans,
908                                            struct btree_path *path,
909                                            unsigned flags,
910                                            unsigned long trace_ip)
911 {
912         struct bch_fs *c = trans->c;
913         struct btree_path_level *l = path_l(path);
914         struct btree *b;
915         unsigned level = path->level - 1;
916         enum six_lock_type lock_type = __btree_lock_want(path, level);
917         struct bkey_buf tmp;
918         int ret;
919
920         EBUG_ON(!btree_node_locked(path, path->level));
921
922         bch2_bkey_buf_init(&tmp);
923
924         if (unlikely(trans->journal_replay_not_finished)) {
925                 ret = btree_node_iter_and_journal_peek(trans, path, flags, &tmp);
926                 if (ret)
927                         goto err;
928         } else {
929                 bch2_bkey_buf_unpack(&tmp, c, l->b,
930                                  bch2_btree_node_iter_peek(&l->iter, l->b));
931
932                 if (flags & BTREE_ITER_PREFETCH) {
933                         ret = btree_path_prefetch(trans, path);
934                         if (ret)
935                                 goto err;
936                 }
937         }
938
939         b = bch2_btree_node_get(trans, path, tmp.k, level, lock_type, trace_ip);
940         ret = PTR_ERR_OR_ZERO(b);
941         if (unlikely(ret))
942                 goto err;
943
944         if (likely(!trans->journal_replay_not_finished &&
945                    tmp.k->k.type == KEY_TYPE_btree_ptr_v2) &&
946             unlikely(b != btree_node_mem_ptr(tmp.k)))
947                 btree_node_mem_ptr_set(trans, path, level + 1, b);
948
949         if (btree_node_read_locked(path, level + 1))
950                 btree_node_unlock(trans, path, level + 1);
951
952         mark_btree_node_locked(trans, path, level,
953                                (enum btree_node_locked_type) lock_type);
954         path->level = level;
955         bch2_btree_path_level_init(trans, path, b);
956
957         bch2_btree_path_verify_locks(path);
958 err:
959         bch2_bkey_buf_exit(&tmp, c);
960         return ret;
961 }
962
963
964 static int bch2_btree_path_traverse_all(struct btree_trans *trans)
965 {
966         struct bch_fs *c = trans->c;
967         struct btree_path *path;
968         unsigned long trace_ip = _RET_IP_;
969         unsigned i;
970         int ret = 0;
971
972         if (trans->in_traverse_all)
973                 return -BCH_ERR_transaction_restart_in_traverse_all;
974
975         trans->in_traverse_all = true;
976 retry_all:
977         trans->restarted = 0;
978         trans->last_restarted_ip = 0;
979
980         trans_for_each_path(trans, path, i)
981                 path->should_be_locked = false;
982
983         btree_trans_sort_paths(trans);
984
985         bch2_trans_unlock(trans);
986         cond_resched();
987
988         if (unlikely(trans->memory_allocation_failure)) {
989                 struct closure cl;
990
991                 closure_init_stack(&cl);
992
993                 do {
994                         ret = bch2_btree_cache_cannibalize_lock(trans, &cl);
995                         closure_sync(&cl);
996                 } while (ret);
997         }
998
999         /* Now, redo traversals in correct order: */
1000         i = 0;
1001         while (i < trans->nr_sorted) {
1002                 btree_path_idx_t idx = trans->sorted[i];
1003
1004                 /*
1005                  * Traversing a path can cause another path to be added at about
1006                  * the same position:
1007                  */
1008                 if (trans->paths[idx].uptodate) {
1009                         __btree_path_get(&trans->paths[idx], false);
1010                         ret = bch2_btree_path_traverse_one(trans, idx, 0, _THIS_IP_);
1011                         __btree_path_put(&trans->paths[idx], false);
1012
1013                         if (bch2_err_matches(ret, BCH_ERR_transaction_restart) ||
1014                             bch2_err_matches(ret, ENOMEM))
1015                                 goto retry_all;
1016                         if (ret)
1017                                 goto err;
1018                 } else {
1019                         i++;
1020                 }
1021         }
1022
1023         /*
1024          * We used to assert that all paths had been traversed here
1025          * (path->uptodate < BTREE_ITER_NEED_TRAVERSE); however, since
1026          * path->should_be_locked is not set yet, we might have unlocked and
1027          * then failed to relock a path - that's fine.
1028          */
1029 err:
1030         bch2_btree_cache_cannibalize_unlock(trans);
1031
1032         trans->in_traverse_all = false;
1033
1034         trace_and_count(c, trans_traverse_all, trans, trace_ip);
1035         return ret;
1036 }
1037
1038 static inline bool btree_path_check_pos_in_node(struct btree_path *path,
1039                                                 unsigned l, int check_pos)
1040 {
1041         if (check_pos < 0 && btree_path_pos_before_node(path, path->l[l].b))
1042                 return false;
1043         if (check_pos > 0 && btree_path_pos_after_node(path, path->l[l].b))
1044                 return false;
1045         return true;
1046 }
1047
1048 static inline bool btree_path_good_node(struct btree_trans *trans,
1049                                         struct btree_path *path,
1050                                         unsigned l, int check_pos)
1051 {
1052         return is_btree_node(path, l) &&
1053                 bch2_btree_node_relock(trans, path, l) &&
1054                 btree_path_check_pos_in_node(path, l, check_pos);
1055 }
1056
1057 static void btree_path_set_level_down(struct btree_trans *trans,
1058                                       struct btree_path *path,
1059                                       unsigned new_level)
1060 {
1061         unsigned l;
1062
1063         path->level = new_level;
1064
1065         for (l = path->level + 1; l < BTREE_MAX_DEPTH; l++)
1066                 if (btree_lock_want(path, l) == BTREE_NODE_UNLOCKED)
1067                         btree_node_unlock(trans, path, l);
1068
1069         btree_path_set_dirty(path, BTREE_ITER_NEED_TRAVERSE);
1070         bch2_btree_path_verify(trans, path);
1071 }
1072
1073 static noinline unsigned __btree_path_up_until_good_node(struct btree_trans *trans,
1074                                                          struct btree_path *path,
1075                                                          int check_pos)
1076 {
1077         unsigned i, l = path->level;
1078 again:
1079         while (btree_path_node(path, l) &&
1080                !btree_path_good_node(trans, path, l, check_pos))
1081                 __btree_path_set_level_up(trans, path, l++);
1082
1083         /* If we need intent locks, take them too: */
1084         for (i = l + 1;
1085              i < path->locks_want && btree_path_node(path, i);
1086              i++)
1087                 if (!bch2_btree_node_relock(trans, path, i)) {
1088                         while (l <= i)
1089                                 __btree_path_set_level_up(trans, path, l++);
1090                         goto again;
1091                 }
1092
1093         return l;
1094 }
1095
1096 static inline unsigned btree_path_up_until_good_node(struct btree_trans *trans,
1097                                                      struct btree_path *path,
1098                                                      int check_pos)
1099 {
1100         return likely(btree_node_locked(path, path->level) &&
1101                       btree_path_check_pos_in_node(path, path->level, check_pos))
1102                 ? path->level
1103                 : __btree_path_up_until_good_node(trans, path, check_pos);
1104 }
1105
1106 /*
1107  * This is the main state machine for walking down the btree - walks down to a
1108  * specified depth
1109  *
1110  * Returns 0 on success, -EIO on error (error reading in a btree node).
1111  *
1112  * On error, caller (peek_node()/peek_key()) must return NULL; the error is
1113  * stashed in the iterator and returned from bch2_trans_exit().
1114  */
1115 int bch2_btree_path_traverse_one(struct btree_trans *trans,
1116                                  btree_path_idx_t path_idx,
1117                                  unsigned flags,
1118                                  unsigned long trace_ip)
1119 {
1120         struct btree_path *path = &trans->paths[path_idx];
1121         unsigned depth_want = path->level;
1122         int ret = -((int) trans->restarted);
1123
1124         if (unlikely(ret))
1125                 goto out;
1126
1127         if (unlikely(!trans->srcu_held))
1128                 bch2_trans_srcu_lock(trans);
1129
1130         /*
1131          * Ensure we obey path->should_be_locked: if it's set, we can't unlock
1132          * and re-traverse the path without a transaction restart:
1133          */
1134         if (path->should_be_locked) {
1135                 ret = bch2_btree_path_relock(trans, path, trace_ip);
1136                 goto out;
1137         }
1138
1139         if (path->cached) {
1140                 ret = bch2_btree_path_traverse_cached(trans, path, flags);
1141                 goto out;
1142         }
1143
1144         path = &trans->paths[path_idx];
1145
1146         if (unlikely(path->level >= BTREE_MAX_DEPTH))
1147                 goto out;
1148
1149         path->level = btree_path_up_until_good_node(trans, path, 0);
1150
1151         EBUG_ON(btree_path_node(path, path->level) &&
1152                 !btree_node_locked(path, path->level));
1153
1154         /*
1155          * Note: path->nodes[path->level] may be temporarily NULL here - that
1156          * would indicate to other code that we got to the end of the btree,
1157          * here it indicates that relocking the root failed - it's critical that
1158          * btree_path_lock_root() comes next and that it can't fail
1159          */
1160         while (path->level > depth_want) {
1161                 ret = btree_path_node(path, path->level)
1162                         ? btree_path_down(trans, path, flags, trace_ip)
1163                         : btree_path_lock_root(trans, path, depth_want, trace_ip);
1164                 if (unlikely(ret)) {
1165                         if (ret == 1) {
1166                                 /*
1167                                  * No nodes at this level - got to the end of
1168                                  * the btree:
1169                                  */
1170                                 ret = 0;
1171                                 goto out;
1172                         }
1173
1174                         __bch2_btree_path_unlock(trans, path);
1175                         path->level = depth_want;
1176                         path->l[path->level].b = ERR_PTR(ret);
1177                         goto out;
1178                 }
1179         }
1180
1181         path->uptodate = BTREE_ITER_UPTODATE;
1182 out:
1183         if (bch2_err_matches(ret, BCH_ERR_transaction_restart) != !!trans->restarted)
1184                 panic("ret %s (%i) trans->restarted %s (%i)\n",
1185                       bch2_err_str(ret), ret,
1186                       bch2_err_str(trans->restarted), trans->restarted);
1187         bch2_btree_path_verify(trans, path);
1188         return ret;
1189 }
1190
1191 static inline void btree_path_copy(struct btree_trans *trans, struct btree_path *dst,
1192                             struct btree_path *src)
1193 {
1194         unsigned i, offset = offsetof(struct btree_path, pos);
1195
1196         memcpy((void *) dst + offset,
1197                (void *) src + offset,
1198                sizeof(struct btree_path) - offset);
1199
1200         for (i = 0; i < BTREE_MAX_DEPTH; i++) {
1201                 unsigned t = btree_node_locked_type(dst, i);
1202
1203                 if (t != BTREE_NODE_UNLOCKED)
1204                         six_lock_increment(&dst->l[i].b->c.lock, t);
1205         }
1206 }
1207
1208 static btree_path_idx_t btree_path_clone(struct btree_trans *trans, btree_path_idx_t src,
1209                                          bool intent)
1210 {
1211         btree_path_idx_t new = btree_path_alloc(trans, src);
1212
1213         btree_path_copy(trans, trans->paths + new, trans->paths + src);
1214         __btree_path_get(trans->paths + new, intent);
1215         return new;
1216 }
1217
1218 __flatten
1219 btree_path_idx_t __bch2_btree_path_make_mut(struct btree_trans *trans,
1220                         btree_path_idx_t path, bool intent, unsigned long ip)
1221 {
1222         __btree_path_put(trans->paths + path, intent);
1223         path = btree_path_clone(trans, path, intent);
1224         trans->paths[path].preserve = false;
1225         return path;
1226 }
1227
1228 btree_path_idx_t __must_check
1229 __bch2_btree_path_set_pos(struct btree_trans *trans,
1230                           btree_path_idx_t path_idx, struct bpos new_pos,
1231                           bool intent, unsigned long ip)
1232 {
1233         int cmp = bpos_cmp(new_pos, trans->paths[path_idx].pos);
1234
1235         bch2_trans_verify_not_in_restart(trans);
1236         EBUG_ON(!trans->paths[path_idx].ref);
1237
1238         path_idx = bch2_btree_path_make_mut(trans, path_idx, intent, ip);
1239
1240         struct btree_path *path = trans->paths + path_idx;
1241         path->pos               = new_pos;
1242         trans->paths_sorted     = false;
1243
1244         if (unlikely(path->cached)) {
1245                 btree_node_unlock(trans, path, 0);
1246                 path->l[0].b = ERR_PTR(-BCH_ERR_no_btree_node_up);
1247                 btree_path_set_dirty(path, BTREE_ITER_NEED_TRAVERSE);
1248                 goto out;
1249         }
1250
1251         unsigned level = btree_path_up_until_good_node(trans, path, cmp);
1252
1253         if (btree_path_node(path, level)) {
1254                 struct btree_path_level *l = &path->l[level];
1255
1256                 BUG_ON(!btree_node_locked(path, level));
1257                 /*
1258                  * We might have to skip over many keys, or just a few: try
1259                  * advancing the node iterator, and if we have to skip over too
1260                  * many keys just reinit it (or if we're rewinding, since that
1261                  * is expensive).
1262                  */
1263                 if (cmp < 0 ||
1264                     !btree_path_advance_to_pos(path, l, 8))
1265                         bch2_btree_node_iter_init(&l->iter, l->b, &path->pos);
1266
1267                 /*
1268                  * Iterators to interior nodes should always be pointed at the first non
1269                  * whiteout:
1270                  */
1271                 if (unlikely(level))
1272                         bch2_btree_node_iter_peek(&l->iter, l->b);
1273         }
1274
1275         if (unlikely(level != path->level)) {
1276                 btree_path_set_dirty(path, BTREE_ITER_NEED_TRAVERSE);
1277                 __bch2_btree_path_unlock(trans, path);
1278         }
1279 out:
1280         bch2_btree_path_verify(trans, path);
1281         return path_idx;
1282 }
1283
1284 /* Btree path: main interface: */
1285
1286 static struct btree_path *have_path_at_pos(struct btree_trans *trans, struct btree_path *path)
1287 {
1288         struct btree_path *sib;
1289
1290         sib = prev_btree_path(trans, path);
1291         if (sib && !btree_path_cmp(sib, path))
1292                 return sib;
1293
1294         sib = next_btree_path(trans, path);
1295         if (sib && !btree_path_cmp(sib, path))
1296                 return sib;
1297
1298         return NULL;
1299 }
1300
1301 static struct btree_path *have_node_at_pos(struct btree_trans *trans, struct btree_path *path)
1302 {
1303         struct btree_path *sib;
1304
1305         sib = prev_btree_path(trans, path);
1306         if (sib && sib->level == path->level && path_l(sib)->b == path_l(path)->b)
1307                 return sib;
1308
1309         sib = next_btree_path(trans, path);
1310         if (sib && sib->level == path->level && path_l(sib)->b == path_l(path)->b)
1311                 return sib;
1312
1313         return NULL;
1314 }
1315
1316 static inline void __bch2_path_free(struct btree_trans *trans, btree_path_idx_t path)
1317 {
1318         __bch2_btree_path_unlock(trans, trans->paths + path);
1319         btree_path_list_remove(trans, trans->paths + path);
1320         __clear_bit(path, trans->paths_allocated);
1321 }
1322
1323 void bch2_path_put(struct btree_trans *trans, btree_path_idx_t path_idx, bool intent)
1324 {
1325         struct btree_path *path = trans->paths + path_idx, *dup;
1326
1327         if (!__btree_path_put(path, intent))
1328                 return;
1329
1330         dup = path->preserve
1331                 ? have_path_at_pos(trans, path)
1332                 : have_node_at_pos(trans, path);
1333
1334         if (!dup && !(!path->preserve && !is_btree_node(path, path->level)))
1335                 return;
1336
1337         if (path->should_be_locked &&
1338             !trans->restarted &&
1339             (!dup || !bch2_btree_path_relock_norestart(trans, dup, _THIS_IP_)))
1340                 return;
1341
1342         if (dup) {
1343                 dup->preserve           |= path->preserve;
1344                 dup->should_be_locked   |= path->should_be_locked;
1345         }
1346
1347         __bch2_path_free(trans, path_idx);
1348 }
1349
1350 static void bch2_path_put_nokeep(struct btree_trans *trans, btree_path_idx_t path,
1351                                  bool intent)
1352 {
1353         if (!__btree_path_put(trans->paths + path, intent))
1354                 return;
1355
1356         __bch2_path_free(trans, path);
1357 }
1358
1359 void __noreturn bch2_trans_restart_error(struct btree_trans *trans, u32 restart_count)
1360 {
1361         panic("trans->restart_count %u, should be %u, last restarted by %pS\n",
1362               trans->restart_count, restart_count,
1363               (void *) trans->last_begin_ip);
1364 }
1365
1366 void __noreturn bch2_trans_in_restart_error(struct btree_trans *trans)
1367 {
1368         panic("in transaction restart: %s, last restarted by %pS\n",
1369               bch2_err_str(trans->restarted),
1370               (void *) trans->last_restarted_ip);
1371 }
1372
1373 noinline __cold
1374 void bch2_trans_updates_to_text(struct printbuf *buf, struct btree_trans *trans)
1375 {
1376         prt_printf(buf, "transaction updates for %s journal seq %llu",
1377                trans->fn, trans->journal_res.seq);
1378         prt_newline(buf);
1379         printbuf_indent_add(buf, 2);
1380
1381         trans_for_each_update(trans, i) {
1382                 struct bkey_s_c old = { &i->old_k, i->old_v };
1383
1384                 prt_printf(buf, "update: btree=%s cached=%u %pS",
1385                        bch2_btree_id_str(i->btree_id),
1386                        i->cached,
1387                        (void *) i->ip_allocated);
1388                 prt_newline(buf);
1389
1390                 prt_printf(buf, "  old ");
1391                 bch2_bkey_val_to_text(buf, trans->c, old);
1392                 prt_newline(buf);
1393
1394                 prt_printf(buf, "  new ");
1395                 bch2_bkey_val_to_text(buf, trans->c, bkey_i_to_s_c(i->k));
1396                 prt_newline(buf);
1397         }
1398
1399         for (struct jset_entry *e = trans->journal_entries;
1400              e != btree_trans_journal_entries_top(trans);
1401              e = vstruct_next(e))
1402                 bch2_journal_entry_to_text(buf, trans->c, e);
1403
1404         printbuf_indent_sub(buf, 2);
1405 }
1406
1407 noinline __cold
1408 void bch2_dump_trans_updates(struct btree_trans *trans)
1409 {
1410         struct printbuf buf = PRINTBUF;
1411
1412         bch2_trans_updates_to_text(&buf, trans);
1413         bch2_print_string_as_lines(KERN_ERR, buf.buf);
1414         printbuf_exit(&buf);
1415 }
1416
1417 static void bch2_btree_path_to_text(struct printbuf *out, struct btree_trans *trans, btree_path_idx_t path_idx)
1418 {
1419         struct btree_path *path = trans->paths + path_idx;
1420
1421         prt_printf(out, "path: idx %2u ref %u:%u %c %c btree=%s l=%u pos ",
1422                    path_idx, path->ref, path->intent_ref,
1423                    path->preserve ? 'P' : ' ',
1424                    path->should_be_locked ? 'S' : ' ',
1425                    bch2_btree_id_str(path->btree_id),
1426                    path->level);
1427         bch2_bpos_to_text(out, path->pos);
1428
1429         prt_printf(out, " locks %u", path->nodes_locked);
1430 #ifdef TRACK_PATH_ALLOCATED
1431         prt_printf(out, " %pS", (void *) path->ip_allocated);
1432 #endif
1433         prt_newline(out);
1434 }
1435
1436 static noinline __cold
1437 void __bch2_trans_paths_to_text(struct printbuf *out, struct btree_trans *trans,
1438                                 bool nosort)
1439 {
1440         struct trans_for_each_path_inorder_iter iter;
1441
1442         if (!nosort)
1443                 btree_trans_sort_paths(trans);
1444
1445         trans_for_each_path_idx_inorder(trans, iter)
1446                 bch2_btree_path_to_text(out, trans, iter.path_idx);
1447 }
1448
1449 noinline __cold
1450 void bch2_trans_paths_to_text(struct printbuf *out, struct btree_trans *trans)
1451 {
1452         __bch2_trans_paths_to_text(out, trans, false);
1453 }
1454
1455 static noinline __cold
1456 void __bch2_dump_trans_paths_updates(struct btree_trans *trans, bool nosort)
1457 {
1458         struct printbuf buf = PRINTBUF;
1459
1460         __bch2_trans_paths_to_text(&buf, trans, nosort);
1461         bch2_trans_updates_to_text(&buf, trans);
1462
1463         bch2_print_string_as_lines(KERN_ERR, buf.buf);
1464         printbuf_exit(&buf);
1465 }
1466
1467 noinline __cold
1468 void bch2_dump_trans_paths_updates(struct btree_trans *trans)
1469 {
1470         __bch2_dump_trans_paths_updates(trans, false);
1471 }
1472
1473 noinline __cold
1474 static void bch2_trans_update_max_paths(struct btree_trans *trans)
1475 {
1476         struct btree_transaction_stats *s = btree_trans_stats(trans);
1477         struct printbuf buf = PRINTBUF;
1478         size_t nr = bitmap_weight(trans->paths_allocated, trans->nr_paths);
1479
1480         if (!s)
1481                 return;
1482
1483         bch2_trans_paths_to_text(&buf, trans);
1484
1485         if (!buf.allocation_failure) {
1486                 mutex_lock(&s->lock);
1487                 if (nr > s->nr_max_paths) {
1488                         s->nr_max_paths = nr;
1489                         swap(s->max_paths_text, buf.buf);
1490                 }
1491                 mutex_unlock(&s->lock);
1492         }
1493
1494         printbuf_exit(&buf);
1495
1496         trans->nr_paths_max = nr;
1497 }
1498
1499 noinline __cold
1500 int __bch2_btree_trans_too_many_iters(struct btree_trans *trans)
1501 {
1502         if (trace_trans_restart_too_many_iters_enabled()) {
1503                 struct printbuf buf = PRINTBUF;
1504
1505                 bch2_trans_paths_to_text(&buf, trans);
1506                 trace_trans_restart_too_many_iters(trans, _THIS_IP_, buf.buf);
1507                 printbuf_exit(&buf);
1508         }
1509
1510         count_event(trans->c, trans_restart_too_many_iters);
1511
1512         return btree_trans_restart(trans, BCH_ERR_transaction_restart_too_many_iters);
1513 }
1514
1515 static noinline void btree_paths_realloc(struct btree_trans *trans)
1516 {
1517         unsigned nr = trans->nr_paths * 2;
1518
1519         void *p = kzalloc(BITS_TO_LONGS(nr) * sizeof(unsigned long) +
1520                           nr + 8 +
1521                           sizeof(struct btree_trans_paths) +
1522                           nr * sizeof(struct btree_path) +
1523                           nr * sizeof(struct btree_insert_entry), GFP_KERNEL|__GFP_NOFAIL);
1524
1525         unsigned long *paths_allocated = p;
1526         p += BITS_TO_LONGS(nr) * sizeof(unsigned long);
1527         struct btree_path *paths = p;
1528         p += nr * sizeof(struct btree_path);
1529         u8 *sorted = p;
1530         p += nr + 8;
1531         struct btree_insert_entry *updates = p;
1532
1533         *trans_paths_nr(paths) = nr;
1534
1535         memcpy(paths_allocated, trans->paths_allocated, BITS_TO_LONGS(trans->nr_paths) * sizeof(unsigned long));
1536         memcpy(sorted, trans->sorted, trans->nr_sorted);
1537         memcpy(paths, trans->paths, trans->nr_paths * sizeof(struct btree_path));
1538         memcpy(updates, trans->updates, trans->nr_paths * sizeof(struct btree_path));
1539
1540         unsigned long *old = trans->paths_allocated;
1541
1542         rcu_assign_pointer(trans->paths_allocated,      paths_allocated);
1543         rcu_assign_pointer(trans->sorted,               sorted);
1544         rcu_assign_pointer(trans->paths,                paths);
1545         rcu_assign_pointer(trans->updates,              updates);
1546
1547         trans->nr_paths         = nr;
1548
1549         if (old != trans->_paths_allocated)
1550                 kfree_rcu_mightsleep(trans->paths_allocated);
1551 }
1552
1553 static inline btree_path_idx_t btree_path_alloc(struct btree_trans *trans,
1554                                                 btree_path_idx_t pos)
1555 {
1556         btree_path_idx_t idx = find_first_zero_bit(trans->paths_allocated, trans->nr_paths);
1557
1558         if (unlikely(idx == trans->nr_paths))
1559                 btree_paths_realloc(trans);
1560
1561         /*
1562          * Do this before marking the new path as allocated, since it won't be
1563          * initialized yet:
1564          */
1565         if (unlikely(idx > trans->nr_paths_max))
1566                 bch2_trans_update_max_paths(trans);
1567
1568         __set_bit(idx, trans->paths_allocated);
1569
1570         struct btree_path *path = &trans->paths[idx];
1571         path->ref               = 0;
1572         path->intent_ref        = 0;
1573         path->nodes_locked      = 0;
1574
1575         btree_path_list_add(trans, pos, idx);
1576         trans->paths_sorted = false;
1577         return idx;
1578 }
1579
1580 btree_path_idx_t bch2_path_get(struct btree_trans *trans,
1581                              enum btree_id btree_id, struct bpos pos,
1582                              unsigned locks_want, unsigned level,
1583                              unsigned flags, unsigned long ip)
1584 {
1585         struct btree_path *path;
1586         bool cached = flags & BTREE_ITER_CACHED;
1587         bool intent = flags & BTREE_ITER_INTENT;
1588         struct trans_for_each_path_inorder_iter iter;
1589         btree_path_idx_t path_pos = 0, path_idx;
1590
1591         bch2_trans_verify_not_in_restart(trans);
1592         bch2_trans_verify_locks(trans);
1593
1594         btree_trans_sort_paths(trans);
1595
1596         trans_for_each_path_inorder(trans, path, iter) {
1597                 if (__btree_path_cmp(path,
1598                                      btree_id,
1599                                      cached,
1600                                      pos,
1601                                      level) > 0)
1602                         break;
1603
1604                 path_pos = iter.path_idx;
1605         }
1606
1607         if (path_pos &&
1608             trans->paths[path_pos].cached       == cached &&
1609             trans->paths[path_pos].btree_id     == btree_id &&
1610             trans->paths[path_pos].level        == level) {
1611                 __btree_path_get(trans->paths + path_pos, intent);
1612                 path_idx = bch2_btree_path_set_pos(trans, path_pos, pos, intent, ip);
1613                 path = trans->paths + path_idx;
1614         } else {
1615                 path_idx = btree_path_alloc(trans, path_pos);
1616                 path = trans->paths + path_idx;
1617
1618                 __btree_path_get(path, intent);
1619                 path->pos                       = pos;
1620                 path->btree_id                  = btree_id;
1621                 path->cached                    = cached;
1622                 path->uptodate                  = BTREE_ITER_NEED_TRAVERSE;
1623                 path->should_be_locked          = false;
1624                 path->level                     = level;
1625                 path->locks_want                = locks_want;
1626                 path->nodes_locked              = 0;
1627                 for (unsigned i = 0; i < ARRAY_SIZE(path->l); i++)
1628                         path->l[i].b            = ERR_PTR(-BCH_ERR_no_btree_node_init);
1629 #ifdef TRACK_PATH_ALLOCATED
1630                 path->ip_allocated              = ip;
1631 #endif
1632                 trans->paths_sorted             = false;
1633         }
1634
1635         if (!(flags & BTREE_ITER_NOPRESERVE))
1636                 path->preserve = true;
1637
1638         if (path->intent_ref)
1639                 locks_want = max(locks_want, level + 1);
1640
1641         /*
1642          * If the path has locks_want greater than requested, we don't downgrade
1643          * it here - on transaction restart because btree node split needs to
1644          * upgrade locks, we might be putting/getting the iterator again.
1645          * Downgrading iterators only happens via bch2_trans_downgrade(), after
1646          * a successful transaction commit.
1647          */
1648
1649         locks_want = min(locks_want, BTREE_MAX_DEPTH);
1650         if (locks_want > path->locks_want)
1651                 bch2_btree_path_upgrade_noupgrade_sibs(trans, path, locks_want, NULL);
1652
1653         return path_idx;
1654 }
1655
1656 struct bkey_s_c bch2_btree_path_peek_slot(struct btree_path *path, struct bkey *u)
1657 {
1658
1659         struct btree_path_level *l = path_l(path);
1660         struct bkey_packed *_k;
1661         struct bkey_s_c k;
1662
1663         if (unlikely(!l->b))
1664                 return bkey_s_c_null;
1665
1666         EBUG_ON(path->uptodate != BTREE_ITER_UPTODATE);
1667         EBUG_ON(!btree_node_locked(path, path->level));
1668
1669         if (!path->cached) {
1670                 _k = bch2_btree_node_iter_peek_all(&l->iter, l->b);
1671                 k = _k ? bkey_disassemble(l->b, _k, u) : bkey_s_c_null;
1672
1673                 EBUG_ON(k.k && bkey_deleted(k.k) && bpos_eq(k.k->p, path->pos));
1674
1675                 if (!k.k || !bpos_eq(path->pos, k.k->p))
1676                         goto hole;
1677         } else {
1678                 struct bkey_cached *ck = (void *) path->l[0].b;
1679
1680                 EBUG_ON(ck &&
1681                         (path->btree_id != ck->key.btree_id ||
1682                          !bkey_eq(path->pos, ck->key.pos)));
1683                 if (!ck || !ck->valid)
1684                         return bkey_s_c_null;
1685
1686                 *u = ck->k->k;
1687                 k = bkey_i_to_s_c(ck->k);
1688         }
1689
1690         return k;
1691 hole:
1692         bkey_init(u);
1693         u->p = path->pos;
1694         return (struct bkey_s_c) { u, NULL };
1695 }
1696
1697 /* Btree iterators: */
1698
1699 int __must_check
1700 __bch2_btree_iter_traverse(struct btree_iter *iter)
1701 {
1702         return bch2_btree_path_traverse(iter->trans, iter->path, iter->flags);
1703 }
1704
1705 int __must_check
1706 bch2_btree_iter_traverse(struct btree_iter *iter)
1707 {
1708         struct btree_trans *trans = iter->trans;
1709         int ret;
1710
1711         iter->path = bch2_btree_path_set_pos(trans, iter->path,
1712                                         btree_iter_search_key(iter),
1713                                         iter->flags & BTREE_ITER_INTENT,
1714                                         btree_iter_ip_allocated(iter));
1715
1716         ret = bch2_btree_path_traverse(iter->trans, iter->path, iter->flags);
1717         if (ret)
1718                 return ret;
1719
1720         btree_path_set_should_be_locked(trans->paths + iter->path);
1721         return 0;
1722 }
1723
1724 /* Iterate across nodes (leaf and interior nodes) */
1725
1726 struct btree *bch2_btree_iter_peek_node(struct btree_iter *iter)
1727 {
1728         struct btree_trans *trans = iter->trans;
1729         struct btree *b = NULL;
1730         int ret;
1731
1732         EBUG_ON(trans->paths[iter->path].cached);
1733         bch2_btree_iter_verify(iter);
1734
1735         ret = bch2_btree_path_traverse(trans, iter->path, iter->flags);
1736         if (ret)
1737                 goto err;
1738
1739         struct btree_path *path = btree_iter_path(trans, iter);
1740         b = btree_path_node(path, path->level);
1741         if (!b)
1742                 goto out;
1743
1744         BUG_ON(bpos_lt(b->key.k.p, iter->pos));
1745
1746         bkey_init(&iter->k);
1747         iter->k.p = iter->pos = b->key.k.p;
1748
1749         iter->path = bch2_btree_path_set_pos(trans, iter->path, b->key.k.p,
1750                                         iter->flags & BTREE_ITER_INTENT,
1751                                         btree_iter_ip_allocated(iter));
1752         btree_path_set_should_be_locked(btree_iter_path(trans, iter));
1753 out:
1754         bch2_btree_iter_verify_entry_exit(iter);
1755         bch2_btree_iter_verify(iter);
1756
1757         return b;
1758 err:
1759         b = ERR_PTR(ret);
1760         goto out;
1761 }
1762
1763 struct btree *bch2_btree_iter_peek_node_and_restart(struct btree_iter *iter)
1764 {
1765         struct btree *b;
1766
1767         while (b = bch2_btree_iter_peek_node(iter),
1768                bch2_err_matches(PTR_ERR_OR_ZERO(b), BCH_ERR_transaction_restart))
1769                 bch2_trans_begin(iter->trans);
1770
1771         return b;
1772 }
1773
1774 struct btree *bch2_btree_iter_next_node(struct btree_iter *iter)
1775 {
1776         struct btree_trans *trans = iter->trans;
1777         struct btree *b = NULL;
1778         int ret;
1779
1780         EBUG_ON(trans->paths[iter->path].cached);
1781         bch2_trans_verify_not_in_restart(trans);
1782         bch2_btree_iter_verify(iter);
1783
1784         struct btree_path *path = btree_iter_path(trans, iter);
1785
1786         /* already at end? */
1787         if (!btree_path_node(path, path->level))
1788                 return NULL;
1789
1790         /* got to end? */
1791         if (!btree_path_node(path, path->level + 1)) {
1792                 btree_path_set_level_up(trans, path);
1793                 return NULL;
1794         }
1795
1796         if (!bch2_btree_node_relock(trans, path, path->level + 1)) {
1797                 __bch2_btree_path_unlock(trans, path);
1798                 path->l[path->level].b          = ERR_PTR(-BCH_ERR_no_btree_node_relock);
1799                 path->l[path->level + 1].b      = ERR_PTR(-BCH_ERR_no_btree_node_relock);
1800                 btree_path_set_dirty(path, BTREE_ITER_NEED_TRAVERSE);
1801                 trace_and_count(trans->c, trans_restart_relock_next_node, trans, _THIS_IP_, path);
1802                 ret = btree_trans_restart(trans, BCH_ERR_transaction_restart_relock);
1803                 goto err;
1804         }
1805
1806         b = btree_path_node(path, path->level + 1);
1807
1808         if (bpos_eq(iter->pos, b->key.k.p)) {
1809                 __btree_path_set_level_up(trans, path, path->level++);
1810         } else {
1811                 /*
1812                  * Haven't gotten to the end of the parent node: go back down to
1813                  * the next child node
1814                  */
1815                 iter->path = bch2_btree_path_set_pos(trans, iter->path,
1816                                         bpos_successor(iter->pos),
1817                                         iter->flags & BTREE_ITER_INTENT,
1818                                         btree_iter_ip_allocated(iter));
1819
1820                 path = btree_iter_path(trans, iter);
1821                 btree_path_set_level_down(trans, path, iter->min_depth);
1822
1823                 ret = bch2_btree_path_traverse(trans, iter->path, iter->flags);
1824                 if (ret)
1825                         goto err;
1826
1827                 path = btree_iter_path(trans, iter);
1828                 b = path->l[path->level].b;
1829         }
1830
1831         bkey_init(&iter->k);
1832         iter->k.p = iter->pos = b->key.k.p;
1833
1834         iter->path = bch2_btree_path_set_pos(trans, iter->path, b->key.k.p,
1835                                         iter->flags & BTREE_ITER_INTENT,
1836                                         btree_iter_ip_allocated(iter));
1837         btree_path_set_should_be_locked(btree_iter_path(trans, iter));
1838         EBUG_ON(btree_iter_path(trans, iter)->uptodate);
1839 out:
1840         bch2_btree_iter_verify_entry_exit(iter);
1841         bch2_btree_iter_verify(iter);
1842
1843         return b;
1844 err:
1845         b = ERR_PTR(ret);
1846         goto out;
1847 }
1848
1849 /* Iterate across keys (in leaf nodes only) */
1850
1851 inline bool bch2_btree_iter_advance(struct btree_iter *iter)
1852 {
1853         struct bpos pos = iter->k.p;
1854         bool ret = !(iter->flags & BTREE_ITER_ALL_SNAPSHOTS
1855                      ? bpos_eq(pos, SPOS_MAX)
1856                      : bkey_eq(pos, SPOS_MAX));
1857
1858         if (ret && !(iter->flags & BTREE_ITER_IS_EXTENTS))
1859                 pos = bkey_successor(iter, pos);
1860         bch2_btree_iter_set_pos(iter, pos);
1861         return ret;
1862 }
1863
1864 inline bool bch2_btree_iter_rewind(struct btree_iter *iter)
1865 {
1866         struct bpos pos = bkey_start_pos(&iter->k);
1867         bool ret = !(iter->flags & BTREE_ITER_ALL_SNAPSHOTS
1868                      ? bpos_eq(pos, POS_MIN)
1869                      : bkey_eq(pos, POS_MIN));
1870
1871         if (ret && !(iter->flags & BTREE_ITER_IS_EXTENTS))
1872                 pos = bkey_predecessor(iter, pos);
1873         bch2_btree_iter_set_pos(iter, pos);
1874         return ret;
1875 }
1876
1877 static noinline
1878 struct bkey_i *__bch2_btree_trans_peek_updates(struct btree_iter *iter)
1879 {
1880         struct btree_trans *trans = iter->trans;
1881         struct bkey_i *ret = NULL;
1882
1883         trans_for_each_update(trans, i) {
1884                 if (i->btree_id < iter->btree_id)
1885                         continue;
1886                 if (i->btree_id > iter->btree_id)
1887                         break;
1888                 if (bpos_lt(i->k->k.p, btree_iter_path(trans, iter)->pos))
1889                         continue;
1890                 if (i->key_cache_already_flushed)
1891                         continue;
1892                 if (!ret || bpos_lt(i->k->k.p, ret->k.p))
1893                         ret = i->k;
1894         }
1895
1896         return ret;
1897 }
1898
1899 static inline struct bkey_i *btree_trans_peek_updates(struct btree_iter *iter)
1900 {
1901         return iter->flags & BTREE_ITER_WITH_UPDATES
1902                 ? __bch2_btree_trans_peek_updates(iter)
1903                 : NULL;
1904 }
1905
1906 static struct bkey_i *bch2_btree_journal_peek(struct btree_trans *trans,
1907                                               struct btree_iter *iter,
1908                                               struct bpos end_pos)
1909 {
1910         struct btree_path *path = btree_iter_path(trans, iter);
1911
1912         return bch2_journal_keys_peek_upto(trans->c, iter->btree_id,
1913                                            path->level,
1914                                            path->pos,
1915                                            end_pos,
1916                                            &iter->journal_idx);
1917 }
1918
1919 static noinline
1920 struct bkey_s_c btree_trans_peek_slot_journal(struct btree_trans *trans,
1921                                               struct btree_iter *iter)
1922 {
1923         struct btree_path *path = btree_iter_path(trans, iter);
1924         struct bkey_i *k = bch2_btree_journal_peek(trans, iter, path->pos);
1925
1926         if (k) {
1927                 iter->k = k->k;
1928                 return bkey_i_to_s_c(k);
1929         } else {
1930                 return bkey_s_c_null;
1931         }
1932 }
1933
1934 static noinline
1935 struct bkey_s_c btree_trans_peek_journal(struct btree_trans *trans,
1936                                          struct btree_iter *iter,
1937                                          struct bkey_s_c k)
1938 {
1939         struct btree_path *path = btree_iter_path(trans, iter);
1940         struct bkey_i *next_journal =
1941                 bch2_btree_journal_peek(trans, iter,
1942                                 k.k ? k.k->p : path_l(path)->b->key.k.p);
1943
1944         if (next_journal) {
1945                 iter->k = next_journal->k;
1946                 k = bkey_i_to_s_c(next_journal);
1947         }
1948
1949         return k;
1950 }
1951
1952 /*
1953  * Checks btree key cache for key at iter->pos and returns it if present, or
1954  * bkey_s_c_null:
1955  */
1956 static noinline
1957 struct bkey_s_c btree_trans_peek_key_cache(struct btree_iter *iter, struct bpos pos)
1958 {
1959         struct btree_trans *trans = iter->trans;
1960         struct bch_fs *c = trans->c;
1961         struct bkey u;
1962         struct bkey_s_c k;
1963         int ret;
1964
1965         if ((iter->flags & BTREE_ITER_KEY_CACHE_FILL) &&
1966             bpos_eq(iter->pos, pos))
1967                 return bkey_s_c_null;
1968
1969         if (!bch2_btree_key_cache_find(c, iter->btree_id, pos))
1970                 return bkey_s_c_null;
1971
1972         if (!iter->key_cache_path)
1973                 iter->key_cache_path = bch2_path_get(trans, iter->btree_id, pos,
1974                                                      iter->flags & BTREE_ITER_INTENT, 0,
1975                                                      iter->flags|BTREE_ITER_CACHED|
1976                                                      BTREE_ITER_CACHED_NOFILL,
1977                                                      _THIS_IP_);
1978
1979         iter->key_cache_path = bch2_btree_path_set_pos(trans, iter->key_cache_path, pos,
1980                                         iter->flags & BTREE_ITER_INTENT,
1981                                         btree_iter_ip_allocated(iter));
1982
1983         ret =   bch2_btree_path_traverse(trans, iter->key_cache_path,
1984                                          iter->flags|BTREE_ITER_CACHED) ?:
1985                 bch2_btree_path_relock(trans, btree_iter_path(trans, iter), _THIS_IP_);
1986         if (unlikely(ret))
1987                 return bkey_s_c_err(ret);
1988
1989         btree_path_set_should_be_locked(trans->paths + iter->key_cache_path);
1990
1991         k = bch2_btree_path_peek_slot(trans->paths + iter->key_cache_path, &u);
1992         if (k.k && !bkey_err(k)) {
1993                 iter->k = u;
1994                 k.k = &iter->k;
1995         }
1996         return k;
1997 }
1998
1999 static struct bkey_s_c __bch2_btree_iter_peek(struct btree_iter *iter, struct bpos search_key)
2000 {
2001         struct btree_trans *trans = iter->trans;
2002         struct bkey_i *next_update;
2003         struct bkey_s_c k, k2;
2004         int ret;
2005
2006         EBUG_ON(btree_iter_path(trans, iter)->cached);
2007         bch2_btree_iter_verify(iter);
2008
2009         while (1) {
2010                 struct btree_path_level *l;
2011
2012                 iter->path = bch2_btree_path_set_pos(trans, iter->path, search_key,
2013                                         iter->flags & BTREE_ITER_INTENT,
2014                                         btree_iter_ip_allocated(iter));
2015
2016                 ret = bch2_btree_path_traverse(trans, iter->path, iter->flags);
2017                 if (unlikely(ret)) {
2018                         /* ensure that iter->k is consistent with iter->pos: */
2019                         bch2_btree_iter_set_pos(iter, iter->pos);
2020                         k = bkey_s_c_err(ret);
2021                         goto out;
2022                 }
2023
2024                 struct btree_path *path = btree_iter_path(trans, iter);
2025                 l = path_l(path);
2026
2027                 if (unlikely(!l->b)) {
2028                         /* No btree nodes at requested level: */
2029                         bch2_btree_iter_set_pos(iter, SPOS_MAX);
2030                         k = bkey_s_c_null;
2031                         goto out;
2032                 }
2033
2034                 btree_path_set_should_be_locked(path);
2035
2036                 k = btree_path_level_peek_all(trans->c, l, &iter->k);
2037
2038                 if (unlikely(iter->flags & BTREE_ITER_WITH_KEY_CACHE) &&
2039                     k.k &&
2040                     (k2 = btree_trans_peek_key_cache(iter, k.k->p)).k) {
2041                         k = k2;
2042                         ret = bkey_err(k);
2043                         if (ret) {
2044                                 bch2_btree_iter_set_pos(iter, iter->pos);
2045                                 goto out;
2046                         }
2047                 }
2048
2049                 if (unlikely(iter->flags & BTREE_ITER_WITH_JOURNAL))
2050                         k = btree_trans_peek_journal(trans, iter, k);
2051
2052                 next_update = btree_trans_peek_updates(iter);
2053
2054                 if (next_update &&
2055                     bpos_le(next_update->k.p,
2056                             k.k ? k.k->p : l->b->key.k.p)) {
2057                         iter->k = next_update->k;
2058                         k = bkey_i_to_s_c(next_update);
2059                 }
2060
2061                 if (k.k && bkey_deleted(k.k)) {
2062                         /*
2063                          * If we've got a whiteout, and it's after the search
2064                          * key, advance the search key to the whiteout instead
2065                          * of just after the whiteout - it might be a btree
2066                          * whiteout, with a real key at the same position, since
2067                          * in the btree deleted keys sort before non deleted.
2068                          */
2069                         search_key = !bpos_eq(search_key, k.k->p)
2070                                 ? k.k->p
2071                                 : bpos_successor(k.k->p);
2072                         continue;
2073                 }
2074
2075                 if (likely(k.k)) {
2076                         break;
2077                 } else if (likely(!bpos_eq(l->b->key.k.p, SPOS_MAX))) {
2078                         /* Advance to next leaf node: */
2079                         search_key = bpos_successor(l->b->key.k.p);
2080                 } else {
2081                         /* End of btree: */
2082                         bch2_btree_iter_set_pos(iter, SPOS_MAX);
2083                         k = bkey_s_c_null;
2084                         goto out;
2085                 }
2086         }
2087 out:
2088         bch2_btree_iter_verify(iter);
2089
2090         return k;
2091 }
2092
2093 /**
2094  * bch2_btree_iter_peek_upto() - returns first key greater than or equal to
2095  * iterator's current position
2096  * @iter:       iterator to peek from
2097  * @end:        search limit: returns keys less than or equal to @end
2098  *
2099  * Returns:     key if found, or an error extractable with bkey_err().
2100  */
2101 struct bkey_s_c bch2_btree_iter_peek_upto(struct btree_iter *iter, struct bpos end)
2102 {
2103         struct btree_trans *trans = iter->trans;
2104         struct bpos search_key = btree_iter_search_key(iter);
2105         struct bkey_s_c k;
2106         struct bpos iter_pos;
2107         int ret;
2108
2109         EBUG_ON((iter->flags & BTREE_ITER_FILTER_SNAPSHOTS) && bkey_eq(end, POS_MAX));
2110
2111         if (iter->update_path) {
2112                 bch2_path_put_nokeep(trans, iter->update_path,
2113                                      iter->flags & BTREE_ITER_INTENT);
2114                 iter->update_path = 0;
2115         }
2116
2117         bch2_btree_iter_verify_entry_exit(iter);
2118
2119         while (1) {
2120                 k = __bch2_btree_iter_peek(iter, search_key);
2121                 if (unlikely(!k.k))
2122                         goto end;
2123                 if (unlikely(bkey_err(k)))
2124                         goto out_no_locked;
2125
2126                 /*
2127                  * iter->pos should be mononotically increasing, and always be
2128                  * equal to the key we just returned - except extents can
2129                  * straddle iter->pos:
2130                  */
2131                 if (!(iter->flags & BTREE_ITER_IS_EXTENTS))
2132                         iter_pos = k.k->p;
2133                 else
2134                         iter_pos = bkey_max(iter->pos, bkey_start_pos(k.k));
2135
2136                 if (unlikely(!(iter->flags & BTREE_ITER_IS_EXTENTS)
2137                              ? bkey_gt(iter_pos, end)
2138                              : bkey_ge(iter_pos, end)))
2139                         goto end;
2140
2141                 if (iter->update_path &&
2142                     !bkey_eq(trans->paths[iter->update_path].pos, k.k->p)) {
2143                         bch2_path_put_nokeep(trans, iter->update_path,
2144                                              iter->flags & BTREE_ITER_INTENT);
2145                         iter->update_path = 0;
2146                 }
2147
2148                 if ((iter->flags & BTREE_ITER_FILTER_SNAPSHOTS) &&
2149                     (iter->flags & BTREE_ITER_INTENT) &&
2150                     !(iter->flags & BTREE_ITER_IS_EXTENTS) &&
2151                     !iter->update_path) {
2152                         struct bpos pos = k.k->p;
2153
2154                         if (pos.snapshot < iter->snapshot) {
2155                                 search_key = bpos_successor(k.k->p);
2156                                 continue;
2157                         }
2158
2159                         pos.snapshot = iter->snapshot;
2160
2161                         /*
2162                          * advance, same as on exit for iter->path, but only up
2163                          * to snapshot
2164                          */
2165                         __btree_path_get(trans->paths + iter->path, iter->flags & BTREE_ITER_INTENT);
2166                         iter->update_path = iter->path;
2167
2168                         iter->update_path = bch2_btree_path_set_pos(trans,
2169                                                 iter->update_path, pos,
2170                                                 iter->flags & BTREE_ITER_INTENT,
2171                                                 _THIS_IP_);
2172                         ret = bch2_btree_path_traverse(trans, iter->update_path, iter->flags);
2173                         if (unlikely(ret)) {
2174                                 k = bkey_s_c_err(ret);
2175                                 goto out_no_locked;
2176                         }
2177                 }
2178
2179                 /*
2180                  * We can never have a key in a leaf node at POS_MAX, so
2181                  * we don't have to check these successor() calls:
2182                  */
2183                 if ((iter->flags & BTREE_ITER_FILTER_SNAPSHOTS) &&
2184                     !bch2_snapshot_is_ancestor(trans->c,
2185                                                iter->snapshot,
2186                                                k.k->p.snapshot)) {
2187                         search_key = bpos_successor(k.k->p);
2188                         continue;
2189                 }
2190
2191                 if (bkey_whiteout(k.k) &&
2192                     !(iter->flags & BTREE_ITER_ALL_SNAPSHOTS)) {
2193                         search_key = bkey_successor(iter, k.k->p);
2194                         continue;
2195                 }
2196
2197                 break;
2198         }
2199
2200         iter->pos = iter_pos;
2201
2202         iter->path = bch2_btree_path_set_pos(trans, iter->path, k.k->p,
2203                                 iter->flags & BTREE_ITER_INTENT,
2204                                 btree_iter_ip_allocated(iter));
2205
2206         btree_path_set_should_be_locked(btree_iter_path(trans, iter));
2207 out_no_locked:
2208         if (iter->update_path) {
2209                 ret = bch2_btree_path_relock(trans, trans->paths + iter->update_path, _THIS_IP_);
2210                 if (unlikely(ret))
2211                         k = bkey_s_c_err(ret);
2212                 else
2213                         btree_path_set_should_be_locked(trans->paths + iter->update_path);
2214         }
2215
2216         if (!(iter->flags & BTREE_ITER_ALL_SNAPSHOTS))
2217                 iter->pos.snapshot = iter->snapshot;
2218
2219         ret = bch2_btree_iter_verify_ret(iter, k);
2220         if (unlikely(ret)) {
2221                 bch2_btree_iter_set_pos(iter, iter->pos);
2222                 k = bkey_s_c_err(ret);
2223         }
2224
2225         bch2_btree_iter_verify_entry_exit(iter);
2226
2227         return k;
2228 end:
2229         bch2_btree_iter_set_pos(iter, end);
2230         k = bkey_s_c_null;
2231         goto out_no_locked;
2232 }
2233
2234 /**
2235  * bch2_btree_iter_next() - returns first key greater than iterator's current
2236  * position
2237  * @iter:       iterator to peek from
2238  *
2239  * Returns:     key if found, or an error extractable with bkey_err().
2240  */
2241 struct bkey_s_c bch2_btree_iter_next(struct btree_iter *iter)
2242 {
2243         if (!bch2_btree_iter_advance(iter))
2244                 return bkey_s_c_null;
2245
2246         return bch2_btree_iter_peek(iter);
2247 }
2248
2249 /**
2250  * bch2_btree_iter_peek_prev() - returns first key less than or equal to
2251  * iterator's current position
2252  * @iter:       iterator to peek from
2253  *
2254  * Returns:     key if found, or an error extractable with bkey_err().
2255  */
2256 struct bkey_s_c bch2_btree_iter_peek_prev(struct btree_iter *iter)
2257 {
2258         struct btree_trans *trans = iter->trans;
2259         struct bpos search_key = iter->pos;
2260         struct bkey_s_c k;
2261         struct bkey saved_k;
2262         const struct bch_val *saved_v;
2263         btree_path_idx_t saved_path = 0;
2264         int ret;
2265
2266         EBUG_ON(btree_iter_path(trans, iter)->cached ||
2267                 btree_iter_path(trans, iter)->level);
2268         EBUG_ON(iter->flags & BTREE_ITER_WITH_UPDATES);
2269
2270         if (iter->flags & BTREE_ITER_WITH_JOURNAL)
2271                 return bkey_s_c_err(-EIO);
2272
2273         bch2_btree_iter_verify(iter);
2274         bch2_btree_iter_verify_entry_exit(iter);
2275
2276         if (iter->flags & BTREE_ITER_FILTER_SNAPSHOTS)
2277                 search_key.snapshot = U32_MAX;
2278
2279         while (1) {
2280                 iter->path = bch2_btree_path_set_pos(trans, iter->path, search_key,
2281                                                 iter->flags & BTREE_ITER_INTENT,
2282                                                 btree_iter_ip_allocated(iter));
2283
2284                 ret = bch2_btree_path_traverse(trans, iter->path, iter->flags);
2285                 if (unlikely(ret)) {
2286                         /* ensure that iter->k is consistent with iter->pos: */
2287                         bch2_btree_iter_set_pos(iter, iter->pos);
2288                         k = bkey_s_c_err(ret);
2289                         goto out_no_locked;
2290                 }
2291
2292                 struct btree_path *path = btree_iter_path(trans, iter);
2293
2294                 k = btree_path_level_peek(trans, path, &path->l[0], &iter->k);
2295                 if (!k.k ||
2296                     ((iter->flags & BTREE_ITER_IS_EXTENTS)
2297                      ? bpos_ge(bkey_start_pos(k.k), search_key)
2298                      : bpos_gt(k.k->p, search_key)))
2299                         k = btree_path_level_prev(trans, path, &path->l[0], &iter->k);
2300
2301                 if (likely(k.k)) {
2302                         if (iter->flags & BTREE_ITER_FILTER_SNAPSHOTS) {
2303                                 if (k.k->p.snapshot == iter->snapshot)
2304                                         goto got_key;
2305
2306                                 /*
2307                                  * If we have a saved candidate, and we're no
2308                                  * longer at the same _key_ (not pos), return
2309                                  * that candidate
2310                                  */
2311                                 if (saved_path && !bkey_eq(k.k->p, saved_k.p)) {
2312                                         bch2_path_put_nokeep(trans, iter->path,
2313                                                       iter->flags & BTREE_ITER_INTENT);
2314                                         iter->path = saved_path;
2315                                         saved_path = 0;
2316                                         iter->k = saved_k;
2317                                         k.v     = saved_v;
2318                                         goto got_key;
2319                                 }
2320
2321                                 if (bch2_snapshot_is_ancestor(trans->c,
2322                                                               iter->snapshot,
2323                                                               k.k->p.snapshot)) {
2324                                         if (saved_path)
2325                                                 bch2_path_put_nokeep(trans, saved_path,
2326                                                       iter->flags & BTREE_ITER_INTENT);
2327                                         saved_path = btree_path_clone(trans, iter->path,
2328                                                                 iter->flags & BTREE_ITER_INTENT);
2329                                         path = btree_iter_path(trans, iter);
2330                                         saved_k = *k.k;
2331                                         saved_v = k.v;
2332                                 }
2333
2334                                 search_key = bpos_predecessor(k.k->p);
2335                                 continue;
2336                         }
2337 got_key:
2338                         if (bkey_whiteout(k.k) &&
2339                             !(iter->flags & BTREE_ITER_ALL_SNAPSHOTS)) {
2340                                 search_key = bkey_predecessor(iter, k.k->p);
2341                                 if (iter->flags & BTREE_ITER_FILTER_SNAPSHOTS)
2342                                         search_key.snapshot = U32_MAX;
2343                                 continue;
2344                         }
2345
2346                         btree_path_set_should_be_locked(path);
2347                         break;
2348                 } else if (likely(!bpos_eq(path->l[0].b->data->min_key, POS_MIN))) {
2349                         /* Advance to previous leaf node: */
2350                         search_key = bpos_predecessor(path->l[0].b->data->min_key);
2351                 } else {
2352                         /* Start of btree: */
2353                         bch2_btree_iter_set_pos(iter, POS_MIN);
2354                         k = bkey_s_c_null;
2355                         goto out_no_locked;
2356                 }
2357         }
2358
2359         EBUG_ON(bkey_gt(bkey_start_pos(k.k), iter->pos));
2360
2361         /* Extents can straddle iter->pos: */
2362         if (bkey_lt(k.k->p, iter->pos))
2363                 iter->pos = k.k->p;
2364
2365         if (iter->flags & BTREE_ITER_FILTER_SNAPSHOTS)
2366                 iter->pos.snapshot = iter->snapshot;
2367 out_no_locked:
2368         if (saved_path)
2369                 bch2_path_put_nokeep(trans, saved_path, iter->flags & BTREE_ITER_INTENT);
2370
2371         bch2_btree_iter_verify_entry_exit(iter);
2372         bch2_btree_iter_verify(iter);
2373
2374         return k;
2375 }
2376
2377 /**
2378  * bch2_btree_iter_prev() - returns first key less than iterator's current
2379  * position
2380  * @iter:       iterator to peek from
2381  *
2382  * Returns:     key if found, or an error extractable with bkey_err().
2383  */
2384 struct bkey_s_c bch2_btree_iter_prev(struct btree_iter *iter)
2385 {
2386         if (!bch2_btree_iter_rewind(iter))
2387                 return bkey_s_c_null;
2388
2389         return bch2_btree_iter_peek_prev(iter);
2390 }
2391
2392 struct bkey_s_c bch2_btree_iter_peek_slot(struct btree_iter *iter)
2393 {
2394         struct btree_trans *trans = iter->trans;
2395         struct bpos search_key;
2396         struct bkey_s_c k;
2397         int ret;
2398
2399         bch2_btree_iter_verify(iter);
2400         bch2_btree_iter_verify_entry_exit(iter);
2401         EBUG_ON(btree_iter_path(trans, iter)->level && (iter->flags & BTREE_ITER_WITH_KEY_CACHE));
2402
2403         /* extents can't span inode numbers: */
2404         if ((iter->flags & BTREE_ITER_IS_EXTENTS) &&
2405             unlikely(iter->pos.offset == KEY_OFFSET_MAX)) {
2406                 if (iter->pos.inode == KEY_INODE_MAX)
2407                         return bkey_s_c_null;
2408
2409                 bch2_btree_iter_set_pos(iter, bpos_nosnap_successor(iter->pos));
2410         }
2411
2412         search_key = btree_iter_search_key(iter);
2413         iter->path = bch2_btree_path_set_pos(trans, iter->path, search_key,
2414                                         iter->flags & BTREE_ITER_INTENT,
2415                                         btree_iter_ip_allocated(iter));
2416
2417         ret = bch2_btree_path_traverse(trans, iter->path, iter->flags);
2418         if (unlikely(ret)) {
2419                 k = bkey_s_c_err(ret);
2420                 goto out_no_locked;
2421         }
2422
2423         if ((iter->flags & BTREE_ITER_CACHED) ||
2424             !(iter->flags & (BTREE_ITER_IS_EXTENTS|BTREE_ITER_FILTER_SNAPSHOTS))) {
2425                 struct bkey_i *next_update;
2426
2427                 if ((next_update = btree_trans_peek_updates(iter)) &&
2428                     bpos_eq(next_update->k.p, iter->pos)) {
2429                         iter->k = next_update->k;
2430                         k = bkey_i_to_s_c(next_update);
2431                         goto out;
2432                 }
2433
2434                 if (unlikely(iter->flags & BTREE_ITER_WITH_JOURNAL) &&
2435                     (k = btree_trans_peek_slot_journal(trans, iter)).k)
2436                         goto out;
2437
2438                 if (unlikely(iter->flags & BTREE_ITER_WITH_KEY_CACHE) &&
2439                     (k = btree_trans_peek_key_cache(iter, iter->pos)).k) {
2440                         if (!bkey_err(k))
2441                                 iter->k = *k.k;
2442                         /* We're not returning a key from iter->path: */
2443                         goto out_no_locked;
2444                 }
2445
2446                 k = bch2_btree_path_peek_slot(trans->paths + iter->path, &iter->k);
2447                 if (unlikely(!k.k))
2448                         goto out_no_locked;
2449         } else {
2450                 struct bpos next;
2451                 struct bpos end = iter->pos;
2452
2453                 if (iter->flags & BTREE_ITER_IS_EXTENTS)
2454                         end.offset = U64_MAX;
2455
2456                 EBUG_ON(btree_iter_path(trans, iter)->level);
2457
2458                 if (iter->flags & BTREE_ITER_INTENT) {
2459                         struct btree_iter iter2;
2460
2461                         bch2_trans_copy_iter(&iter2, iter);
2462                         k = bch2_btree_iter_peek_upto(&iter2, end);
2463
2464                         if (k.k && !bkey_err(k)) {
2465                                 iter->k = iter2.k;
2466                                 k.k = &iter->k;
2467                         }
2468                         bch2_trans_iter_exit(trans, &iter2);
2469                 } else {
2470                         struct bpos pos = iter->pos;
2471
2472                         k = bch2_btree_iter_peek_upto(iter, end);
2473                         if (unlikely(bkey_err(k)))
2474                                 bch2_btree_iter_set_pos(iter, pos);
2475                         else
2476                                 iter->pos = pos;
2477                 }
2478
2479                 if (unlikely(bkey_err(k)))
2480                         goto out_no_locked;
2481
2482                 next = k.k ? bkey_start_pos(k.k) : POS_MAX;
2483
2484                 if (bkey_lt(iter->pos, next)) {
2485                         bkey_init(&iter->k);
2486                         iter->k.p = iter->pos;
2487
2488                         if (iter->flags & BTREE_ITER_IS_EXTENTS) {
2489                                 bch2_key_resize(&iter->k,
2490                                                 min_t(u64, KEY_SIZE_MAX,
2491                                                       (next.inode == iter->pos.inode
2492                                                        ? next.offset
2493                                                        : KEY_OFFSET_MAX) -
2494                                                       iter->pos.offset));
2495                                 EBUG_ON(!iter->k.size);
2496                         }
2497
2498                         k = (struct bkey_s_c) { &iter->k, NULL };
2499                 }
2500         }
2501 out:
2502         btree_path_set_should_be_locked(btree_iter_path(trans, iter));
2503 out_no_locked:
2504         bch2_btree_iter_verify_entry_exit(iter);
2505         bch2_btree_iter_verify(iter);
2506         ret = bch2_btree_iter_verify_ret(iter, k);
2507         if (unlikely(ret))
2508                 return bkey_s_c_err(ret);
2509
2510         return k;
2511 }
2512
2513 struct bkey_s_c bch2_btree_iter_next_slot(struct btree_iter *iter)
2514 {
2515         if (!bch2_btree_iter_advance(iter))
2516                 return bkey_s_c_null;
2517
2518         return bch2_btree_iter_peek_slot(iter);
2519 }
2520
2521 struct bkey_s_c bch2_btree_iter_prev_slot(struct btree_iter *iter)
2522 {
2523         if (!bch2_btree_iter_rewind(iter))
2524                 return bkey_s_c_null;
2525
2526         return bch2_btree_iter_peek_slot(iter);
2527 }
2528
2529 struct bkey_s_c bch2_btree_iter_peek_and_restart_outlined(struct btree_iter *iter)
2530 {
2531         struct bkey_s_c k;
2532
2533         while (btree_trans_too_many_iters(iter->trans) ||
2534                (k = bch2_btree_iter_peek_type(iter, iter->flags),
2535                 bch2_err_matches(bkey_err(k), BCH_ERR_transaction_restart)))
2536                 bch2_trans_begin(iter->trans);
2537
2538         return k;
2539 }
2540
2541 /* new transactional stuff: */
2542
2543 #ifdef CONFIG_BCACHEFS_DEBUG
2544 static void btree_trans_verify_sorted_refs(struct btree_trans *trans)
2545 {
2546         struct btree_path *path;
2547         unsigned i;
2548
2549         BUG_ON(trans->nr_sorted != bitmap_weight(trans->paths_allocated, trans->nr_paths) - 1);
2550
2551         trans_for_each_path(trans, path, i) {
2552                 BUG_ON(path->sorted_idx >= trans->nr_sorted);
2553                 BUG_ON(trans->sorted[path->sorted_idx] != i);
2554         }
2555
2556         for (i = 0; i < trans->nr_sorted; i++) {
2557                 unsigned idx = trans->sorted[i];
2558
2559                 BUG_ON(!test_bit(idx, trans->paths_allocated));
2560                 BUG_ON(trans->paths[idx].sorted_idx != i);
2561         }
2562 }
2563
2564 static void btree_trans_verify_sorted(struct btree_trans *trans)
2565 {
2566         struct btree_path *path, *prev = NULL;
2567         struct trans_for_each_path_inorder_iter iter;
2568
2569         if (!bch2_debug_check_iterators)
2570                 return;
2571
2572         trans_for_each_path_inorder(trans, path, iter) {
2573                 if (prev && btree_path_cmp(prev, path) > 0) {
2574                         __bch2_dump_trans_paths_updates(trans, true);
2575                         panic("trans paths out of order!\n");
2576                 }
2577                 prev = path;
2578         }
2579 }
2580 #else
2581 static inline void btree_trans_verify_sorted_refs(struct btree_trans *trans) {}
2582 static inline void btree_trans_verify_sorted(struct btree_trans *trans) {}
2583 #endif
2584
2585 void __bch2_btree_trans_sort_paths(struct btree_trans *trans)
2586 {
2587         int i, l = 0, r = trans->nr_sorted, inc = 1;
2588         bool swapped;
2589
2590         btree_trans_verify_sorted_refs(trans);
2591
2592         if (trans->paths_sorted)
2593                 goto out;
2594
2595         /*
2596          * Cocktail shaker sort: this is efficient because iterators will be
2597          * mostly sorted.
2598          */
2599         do {
2600                 swapped = false;
2601
2602                 for (i = inc > 0 ? l : r - 2;
2603                      i + 1 < r && i >= l;
2604                      i += inc) {
2605                         if (btree_path_cmp(trans->paths + trans->sorted[i],
2606                                            trans->paths + trans->sorted[i + 1]) > 0) {
2607                                 swap(trans->sorted[i], trans->sorted[i + 1]);
2608                                 trans->paths[trans->sorted[i]].sorted_idx = i;
2609                                 trans->paths[trans->sorted[i + 1]].sorted_idx = i + 1;
2610                                 swapped = true;
2611                         }
2612                 }
2613
2614                 if (inc > 0)
2615                         --r;
2616                 else
2617                         l++;
2618                 inc = -inc;
2619         } while (swapped);
2620
2621         trans->paths_sorted = true;
2622 out:
2623         btree_trans_verify_sorted(trans);
2624 }
2625
2626 static inline void btree_path_list_remove(struct btree_trans *trans,
2627                                           struct btree_path *path)
2628 {
2629         unsigned i;
2630
2631         EBUG_ON(path->sorted_idx >= trans->nr_sorted);
2632 #ifdef CONFIG_HAVE_EFFICIENT_UNALIGNED_ACCESS
2633         trans->nr_sorted--;
2634         memmove_u64s_down_small(trans->sorted + path->sorted_idx,
2635                                 trans->sorted + path->sorted_idx + 1,
2636                                 DIV_ROUND_UP(trans->nr_sorted - path->sorted_idx, 8));
2637 #else
2638         array_remove_item(trans->sorted, trans->nr_sorted, path->sorted_idx);
2639 #endif
2640         for (i = path->sorted_idx; i < trans->nr_sorted; i++)
2641                 trans->paths[trans->sorted[i]].sorted_idx = i;
2642
2643         path->sorted_idx = U8_MAX;
2644 }
2645
2646 static inline void btree_path_list_add(struct btree_trans *trans,
2647                                        btree_path_idx_t pos,
2648                                        btree_path_idx_t path_idx)
2649 {
2650         struct btree_path *path = trans->paths + path_idx;
2651         unsigned i;
2652
2653         path->sorted_idx = pos ? trans->paths[pos].sorted_idx + 1 : trans->nr_sorted;
2654
2655 #ifdef CONFIG_HAVE_EFFICIENT_UNALIGNED_ACCESS
2656         memmove_u64s_up_small(trans->sorted + path->sorted_idx + 1,
2657                               trans->sorted + path->sorted_idx,
2658                               DIV_ROUND_UP(trans->nr_sorted - path->sorted_idx, 8));
2659         trans->nr_sorted++;
2660         trans->sorted[path->sorted_idx] = path_idx;
2661 #else
2662         array_insert_item(trans->sorted, trans->nr_sorted, path->sorted_idx, path_idx);
2663 #endif
2664
2665         for (i = path->sorted_idx; i < trans->nr_sorted; i++)
2666                 trans->paths[trans->sorted[i]].sorted_idx = i;
2667
2668         btree_trans_verify_sorted_refs(trans);
2669 }
2670
2671 void bch2_trans_iter_exit(struct btree_trans *trans, struct btree_iter *iter)
2672 {
2673         if (iter->update_path)
2674                 bch2_path_put_nokeep(trans, iter->update_path,
2675                               iter->flags & BTREE_ITER_INTENT);
2676         if (iter->path)
2677                 bch2_path_put(trans, iter->path,
2678                               iter->flags & BTREE_ITER_INTENT);
2679         if (iter->key_cache_path)
2680                 bch2_path_put(trans, iter->key_cache_path,
2681                               iter->flags & BTREE_ITER_INTENT);
2682         iter->path              = 0;
2683         iter->update_path       = 0;
2684         iter->key_cache_path    = 0;
2685         iter->trans             = NULL;
2686 }
2687
2688 void bch2_trans_iter_init_outlined(struct btree_trans *trans,
2689                           struct btree_iter *iter,
2690                           enum btree_id btree_id, struct bpos pos,
2691                           unsigned flags)
2692 {
2693         bch2_trans_iter_init_common(trans, iter, btree_id, pos, 0, 0,
2694                                bch2_btree_iter_flags(trans, btree_id, flags),
2695                                _RET_IP_);
2696 }
2697
2698 void bch2_trans_node_iter_init(struct btree_trans *trans,
2699                                struct btree_iter *iter,
2700                                enum btree_id btree_id,
2701                                struct bpos pos,
2702                                unsigned locks_want,
2703                                unsigned depth,
2704                                unsigned flags)
2705 {
2706         flags |= BTREE_ITER_NOT_EXTENTS;
2707         flags |= __BTREE_ITER_ALL_SNAPSHOTS;
2708         flags |= BTREE_ITER_ALL_SNAPSHOTS;
2709
2710         bch2_trans_iter_init_common(trans, iter, btree_id, pos, locks_want, depth,
2711                                __bch2_btree_iter_flags(trans, btree_id, flags),
2712                                _RET_IP_);
2713
2714         iter->min_depth = depth;
2715
2716         struct btree_path *path = btree_iter_path(trans, iter);
2717         BUG_ON(path->locks_want  < min(locks_want, BTREE_MAX_DEPTH));
2718         BUG_ON(path->level      != depth);
2719         BUG_ON(iter->min_depth  != depth);
2720 }
2721
2722 void bch2_trans_copy_iter(struct btree_iter *dst, struct btree_iter *src)
2723 {
2724         struct btree_trans *trans = src->trans;
2725
2726         *dst = *src;
2727         if (src->path)
2728                 __btree_path_get(trans->paths + src->path, src->flags & BTREE_ITER_INTENT);
2729         if (src->update_path)
2730                 __btree_path_get(trans->paths + src->update_path, src->flags & BTREE_ITER_INTENT);
2731         dst->key_cache_path = 0;
2732 }
2733
2734 void *__bch2_trans_kmalloc(struct btree_trans *trans, size_t size)
2735 {
2736         struct bch_fs *c = trans->c;
2737         unsigned new_top = trans->mem_top + size;
2738         unsigned old_bytes = trans->mem_bytes;
2739         unsigned new_bytes = roundup_pow_of_two(new_top);
2740         int ret;
2741         void *new_mem;
2742         void *p;
2743
2744         WARN_ON_ONCE(new_bytes > BTREE_TRANS_MEM_MAX);
2745
2746         struct btree_transaction_stats *s = btree_trans_stats(trans);
2747         if (s)
2748                 s->max_mem = max(s->max_mem, new_bytes);
2749
2750         new_mem = krealloc(trans->mem, new_bytes, GFP_NOWAIT|__GFP_NOWARN);
2751         if (unlikely(!new_mem)) {
2752                 bch2_trans_unlock(trans);
2753
2754                 new_mem = krealloc(trans->mem, new_bytes, GFP_KERNEL);
2755                 if (!new_mem && new_bytes <= BTREE_TRANS_MEM_MAX) {
2756                         new_mem = mempool_alloc(&c->btree_trans_mem_pool, GFP_KERNEL);
2757                         new_bytes = BTREE_TRANS_MEM_MAX;
2758                         kfree(trans->mem);
2759                 }
2760
2761                 if (!new_mem)
2762                         return ERR_PTR(-BCH_ERR_ENOMEM_trans_kmalloc);
2763
2764                 trans->mem = new_mem;
2765                 trans->mem_bytes = new_bytes;
2766
2767                 ret = bch2_trans_relock(trans);
2768                 if (ret)
2769                         return ERR_PTR(ret);
2770         }
2771
2772         trans->mem = new_mem;
2773         trans->mem_bytes = new_bytes;
2774
2775         if (old_bytes) {
2776                 trace_and_count(c, trans_restart_mem_realloced, trans, _RET_IP_, new_bytes);
2777                 return ERR_PTR(btree_trans_restart(trans, BCH_ERR_transaction_restart_mem_realloced));
2778         }
2779
2780         p = trans->mem + trans->mem_top;
2781         trans->mem_top += size;
2782         memset(p, 0, size);
2783         return p;
2784 }
2785
2786 static inline void check_srcu_held_too_long(struct btree_trans *trans)
2787 {
2788         WARN(trans->srcu_held && time_after(jiffies, trans->srcu_lock_time + HZ * 10),
2789              "btree trans held srcu lock (delaying memory reclaim) for %lu seconds",
2790              (jiffies - trans->srcu_lock_time) / HZ);
2791 }
2792
2793 void bch2_trans_srcu_unlock(struct btree_trans *trans)
2794 {
2795         if (trans->srcu_held) {
2796                 struct bch_fs *c = trans->c;
2797                 struct btree_path *path;
2798                 unsigned i;
2799
2800                 trans_for_each_path(trans, path, i)
2801                         if (path->cached && !btree_node_locked(path, 0))
2802                                 path->l[0].b = ERR_PTR(-BCH_ERR_no_btree_node_srcu_reset);
2803
2804                 check_srcu_held_too_long(trans);
2805                 srcu_read_unlock(&c->btree_trans_barrier, trans->srcu_idx);
2806                 trans->srcu_held = false;
2807         }
2808 }
2809
2810 static void bch2_trans_srcu_lock(struct btree_trans *trans)
2811 {
2812         if (!trans->srcu_held) {
2813                 trans->srcu_idx = srcu_read_lock(&trans->c->btree_trans_barrier);
2814                 trans->srcu_lock_time   = jiffies;
2815                 trans->srcu_held = true;
2816         }
2817 }
2818
2819 /**
2820  * bch2_trans_begin() - reset a transaction after a interrupted attempt
2821  * @trans: transaction to reset
2822  *
2823  * Returns:     current restart counter, to be used with trans_was_restarted()
2824  *
2825  * While iterating over nodes or updating nodes a attempt to lock a btree node
2826  * may return BCH_ERR_transaction_restart when the trylock fails. When this
2827  * occurs bch2_trans_begin() should be called and the transaction retried.
2828  */
2829 u32 bch2_trans_begin(struct btree_trans *trans)
2830 {
2831         struct btree_path *path;
2832         unsigned i;
2833         u64 now;
2834
2835         bch2_trans_reset_updates(trans);
2836
2837         trans->restart_count++;
2838         trans->mem_top                  = 0;
2839         trans->journal_entries          = NULL;
2840
2841         trans_for_each_path(trans, path, i) {
2842                 path->should_be_locked = false;
2843
2844                 /*
2845                  * If the transaction wasn't restarted, we're presuming to be
2846                  * doing something new: dont keep iterators excpt the ones that
2847                  * are in use - except for the subvolumes btree:
2848                  */
2849                 if (!trans->restarted && path->btree_id != BTREE_ID_subvolumes)
2850                         path->preserve = false;
2851
2852                 /*
2853                  * XXX: we probably shouldn't be doing this if the transaction
2854                  * was restarted, but currently we still overflow transaction
2855                  * iterators if we do that
2856                  */
2857                 if (!path->ref && !path->preserve)
2858                         __bch2_path_free(trans, i);
2859                 else
2860                         path->preserve = false;
2861         }
2862
2863         now = local_clock();
2864         if (!trans->restarted &&
2865             (need_resched() ||
2866              now - trans->last_begin_time > BTREE_TRANS_MAX_LOCK_HOLD_TIME_NS)) {
2867                 drop_locks_do(trans, (cond_resched(), 0));
2868                 now = local_clock();
2869         }
2870         trans->last_begin_time = now;
2871
2872         if (unlikely(trans->srcu_held &&
2873                      time_after(jiffies, trans->srcu_lock_time + msecs_to_jiffies(10))))
2874                 bch2_trans_srcu_unlock(trans);
2875
2876         trans->last_begin_ip = _RET_IP_;
2877         if (trans->restarted) {
2878                 bch2_btree_path_traverse_all(trans);
2879                 trans->notrace_relock_fail = false;
2880         }
2881
2882         return trans->restart_count;
2883 }
2884
2885 const char *bch2_btree_transaction_fns[BCH_TRANSACTIONS_NR];
2886
2887 unsigned bch2_trans_get_fn_idx(const char *fn)
2888 {
2889         unsigned i;
2890
2891         for (i = 0; i < ARRAY_SIZE(bch2_btree_transaction_fns); i++)
2892                 if (!bch2_btree_transaction_fns[i] ||
2893                     bch2_btree_transaction_fns[i] == fn) {
2894                         bch2_btree_transaction_fns[i] = fn;
2895                         return i;
2896                 }
2897
2898         pr_warn_once("BCH_TRANSACTIONS_NR not big enough!");
2899         return i;
2900 }
2901
2902 struct btree_trans *__bch2_trans_get(struct bch_fs *c, unsigned fn_idx)
2903         __acquires(&c->btree_trans_barrier)
2904 {
2905         struct btree_trans *trans;
2906
2907         if (IS_ENABLED(__KERNEL__)) {
2908                 trans = this_cpu_xchg(c->btree_trans_bufs->trans, NULL);
2909                 if (trans) {
2910                         memset(trans, 0, offsetof(struct btree_trans, list));
2911                         goto got_trans;
2912                 }
2913         }
2914
2915         trans = mempool_alloc(&c->btree_trans_pool, GFP_NOFS);
2916         memset(trans, 0, sizeof(*trans));
2917         closure_init_stack(&trans->ref);
2918
2919         seqmutex_lock(&c->btree_trans_lock);
2920         if (IS_ENABLED(CONFIG_BCACHEFS_DEBUG)) {
2921                 struct btree_trans *pos;
2922                 pid_t pid = current->pid;
2923
2924                 trans->locking_wait.task = current;
2925
2926                 list_for_each_entry(pos, &c->btree_trans_list, list) {
2927                         struct task_struct *pos_task = READ_ONCE(pos->locking_wait.task);
2928                         /*
2929                          * We'd much prefer to be stricter here and completely
2930                          * disallow multiple btree_trans in the same thread -
2931                          * but the data move path calls bch2_write when we
2932                          * already have a btree_trans initialized.
2933                          */
2934                         BUG_ON(pos_task &&
2935                                pid == pos_task->pid &&
2936                                bch2_trans_locked(pos));
2937
2938                         if (pos_task && pid < pos_task->pid) {
2939                                 list_add_tail(&trans->list, &pos->list);
2940                                 goto list_add_done;
2941                         }
2942                 }
2943         }
2944         list_add_tail(&trans->list, &c->btree_trans_list);
2945 list_add_done:
2946         seqmutex_unlock(&c->btree_trans_lock);
2947 got_trans:
2948         trans->c                = c;
2949         trans->last_begin_time  = local_clock();
2950         trans->fn_idx           = fn_idx;
2951         trans->locking_wait.task = current;
2952         trans->journal_replay_not_finished =
2953                 unlikely(!test_bit(JOURNAL_REPLAY_DONE, &c->journal.flags)) &&
2954                 atomic_inc_not_zero(&c->journal_keys.ref);
2955         trans->nr_paths         = ARRAY_SIZE(trans->_paths);
2956         trans->paths_allocated  = trans->_paths_allocated;
2957         trans->sorted           = trans->_sorted;
2958         trans->paths            = trans->_paths;
2959         trans->updates          = trans->_updates;
2960
2961         *trans_paths_nr(trans->paths) = BTREE_ITER_MAX;
2962
2963         trans->paths_allocated[0] = 1;
2964
2965         if (fn_idx < BCH_TRANSACTIONS_NR) {
2966                 trans->fn = bch2_btree_transaction_fns[fn_idx];
2967
2968                 struct btree_transaction_stats *s = &c->btree_transaction_stats[fn_idx];
2969
2970                 if (s->max_mem) {
2971                         unsigned expected_mem_bytes = roundup_pow_of_two(s->max_mem);
2972
2973                         trans->mem = kmalloc(expected_mem_bytes, GFP_KERNEL);
2974                         if (likely(trans->mem))
2975                                 trans->mem_bytes = expected_mem_bytes;
2976                 }
2977
2978                 trans->nr_paths_max = s->nr_max_paths;
2979                 trans->journal_entries_size = s->journal_entries_size;
2980         }
2981
2982         trans->srcu_idx         = srcu_read_lock(&c->btree_trans_barrier);
2983         trans->srcu_lock_time   = jiffies;
2984         trans->srcu_held        = true;
2985         return trans;
2986 }
2987
2988 static void check_btree_paths_leaked(struct btree_trans *trans)
2989 {
2990 #ifdef CONFIG_BCACHEFS_DEBUG
2991         struct bch_fs *c = trans->c;
2992         struct btree_path *path;
2993         unsigned i;
2994
2995         trans_for_each_path(trans, path, i)
2996                 if (path->ref)
2997                         goto leaked;
2998         return;
2999 leaked:
3000         bch_err(c, "btree paths leaked from %s!", trans->fn);
3001         trans_for_each_path(trans, path, i)
3002                 if (path->ref)
3003                         printk(KERN_ERR "  btree %s %pS\n",
3004                                bch2_btree_id_str(path->btree_id),
3005                                (void *) path->ip_allocated);
3006         /* Be noisy about this: */
3007         bch2_fatal_error(c);
3008 #endif
3009 }
3010
3011 void bch2_trans_put(struct btree_trans *trans)
3012         __releases(&c->btree_trans_barrier)
3013 {
3014         struct bch_fs *c = trans->c;
3015
3016         bch2_trans_unlock(trans);
3017
3018         trans_for_each_update(trans, i)
3019                 __btree_path_put(trans->paths + i->path, true);
3020         trans->nr_updates       = 0;
3021         trans->locking_wait.task = NULL;
3022
3023         check_btree_paths_leaked(trans);
3024
3025         if (trans->srcu_held) {
3026                 check_srcu_held_too_long(trans);
3027                 srcu_read_unlock(&c->btree_trans_barrier, trans->srcu_idx);
3028         }
3029
3030         if (trans->fs_usage_deltas) {
3031                 if (trans->fs_usage_deltas->size + sizeof(trans->fs_usage_deltas) ==
3032                     REPLICAS_DELTA_LIST_MAX)
3033                         mempool_free(trans->fs_usage_deltas,
3034                                      &c->replicas_delta_pool);
3035                 else
3036                         kfree(trans->fs_usage_deltas);
3037         }
3038
3039         if (unlikely(trans->journal_replay_not_finished))
3040                 bch2_journal_keys_put(c);
3041
3042         unsigned long *paths_allocated = trans->paths_allocated;
3043         trans->paths_allocated  = NULL;
3044         trans->paths            = NULL;
3045
3046         if (paths_allocated != trans->_paths_allocated)
3047                 kfree_rcu_mightsleep(paths_allocated);
3048
3049         if (trans->mem_bytes == BTREE_TRANS_MEM_MAX)
3050                 mempool_free(trans->mem, &c->btree_trans_mem_pool);
3051         else
3052                 kfree(trans->mem);
3053
3054         /* Userspace doesn't have a real percpu implementation: */
3055         if (IS_ENABLED(__KERNEL__))
3056                 trans = this_cpu_xchg(c->btree_trans_bufs->trans, trans);
3057
3058         if (trans) {
3059                 closure_sync(&trans->ref);
3060
3061                 seqmutex_lock(&c->btree_trans_lock);
3062                 list_del(&trans->list);
3063                 seqmutex_unlock(&c->btree_trans_lock);
3064
3065                 mempool_free(trans, &c->btree_trans_pool);
3066         }
3067 }
3068
3069 static void __maybe_unused
3070 bch2_btree_bkey_cached_common_to_text(struct printbuf *out,
3071                                       struct btree_bkey_cached_common *b)
3072 {
3073         struct six_lock_count c = six_lock_counts(&b->lock);
3074         struct task_struct *owner;
3075         pid_t pid;
3076
3077         rcu_read_lock();
3078         owner = READ_ONCE(b->lock.owner);
3079         pid = owner ? owner->pid : 0;
3080         rcu_read_unlock();
3081
3082         prt_tab(out);
3083         prt_printf(out, "%px %c l=%u %s:", b, b->cached ? 'c' : 'b',
3084                    b->level, bch2_btree_id_str(b->btree_id));
3085         bch2_bpos_to_text(out, btree_node_pos(b));
3086
3087         prt_tab(out);
3088         prt_printf(out, " locks %u:%u:%u held by pid %u",
3089                    c.n[0], c.n[1], c.n[2], pid);
3090 }
3091
3092 void bch2_btree_trans_to_text(struct printbuf *out, struct btree_trans *trans)
3093 {
3094         struct btree_bkey_cached_common *b;
3095         static char lock_types[] = { 'r', 'i', 'w' };
3096         struct task_struct *task = READ_ONCE(trans->locking_wait.task);
3097         unsigned l, idx;
3098
3099         /* before rcu_read_lock(): */
3100         bch2_printbuf_make_room(out, 4096);
3101
3102         if (!out->nr_tabstops) {
3103                 printbuf_tabstop_push(out, 16);
3104                 printbuf_tabstop_push(out, 32);
3105         }
3106
3107         prt_printf(out, "%i %s\n", task ? task->pid : 0, trans->fn);
3108
3109         /* trans->paths is rcu protected vs. freeing */
3110         rcu_read_lock();
3111         out->atomic++;
3112
3113         struct btree_path *paths = rcu_dereference(trans->paths);
3114         if (!paths)
3115                 goto out;
3116
3117         unsigned long *paths_allocated = trans_paths_allocated(paths);
3118
3119         trans_for_each_path_idx_from(paths_allocated, *trans_paths_nr(paths), idx, 1) {
3120                 struct btree_path *path = paths + idx;
3121                 if (!path->nodes_locked)
3122                         continue;
3123
3124                 prt_printf(out, "  path %u %c l=%u %s:",
3125                        idx,
3126                        path->cached ? 'c' : 'b',
3127                        path->level,
3128                        bch2_btree_id_str(path->btree_id));
3129                 bch2_bpos_to_text(out, path->pos);
3130                 prt_newline(out);
3131
3132                 for (l = 0; l < BTREE_MAX_DEPTH; l++) {
3133                         if (btree_node_locked(path, l) &&
3134                             !IS_ERR_OR_NULL(b = (void *) READ_ONCE(path->l[l].b))) {
3135                                 prt_printf(out, "    %c l=%u ",
3136                                            lock_types[btree_node_locked_type(path, l)], l);
3137                                 bch2_btree_bkey_cached_common_to_text(out, b);
3138                                 prt_newline(out);
3139                         }
3140                 }
3141         }
3142
3143         b = READ_ONCE(trans->locking);
3144         if (b) {
3145                 prt_printf(out, "  blocked for %lluus on",
3146                            div_u64(local_clock() - trans->locking_wait.start_time,
3147                                    1000));
3148                 prt_newline(out);
3149                 prt_printf(out, "    %c", lock_types[trans->locking_wait.lock_want]);
3150                 bch2_btree_bkey_cached_common_to_text(out, b);
3151                 prt_newline(out);
3152         }
3153 out:
3154         --out->atomic;
3155         rcu_read_unlock();
3156 }
3157
3158 void bch2_fs_btree_iter_exit(struct bch_fs *c)
3159 {
3160         struct btree_transaction_stats *s;
3161         struct btree_trans *trans;
3162         int cpu;
3163
3164         if (c->btree_trans_bufs)
3165                 for_each_possible_cpu(cpu) {
3166                         struct btree_trans *trans =
3167                                 per_cpu_ptr(c->btree_trans_bufs, cpu)->trans;
3168
3169                         if (trans) {
3170                                 closure_sync(&trans->ref);
3171
3172                                 seqmutex_lock(&c->btree_trans_lock);
3173                                 list_del(&trans->list);
3174                                 seqmutex_unlock(&c->btree_trans_lock);
3175                         }
3176                         kfree(trans);
3177                 }
3178         free_percpu(c->btree_trans_bufs);
3179
3180         trans = list_first_entry_or_null(&c->btree_trans_list, struct btree_trans, list);
3181         if (trans)
3182                 panic("%s leaked btree_trans\n", trans->fn);
3183
3184         for (s = c->btree_transaction_stats;
3185              s < c->btree_transaction_stats + ARRAY_SIZE(c->btree_transaction_stats);
3186              s++) {
3187                 kfree(s->max_paths_text);
3188                 bch2_time_stats_exit(&s->lock_hold_times);
3189         }
3190
3191         if (c->btree_trans_barrier_initialized)
3192                 cleanup_srcu_struct(&c->btree_trans_barrier);
3193         mempool_exit(&c->btree_trans_mem_pool);
3194         mempool_exit(&c->btree_trans_pool);
3195 }
3196
3197 void bch2_fs_btree_iter_init_early(struct bch_fs *c)
3198 {
3199         struct btree_transaction_stats *s;
3200
3201         for (s = c->btree_transaction_stats;
3202              s < c->btree_transaction_stats + ARRAY_SIZE(c->btree_transaction_stats);
3203              s++) {
3204                 bch2_time_stats_init(&s->lock_hold_times);
3205                 mutex_init(&s->lock);
3206         }
3207
3208         INIT_LIST_HEAD(&c->btree_trans_list);
3209         seqmutex_init(&c->btree_trans_lock);
3210 }
3211
3212 int bch2_fs_btree_iter_init(struct bch_fs *c)
3213 {
3214         int ret;
3215
3216         c->btree_trans_bufs = alloc_percpu(struct btree_trans_buf);
3217         if (!c->btree_trans_bufs)
3218                 return -ENOMEM;
3219
3220         ret   = mempool_init_kmalloc_pool(&c->btree_trans_pool, 1,
3221                                           sizeof(struct btree_trans)) ?:
3222                 mempool_init_kmalloc_pool(&c->btree_trans_mem_pool, 1,
3223                                           BTREE_TRANS_MEM_MAX) ?:
3224                 init_srcu_struct(&c->btree_trans_barrier);
3225         if (!ret)
3226                 c->btree_trans_barrier_initialized = true;
3227         return ret;
3228 }