]> git.sesse.net Git - bcachefs-tools-debian/blob - libbcachefs/btree_update.c
Merge pull request #190 from Dikay900/fs_free_space
[bcachefs-tools-debian] / libbcachefs / btree_update.c
1 // SPDX-License-Identifier: GPL-2.0
2
3 #include "bcachefs.h"
4 #include "btree_update.h"
5 #include "btree_iter.h"
6 #include "btree_journal_iter.h"
7 #include "btree_locking.h"
8 #include "buckets.h"
9 #include "debug.h"
10 #include "errcode.h"
11 #include "error.h"
12 #include "extents.h"
13 #include "keylist.h"
14 #include "snapshot.h"
15 #include "trace.h"
16
17 static inline int btree_insert_entry_cmp(const struct btree_insert_entry *l,
18                                          const struct btree_insert_entry *r)
19 {
20         return   cmp_int(l->btree_id,   r->btree_id) ?:
21                  cmp_int(l->cached,     r->cached) ?:
22                  -cmp_int(l->level,     r->level) ?:
23                  bpos_cmp(l->k->k.p,    r->k->k.p);
24 }
25
26 static int __must_check
27 bch2_trans_update_by_path(struct btree_trans *, struct btree_path *,
28                           struct bkey_i *, enum btree_update_flags,
29                           unsigned long ip);
30
31 static noinline int extent_front_merge(struct btree_trans *trans,
32                                        struct btree_iter *iter,
33                                        struct bkey_s_c k,
34                                        struct bkey_i **insert,
35                                        enum btree_update_flags flags)
36 {
37         struct bch_fs *c = trans->c;
38         struct bkey_i *update;
39         int ret;
40
41         update = bch2_bkey_make_mut_noupdate(trans, k);
42         ret = PTR_ERR_OR_ZERO(update);
43         if (ret)
44                 return ret;
45
46         if (!bch2_bkey_merge(c, bkey_i_to_s(update), bkey_i_to_s_c(*insert)))
47                 return 0;
48
49         ret =   bch2_key_has_snapshot_overwrites(trans, iter->btree_id, k.k->p) ?:
50                 bch2_key_has_snapshot_overwrites(trans, iter->btree_id, (*insert)->k.p);
51         if (ret < 0)
52                 return ret;
53         if (ret)
54                 return 0;
55
56         ret = bch2_btree_delete_at(trans, iter, flags);
57         if (ret)
58                 return ret;
59
60         *insert = update;
61         return 0;
62 }
63
64 static noinline int extent_back_merge(struct btree_trans *trans,
65                                       struct btree_iter *iter,
66                                       struct bkey_i *insert,
67                                       struct bkey_s_c k)
68 {
69         struct bch_fs *c = trans->c;
70         int ret;
71
72         ret =   bch2_key_has_snapshot_overwrites(trans, iter->btree_id, insert->k.p) ?:
73                 bch2_key_has_snapshot_overwrites(trans, iter->btree_id, k.k->p);
74         if (ret < 0)
75                 return ret;
76         if (ret)
77                 return 0;
78
79         bch2_bkey_merge(c, bkey_i_to_s(insert), k);
80         return 0;
81 }
82
83 /*
84  * When deleting, check if we need to emit a whiteout (because we're overwriting
85  * something in an ancestor snapshot)
86  */
87 static int need_whiteout_for_snapshot(struct btree_trans *trans,
88                                       enum btree_id btree_id, struct bpos pos)
89 {
90         struct btree_iter iter;
91         struct bkey_s_c k;
92         u32 snapshot = pos.snapshot;
93         int ret;
94
95         if (!bch2_snapshot_parent(trans->c, pos.snapshot))
96                 return 0;
97
98         pos.snapshot++;
99
100         for_each_btree_key_norestart(trans, iter, btree_id, pos,
101                            BTREE_ITER_ALL_SNAPSHOTS|
102                            BTREE_ITER_NOPRESERVE, k, ret) {
103                 if (!bkey_eq(k.k->p, pos))
104                         break;
105
106                 if (bch2_snapshot_is_ancestor(trans->c, snapshot,
107                                               k.k->p.snapshot)) {
108                         ret = !bkey_whiteout(k.k);
109                         break;
110                 }
111         }
112         bch2_trans_iter_exit(trans, &iter);
113
114         return ret;
115 }
116
117 int __bch2_insert_snapshot_whiteouts(struct btree_trans *trans,
118                                    enum btree_id id,
119                                    struct bpos old_pos,
120                                    struct bpos new_pos)
121 {
122         struct bch_fs *c = trans->c;
123         struct btree_iter old_iter, new_iter = { NULL };
124         struct bkey_s_c old_k, new_k;
125         snapshot_id_list s;
126         struct bkey_i *update;
127         int ret = 0;
128
129         if (!bch2_snapshot_has_children(c, old_pos.snapshot))
130                 return 0;
131
132         darray_init(&s);
133
134         bch2_trans_iter_init(trans, &old_iter, id, old_pos,
135                              BTREE_ITER_NOT_EXTENTS|
136                              BTREE_ITER_ALL_SNAPSHOTS);
137         while ((old_k = bch2_btree_iter_prev(&old_iter)).k &&
138                !(ret = bkey_err(old_k)) &&
139                bkey_eq(old_pos, old_k.k->p)) {
140                 struct bpos whiteout_pos =
141                         SPOS(new_pos.inode, new_pos.offset, old_k.k->p.snapshot);;
142
143                 if (!bch2_snapshot_is_ancestor(c, old_k.k->p.snapshot, old_pos.snapshot) ||
144                     snapshot_list_has_ancestor(c, &s, old_k.k->p.snapshot))
145                         continue;
146
147                 new_k = bch2_bkey_get_iter(trans, &new_iter, id, whiteout_pos,
148                                            BTREE_ITER_NOT_EXTENTS|
149                                            BTREE_ITER_INTENT);
150                 ret = bkey_err(new_k);
151                 if (ret)
152                         break;
153
154                 if (new_k.k->type == KEY_TYPE_deleted) {
155                         update = bch2_trans_kmalloc(trans, sizeof(struct bkey_i));
156                         ret = PTR_ERR_OR_ZERO(update);
157                         if (ret)
158                                 break;
159
160                         bkey_init(&update->k);
161                         update->k.p             = whiteout_pos;
162                         update->k.type          = KEY_TYPE_whiteout;
163
164                         ret = bch2_trans_update(trans, &new_iter, update,
165                                                 BTREE_UPDATE_INTERNAL_SNAPSHOT_NODE);
166                 }
167                 bch2_trans_iter_exit(trans, &new_iter);
168
169                 ret = snapshot_list_add(c, &s, old_k.k->p.snapshot);
170                 if (ret)
171                         break;
172         }
173         bch2_trans_iter_exit(trans, &new_iter);
174         bch2_trans_iter_exit(trans, &old_iter);
175         darray_exit(&s);
176
177         return ret;
178 }
179
180 int bch2_trans_update_extent_overwrite(struct btree_trans *trans,
181                                        struct btree_iter *iter,
182                                        enum btree_update_flags flags,
183                                        struct bkey_s_c old,
184                                        struct bkey_s_c new)
185 {
186         enum btree_id btree_id = iter->btree_id;
187         struct bkey_i *update;
188         struct bpos new_start = bkey_start_pos(new.k);
189         bool front_split = bkey_lt(bkey_start_pos(old.k), new_start);
190         bool back_split  = bkey_gt(old.k->p, new.k->p);
191         int ret = 0, compressed_sectors;
192
193         /*
194          * If we're going to be splitting a compressed extent, note it
195          * so that __bch2_trans_commit() can increase our disk
196          * reservation:
197          */
198         if (((front_split && back_split) ||
199              ((front_split || back_split) && old.k->p.snapshot != new.k->p.snapshot)) &&
200             (compressed_sectors = bch2_bkey_sectors_compressed(old)))
201                 trans->extra_journal_res += compressed_sectors;
202
203         if (front_split) {
204                 update = bch2_bkey_make_mut_noupdate(trans, old);
205                 if ((ret = PTR_ERR_OR_ZERO(update)))
206                         return ret;
207
208                 bch2_cut_back(new_start, update);
209
210                 ret =   bch2_insert_snapshot_whiteouts(trans, btree_id,
211                                         old.k->p, update->k.p) ?:
212                         bch2_btree_insert_nonextent(trans, btree_id, update,
213                                         BTREE_UPDATE_INTERNAL_SNAPSHOT_NODE|flags);
214                 if (ret)
215                         return ret;
216         }
217
218         /* If we're overwriting in a different snapshot - middle split: */
219         if (old.k->p.snapshot != new.k->p.snapshot &&
220             (front_split || back_split)) {
221                 update = bch2_bkey_make_mut_noupdate(trans, old);
222                 if ((ret = PTR_ERR_OR_ZERO(update)))
223                         return ret;
224
225                 bch2_cut_front(new_start, update);
226                 bch2_cut_back(new.k->p, update);
227
228                 ret =   bch2_insert_snapshot_whiteouts(trans, btree_id,
229                                         old.k->p, update->k.p) ?:
230                         bch2_btree_insert_nonextent(trans, btree_id, update,
231                                           BTREE_UPDATE_INTERNAL_SNAPSHOT_NODE|flags);
232                 if (ret)
233                         return ret;
234         }
235
236         if (bkey_le(old.k->p, new.k->p)) {
237                 update = bch2_trans_kmalloc(trans, sizeof(*update));
238                 if ((ret = PTR_ERR_OR_ZERO(update)))
239                         return ret;
240
241                 bkey_init(&update->k);
242                 update->k.p = old.k->p;
243                 update->k.p.snapshot = new.k->p.snapshot;
244
245                 if (new.k->p.snapshot != old.k->p.snapshot) {
246                         update->k.type = KEY_TYPE_whiteout;
247                 } else if (btree_type_has_snapshots(btree_id)) {
248                         ret = need_whiteout_for_snapshot(trans, btree_id, update->k.p);
249                         if (ret < 0)
250                                 return ret;
251                         if (ret)
252                                 update->k.type = KEY_TYPE_whiteout;
253                 }
254
255                 ret = bch2_btree_insert_nonextent(trans, btree_id, update,
256                                           BTREE_UPDATE_INTERNAL_SNAPSHOT_NODE|flags);
257                 if (ret)
258                         return ret;
259         }
260
261         if (back_split) {
262                 update = bch2_bkey_make_mut_noupdate(trans, old);
263                 if ((ret = PTR_ERR_OR_ZERO(update)))
264                         return ret;
265
266                 bch2_cut_front(new.k->p, update);
267
268                 ret = bch2_trans_update_by_path(trans, iter->path, update,
269                                           BTREE_UPDATE_INTERNAL_SNAPSHOT_NODE|
270                                           flags, _RET_IP_);
271                 if (ret)
272                         return ret;
273         }
274
275         return 0;
276 }
277
278 static int bch2_trans_update_extent(struct btree_trans *trans,
279                                     struct btree_iter *orig_iter,
280                                     struct bkey_i *insert,
281                                     enum btree_update_flags flags)
282 {
283         struct btree_iter iter;
284         struct bkey_s_c k;
285         enum btree_id btree_id = orig_iter->btree_id;
286         int ret = 0;
287
288         bch2_trans_iter_init(trans, &iter, btree_id, bkey_start_pos(&insert->k),
289                              BTREE_ITER_INTENT|
290                              BTREE_ITER_WITH_UPDATES|
291                              BTREE_ITER_NOT_EXTENTS);
292         k = bch2_btree_iter_peek_upto(&iter, POS(insert->k.p.inode, U64_MAX));
293         if ((ret = bkey_err(k)))
294                 goto err;
295         if (!k.k)
296                 goto out;
297
298         if (bkey_eq(k.k->p, bkey_start_pos(&insert->k))) {
299                 if (bch2_bkey_maybe_mergable(k.k, &insert->k)) {
300                         ret = extent_front_merge(trans, &iter, k, &insert, flags);
301                         if (ret)
302                                 goto err;
303                 }
304
305                 goto next;
306         }
307
308         while (bkey_gt(insert->k.p, bkey_start_pos(k.k))) {
309                 bool done = bkey_lt(insert->k.p, k.k->p);
310
311                 ret = bch2_trans_update_extent_overwrite(trans, &iter, flags, k, bkey_i_to_s_c(insert));
312                 if (ret)
313                         goto err;
314
315                 if (done)
316                         goto out;
317 next:
318                 bch2_btree_iter_advance(&iter);
319                 k = bch2_btree_iter_peek_upto(&iter, POS(insert->k.p.inode, U64_MAX));
320                 if ((ret = bkey_err(k)))
321                         goto err;
322                 if (!k.k)
323                         goto out;
324         }
325
326         if (bch2_bkey_maybe_mergable(&insert->k, k.k)) {
327                 ret = extent_back_merge(trans, &iter, insert, k);
328                 if (ret)
329                         goto err;
330         }
331 out:
332         if (!bkey_deleted(&insert->k))
333                 ret = bch2_btree_insert_nonextent(trans, btree_id, insert, flags);
334 err:
335         bch2_trans_iter_exit(trans, &iter);
336
337         return ret;
338 }
339
340 static noinline int flush_new_cached_update(struct btree_trans *trans,
341                                             struct btree_path *path,
342                                             struct btree_insert_entry *i,
343                                             enum btree_update_flags flags,
344                                             unsigned long ip)
345 {
346         struct btree_path *btree_path;
347         struct bkey k;
348         int ret;
349
350         btree_path = bch2_path_get(trans, path->btree_id, path->pos, 1, 0,
351                                    BTREE_ITER_INTENT, _THIS_IP_);
352         ret = bch2_btree_path_traverse(trans, btree_path, 0);
353         if (ret)
354                 goto out;
355
356         /*
357          * The old key in the insert entry might actually refer to an existing
358          * key in the btree that has been deleted from cache and not yet
359          * flushed. Check for this and skip the flush so we don't run triggers
360          * against a stale key.
361          */
362         bch2_btree_path_peek_slot_exact(btree_path, &k);
363         if (!bkey_deleted(&k))
364                 goto out;
365
366         i->key_cache_already_flushed = true;
367         i->flags |= BTREE_TRIGGER_NORUN;
368
369         btree_path_set_should_be_locked(btree_path);
370         ret = bch2_trans_update_by_path(trans, btree_path, i->k, flags, ip);
371 out:
372         bch2_path_put(trans, btree_path, true);
373         return ret;
374 }
375
376 static int __must_check
377 bch2_trans_update_by_path(struct btree_trans *trans, struct btree_path *path,
378                           struct bkey_i *k, enum btree_update_flags flags,
379                           unsigned long ip)
380 {
381         struct bch_fs *c = trans->c;
382         struct btree_insert_entry *i, n;
383         int cmp;
384
385         EBUG_ON(!path->should_be_locked);
386         EBUG_ON(trans->nr_updates >= BTREE_ITER_MAX);
387         EBUG_ON(!bpos_eq(k->k.p, path->pos));
388
389         n = (struct btree_insert_entry) {
390                 .flags          = flags,
391                 .bkey_type      = __btree_node_type(path->level, path->btree_id),
392                 .btree_id       = path->btree_id,
393                 .level          = path->level,
394                 .cached         = path->cached,
395                 .path           = path,
396                 .k              = k,
397                 .ip_allocated   = ip,
398         };
399
400 #ifdef CONFIG_BCACHEFS_DEBUG
401         trans_for_each_update(trans, i)
402                 BUG_ON(i != trans->updates &&
403                        btree_insert_entry_cmp(i - 1, i) >= 0);
404 #endif
405
406         /*
407          * Pending updates are kept sorted: first, find position of new update,
408          * then delete/trim any updates the new update overwrites:
409          */
410         trans_for_each_update(trans, i) {
411                 cmp = btree_insert_entry_cmp(&n, i);
412                 if (cmp <= 0)
413                         break;
414         }
415
416         if (!cmp && i < trans->updates + trans->nr_updates) {
417                 EBUG_ON(i->insert_trigger_run || i->overwrite_trigger_run);
418
419                 bch2_path_put(trans, i->path, true);
420                 i->flags        = n.flags;
421                 i->cached       = n.cached;
422                 i->k            = n.k;
423                 i->path         = n.path;
424                 i->ip_allocated = n.ip_allocated;
425         } else {
426                 array_insert_item(trans->updates, trans->nr_updates,
427                                   i - trans->updates, n);
428
429                 i->old_v = bch2_btree_path_peek_slot_exact(path, &i->old_k).v;
430                 i->old_btree_u64s = !bkey_deleted(&i->old_k) ? i->old_k.u64s : 0;
431
432                 if (unlikely(trans->journal_replay_not_finished)) {
433                         struct bkey_i *j_k =
434                                 bch2_journal_keys_peek_slot(c, n.btree_id, n.level, k->k.p);
435
436                         if (j_k) {
437                                 i->old_k = j_k->k;
438                                 i->old_v = &j_k->v;
439                         }
440                 }
441         }
442
443         __btree_path_get(i->path, true);
444
445         /*
446          * If a key is present in the key cache, it must also exist in the
447          * btree - this is necessary for cache coherency. When iterating over
448          * a btree that's cached in the key cache, the btree iter code checks
449          * the key cache - but the key has to exist in the btree for that to
450          * work:
451          */
452         if (path->cached && bkey_deleted(&i->old_k))
453                 return flush_new_cached_update(trans, path, i, flags, ip);
454
455         return 0;
456 }
457
458 static noinline int bch2_trans_update_get_key_cache(struct btree_trans *trans,
459                                                     struct btree_iter *iter,
460                                                     struct btree_path *path)
461 {
462         if (!iter->key_cache_path ||
463             !iter->key_cache_path->should_be_locked ||
464             !bpos_eq(iter->key_cache_path->pos, iter->pos)) {
465                 struct bkey_cached *ck;
466                 int ret;
467
468                 if (!iter->key_cache_path)
469                         iter->key_cache_path =
470                                 bch2_path_get(trans, path->btree_id, path->pos, 1, 0,
471                                               BTREE_ITER_INTENT|
472                                               BTREE_ITER_CACHED, _THIS_IP_);
473
474                 iter->key_cache_path =
475                         bch2_btree_path_set_pos(trans, iter->key_cache_path, path->pos,
476                                                 iter->flags & BTREE_ITER_INTENT,
477                                                 _THIS_IP_);
478
479                 ret = bch2_btree_path_traverse(trans, iter->key_cache_path,
480                                                BTREE_ITER_CACHED);
481                 if (unlikely(ret))
482                         return ret;
483
484                 ck = (void *) iter->key_cache_path->l[0].b;
485
486                 if (test_bit(BKEY_CACHED_DIRTY, &ck->flags)) {
487                         trace_and_count(trans->c, trans_restart_key_cache_raced, trans, _RET_IP_);
488                         return btree_trans_restart(trans, BCH_ERR_transaction_restart_key_cache_raced);
489                 }
490
491                 btree_path_set_should_be_locked(iter->key_cache_path);
492         }
493
494         return 0;
495 }
496
497 int __must_check bch2_trans_update(struct btree_trans *trans, struct btree_iter *iter,
498                                    struct bkey_i *k, enum btree_update_flags flags)
499 {
500         struct btree_path *path = iter->update_path ?: iter->path;
501         int ret;
502
503         if (iter->flags & BTREE_ITER_IS_EXTENTS)
504                 return bch2_trans_update_extent(trans, iter, k, flags);
505
506         if (bkey_deleted(&k->k) &&
507             !(flags & BTREE_UPDATE_KEY_CACHE_RECLAIM) &&
508             (iter->flags & BTREE_ITER_FILTER_SNAPSHOTS)) {
509                 ret = need_whiteout_for_snapshot(trans, iter->btree_id, k->k.p);
510                 if (unlikely(ret < 0))
511                         return ret;
512
513                 if (ret)
514                         k->k.type = KEY_TYPE_whiteout;
515         }
516
517         /*
518          * Ensure that updates to cached btrees go to the key cache:
519          */
520         if (!(flags & BTREE_UPDATE_KEY_CACHE_RECLAIM) &&
521             !path->cached &&
522             !path->level &&
523             btree_id_cached(trans->c, path->btree_id)) {
524                 ret = bch2_trans_update_get_key_cache(trans, iter, path);
525                 if (ret)
526                         return ret;
527
528                 path = iter->key_cache_path;
529         }
530
531         return bch2_trans_update_by_path(trans, path, k, flags, _RET_IP_);
532 }
533
534 static noinline int bch2_btree_insert_clone_trans(struct btree_trans *trans,
535                                                   enum btree_id btree,
536                                                   struct bkey_i *k)
537 {
538         struct bkey_i *n = bch2_trans_kmalloc(trans, bkey_bytes(&k->k));
539         int ret = PTR_ERR_OR_ZERO(n);
540         if (ret)
541                 return ret;
542
543         bkey_copy(n, k);
544         return bch2_btree_insert_trans(trans, btree, n, 0);
545 }
546
547 int __must_check bch2_trans_update_buffered(struct btree_trans *trans,
548                                             enum btree_id btree,
549                                             struct bkey_i *k)
550 {
551         struct btree_write_buffered_key *i;
552         int ret;
553
554         EBUG_ON(trans->nr_wb_updates > trans->wb_updates_size);
555         EBUG_ON(k->k.u64s > BTREE_WRITE_BUFERED_U64s_MAX);
556
557         if (unlikely(trans->journal_replay_not_finished))
558                 return bch2_btree_insert_clone_trans(trans, btree, k);
559
560         trans_for_each_wb_update(trans, i) {
561                 if (i->btree == btree && bpos_eq(i->k.k.p, k->k.p)) {
562                         bkey_copy(&i->k, k);
563                         return 0;
564                 }
565         }
566
567         if (!trans->wb_updates ||
568             trans->nr_wb_updates == trans->wb_updates_size) {
569                 struct btree_write_buffered_key *u;
570
571                 if (trans->nr_wb_updates == trans->wb_updates_size) {
572                         struct btree_transaction_stats *s = btree_trans_stats(trans);
573
574                         BUG_ON(trans->wb_updates_size > U8_MAX / 2);
575                         trans->wb_updates_size = max(1, trans->wb_updates_size * 2);
576                         if (s)
577                                 s->wb_updates_size = trans->wb_updates_size;
578                 }
579
580                 u = bch2_trans_kmalloc_nomemzero(trans,
581                                         trans->wb_updates_size *
582                                         sizeof(struct btree_write_buffered_key));
583                 ret = PTR_ERR_OR_ZERO(u);
584                 if (ret)
585                         return ret;
586
587                 if (trans->nr_wb_updates)
588                         memcpy(u, trans->wb_updates, trans->nr_wb_updates *
589                                sizeof(struct btree_write_buffered_key));
590                 trans->wb_updates = u;
591         }
592
593         trans->wb_updates[trans->nr_wb_updates] = (struct btree_write_buffered_key) {
594                 .btree  = btree,
595         };
596
597         bkey_copy(&trans->wb_updates[trans->nr_wb_updates].k, k);
598         trans->nr_wb_updates++;
599
600         return 0;
601 }
602
603 int bch2_bkey_get_empty_slot(struct btree_trans *trans, struct btree_iter *iter,
604                              enum btree_id btree, struct bpos end)
605 {
606         struct bkey_s_c k;
607         int ret = 0;
608
609         bch2_trans_iter_init(trans, iter, btree, POS_MAX, BTREE_ITER_INTENT);
610         k = bch2_btree_iter_prev(iter);
611         ret = bkey_err(k);
612         if (ret)
613                 goto err;
614
615         bch2_btree_iter_advance(iter);
616         k = bch2_btree_iter_peek_slot(iter);
617         ret = bkey_err(k);
618         if (ret)
619                 goto err;
620
621         BUG_ON(k.k->type != KEY_TYPE_deleted);
622
623         if (bkey_gt(k.k->p, end)) {
624                 ret = -BCH_ERR_ENOSPC_btree_slot;
625                 goto err;
626         }
627
628         return 0;
629 err:
630         bch2_trans_iter_exit(trans, iter);
631         return ret;
632 }
633
634 void bch2_trans_commit_hook(struct btree_trans *trans,
635                             struct btree_trans_commit_hook *h)
636 {
637         h->next = trans->hooks;
638         trans->hooks = h;
639 }
640
641 int bch2_btree_insert_nonextent(struct btree_trans *trans,
642                                 enum btree_id btree, struct bkey_i *k,
643                                 enum btree_update_flags flags)
644 {
645         struct btree_iter iter;
646         int ret;
647
648         bch2_trans_iter_init(trans, &iter, btree, k->k.p,
649                              BTREE_ITER_CACHED|
650                              BTREE_ITER_NOT_EXTENTS|
651                              BTREE_ITER_INTENT);
652         ret   = bch2_btree_iter_traverse(&iter) ?:
653                 bch2_trans_update(trans, &iter, k, flags);
654         bch2_trans_iter_exit(trans, &iter);
655         return ret;
656 }
657
658 int bch2_btree_insert_trans(struct btree_trans *trans, enum btree_id id,
659                             struct bkey_i *k, enum btree_update_flags flags)
660 {
661         struct btree_iter iter;
662         int ret;
663
664         bch2_trans_iter_init(trans, &iter, id, bkey_start_pos(&k->k),
665                              BTREE_ITER_CACHED|
666                              BTREE_ITER_INTENT);
667         ret   = bch2_btree_iter_traverse(&iter) ?:
668                 bch2_trans_update(trans, &iter, k, flags);
669         bch2_trans_iter_exit(trans, &iter);
670         return ret;
671 }
672
673 /**
674  * bch2_btree_insert - insert keys into the extent btree
675  * @c:                  pointer to struct bch_fs
676  * @id:                 btree to insert into
677  * @k:                  key to insert
678  * @disk_res:           must be non-NULL whenever inserting or potentially
679  *                      splitting data extents
680  * @flags:              transaction commit flags
681  *
682  * Returns:             0 on success, error code on failure
683  */
684 int bch2_btree_insert(struct bch_fs *c, enum btree_id id, struct bkey_i *k,
685                       struct disk_reservation *disk_res, int flags)
686 {
687         return bch2_trans_do(c, disk_res, NULL, flags,
688                              bch2_btree_insert_trans(trans, id, k, 0));
689 }
690
691 int bch2_btree_delete_extent_at(struct btree_trans *trans, struct btree_iter *iter,
692                                 unsigned len, unsigned update_flags)
693 {
694         struct bkey_i *k;
695
696         k = bch2_trans_kmalloc(trans, sizeof(*k));
697         if (IS_ERR(k))
698                 return PTR_ERR(k);
699
700         bkey_init(&k->k);
701         k->k.p = iter->pos;
702         bch2_key_resize(&k->k, len);
703         return bch2_trans_update(trans, iter, k, update_flags);
704 }
705
706 int bch2_btree_delete_at(struct btree_trans *trans,
707                          struct btree_iter *iter, unsigned update_flags)
708 {
709         return bch2_btree_delete_extent_at(trans, iter, 0, update_flags);
710 }
711
712 int bch2_btree_delete(struct btree_trans *trans,
713                       enum btree_id btree, struct bpos pos,
714                       unsigned update_flags)
715 {
716         struct btree_iter iter;
717         int ret;
718
719         bch2_trans_iter_init(trans, &iter, btree, pos,
720                              BTREE_ITER_CACHED|
721                              BTREE_ITER_INTENT);
722         ret   = bch2_btree_iter_traverse(&iter) ?:
723                 bch2_btree_delete_at(trans, &iter, update_flags);
724         bch2_trans_iter_exit(trans, &iter);
725
726         return ret;
727 }
728
729 int bch2_btree_delete_range_trans(struct btree_trans *trans, enum btree_id id,
730                                   struct bpos start, struct bpos end,
731                                   unsigned update_flags,
732                                   u64 *journal_seq)
733 {
734         u32 restart_count = trans->restart_count;
735         struct btree_iter iter;
736         struct bkey_s_c k;
737         int ret = 0;
738
739         bch2_trans_iter_init(trans, &iter, id, start, BTREE_ITER_INTENT);
740         while ((k = bch2_btree_iter_peek_upto(&iter, end)).k) {
741                 struct disk_reservation disk_res =
742                         bch2_disk_reservation_init(trans->c, 0);
743                 struct bkey_i delete;
744
745                 ret = bkey_err(k);
746                 if (ret)
747                         goto err;
748
749                 bkey_init(&delete.k);
750
751                 /*
752                  * This could probably be more efficient for extents:
753                  */
754
755                 /*
756                  * For extents, iter.pos won't necessarily be the same as
757                  * bkey_start_pos(k.k) (for non extents they always will be the
758                  * same). It's important that we delete starting from iter.pos
759                  * because the range we want to delete could start in the middle
760                  * of k.
761                  *
762                  * (bch2_btree_iter_peek() does guarantee that iter.pos >=
763                  * bkey_start_pos(k.k)).
764                  */
765                 delete.k.p = iter.pos;
766
767                 if (iter.flags & BTREE_ITER_IS_EXTENTS)
768                         bch2_key_resize(&delete.k,
769                                         bpos_min(end, k.k->p).offset -
770                                         iter.pos.offset);
771
772                 ret   = bch2_trans_update(trans, &iter, &delete, update_flags) ?:
773                         bch2_trans_commit(trans, &disk_res, journal_seq,
774                                           BCH_TRANS_COMMIT_no_enospc);
775                 bch2_disk_reservation_put(trans->c, &disk_res);
776 err:
777                 /*
778                  * the bch2_trans_begin() call is in a weird place because we
779                  * need to call it after every transaction commit, to avoid path
780                  * overflow, but don't want to call it if the delete operation
781                  * is a no-op and we have no work to do:
782                  */
783                 bch2_trans_begin(trans);
784
785                 if (bch2_err_matches(ret, BCH_ERR_transaction_restart))
786                         ret = 0;
787                 if (ret)
788                         break;
789         }
790         bch2_trans_iter_exit(trans, &iter);
791
792         return ret ?: trans_was_restarted(trans, restart_count);
793 }
794
795 /*
796  * bch_btree_delete_range - delete everything within a given range
797  *
798  * Range is a half open interval - [start, end)
799  */
800 int bch2_btree_delete_range(struct bch_fs *c, enum btree_id id,
801                             struct bpos start, struct bpos end,
802                             unsigned update_flags,
803                             u64 *journal_seq)
804 {
805         int ret = bch2_trans_run(c,
806                         bch2_btree_delete_range_trans(trans, id, start, end,
807                                                       update_flags, journal_seq));
808         if (ret == -BCH_ERR_transaction_restart_nested)
809                 ret = 0;
810         return ret;
811 }
812
813 int bch2_btree_bit_mod(struct btree_trans *trans, enum btree_id btree,
814                        struct bpos pos, bool set)
815 {
816         struct bkey_i k;
817
818         bkey_init(&k.k);
819         k.k.type = set ? KEY_TYPE_set : KEY_TYPE_deleted;
820         k.k.p = pos;
821
822         return bch2_trans_update_buffered(trans, btree, &k);
823 }
824
825 __printf(2, 0)
826 static int __bch2_trans_log_msg(darray_u64 *entries, const char *fmt, va_list args)
827 {
828         struct printbuf buf = PRINTBUF;
829         struct jset_entry_log *l;
830         unsigned u64s;
831         int ret;
832
833         prt_vprintf(&buf, fmt, args);
834         ret = buf.allocation_failure ? -BCH_ERR_ENOMEM_trans_log_msg : 0;
835         if (ret)
836                 goto err;
837
838         u64s = DIV_ROUND_UP(buf.pos, sizeof(u64));
839
840         ret = darray_make_room(entries, jset_u64s(u64s));
841         if (ret)
842                 goto err;
843
844         l = (void *) &darray_top(*entries);
845         l->entry.u64s           = cpu_to_le16(u64s);
846         l->entry.btree_id       = 0;
847         l->entry.level          = 1;
848         l->entry.type           = BCH_JSET_ENTRY_log;
849         l->entry.pad[0]         = 0;
850         l->entry.pad[1]         = 0;
851         l->entry.pad[2]         = 0;
852         memcpy(l->d, buf.buf, buf.pos);
853         while (buf.pos & 7)
854                 l->d[buf.pos++] = '\0';
855
856         entries->nr += jset_u64s(u64s);
857 err:
858         printbuf_exit(&buf);
859         return ret;
860 }
861
862 __printf(3, 0)
863 static int
864 __bch2_fs_log_msg(struct bch_fs *c, unsigned commit_flags, const char *fmt,
865                   va_list args)
866 {
867         int ret;
868
869         if (!test_bit(JOURNAL_STARTED, &c->journal.flags)) {
870                 ret = __bch2_trans_log_msg(&c->journal.early_journal_entries, fmt, args);
871         } else {
872                 ret = bch2_trans_do(c, NULL, NULL,
873                         BCH_TRANS_COMMIT_lazy_rw|commit_flags,
874                         __bch2_trans_log_msg(&trans->extra_journal_entries, fmt, args));
875         }
876
877         return ret;
878 }
879
880 __printf(2, 3)
881 int bch2_fs_log_msg(struct bch_fs *c, const char *fmt, ...)
882 {
883         va_list args;
884         int ret;
885
886         va_start(args, fmt);
887         ret = __bch2_fs_log_msg(c, 0, fmt, args);
888         va_end(args);
889         return ret;
890 }
891
892 /*
893  * Use for logging messages during recovery to enable reserved space and avoid
894  * blocking.
895  */
896 __printf(2, 3)
897 int bch2_journal_log_msg(struct bch_fs *c, const char *fmt, ...)
898 {
899         va_list args;
900         int ret;
901
902         va_start(args, fmt);
903         ret = __bch2_fs_log_msg(c, BCH_WATERMARK_reclaim, fmt, args);
904         va_end(args);
905         return ret;
906 }