]> git.sesse.net Git - bcachefs-tools-debian/blob - libbcachefs/btree_update_leaf.c
Update bcachefs sources to 25de2b00dc bcachefs: Change check for invalid key types
[bcachefs-tools-debian] / libbcachefs / btree_update_leaf.c
1 // SPDX-License-Identifier: GPL-2.0
2
3 #include "bcachefs.h"
4 #include "btree_update.h"
5 #include "btree_update_interior.h"
6 #include "btree_gc.h"
7 #include "btree_io.h"
8 #include "btree_iter.h"
9 #include "btree_key_cache.h"
10 #include "btree_locking.h"
11 #include "btree_write_buffer.h"
12 #include "buckets.h"
13 #include "debug.h"
14 #include "errcode.h"
15 #include "error.h"
16 #include "extent_update.h"
17 #include "journal.h"
18 #include "journal_reclaim.h"
19 #include "keylist.h"
20 #include "recovery.h"
21 #include "subvolume.h"
22 #include "replicas.h"
23 #include "trace.h"
24
25 #include <linux/prefetch.h>
26 #include <linux/sort.h>
27
28 /*
29  * bch2_btree_path_peek_slot() for a cached iterator might return a key in a
30  * different snapshot:
31  */
32 static struct bkey_s_c bch2_btree_path_peek_slot_exact(struct btree_path *path, struct bkey *u)
33 {
34         struct bkey_s_c k = bch2_btree_path_peek_slot(path, u);
35
36         if (k.k && bpos_eq(path->pos, k.k->p))
37                 return k;
38
39         bkey_init(u);
40         u->p = path->pos;
41         return (struct bkey_s_c) { u, NULL };
42 }
43
44 static void verify_update_old_key(struct btree_trans *trans, struct btree_insert_entry *i)
45 {
46 #ifdef CONFIG_BCACHEFS_DEBUG
47         struct bch_fs *c = trans->c;
48         struct bkey u;
49         struct bkey_s_c k = bch2_btree_path_peek_slot_exact(i->path, &u);
50
51         if (unlikely(trans->journal_replay_not_finished)) {
52                 struct bkey_i *j_k =
53                         bch2_journal_keys_peek_slot(c, i->btree_id, i->level, i->k->k.p);
54
55                 if (j_k)
56                         k = bkey_i_to_s_c(j_k);
57         }
58
59         u = *k.k;
60         u.needs_whiteout = i->old_k.needs_whiteout;
61
62         BUG_ON(memcmp(&i->old_k, &u, sizeof(struct bkey)));
63         BUG_ON(i->old_v != k.v);
64 #endif
65 }
66
67 static int __must_check
68 bch2_trans_update_by_path(struct btree_trans *, struct btree_path *,
69                           struct bkey_i *, enum btree_update_flags);
70
71 static inline int btree_insert_entry_cmp(const struct btree_insert_entry *l,
72                                          const struct btree_insert_entry *r)
73 {
74         return   cmp_int(l->btree_id,   r->btree_id) ?:
75                  cmp_int(l->cached,     r->cached) ?:
76                  -cmp_int(l->level,     r->level) ?:
77                  bpos_cmp(l->k->k.p,    r->k->k.p);
78 }
79
80 static inline struct btree_path_level *insert_l(struct btree_insert_entry *i)
81 {
82         return i->path->l + i->level;
83 }
84
85 static inline bool same_leaf_as_prev(struct btree_trans *trans,
86                                      struct btree_insert_entry *i)
87 {
88         return i != trans->updates &&
89                 insert_l(&i[0])->b == insert_l(&i[-1])->b;
90 }
91
92 static inline bool same_leaf_as_next(struct btree_trans *trans,
93                                      struct btree_insert_entry *i)
94 {
95         return i + 1 < trans->updates + trans->nr_updates &&
96                 insert_l(&i[0])->b == insert_l(&i[1])->b;
97 }
98
99 inline void bch2_btree_node_prep_for_write(struct btree_trans *trans,
100                                            struct btree_path *path,
101                                            struct btree *b)
102 {
103         struct bch_fs *c = trans->c;
104
105         if (unlikely(btree_node_just_written(b)) &&
106             bch2_btree_post_write_cleanup(c, b))
107                 bch2_trans_node_reinit_iter(trans, b);
108
109         /*
110          * If the last bset has been written, or if it's gotten too big - start
111          * a new bset to insert into:
112          */
113         if (want_new_bset(c, b))
114                 bch2_btree_init_next(trans, b);
115 }
116
117 /* Inserting into a given leaf node (last stage of insert): */
118
119 /* Handle overwrites and do insert, for non extents: */
120 bool bch2_btree_bset_insert_key(struct btree_trans *trans,
121                                 struct btree_path *path,
122                                 struct btree *b,
123                                 struct btree_node_iter *node_iter,
124                                 struct bkey_i *insert)
125 {
126         struct bkey_packed *k;
127         unsigned clobber_u64s = 0, new_u64s = 0;
128
129         EBUG_ON(btree_node_just_written(b));
130         EBUG_ON(bset_written(b, btree_bset_last(b)));
131         EBUG_ON(bkey_deleted(&insert->k) && bkey_val_u64s(&insert->k));
132         EBUG_ON(bpos_lt(insert->k.p, b->data->min_key));
133         EBUG_ON(bpos_gt(insert->k.p, b->data->max_key));
134         EBUG_ON(insert->k.u64s >
135                 bch_btree_keys_u64s_remaining(trans->c, b));
136
137         k = bch2_btree_node_iter_peek_all(node_iter, b);
138         if (k && bkey_cmp_left_packed(b, k, &insert->k.p))
139                 k = NULL;
140
141         /* @k is the key being overwritten/deleted, if any: */
142         EBUG_ON(k && bkey_deleted(k));
143
144         /* Deleting, but not found? nothing to do: */
145         if (bkey_deleted(&insert->k) && !k)
146                 return false;
147
148         if (bkey_deleted(&insert->k)) {
149                 /* Deleting: */
150                 btree_account_key_drop(b, k);
151                 k->type = KEY_TYPE_deleted;
152
153                 if (k->needs_whiteout)
154                         push_whiteout(trans->c, b, insert->k.p);
155                 k->needs_whiteout = false;
156
157                 if (k >= btree_bset_last(b)->start) {
158                         clobber_u64s = k->u64s;
159                         bch2_bset_delete(b, k, clobber_u64s);
160                         goto fix_iter;
161                 } else {
162                         bch2_btree_path_fix_key_modified(trans, b, k);
163                 }
164
165                 return true;
166         }
167
168         if (k) {
169                 /* Overwriting: */
170                 btree_account_key_drop(b, k);
171                 k->type = KEY_TYPE_deleted;
172
173                 insert->k.needs_whiteout = k->needs_whiteout;
174                 k->needs_whiteout = false;
175
176                 if (k >= btree_bset_last(b)->start) {
177                         clobber_u64s = k->u64s;
178                         goto overwrite;
179                 } else {
180                         bch2_btree_path_fix_key_modified(trans, b, k);
181                 }
182         }
183
184         k = bch2_btree_node_iter_bset_pos(node_iter, b, bset_tree_last(b));
185 overwrite:
186         bch2_bset_insert(b, node_iter, k, insert, clobber_u64s);
187         new_u64s = k->u64s;
188 fix_iter:
189         if (clobber_u64s != new_u64s)
190                 bch2_btree_node_iter_fix(trans, path, b, node_iter, k,
191                                          clobber_u64s, new_u64s);
192         return true;
193 }
194
195 static int __btree_node_flush(struct journal *j, struct journal_entry_pin *pin,
196                                unsigned i, u64 seq)
197 {
198         struct bch_fs *c = container_of(j, struct bch_fs, journal);
199         struct btree_write *w = container_of(pin, struct btree_write, journal);
200         struct btree *b = container_of(w, struct btree, writes[i]);
201         struct btree_trans trans;
202         unsigned long old, new, v;
203         unsigned idx = w - b->writes;
204
205         bch2_trans_init(&trans, c, 0, 0);
206
207         btree_node_lock_nopath_nofail(&trans, &b->c, SIX_LOCK_read);
208         v = READ_ONCE(b->flags);
209
210         do {
211                 old = new = v;
212
213                 if (!(old & (1 << BTREE_NODE_dirty)) ||
214                     !!(old & (1 << BTREE_NODE_write_idx)) != idx ||
215                     w->journal.seq != seq)
216                         break;
217
218                 new &= ~BTREE_WRITE_TYPE_MASK;
219                 new |= BTREE_WRITE_journal_reclaim;
220                 new |= 1 << BTREE_NODE_need_write;
221         } while ((v = cmpxchg(&b->flags, old, new)) != old);
222
223         btree_node_write_if_need(c, b, SIX_LOCK_read);
224         six_unlock_read(&b->c.lock);
225
226         bch2_trans_exit(&trans);
227         return 0;
228 }
229
230 int bch2_btree_node_flush0(struct journal *j, struct journal_entry_pin *pin, u64 seq)
231 {
232         return __btree_node_flush(j, pin, 0, seq);
233 }
234
235 int bch2_btree_node_flush1(struct journal *j, struct journal_entry_pin *pin, u64 seq)
236 {
237         return __btree_node_flush(j, pin, 1, seq);
238 }
239
240 inline void bch2_btree_add_journal_pin(struct bch_fs *c,
241                                        struct btree *b, u64 seq)
242 {
243         struct btree_write *w = btree_current_write(b);
244
245         bch2_journal_pin_add(&c->journal, seq, &w->journal,
246                              btree_node_write_idx(b) == 0
247                              ? bch2_btree_node_flush0
248                              : bch2_btree_node_flush1);
249 }
250
251 /**
252  * btree_insert_key - insert a key one key into a leaf node
253  */
254 inline void bch2_btree_insert_key_leaf(struct btree_trans *trans,
255                                        struct btree_path *path,
256                                        struct bkey_i *insert,
257                                        u64 journal_seq)
258 {
259         struct bch_fs *c = trans->c;
260         struct btree *b = path_l(path)->b;
261         struct bset_tree *t = bset_tree_last(b);
262         struct bset *i = bset(b, t);
263         int old_u64s = bset_u64s(t);
264         int old_live_u64s = b->nr.live_u64s;
265         int live_u64s_added, u64s_added;
266
267         if (unlikely(!bch2_btree_bset_insert_key(trans, path, b,
268                                         &path_l(path)->iter, insert)))
269                 return;
270
271         i->journal_seq = cpu_to_le64(max(journal_seq, le64_to_cpu(i->journal_seq)));
272
273         bch2_btree_add_journal_pin(c, b, journal_seq);
274
275         if (unlikely(!btree_node_dirty(b)))
276                 set_btree_node_dirty_acct(c, b);
277
278         live_u64s_added = (int) b->nr.live_u64s - old_live_u64s;
279         u64s_added = (int) bset_u64s(t) - old_u64s;
280
281         if (b->sib_u64s[0] != U16_MAX && live_u64s_added < 0)
282                 b->sib_u64s[0] = max(0, (int) b->sib_u64s[0] + live_u64s_added);
283         if (b->sib_u64s[1] != U16_MAX && live_u64s_added < 0)
284                 b->sib_u64s[1] = max(0, (int) b->sib_u64s[1] + live_u64s_added);
285
286         if (u64s_added > live_u64s_added &&
287             bch2_maybe_compact_whiteouts(c, b))
288                 bch2_trans_node_reinit_iter(trans, b);
289 }
290
291 static void btree_insert_key_leaf(struct btree_trans *trans,
292                                   struct btree_insert_entry *insert)
293 {
294         bch2_btree_insert_key_leaf(trans, insert->path, insert->k, trans->journal_res.seq);
295 }
296
297 /* Cached btree updates: */
298
299 /* Normal update interface: */
300
301 static inline void btree_insert_entry_checks(struct btree_trans *trans,
302                                              struct btree_insert_entry *i)
303 {
304         BUG_ON(!bpos_eq(i->k->k.p, i->path->pos));
305         BUG_ON(i->cached        != i->path->cached);
306         BUG_ON(i->level         != i->path->level);
307         BUG_ON(i->btree_id      != i->path->btree_id);
308         EBUG_ON(!i->level &&
309                 !(i->flags & BTREE_UPDATE_INTERNAL_SNAPSHOT_NODE) &&
310                 test_bit(JOURNAL_REPLAY_DONE, &trans->c->journal.flags) &&
311                 i->k->k.p.snapshot &&
312                 bch2_snapshot_internal_node(trans->c, i->k->k.p.snapshot));
313 }
314
315 static noinline int
316 bch2_trans_journal_preres_get_cold(struct btree_trans *trans, unsigned flags,
317                                    unsigned long trace_ip)
318 {
319         return drop_locks_do(trans,
320                 bch2_journal_preres_get(&trans->c->journal,
321                         &trans->journal_preres,
322                         trans->journal_preres_u64s,
323                         (flags & BCH_WATERMARK_MASK)));
324 }
325
326 static __always_inline int bch2_trans_journal_res_get(struct btree_trans *trans,
327                                                       unsigned flags)
328 {
329         return bch2_journal_res_get(&trans->c->journal, &trans->journal_res,
330                                     trans->journal_u64s, flags);
331 }
332
333 #define JSET_ENTRY_LOG_U64s             4
334
335 static noinline void journal_transaction_name(struct btree_trans *trans)
336 {
337         struct bch_fs *c = trans->c;
338         struct journal *j = &c->journal;
339         struct jset_entry *entry =
340                 bch2_journal_add_entry(j, &trans->journal_res,
341                                        BCH_JSET_ENTRY_log, 0, 0,
342                                        JSET_ENTRY_LOG_U64s);
343         struct jset_entry_log *l =
344                 container_of(entry, struct jset_entry_log, entry);
345
346         strncpy(l->d, trans->fn, JSET_ENTRY_LOG_U64s * sizeof(u64));
347 }
348
349 static inline int btree_key_can_insert(struct btree_trans *trans,
350                                        struct btree *b, unsigned u64s)
351 {
352         struct bch_fs *c = trans->c;
353
354         if (!bch2_btree_node_insert_fits(c, b, u64s))
355                 return -BCH_ERR_btree_insert_btree_node_full;
356
357         return 0;
358 }
359
360 static int btree_key_can_insert_cached(struct btree_trans *trans, unsigned flags,
361                                        struct btree_path *path, unsigned u64s)
362 {
363         struct bch_fs *c = trans->c;
364         struct bkey_cached *ck = (void *) path->l[0].b;
365         struct btree_insert_entry *i;
366         unsigned new_u64s;
367         struct bkey_i *new_k;
368
369         EBUG_ON(path->level);
370
371         if (!test_bit(BKEY_CACHED_DIRTY, &ck->flags) &&
372             bch2_btree_key_cache_must_wait(c) &&
373             !(flags & BTREE_INSERT_JOURNAL_RECLAIM))
374                 return -BCH_ERR_btree_insert_need_journal_reclaim;
375
376         /*
377          * bch2_varint_decode can read past the end of the buffer by at most 7
378          * bytes (it won't be used):
379          */
380         u64s += 1;
381
382         if (u64s <= ck->u64s)
383                 return 0;
384
385         new_u64s        = roundup_pow_of_two(u64s);
386         new_k           = krealloc(ck->k, new_u64s * sizeof(u64), GFP_NOFS);
387         if (!new_k) {
388                 bch_err(c, "error allocating memory for key cache key, btree %s u64s %u",
389                         bch2_btree_ids[path->btree_id], new_u64s);
390                 return -BCH_ERR_ENOMEM_btree_key_cache_insert;
391         }
392
393         trans_for_each_update(trans, i)
394                 if (i->old_v == &ck->k->v)
395                         i->old_v = &new_k->v;
396
397         ck->u64s        = new_u64s;
398         ck->k           = new_k;
399         return 0;
400 }
401
402 /* Triggers: */
403
404 static int run_one_mem_trigger(struct btree_trans *trans,
405                                struct btree_insert_entry *i,
406                                unsigned flags)
407 {
408         struct bkey_s_c old = { &i->old_k, i->old_v };
409         struct bkey_i *new = i->k;
410         const struct bkey_ops *old_ops = bch2_bkey_type_ops(old.k->type);
411         const struct bkey_ops *new_ops = bch2_bkey_type_ops(i->k->k.type);
412         int ret;
413
414         verify_update_old_key(trans, i);
415
416         if (unlikely(flags & BTREE_TRIGGER_NORUN))
417                 return 0;
418
419         if (!btree_node_type_needs_gc(i->btree_id))
420                 return 0;
421
422         if (old_ops->atomic_trigger == new_ops->atomic_trigger) {
423                 ret   = bch2_mark_key(trans, i->btree_id, i->level,
424                                 old, bkey_i_to_s_c(new),
425                                 BTREE_TRIGGER_INSERT|BTREE_TRIGGER_OVERWRITE|flags);
426         } else {
427                 struct bkey             _deleted = KEY(0, 0, 0);
428                 struct bkey_s_c         deleted = (struct bkey_s_c) { &_deleted, NULL };
429
430                 _deleted.p = i->path->pos;
431
432                 ret   = bch2_mark_key(trans, i->btree_id, i->level,
433                                 deleted, bkey_i_to_s_c(new),
434                                 BTREE_TRIGGER_INSERT|flags) ?:
435                         bch2_mark_key(trans, i->btree_id, i->level,
436                                 old, deleted,
437                                 BTREE_TRIGGER_OVERWRITE|flags);
438         }
439
440         return ret;
441 }
442
443 static int run_one_trans_trigger(struct btree_trans *trans, struct btree_insert_entry *i,
444                                  bool overwrite)
445 {
446         /*
447          * Transactional triggers create new btree_insert_entries, so we can't
448          * pass them a pointer to a btree_insert_entry, that memory is going to
449          * move:
450          */
451         struct bkey old_k = i->old_k;
452         struct bkey_s_c old = { &old_k, i->old_v };
453         const struct bkey_ops *old_ops = bch2_bkey_type_ops(old.k->type);
454         const struct bkey_ops *new_ops = bch2_bkey_type_ops(i->k->k.type);
455
456         verify_update_old_key(trans, i);
457
458         if ((i->flags & BTREE_TRIGGER_NORUN) ||
459             !(BTREE_NODE_TYPE_HAS_TRANS_TRIGGERS & (1U << i->bkey_type)))
460                 return 0;
461
462         if (!i->insert_trigger_run &&
463             !i->overwrite_trigger_run &&
464             old_ops->trans_trigger == new_ops->trans_trigger) {
465                 i->overwrite_trigger_run = true;
466                 i->insert_trigger_run = true;
467                 return bch2_trans_mark_key(trans, i->btree_id, i->level, old, i->k,
468                                            BTREE_TRIGGER_INSERT|
469                                            BTREE_TRIGGER_OVERWRITE|
470                                            i->flags) ?: 1;
471         } else if (overwrite && !i->overwrite_trigger_run) {
472                 i->overwrite_trigger_run = true;
473                 return bch2_trans_mark_old(trans, i->btree_id, i->level, old, i->flags) ?: 1;
474         } else if (!overwrite && !i->insert_trigger_run) {
475                 i->insert_trigger_run = true;
476                 return bch2_trans_mark_new(trans, i->btree_id, i->level, i->k, i->flags) ?: 1;
477         } else {
478                 return 0;
479         }
480 }
481
482 static int run_btree_triggers(struct btree_trans *trans, enum btree_id btree_id,
483                               struct btree_insert_entry *btree_id_start)
484 {
485         struct btree_insert_entry *i;
486         bool trans_trigger_run;
487         int ret, overwrite;
488
489         for (overwrite = 1; overwrite >= 0; --overwrite) {
490
491                 /*
492                  * Running triggers will append more updates to the list of updates as
493                  * we're walking it:
494                  */
495                 do {
496                         trans_trigger_run = false;
497
498                         for (i = btree_id_start;
499                              i < trans->updates + trans->nr_updates && i->btree_id <= btree_id;
500                              i++) {
501                                 if (i->btree_id != btree_id)
502                                         continue;
503
504                                 ret = run_one_trans_trigger(trans, i, overwrite);
505                                 if (ret < 0)
506                                         return ret;
507                                 if (ret)
508                                         trans_trigger_run = true;
509                         }
510                 } while (trans_trigger_run);
511         }
512
513         return 0;
514 }
515
516 static int bch2_trans_commit_run_triggers(struct btree_trans *trans)
517 {
518         struct btree_insert_entry *i = NULL, *btree_id_start = trans->updates;
519         unsigned btree_id = 0;
520         int ret = 0;
521
522         /*
523          *
524          * For a given btree, this algorithm runs insert triggers before
525          * overwrite triggers: this is so that when extents are being moved
526          * (e.g. by FALLOCATE_FL_INSERT_RANGE), we don't drop references before
527          * they are re-added.
528          */
529         for (btree_id = 0; btree_id < BTREE_ID_NR; btree_id++) {
530                 if (btree_id == BTREE_ID_alloc)
531                         continue;
532
533                 while (btree_id_start < trans->updates + trans->nr_updates &&
534                        btree_id_start->btree_id < btree_id)
535                         btree_id_start++;
536
537                 ret = run_btree_triggers(trans, btree_id, btree_id_start);
538                 if (ret)
539                         return ret;
540         }
541
542         trans_for_each_update(trans, i) {
543                 if (i->btree_id > BTREE_ID_alloc)
544                         break;
545                 if (i->btree_id == BTREE_ID_alloc) {
546                         ret = run_btree_triggers(trans, BTREE_ID_alloc, i);
547                         if (ret)
548                                 return ret;
549                         break;
550                 }
551         }
552
553 #ifdef CONFIG_BCACHEFS_DEBUG
554         trans_for_each_update(trans, i)
555                 BUG_ON(!(i->flags & BTREE_TRIGGER_NORUN) &&
556                        (BTREE_NODE_TYPE_HAS_TRANS_TRIGGERS & (1U << i->bkey_type)) &&
557                        (!i->insert_trigger_run || !i->overwrite_trigger_run));
558 #endif
559         return 0;
560 }
561
562 static noinline int bch2_trans_commit_run_gc_triggers(struct btree_trans *trans)
563 {
564         struct bch_fs *c = trans->c;
565         struct btree_insert_entry *i;
566         int ret = 0;
567
568         trans_for_each_update(trans, i) {
569                 /*
570                  * XXX: synchronization of cached update triggers with gc
571                  * XXX: synchronization of interior node updates with gc
572                  */
573                 BUG_ON(i->cached || i->level);
574
575                 if (gc_visited(c, gc_pos_btree_node(insert_l(i)->b))) {
576                         ret = run_one_mem_trigger(trans, i, i->flags|BTREE_TRIGGER_GC);
577                         if (ret)
578                                 break;
579                 }
580         }
581
582         return ret;
583 }
584
585 static inline int
586 bch2_trans_commit_write_locked(struct btree_trans *trans, unsigned flags,
587                                struct btree_insert_entry **stopped_at,
588                                unsigned long trace_ip)
589 {
590         struct bch_fs *c = trans->c;
591         struct btree_insert_entry *i;
592         struct btree_write_buffered_key *wb;
593         struct btree_trans_commit_hook *h;
594         unsigned u64s = 0;
595         bool marking = false;
596         int ret;
597
598         if (race_fault()) {
599                 trace_and_count(c, trans_restart_fault_inject, trans, trace_ip);
600                 return btree_trans_restart_nounlock(trans, BCH_ERR_transaction_restart_fault_inject);
601         }
602
603         /*
604          * Check if the insert will fit in the leaf node with the write lock
605          * held, otherwise another thread could write the node changing the
606          * amount of space available:
607          */
608
609         prefetch(&trans->c->journal.flags);
610
611         trans_for_each_update(trans, i) {
612                 /* Multiple inserts might go to same leaf: */
613                 if (!same_leaf_as_prev(trans, i))
614                         u64s = 0;
615
616                 u64s += i->k->k.u64s;
617                 ret = !i->cached
618                         ? btree_key_can_insert(trans, insert_l(i)->b, u64s)
619                         : btree_key_can_insert_cached(trans, flags, i->path, u64s);
620                 if (ret) {
621                         *stopped_at = i;
622                         return ret;
623                 }
624
625                 if (btree_node_type_needs_gc(i->bkey_type))
626                         marking = true;
627         }
628
629         if (trans->nr_wb_updates &&
630             trans->nr_wb_updates + c->btree_write_buffer.state.nr > c->btree_write_buffer.size)
631                 return -BCH_ERR_btree_insert_need_flush_buffer;
632
633         /*
634          * Don't get journal reservation until after we know insert will
635          * succeed:
636          */
637         if (likely(!(flags & BTREE_INSERT_JOURNAL_REPLAY))) {
638                 ret = bch2_trans_journal_res_get(trans,
639                                 (flags & BCH_WATERMARK_MASK)|
640                                 JOURNAL_RES_GET_NONBLOCK);
641                 if (ret)
642                         return ret;
643
644                 if (unlikely(trans->journal_transaction_names))
645                         journal_transaction_name(trans);
646         } else {
647                 trans->journal_res.seq = c->journal.replay_journal_seq;
648         }
649
650         /*
651          * Not allowed to fail after we've gotten our journal reservation - we
652          * have to use it:
653          */
654
655         if (IS_ENABLED(CONFIG_BCACHEFS_DEBUG) &&
656             !(flags & BTREE_INSERT_JOURNAL_REPLAY)) {
657                 if (bch2_journal_seq_verify)
658                         trans_for_each_update(trans, i)
659                                 i->k->k.version.lo = trans->journal_res.seq;
660                 else if (bch2_inject_invalid_keys)
661                         trans_for_each_update(trans, i)
662                                 i->k->k.version = MAX_VERSION;
663         }
664
665         if (trans->fs_usage_deltas &&
666             bch2_trans_fs_usage_apply(trans, trans->fs_usage_deltas))
667                 return -BCH_ERR_btree_insert_need_mark_replicas;
668
669         if (trans->nr_wb_updates) {
670                 EBUG_ON(flags & BTREE_INSERT_JOURNAL_REPLAY);
671
672                 ret = bch2_btree_insert_keys_write_buffer(trans);
673                 if (ret)
674                         goto revert_fs_usage;
675         }
676
677         h = trans->hooks;
678         while (h) {
679                 ret = h->fn(trans, h);
680                 if (ret)
681                         goto revert_fs_usage;
682                 h = h->next;
683         }
684
685         trans_for_each_update(trans, i)
686                 if (BTREE_NODE_TYPE_HAS_MEM_TRIGGERS & (1U << i->bkey_type)) {
687                         ret = run_one_mem_trigger(trans, i, i->flags);
688                         if (ret)
689                                 goto fatal_err;
690                 }
691
692         if (unlikely(c->gc_pos.phase)) {
693                 ret = bch2_trans_commit_run_gc_triggers(trans);
694                 if  (ret)
695                         goto fatal_err;
696         }
697
698         if (unlikely(trans->extra_journal_entries.nr)) {
699                 memcpy_u64s_small(journal_res_entry(&c->journal, &trans->journal_res),
700                                   trans->extra_journal_entries.data,
701                                   trans->extra_journal_entries.nr);
702
703                 trans->journal_res.offset       += trans->extra_journal_entries.nr;
704                 trans->journal_res.u64s         -= trans->extra_journal_entries.nr;
705         }
706
707         if (likely(!(flags & BTREE_INSERT_JOURNAL_REPLAY))) {
708                 struct journal *j = &c->journal;
709                 struct jset_entry *entry;
710
711                 trans_for_each_update(trans, i) {
712                         if (i->key_cache_already_flushed)
713                                 continue;
714
715                         if (i->flags & BTREE_UPDATE_NOJOURNAL)
716                                 continue;
717
718                         verify_update_old_key(trans, i);
719
720                         if (trans->journal_transaction_names) {
721                                 entry = bch2_journal_add_entry(j, &trans->journal_res,
722                                                        BCH_JSET_ENTRY_overwrite,
723                                                        i->btree_id, i->level,
724                                                        i->old_k.u64s);
725                                 bkey_reassemble(&entry->start[0],
726                                                 (struct bkey_s_c) { &i->old_k, i->old_v });
727                         }
728
729                         entry = bch2_journal_add_entry(j, &trans->journal_res,
730                                                BCH_JSET_ENTRY_btree_keys,
731                                                i->btree_id, i->level,
732                                                i->k->k.u64s);
733                         bkey_copy(&entry->start[0], i->k);
734                 }
735
736                 trans_for_each_wb_update(trans, wb) {
737                         entry = bch2_journal_add_entry(j, &trans->journal_res,
738                                                BCH_JSET_ENTRY_btree_keys,
739                                                wb->btree, 0,
740                                                wb->k.k.u64s);
741                         bkey_copy(&entry->start[0], &wb->k);
742                 }
743
744                 if (trans->journal_seq)
745                         *trans->journal_seq = trans->journal_res.seq;
746         }
747
748         trans_for_each_update(trans, i) {
749                 i->k->k.needs_whiteout = false;
750
751                 if (!i->cached)
752                         btree_insert_key_leaf(trans, i);
753                 else if (!i->key_cache_already_flushed)
754                         bch2_btree_insert_key_cached(trans, flags, i);
755                 else {
756                         bch2_btree_key_cache_drop(trans, i->path);
757                         btree_path_set_dirty(i->path, BTREE_ITER_NEED_TRAVERSE);
758                 }
759         }
760
761         return 0;
762 fatal_err:
763         bch2_fatal_error(c);
764 revert_fs_usage:
765         if (trans->fs_usage_deltas)
766                 bch2_trans_fs_usage_revert(trans, trans->fs_usage_deltas);
767         return ret;
768 }
769
770 static noinline int trans_lock_write_fail(struct btree_trans *trans, struct btree_insert_entry *i)
771 {
772         while (--i >= trans->updates) {
773                 if (same_leaf_as_prev(trans, i))
774                         continue;
775
776                 bch2_btree_node_unlock_write(trans, i->path, insert_l(i)->b);
777         }
778
779         trace_and_count(trans->c, trans_restart_would_deadlock_write, trans);
780         return btree_trans_restart(trans, BCH_ERR_transaction_restart_would_deadlock_write);
781 }
782
783 static inline int trans_lock_write(struct btree_trans *trans)
784 {
785         struct btree_insert_entry *i;
786
787         trans_for_each_update(trans, i) {
788                 if (same_leaf_as_prev(trans, i))
789                         continue;
790
791                 if (bch2_btree_node_lock_write(trans, i->path, &insert_l(i)->b->c))
792                         return trans_lock_write_fail(trans, i);
793
794                 if (!i->cached)
795                         bch2_btree_node_prep_for_write(trans, i->path, insert_l(i)->b);
796         }
797
798         return 0;
799 }
800
801 static noinline void bch2_drop_overwrites_from_journal(struct btree_trans *trans)
802 {
803         struct btree_insert_entry *i;
804         struct btree_write_buffered_key *wb;
805
806         trans_for_each_update(trans, i)
807                 bch2_journal_key_overwritten(trans->c, i->btree_id, i->level, i->k->k.p);
808
809         trans_for_each_wb_update(trans, wb)
810                 bch2_journal_key_overwritten(trans->c, wb->btree, 0, wb->k.k.p);
811 }
812
813 #ifdef CONFIG_BCACHEFS_DEBUG
814 static noinline int bch2_trans_commit_bkey_invalid(struct btree_trans *trans, unsigned flags,
815                                                    struct btree_insert_entry *i,
816                                                    struct printbuf *err)
817 {
818         struct bch_fs *c = trans->c;
819         int rw = (flags & BTREE_INSERT_JOURNAL_REPLAY) ? READ : WRITE;
820
821         printbuf_reset(err);
822         prt_printf(err, "invalid bkey on insert from %s -> %ps",
823                    trans->fn, (void *) i->ip_allocated);
824         prt_newline(err);
825         printbuf_indent_add(err, 2);
826
827         bch2_bkey_val_to_text(err, c, bkey_i_to_s_c(i->k));
828         prt_newline(err);
829
830         bch2_bkey_invalid(c, bkey_i_to_s_c(i->k),
831                           i->bkey_type, rw, err);
832         bch2_print_string_as_lines(KERN_ERR, err->buf);
833
834         bch2_inconsistent_error(c);
835         bch2_dump_trans_updates(trans);
836         printbuf_exit(err);
837
838         return -EINVAL;
839 }
840 #endif
841
842 /*
843  * Get journal reservation, take write locks, and attempt to do btree update(s):
844  */
845 static inline int do_bch2_trans_commit(struct btree_trans *trans, unsigned flags,
846                                        struct btree_insert_entry **stopped_at,
847                                        unsigned long trace_ip)
848 {
849         struct bch_fs *c = trans->c;
850         struct btree_insert_entry *i;
851         int ret, u64s_delta = 0;
852
853 #ifdef CONFIG_BCACHEFS_DEBUG
854         struct printbuf buf = PRINTBUF;
855
856         trans_for_each_update(trans, i) {
857                 enum bkey_invalid_flags invalid_flags = 0;
858
859                 if (!(flags & BTREE_INSERT_JOURNAL_REPLAY))
860                         invalid_flags |= BKEY_INVALID_WRITE|BKEY_INVALID_COMMIT;
861
862                 if (unlikely(bch2_bkey_invalid(c, bkey_i_to_s_c(i->k),
863                                                i->bkey_type, invalid_flags, &buf)))
864                         return bch2_trans_commit_bkey_invalid(trans, flags, i, &buf);
865                 btree_insert_entry_checks(trans, i);
866         }
867         printbuf_exit(&buf);
868 #endif
869
870         trans_for_each_update(trans, i) {
871                 if (i->cached)
872                         continue;
873
874                 u64s_delta += !bkey_deleted(&i->k->k) ? i->k->k.u64s : 0;
875                 u64s_delta -= i->old_btree_u64s;
876
877                 if (!same_leaf_as_next(trans, i)) {
878                         if (u64s_delta <= 0) {
879                                 ret = bch2_foreground_maybe_merge(trans, i->path,
880                                                         i->level, flags);
881                                 if (unlikely(ret))
882                                         return ret;
883                         }
884
885                         u64s_delta = 0;
886                 }
887         }
888
889         ret = bch2_journal_preres_get(&c->journal,
890                         &trans->journal_preres, trans->journal_preres_u64s,
891                         (flags & BCH_WATERMARK_MASK)|JOURNAL_RES_GET_NONBLOCK);
892         if (unlikely(ret == -BCH_ERR_journal_preres_get_blocked))
893                 ret = bch2_trans_journal_preres_get_cold(trans, flags, trace_ip);
894         if (unlikely(ret))
895                 return ret;
896
897         ret = trans_lock_write(trans);
898         if (unlikely(ret))
899                 return ret;
900
901         ret = bch2_trans_commit_write_locked(trans, flags, stopped_at, trace_ip);
902
903         if (!ret && unlikely(trans->journal_replay_not_finished))
904                 bch2_drop_overwrites_from_journal(trans);
905
906         trans_for_each_update(trans, i)
907                 if (!same_leaf_as_prev(trans, i))
908                         bch2_btree_node_unlock_write_inlined(trans, i->path,
909                                                         insert_l(i)->b);
910
911         if (!ret && trans->journal_pin)
912                 bch2_journal_pin_add(&c->journal, trans->journal_res.seq,
913                                      trans->journal_pin, NULL);
914
915         /*
916          * Drop journal reservation after dropping write locks, since dropping
917          * the journal reservation may kick off a journal write:
918          */
919         bch2_journal_res_put(&c->journal, &trans->journal_res);
920
921         if (unlikely(ret))
922                 return ret;
923
924         bch2_trans_downgrade(trans);
925
926         return 0;
927 }
928
929 static int journal_reclaim_wait_done(struct bch_fs *c)
930 {
931         int ret = bch2_journal_error(&c->journal) ?:
932                 !bch2_btree_key_cache_must_wait(c);
933
934         if (!ret)
935                 journal_reclaim_kick(&c->journal);
936         return ret;
937 }
938
939 static noinline
940 int bch2_trans_commit_error(struct btree_trans *trans, unsigned flags,
941                             struct btree_insert_entry *i,
942                             int ret, unsigned long trace_ip)
943 {
944         struct bch_fs *c = trans->c;
945
946         switch (ret) {
947         case -BCH_ERR_btree_insert_btree_node_full:
948                 ret = bch2_btree_split_leaf(trans, i->path, flags);
949                 if (bch2_err_matches(ret, BCH_ERR_transaction_restart))
950                         trace_and_count(c, trans_restart_btree_node_split, trans, trace_ip, i->path);
951                 break;
952         case -BCH_ERR_btree_insert_need_mark_replicas:
953                 ret = drop_locks_do(trans,
954                         bch2_replicas_delta_list_mark(c, trans->fs_usage_deltas));
955                 break;
956         case -BCH_ERR_journal_res_get_blocked:
957                 if ((flags & BTREE_INSERT_JOURNAL_RECLAIM) &&
958                     (flags & BCH_WATERMARK_MASK) != BCH_WATERMARK_reclaim) {
959                         ret = -BCH_ERR_journal_reclaim_would_deadlock;
960                         break;
961                 }
962
963                 ret = drop_locks_do(trans,
964                         bch2_trans_journal_res_get(trans,
965                                         (flags & BCH_WATERMARK_MASK)|
966                                         JOURNAL_RES_GET_CHECK));
967                 break;
968         case -BCH_ERR_btree_insert_need_journal_reclaim:
969                 bch2_trans_unlock(trans);
970
971                 trace_and_count(c, trans_blocked_journal_reclaim, trans, trace_ip);
972
973                 wait_event_freezable(c->journal.reclaim_wait,
974                                      (ret = journal_reclaim_wait_done(c)));
975                 if (ret < 0)
976                         break;
977
978                 ret = bch2_trans_relock(trans);
979                 break;
980         case -BCH_ERR_btree_insert_need_flush_buffer: {
981                 struct btree_write_buffer *wb = &c->btree_write_buffer;
982
983                 ret = 0;
984
985                 if (wb->state.nr > wb->size * 3 / 4) {
986                         bch2_trans_unlock(trans);
987                         mutex_lock(&wb->flush_lock);
988
989                         if (wb->state.nr > wb->size * 3 / 4) {
990                                 bch2_trans_begin(trans);
991                                 ret = __bch2_btree_write_buffer_flush(trans,
992                                                 flags|BTREE_INSERT_NOCHECK_RW, true);
993                                 if (!ret) {
994                                         trace_and_count(c, trans_restart_write_buffer_flush, trans, _THIS_IP_);
995                                         ret = btree_trans_restart(trans, BCH_ERR_transaction_restart_write_buffer_flush);
996                                 }
997                         } else {
998                                 mutex_unlock(&wb->flush_lock);
999                                 ret = bch2_trans_relock(trans);
1000                         }
1001                 }
1002                 break;
1003         }
1004         default:
1005                 BUG_ON(ret >= 0);
1006                 break;
1007         }
1008
1009         BUG_ON(bch2_err_matches(ret, BCH_ERR_transaction_restart) != !!trans->restarted);
1010
1011         bch2_fs_inconsistent_on(bch2_err_matches(ret, ENOSPC) &&
1012                                 !(flags & BTREE_INSERT_NOWAIT) &&
1013                                 (flags & BTREE_INSERT_NOFAIL), c,
1014                 "%s: incorrectly got %s\n", __func__, bch2_err_str(ret));
1015
1016         return ret;
1017 }
1018
1019 static noinline int
1020 bch2_trans_commit_get_rw_cold(struct btree_trans *trans, unsigned flags)
1021 {
1022         struct bch_fs *c = trans->c;
1023         int ret;
1024
1025         if (likely(!(flags & BTREE_INSERT_LAZY_RW)) ||
1026             test_bit(BCH_FS_STARTED, &c->flags))
1027                 return -BCH_ERR_erofs_trans_commit;
1028
1029         ret = drop_locks_do(trans, bch2_fs_read_write_early(c));
1030         if (ret)
1031                 return ret;
1032
1033         bch2_write_ref_get(c, BCH_WRITE_REF_trans);
1034         return 0;
1035 }
1036
1037 /*
1038  * This is for updates done in the early part of fsck - btree_gc - before we've
1039  * gone RW. we only add the new key to the list of keys for journal replay to
1040  * do.
1041  */
1042 static noinline int
1043 do_bch2_trans_commit_to_journal_replay(struct btree_trans *trans)
1044 {
1045         struct bch_fs *c = trans->c;
1046         struct btree_insert_entry *i;
1047         int ret = 0;
1048
1049         trans_for_each_update(trans, i) {
1050                 ret = bch2_journal_key_insert(c, i->btree_id, i->level, i->k);
1051                 if (ret)
1052                         break;
1053         }
1054
1055         return ret;
1056 }
1057
1058 int __bch2_trans_commit(struct btree_trans *trans, unsigned flags)
1059 {
1060         struct bch_fs *c = trans->c;
1061         struct btree_insert_entry *i = NULL;
1062         struct btree_write_buffered_key *wb;
1063         unsigned u64s;
1064         int ret = 0;
1065
1066         if (!trans->nr_updates &&
1067             !trans->nr_wb_updates &&
1068             !trans->extra_journal_entries.nr)
1069                 goto out_reset;
1070
1071         if (flags & BTREE_INSERT_GC_LOCK_HELD)
1072                 lockdep_assert_held(&c->gc_lock);
1073
1074         ret = bch2_trans_commit_run_triggers(trans);
1075         if (ret)
1076                 goto out_reset;
1077
1078         if (unlikely(!test_bit(BCH_FS_MAY_GO_RW, &c->flags))) {
1079                 ret = do_bch2_trans_commit_to_journal_replay(trans);
1080                 goto out_reset;
1081         }
1082
1083         if (!(flags & BTREE_INSERT_NOCHECK_RW) &&
1084             unlikely(!bch2_write_ref_tryget(c, BCH_WRITE_REF_trans))) {
1085                 ret = bch2_trans_commit_get_rw_cold(trans, flags);
1086                 if (ret)
1087                         goto out_reset;
1088         }
1089
1090         if (c->btree_write_buffer.state.nr > c->btree_write_buffer.size / 2 &&
1091             mutex_trylock(&c->btree_write_buffer.flush_lock)) {
1092                 bch2_trans_begin(trans);
1093                 bch2_trans_unlock(trans);
1094
1095                 ret = __bch2_btree_write_buffer_flush(trans,
1096                                         flags|BTREE_INSERT_NOCHECK_RW, true);
1097                 if (!ret) {
1098                         trace_and_count(c, trans_restart_write_buffer_flush, trans, _THIS_IP_);
1099                         ret = btree_trans_restart(trans, BCH_ERR_transaction_restart_write_buffer_flush);
1100                 }
1101                 goto out;
1102         }
1103
1104         EBUG_ON(test_bit(BCH_FS_CLEAN_SHUTDOWN, &c->flags));
1105
1106         memset(&trans->journal_preres, 0, sizeof(trans->journal_preres));
1107
1108         trans->journal_u64s             = trans->extra_journal_entries.nr;
1109         trans->journal_preres_u64s      = 0;
1110
1111         trans->journal_transaction_names = READ_ONCE(c->opts.journal_transaction_names);
1112
1113         if (trans->journal_transaction_names)
1114                 trans->journal_u64s += jset_u64s(JSET_ENTRY_LOG_U64s);
1115
1116         trans_for_each_update(trans, i) {
1117                 EBUG_ON(!i->path->should_be_locked);
1118
1119                 ret = bch2_btree_path_upgrade(trans, i->path, i->level + 1);
1120                 if (unlikely(ret))
1121                         goto out;
1122
1123                 EBUG_ON(!btree_node_intent_locked(i->path, i->level));
1124
1125                 if (i->key_cache_already_flushed)
1126                         continue;
1127
1128                 /* we're going to journal the key being updated: */
1129                 u64s = jset_u64s(i->k->k.u64s);
1130                 if (i->cached &&
1131                     likely(!(flags & BTREE_INSERT_JOURNAL_REPLAY)))
1132                         trans->journal_preres_u64s += u64s;
1133
1134                 if (i->flags & BTREE_UPDATE_NOJOURNAL)
1135                         continue;
1136
1137                 trans->journal_u64s += u64s;
1138
1139                 /* and we're also going to log the overwrite: */
1140                 if (trans->journal_transaction_names)
1141                         trans->journal_u64s += jset_u64s(i->old_k.u64s);
1142         }
1143
1144         trans_for_each_wb_update(trans, wb)
1145                 trans->journal_u64s += jset_u64s(wb->k.k.u64s);
1146
1147         if (trans->extra_journal_res) {
1148                 ret = bch2_disk_reservation_add(c, trans->disk_res,
1149                                 trans->extra_journal_res,
1150                                 (flags & BTREE_INSERT_NOFAIL)
1151                                 ? BCH_DISK_RESERVATION_NOFAIL : 0);
1152                 if (ret)
1153                         goto err;
1154         }
1155 retry:
1156         bch2_trans_verify_not_in_restart(trans);
1157         memset(&trans->journal_res, 0, sizeof(trans->journal_res));
1158
1159         ret = do_bch2_trans_commit(trans, flags, &i, _RET_IP_);
1160
1161         /* make sure we didn't drop or screw up locks: */
1162         bch2_trans_verify_locks(trans);
1163
1164         if (ret)
1165                 goto err;
1166
1167         trace_and_count(c, transaction_commit, trans, _RET_IP_);
1168 out:
1169         bch2_journal_preres_put(&c->journal, &trans->journal_preres);
1170
1171         if (likely(!(flags & BTREE_INSERT_NOCHECK_RW)))
1172                 bch2_write_ref_put(c, BCH_WRITE_REF_trans);
1173 out_reset:
1174         bch2_trans_reset_updates(trans);
1175
1176         return ret;
1177 err:
1178         ret = bch2_trans_commit_error(trans, flags, i, ret, _RET_IP_);
1179         if (ret)
1180                 goto out;
1181
1182         goto retry;
1183 }
1184
1185 static noinline int __check_pos_snapshot_overwritten(struct btree_trans *trans,
1186                                           enum btree_id id,
1187                                           struct bpos pos)
1188 {
1189         struct bch_fs *c = trans->c;
1190         struct btree_iter iter;
1191         struct bkey_s_c k;
1192         int ret;
1193
1194         bch2_trans_iter_init(trans, &iter, id, pos,
1195                              BTREE_ITER_NOT_EXTENTS|
1196                              BTREE_ITER_ALL_SNAPSHOTS);
1197         while (1) {
1198                 k = bch2_btree_iter_prev(&iter);
1199                 ret = bkey_err(k);
1200                 if (ret)
1201                         break;
1202
1203                 if (!k.k)
1204                         break;
1205
1206                 if (!bkey_eq(pos, k.k->p))
1207                         break;
1208
1209                 if (bch2_snapshot_is_ancestor(c, k.k->p.snapshot, pos.snapshot)) {
1210                         ret = 1;
1211                         break;
1212                 }
1213         }
1214         bch2_trans_iter_exit(trans, &iter);
1215
1216         return ret;
1217 }
1218
1219 static inline int check_pos_snapshot_overwritten(struct btree_trans *trans,
1220                                           enum btree_id id,
1221                                           struct bpos pos)
1222 {
1223         if (!btree_type_has_snapshots(id) ||
1224             !snapshot_t(trans->c, pos.snapshot)->children[0])
1225                 return 0;
1226
1227         return __check_pos_snapshot_overwritten(trans, id, pos);
1228 }
1229
1230 static noinline int extent_front_merge(struct btree_trans *trans,
1231                                        struct btree_iter *iter,
1232                                        struct bkey_s_c k,
1233                                        struct bkey_i **insert,
1234                                        enum btree_update_flags flags)
1235 {
1236         struct bch_fs *c = trans->c;
1237         struct bkey_i *update;
1238         int ret;
1239
1240         update = bch2_bkey_make_mut_noupdate(trans, k);
1241         ret = PTR_ERR_OR_ZERO(update);
1242         if (ret)
1243                 return ret;
1244
1245         if (!bch2_bkey_merge(c, bkey_i_to_s(update), bkey_i_to_s_c(*insert)))
1246                 return 0;
1247
1248         ret =   check_pos_snapshot_overwritten(trans, iter->btree_id, k.k->p) ?:
1249                 check_pos_snapshot_overwritten(trans, iter->btree_id, (*insert)->k.p);
1250         if (ret < 0)
1251                 return ret;
1252         if (ret)
1253                 return 0;
1254
1255         ret = bch2_btree_delete_at(trans, iter, flags);
1256         if (ret)
1257                 return ret;
1258
1259         *insert = update;
1260         return 0;
1261 }
1262
1263 static noinline int extent_back_merge(struct btree_trans *trans,
1264                                       struct btree_iter *iter,
1265                                       struct bkey_i *insert,
1266                                       struct bkey_s_c k)
1267 {
1268         struct bch_fs *c = trans->c;
1269         int ret;
1270
1271         ret =   check_pos_snapshot_overwritten(trans, iter->btree_id, insert->k.p) ?:
1272                 check_pos_snapshot_overwritten(trans, iter->btree_id, k.k->p);
1273         if (ret < 0)
1274                 return ret;
1275         if (ret)
1276                 return 0;
1277
1278         bch2_bkey_merge(c, bkey_i_to_s(insert), k);
1279         return 0;
1280 }
1281
1282 /*
1283  * When deleting, check if we need to emit a whiteout (because we're overwriting
1284  * something in an ancestor snapshot)
1285  */
1286 static int need_whiteout_for_snapshot(struct btree_trans *trans,
1287                                       enum btree_id btree_id, struct bpos pos)
1288 {
1289         struct btree_iter iter;
1290         struct bkey_s_c k;
1291         u32 snapshot = pos.snapshot;
1292         int ret;
1293
1294         if (!bch2_snapshot_parent(trans->c, pos.snapshot))
1295                 return 0;
1296
1297         pos.snapshot++;
1298
1299         for_each_btree_key_norestart(trans, iter, btree_id, pos,
1300                            BTREE_ITER_ALL_SNAPSHOTS|
1301                            BTREE_ITER_NOPRESERVE, k, ret) {
1302                 if (!bkey_eq(k.k->p, pos))
1303                         break;
1304
1305                 if (bch2_snapshot_is_ancestor(trans->c, snapshot,
1306                                               k.k->p.snapshot)) {
1307                         ret = !bkey_whiteout(k.k);
1308                         break;
1309                 }
1310         }
1311         bch2_trans_iter_exit(trans, &iter);
1312
1313         return ret;
1314 }
1315
1316 int __bch2_insert_snapshot_whiteouts(struct btree_trans *trans,
1317                                    enum btree_id id,
1318                                    struct bpos old_pos,
1319                                    struct bpos new_pos)
1320 {
1321         struct bch_fs *c = trans->c;
1322         struct btree_iter old_iter, new_iter;
1323         struct bkey_s_c old_k, new_k;
1324         snapshot_id_list s;
1325         struct bkey_i *update;
1326         int ret;
1327
1328         if (!bch2_snapshot_has_children(c, old_pos.snapshot))
1329                 return 0;
1330
1331         darray_init(&s);
1332
1333         bch2_trans_iter_init(trans, &old_iter, id, old_pos,
1334                              BTREE_ITER_NOT_EXTENTS|
1335                              BTREE_ITER_ALL_SNAPSHOTS);
1336         while ((old_k = bch2_btree_iter_prev(&old_iter)).k &&
1337                !(ret = bkey_err(old_k)) &&
1338                bkey_eq(old_pos, old_k.k->p)) {
1339                 struct bpos whiteout_pos =
1340                         SPOS(new_pos.inode, new_pos.offset, old_k.k->p.snapshot);;
1341
1342                 if (!bch2_snapshot_is_ancestor(c, old_k.k->p.snapshot, old_pos.snapshot) ||
1343                     snapshot_list_has_ancestor(c, &s, old_k.k->p.snapshot))
1344                         continue;
1345
1346                 new_k = bch2_bkey_get_iter(trans, &new_iter, id, whiteout_pos,
1347                                            BTREE_ITER_NOT_EXTENTS|
1348                                            BTREE_ITER_INTENT);
1349                 ret = bkey_err(new_k);
1350                 if (ret)
1351                         break;
1352
1353                 if (new_k.k->type == KEY_TYPE_deleted) {
1354                         update = bch2_trans_kmalloc(trans, sizeof(struct bkey_i));
1355                         ret = PTR_ERR_OR_ZERO(update);
1356                         if (ret)
1357                                 break;
1358
1359                         bkey_init(&update->k);
1360                         update->k.p             = whiteout_pos;
1361                         update->k.type          = KEY_TYPE_whiteout;
1362
1363                         ret = bch2_trans_update(trans, &new_iter, update,
1364                                                 BTREE_UPDATE_INTERNAL_SNAPSHOT_NODE);
1365                 }
1366                 bch2_trans_iter_exit(trans, &new_iter);
1367
1368                 ret = snapshot_list_add(c, &s, old_k.k->p.snapshot);
1369                 if (ret)
1370                         break;
1371         }
1372         bch2_trans_iter_exit(trans, &old_iter);
1373         darray_exit(&s);
1374
1375         return ret;
1376 }
1377
1378 int bch2_trans_update_extent(struct btree_trans *trans,
1379                              struct btree_iter *orig_iter,
1380                              struct bkey_i *insert,
1381                              enum btree_update_flags flags)
1382 {
1383         struct btree_iter iter;
1384         struct bpos start = bkey_start_pos(&insert->k);
1385         struct bkey_i *update;
1386         struct bkey_s_c k;
1387         enum btree_id btree_id = orig_iter->btree_id;
1388         int ret = 0, compressed_sectors;
1389
1390         bch2_trans_iter_init(trans, &iter, btree_id, start,
1391                              BTREE_ITER_INTENT|
1392                              BTREE_ITER_WITH_UPDATES|
1393                              BTREE_ITER_NOT_EXTENTS);
1394         k = bch2_btree_iter_peek_upto(&iter, POS(insert->k.p.inode, U64_MAX));
1395         if ((ret = bkey_err(k)))
1396                 goto err;
1397         if (!k.k)
1398                 goto out;
1399
1400         if (bkey_eq(k.k->p, bkey_start_pos(&insert->k))) {
1401                 if (bch2_bkey_maybe_mergable(k.k, &insert->k)) {
1402                         ret = extent_front_merge(trans, &iter, k, &insert, flags);
1403                         if (ret)
1404                                 goto err;
1405                 }
1406
1407                 goto next;
1408         }
1409
1410         while (bkey_gt(insert->k.p, bkey_start_pos(k.k))) {
1411                 bool front_split = bkey_lt(bkey_start_pos(k.k), start);
1412                 bool back_split  = bkey_gt(k.k->p, insert->k.p);
1413
1414                 /*
1415                  * If we're going to be splitting a compressed extent, note it
1416                  * so that __bch2_trans_commit() can increase our disk
1417                  * reservation:
1418                  */
1419                 if (((front_split && back_split) ||
1420                      ((front_split || back_split) && k.k->p.snapshot != insert->k.p.snapshot)) &&
1421                     (compressed_sectors = bch2_bkey_sectors_compressed(k)))
1422                         trans->extra_journal_res += compressed_sectors;
1423
1424                 if (front_split) {
1425                         update = bch2_bkey_make_mut_noupdate(trans, k);
1426                         if ((ret = PTR_ERR_OR_ZERO(update)))
1427                                 goto err;
1428
1429                         bch2_cut_back(start, update);
1430
1431                         ret =   bch2_insert_snapshot_whiteouts(trans, btree_id,
1432                                                 k.k->p, update->k.p) ?:
1433                                 bch2_btree_insert_nonextent(trans, btree_id, update,
1434                                                 BTREE_UPDATE_INTERNAL_SNAPSHOT_NODE|flags);
1435                         if (ret)
1436                                 goto err;
1437                 }
1438
1439                 if (k.k->p.snapshot != insert->k.p.snapshot &&
1440                     (front_split || back_split)) {
1441                         update = bch2_bkey_make_mut_noupdate(trans, k);
1442                         if ((ret = PTR_ERR_OR_ZERO(update)))
1443                                 goto err;
1444
1445                         bch2_cut_front(start, update);
1446                         bch2_cut_back(insert->k.p, update);
1447
1448                         ret =   bch2_insert_snapshot_whiteouts(trans, btree_id,
1449                                                 k.k->p, update->k.p) ?:
1450                                 bch2_btree_insert_nonextent(trans, btree_id, update,
1451                                                   BTREE_UPDATE_INTERNAL_SNAPSHOT_NODE|flags);
1452                         if (ret)
1453                                 goto err;
1454                 }
1455
1456                 if (bkey_le(k.k->p, insert->k.p)) {
1457                         update = bch2_trans_kmalloc(trans, sizeof(*update));
1458                         if ((ret = PTR_ERR_OR_ZERO(update)))
1459                                 goto err;
1460
1461                         bkey_init(&update->k);
1462                         update->k.p = k.k->p;
1463                         update->k.p.snapshot = insert->k.p.snapshot;
1464
1465                         if (insert->k.p.snapshot != k.k->p.snapshot) {
1466                                 update->k.type = KEY_TYPE_whiteout;
1467                         } else if (btree_type_has_snapshots(btree_id)) {
1468                                 ret = need_whiteout_for_snapshot(trans, btree_id, update->k.p);
1469                                 if (ret < 0)
1470                                         goto err;
1471                                 if (ret)
1472                                         update->k.type = KEY_TYPE_whiteout;
1473                         }
1474
1475                         ret = bch2_btree_insert_nonextent(trans, btree_id, update,
1476                                                   BTREE_UPDATE_INTERNAL_SNAPSHOT_NODE|flags);
1477                         if (ret)
1478                                 goto err;
1479                 }
1480
1481                 if (back_split) {
1482                         update = bch2_bkey_make_mut_noupdate(trans, k);
1483                         if ((ret = PTR_ERR_OR_ZERO(update)))
1484                                 goto err;
1485
1486                         bch2_cut_front(insert->k.p, update);
1487
1488                         ret = bch2_trans_update_by_path(trans, iter.path, update,
1489                                                   BTREE_UPDATE_INTERNAL_SNAPSHOT_NODE|
1490                                                   flags);
1491                         if (ret)
1492                                 goto err;
1493                         goto out;
1494                 }
1495 next:
1496                 bch2_btree_iter_advance(&iter);
1497                 k = bch2_btree_iter_peek_upto(&iter, POS(insert->k.p.inode, U64_MAX));
1498                 if ((ret = bkey_err(k)))
1499                         goto err;
1500                 if (!k.k)
1501                         goto out;
1502         }
1503
1504         if (bch2_bkey_maybe_mergable(&insert->k, k.k)) {
1505                 ret = extent_back_merge(trans, &iter, insert, k);
1506                 if (ret)
1507                         goto err;
1508         }
1509 out:
1510         if (!bkey_deleted(&insert->k)) {
1511                 /*
1512                  * Rewinding iterators is expensive: get a new one and the one
1513                  * that points to the start of insert will be cloned from:
1514                  */
1515                 bch2_trans_iter_exit(trans, &iter);
1516                 bch2_trans_iter_init(trans, &iter, btree_id, insert->k.p,
1517                                      BTREE_ITER_NOT_EXTENTS|
1518                                      BTREE_ITER_INTENT);
1519                 ret   = bch2_btree_iter_traverse(&iter) ?:
1520                         bch2_trans_update(trans, &iter, insert, flags);
1521         }
1522 err:
1523         bch2_trans_iter_exit(trans, &iter);
1524
1525         return ret;
1526 }
1527
1528 static int __must_check
1529 bch2_trans_update_by_path_trace(struct btree_trans *trans, struct btree_path *path,
1530                                 struct bkey_i *k, enum btree_update_flags flags,
1531                                 unsigned long ip);
1532
1533 static noinline int flush_new_cached_update(struct btree_trans *trans,
1534                                             struct btree_path *path,
1535                                             struct btree_insert_entry *i,
1536                                             enum btree_update_flags flags,
1537                                             unsigned long ip)
1538 {
1539         struct btree_path *btree_path;
1540         struct bkey k;
1541         int ret;
1542
1543         btree_path = bch2_path_get(trans, path->btree_id, path->pos, 1, 0,
1544                                    BTREE_ITER_INTENT, _THIS_IP_);
1545         ret = bch2_btree_path_traverse(trans, btree_path, 0);
1546         if (ret)
1547                 goto out;
1548
1549         /*
1550          * The old key in the insert entry might actually refer to an existing
1551          * key in the btree that has been deleted from cache and not yet
1552          * flushed. Check for this and skip the flush so we don't run triggers
1553          * against a stale key.
1554          */
1555         bch2_btree_path_peek_slot_exact(btree_path, &k);
1556         if (!bkey_deleted(&k))
1557                 goto out;
1558
1559         i->key_cache_already_flushed = true;
1560         i->flags |= BTREE_TRIGGER_NORUN;
1561
1562         btree_path_set_should_be_locked(btree_path);
1563         ret = bch2_trans_update_by_path_trace(trans, btree_path, i->k, flags, ip);
1564 out:
1565         bch2_path_put(trans, btree_path, true);
1566         return ret;
1567 }
1568
1569 static int __must_check
1570 bch2_trans_update_by_path_trace(struct btree_trans *trans, struct btree_path *path,
1571                                 struct bkey_i *k, enum btree_update_flags flags,
1572                                 unsigned long ip)
1573 {
1574         struct bch_fs *c = trans->c;
1575         struct btree_insert_entry *i, n;
1576         int cmp;
1577
1578         EBUG_ON(!path->should_be_locked);
1579         EBUG_ON(trans->nr_updates >= BTREE_ITER_MAX);
1580         EBUG_ON(!bpos_eq(k->k.p, path->pos));
1581
1582         n = (struct btree_insert_entry) {
1583                 .flags          = flags,
1584                 .bkey_type      = __btree_node_type(path->level, path->btree_id),
1585                 .btree_id       = path->btree_id,
1586                 .level          = path->level,
1587                 .cached         = path->cached,
1588                 .path           = path,
1589                 .k              = k,
1590                 .ip_allocated   = ip,
1591         };
1592
1593 #ifdef CONFIG_BCACHEFS_DEBUG
1594         trans_for_each_update(trans, i)
1595                 BUG_ON(i != trans->updates &&
1596                        btree_insert_entry_cmp(i - 1, i) >= 0);
1597 #endif
1598
1599         /*
1600          * Pending updates are kept sorted: first, find position of new update,
1601          * then delete/trim any updates the new update overwrites:
1602          */
1603         trans_for_each_update(trans, i) {
1604                 cmp = btree_insert_entry_cmp(&n, i);
1605                 if (cmp <= 0)
1606                         break;
1607         }
1608
1609         if (!cmp && i < trans->updates + trans->nr_updates) {
1610                 EBUG_ON(i->insert_trigger_run || i->overwrite_trigger_run);
1611
1612                 bch2_path_put(trans, i->path, true);
1613                 i->flags        = n.flags;
1614                 i->cached       = n.cached;
1615                 i->k            = n.k;
1616                 i->path         = n.path;
1617                 i->ip_allocated = n.ip_allocated;
1618         } else {
1619                 array_insert_item(trans->updates, trans->nr_updates,
1620                                   i - trans->updates, n);
1621
1622                 i->old_v = bch2_btree_path_peek_slot_exact(path, &i->old_k).v;
1623                 i->old_btree_u64s = !bkey_deleted(&i->old_k) ? i->old_k.u64s : 0;
1624
1625                 if (unlikely(trans->journal_replay_not_finished)) {
1626                         struct bkey_i *j_k =
1627                                 bch2_journal_keys_peek_slot(c, n.btree_id, n.level, k->k.p);
1628
1629                         if (j_k) {
1630                                 i->old_k = j_k->k;
1631                                 i->old_v = &j_k->v;
1632                         }
1633                 }
1634         }
1635
1636         __btree_path_get(i->path, true);
1637
1638         /*
1639          * If a key is present in the key cache, it must also exist in the
1640          * btree - this is necessary for cache coherency. When iterating over
1641          * a btree that's cached in the key cache, the btree iter code checks
1642          * the key cache - but the key has to exist in the btree for that to
1643          * work:
1644          */
1645         if (path->cached && bkey_deleted(&i->old_k))
1646                 return flush_new_cached_update(trans, path, i, flags, ip);
1647
1648         return 0;
1649 }
1650
1651 static inline int __must_check
1652 bch2_trans_update_by_path(struct btree_trans *trans, struct btree_path *path,
1653                           struct bkey_i *k, enum btree_update_flags flags)
1654 {
1655         return bch2_trans_update_by_path_trace(trans, path, k, flags, _RET_IP_);
1656 }
1657
1658 int __must_check bch2_trans_update(struct btree_trans *trans, struct btree_iter *iter,
1659                                    struct bkey_i *k, enum btree_update_flags flags)
1660 {
1661         struct btree_path *path = iter->update_path ?: iter->path;
1662         struct bkey_cached *ck;
1663         int ret;
1664
1665         if (iter->flags & BTREE_ITER_IS_EXTENTS)
1666                 return bch2_trans_update_extent(trans, iter, k, flags);
1667
1668         if (bkey_deleted(&k->k) &&
1669             !(flags & BTREE_UPDATE_KEY_CACHE_RECLAIM) &&
1670             (iter->flags & BTREE_ITER_FILTER_SNAPSHOTS)) {
1671                 ret = need_whiteout_for_snapshot(trans, iter->btree_id, k->k.p);
1672                 if (unlikely(ret < 0))
1673                         return ret;
1674
1675                 if (ret)
1676                         k->k.type = KEY_TYPE_whiteout;
1677         }
1678
1679         /*
1680          * Ensure that updates to cached btrees go to the key cache:
1681          */
1682         if (!(flags & BTREE_UPDATE_KEY_CACHE_RECLAIM) &&
1683             !path->cached &&
1684             !path->level &&
1685             btree_id_cached(trans->c, path->btree_id)) {
1686                 if (!iter->key_cache_path ||
1687                     !iter->key_cache_path->should_be_locked ||
1688                     !bpos_eq(iter->key_cache_path->pos, k->k.p)) {
1689                         if (!iter->key_cache_path)
1690                                 iter->key_cache_path =
1691                                         bch2_path_get(trans, path->btree_id, path->pos, 1, 0,
1692                                                       BTREE_ITER_INTENT|
1693                                                       BTREE_ITER_CACHED, _THIS_IP_);
1694
1695                         iter->key_cache_path =
1696                                 bch2_btree_path_set_pos(trans, iter->key_cache_path, path->pos,
1697                                                         iter->flags & BTREE_ITER_INTENT,
1698                                                         _THIS_IP_);
1699
1700                         ret = bch2_btree_path_traverse(trans, iter->key_cache_path,
1701                                                        BTREE_ITER_CACHED);
1702                         if (unlikely(ret))
1703                                 return ret;
1704
1705                         ck = (void *) iter->key_cache_path->l[0].b;
1706
1707                         if (test_bit(BKEY_CACHED_DIRTY, &ck->flags)) {
1708                                 trace_and_count(trans->c, trans_restart_key_cache_raced, trans, _RET_IP_);
1709                                 return btree_trans_restart(trans, BCH_ERR_transaction_restart_key_cache_raced);
1710                         }
1711
1712                         btree_path_set_should_be_locked(iter->key_cache_path);
1713                 }
1714
1715                 path = iter->key_cache_path;
1716         }
1717
1718         return bch2_trans_update_by_path(trans, path, k, flags);
1719 }
1720
1721 int __must_check bch2_trans_update_buffered(struct btree_trans *trans,
1722                                             enum btree_id btree,
1723                                             struct bkey_i *k,
1724                                             bool head)
1725 {
1726         int ret, pos;
1727
1728         EBUG_ON(trans->nr_wb_updates > trans->wb_updates_size);
1729         EBUG_ON(k->k.u64s > BTREE_WRITE_BUFERED_U64s_MAX);
1730
1731         if (!trans->wb_updates ||
1732             trans->nr_wb_updates == trans->wb_updates_size) {
1733                 struct btree_write_buffered_key *u;
1734
1735                 if (trans->nr_wb_updates == trans->wb_updates_size) {
1736                         struct btree_transaction_stats *s = btree_trans_stats(trans);
1737
1738                         BUG_ON(trans->wb_updates_size > U8_MAX / 2);
1739                         trans->wb_updates_size = max(1, trans->wb_updates_size * 2);
1740                         if (s)
1741                                 s->wb_updates_size = trans->wb_updates_size;
1742                 }
1743
1744                 u = bch2_trans_kmalloc_nomemzero(trans,
1745                                         trans->wb_updates_size *
1746                                         sizeof(struct btree_write_buffered_key));
1747                 ret = PTR_ERR_OR_ZERO(u);
1748                 if (ret)
1749                         return ret;
1750
1751                 if (trans->nr_wb_updates)
1752                         memcpy(u, trans->wb_updates, trans->nr_wb_updates *
1753                                sizeof(struct btree_write_buffered_key));
1754                 trans->wb_updates = u;
1755         }
1756
1757         if (head) {
1758                 memmove(&trans->wb_updates[1],
1759                         &trans->wb_updates[0],
1760                         sizeof(trans->wb_updates[0]) * trans->nr_wb_updates);
1761                 pos = 0;
1762         } else {
1763                 pos = trans->nr_wb_updates;
1764         }
1765
1766         trans->wb_updates[pos] = (struct btree_write_buffered_key) { .btree = btree, };
1767         bkey_copy(&trans->wb_updates[pos].k, k);
1768         trans->nr_wb_updates++;
1769         return 0;
1770 }
1771
1772 int bch2_bkey_get_empty_slot(struct btree_trans *trans, struct btree_iter *iter,
1773                              enum btree_id btree, struct bpos end)
1774 {
1775         struct bkey_s_c k;
1776         int ret = 0;
1777
1778         bch2_trans_iter_init(trans, iter, btree, POS_MAX, BTREE_ITER_INTENT);
1779         k = bch2_btree_iter_prev(iter);
1780         ret = bkey_err(k);
1781         if (ret)
1782                 goto err;
1783
1784         bch2_btree_iter_advance(iter);
1785         k = bch2_btree_iter_peek_slot(iter);
1786         ret = bkey_err(k);
1787         if (ret)
1788                 goto err;
1789
1790         BUG_ON(k.k->type != KEY_TYPE_deleted);
1791
1792         if (bkey_gt(k.k->p, end)) {
1793                 ret = -BCH_ERR_ENOSPC_btree_slot;
1794                 goto err;
1795         }
1796
1797         return 0;
1798 err:
1799         bch2_trans_iter_exit(trans, iter);
1800         return ret;
1801 }
1802
1803 void bch2_trans_commit_hook(struct btree_trans *trans,
1804                             struct btree_trans_commit_hook *h)
1805 {
1806         h->next = trans->hooks;
1807         trans->hooks = h;
1808 }
1809
1810 int bch2_btree_insert_nonextent(struct btree_trans *trans,
1811                                 enum btree_id btree, struct bkey_i *k,
1812                                 enum btree_update_flags flags)
1813 {
1814         struct btree_iter iter;
1815         int ret;
1816
1817         bch2_trans_iter_init(trans, &iter, btree, k->k.p,
1818                              BTREE_ITER_NOT_EXTENTS|
1819                              BTREE_ITER_INTENT);
1820         ret   = bch2_btree_iter_traverse(&iter) ?:
1821                 bch2_trans_update(trans, &iter, k, flags);
1822         bch2_trans_iter_exit(trans, &iter);
1823         return ret;
1824 }
1825
1826 int __bch2_btree_insert(struct btree_trans *trans, enum btree_id id,
1827                         struct bkey_i *k, enum btree_update_flags flags)
1828 {
1829         struct btree_iter iter;
1830         int ret;
1831
1832         bch2_trans_iter_init(trans, &iter, id, bkey_start_pos(&k->k),
1833                              BTREE_ITER_CACHED|
1834                              BTREE_ITER_INTENT);
1835         ret   = bch2_btree_iter_traverse(&iter) ?:
1836                 bch2_trans_update(trans, &iter, k, flags);
1837         bch2_trans_iter_exit(trans, &iter);
1838         return ret;
1839 }
1840
1841 /**
1842  * bch2_btree_insert - insert keys into the extent btree
1843  * @c:                  pointer to struct bch_fs
1844  * @id:                 btree to insert into
1845  * @insert_keys:        list of keys to insert
1846  * @hook:               insert callback
1847  */
1848 int bch2_btree_insert(struct bch_fs *c, enum btree_id id,
1849                       struct bkey_i *k,
1850                       struct disk_reservation *disk_res,
1851                       u64 *journal_seq, int flags)
1852 {
1853         return bch2_trans_do(c, disk_res, journal_seq, flags,
1854                              __bch2_btree_insert(&trans, id, k, 0));
1855 }
1856
1857 int bch2_btree_delete_extent_at(struct btree_trans *trans, struct btree_iter *iter,
1858                                 unsigned len, unsigned update_flags)
1859 {
1860         struct bkey_i *k;
1861
1862         k = bch2_trans_kmalloc(trans, sizeof(*k));
1863         if (IS_ERR(k))
1864                 return PTR_ERR(k);
1865
1866         bkey_init(&k->k);
1867         k->k.p = iter->pos;
1868         bch2_key_resize(&k->k, len);
1869         return bch2_trans_update(trans, iter, k, update_flags);
1870 }
1871
1872 int bch2_btree_delete_at(struct btree_trans *trans,
1873                          struct btree_iter *iter, unsigned update_flags)
1874 {
1875         return bch2_btree_delete_extent_at(trans, iter, 0, update_flags);
1876 }
1877
1878 int bch2_btree_delete_at_buffered(struct btree_trans *trans,
1879                                   enum btree_id btree, struct bpos pos)
1880 {
1881         struct bkey_i *k;
1882
1883         k = bch2_trans_kmalloc(trans, sizeof(*k));
1884         if (IS_ERR(k))
1885                 return PTR_ERR(k);
1886
1887         bkey_init(&k->k);
1888         k->k.p = pos;
1889         return bch2_trans_update_buffered(trans, btree, k, false);
1890 }
1891
1892 int bch2_btree_delete_range_trans(struct btree_trans *trans, enum btree_id id,
1893                                   struct bpos start, struct bpos end,
1894                                   unsigned update_flags,
1895                                   u64 *journal_seq)
1896 {
1897         u32 restart_count = trans->restart_count;
1898         struct btree_iter iter;
1899         struct bkey_s_c k;
1900         int ret = 0;
1901
1902         bch2_trans_iter_init(trans, &iter, id, start, BTREE_ITER_INTENT);
1903         while ((k = bch2_btree_iter_peek_upto(&iter, end)).k) {
1904                 struct disk_reservation disk_res =
1905                         bch2_disk_reservation_init(trans->c, 0);
1906                 struct bkey_i delete;
1907
1908                 ret = bkey_err(k);
1909                 if (ret)
1910                         goto err;
1911
1912                 bkey_init(&delete.k);
1913
1914                 /*
1915                  * This could probably be more efficient for extents:
1916                  */
1917
1918                 /*
1919                  * For extents, iter.pos won't necessarily be the same as
1920                  * bkey_start_pos(k.k) (for non extents they always will be the
1921                  * same). It's important that we delete starting from iter.pos
1922                  * because the range we want to delete could start in the middle
1923                  * of k.
1924                  *
1925                  * (bch2_btree_iter_peek() does guarantee that iter.pos >=
1926                  * bkey_start_pos(k.k)).
1927                  */
1928                 delete.k.p = iter.pos;
1929
1930                 if (iter.flags & BTREE_ITER_IS_EXTENTS)
1931                         bch2_key_resize(&delete.k,
1932                                         bpos_min(end, k.k->p).offset -
1933                                         iter.pos.offset);
1934
1935                 ret   = bch2_trans_update(trans, &iter, &delete, update_flags) ?:
1936                         bch2_trans_commit(trans, &disk_res, journal_seq,
1937                                           BTREE_INSERT_NOFAIL);
1938                 bch2_disk_reservation_put(trans->c, &disk_res);
1939 err:
1940                 /*
1941                  * the bch2_trans_begin() call is in a weird place because we
1942                  * need to call it after every transaction commit, to avoid path
1943                  * overflow, but don't want to call it if the delete operation
1944                  * is a no-op and we have no work to do:
1945                  */
1946                 bch2_trans_begin(trans);
1947
1948                 if (bch2_err_matches(ret, BCH_ERR_transaction_restart))
1949                         ret = 0;
1950                 if (ret)
1951                         break;
1952         }
1953         bch2_trans_iter_exit(trans, &iter);
1954
1955         if (!ret && trans_was_restarted(trans, restart_count))
1956                 ret = -BCH_ERR_transaction_restart_nested;
1957         return ret;
1958 }
1959
1960 /*
1961  * bch_btree_delete_range - delete everything within a given range
1962  *
1963  * Range is a half open interval - [start, end)
1964  */
1965 int bch2_btree_delete_range(struct bch_fs *c, enum btree_id id,
1966                             struct bpos start, struct bpos end,
1967                             unsigned update_flags,
1968                             u64 *journal_seq)
1969 {
1970         int ret = bch2_trans_run(c,
1971                         bch2_btree_delete_range_trans(&trans, id, start, end,
1972                                                       update_flags, journal_seq));
1973         if (ret == -BCH_ERR_transaction_restart_nested)
1974                 ret = 0;
1975         return ret;
1976 }
1977
1978 static int __bch2_trans_log_msg(darray_u64 *entries, const char *fmt, va_list args)
1979 {
1980         struct printbuf buf = PRINTBUF;
1981         struct jset_entry_log *l;
1982         unsigned u64s;
1983         int ret;
1984
1985         prt_vprintf(&buf, fmt, args);
1986         ret = buf.allocation_failure ? -BCH_ERR_ENOMEM_trans_log_msg : 0;
1987         if (ret)
1988                 goto err;
1989
1990         u64s = DIV_ROUND_UP(buf.pos, sizeof(u64));
1991
1992         ret = darray_make_room(entries, jset_u64s(u64s));
1993         if (ret)
1994                 goto err;
1995
1996         l = (void *) &darray_top(*entries);
1997         l->entry.u64s           = cpu_to_le16(u64s);
1998         l->entry.btree_id       = 0;
1999         l->entry.level          = 1;
2000         l->entry.type           = BCH_JSET_ENTRY_log;
2001         l->entry.pad[0]         = 0;
2002         l->entry.pad[1]         = 0;
2003         l->entry.pad[2]         = 0;
2004         memcpy(l->d, buf.buf, buf.pos);
2005         while (buf.pos & 7)
2006                 l->d[buf.pos++] = '\0';
2007
2008         entries->nr += jset_u64s(u64s);
2009 err:
2010         printbuf_exit(&buf);
2011         return ret;
2012 }
2013
2014 static int
2015 __bch2_fs_log_msg(struct bch_fs *c, unsigned commit_flags, const char *fmt,
2016                   va_list args)
2017 {
2018         int ret;
2019
2020         if (!test_bit(JOURNAL_STARTED, &c->journal.flags)) {
2021                 ret = __bch2_trans_log_msg(&c->journal.early_journal_entries, fmt, args);
2022         } else {
2023                 ret = bch2_trans_do(c, NULL, NULL,
2024                         BTREE_INSERT_LAZY_RW|commit_flags,
2025                         __bch2_trans_log_msg(&trans.extra_journal_entries, fmt, args));
2026         }
2027
2028         return ret;
2029 }
2030
2031 int bch2_fs_log_msg(struct bch_fs *c, const char *fmt, ...)
2032 {
2033         va_list args;
2034         int ret;
2035
2036         va_start(args, fmt);
2037         ret = __bch2_fs_log_msg(c, 0, fmt, args);
2038         va_end(args);
2039         return ret;
2040 }
2041
2042 /*
2043  * Use for logging messages during recovery to enable reserved space and avoid
2044  * blocking.
2045  */
2046 int bch2_journal_log_msg(struct bch_fs *c, const char *fmt, ...)
2047 {
2048         va_list args;
2049         int ret;
2050
2051         va_start(args, fmt);
2052         ret = __bch2_fs_log_msg(c, BCH_WATERMARK_reclaim, fmt, args);
2053         va_end(args);
2054         return ret;
2055 }